)]}'
{"taskflow/jobs/backends/impl_zookeeper.py":[{"author":{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},"change_message_id":"12177575f9162e5c8f218aca853828d2ccd645c5","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        if not k_paths.isabs(path):"},{"line_number":333,"context_line":"            raise ValueError(\"Zookeeper path must be absolute\")"},{"line_number":334,"context_line":"        self._path \u003d path"},{"line_number":335,"context_line":"        self._trash_path \u003d re.sub(\u0027[^/]+$\u0027, TRASH_FOLDER, self._path)"},{"line_number":336,"context_line":"        # The backend to load the full logbooks from, since whats sent over"},{"line_number":337,"context_line":"        # the zookeeper data connection is only the logbook uuid and name, and"},{"line_number":338,"context_line":"        # not currently the full logbook (later when a zookeeper backend"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_e6731e13","line":335,"updated":"2015-02-23 21:50:08.000000000","message":"This isn\u0027t perl. Lets avoid regex here with some simple string manipulation, possibly using this: https://github.com/python-zk/kazoo/blob/master/kazoo/protocol/paths.py#L42","commit_id":"61236071722c4de2b015fed5c51c41b606b0e8b9"},{"author":{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},"change_message_id":"0efad5773e8540fd1c9f3ea1e7338974d81a3dcb","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        if not k_paths.isabs(path):"},{"line_number":333,"context_line":"            raise ValueError(\"Zookeeper path must be absolute\")"},{"line_number":334,"context_line":"        self._path \u003d path"},{"line_number":335,"context_line":"        self._trash_path \u003d re.sub(\u0027[^/]+$\u0027, TRASH_FOLDER, self._path)"},{"line_number":336,"context_line":"        # The backend to load the full logbooks from, since whats sent over"},{"line_number":337,"context_line":"        # the zookeeper data connection is only the logbook uuid and name, and"},{"line_number":338,"context_line":"        # not currently the full logbook (later when a zookeeper backend"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_f54c11ca","line":335,"in_reply_to":"ba7be1f8_288d75d3","updated":"2015-02-26 16:34:13.000000000","message":"Performance isn\u0027t a concern here at all. Readability is.","commit_id":"61236071722c4de2b015fed5c51c41b606b0e8b9"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"93bc5d2736a19b1769135557dc5bbdd962c14dbe","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        if not k_paths.isabs(path):"},{"line_number":333,"context_line":"            raise ValueError(\"Zookeeper path must be absolute\")"},{"line_number":334,"context_line":"        self._path \u003d path"},{"line_number":335,"context_line":"        self._trash_path \u003d re.sub(\u0027[^/]+$\u0027, TRASH_FOLDER, self._path)"},{"line_number":336,"context_line":"        # The backend to load the full logbooks from, since whats sent over"},{"line_number":337,"context_line":"        # the zookeeper data connection is only the logbook uuid and name, and"},{"line_number":338,"context_line":"        # not currently the full logbook (later when a zookeeper backend"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba7be1f8_288d75d3","line":335,"in_reply_to":"ba7be1f8_e6731e13","updated":"2015-02-26 16:00:23.000000000","message":"That\u0027s awfully pedantic.  It probably is less performant than the simple regex.  I\u0027ll do it anyway, but your anti-Perl bias is kind of silly, IMO.","commit_id":"61236071722c4de2b015fed5c51c41b606b0e8b9"}]}