)]}'
{"id":"openstack%2Ftaskflow~165262","triplet_id":"openstack%2Ftaskflow~master~I5916838163e6be843429fe7b89a0b5622e9c2f36","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"I5916838163e6be843429fe7b89a0b5622e9c2f36","subject":"Always return scope walker instances from `fetch_scopes_for`","status":"MERGED","created":"2015-03-18 01:05:35.000000000","updated":"2015-03-19 05:13:47.000000000","submitted":"2015-03-19 05:13:46.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e8114e25d0394bfb09774e209b5e4df9726daf71","_number":165262,"virtual_id_number":165262,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-03-18 21:21:19.000000000","_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2015-03-19 05:13:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2015-03-19 04:13:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2015-03-19 04:13:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-19 05:13:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9cc9b40d624cf7b67651feb2e83a08bd72f6c8e1","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-03-18 01:05:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"abfdd0fd05a12dc33043ca722815260d1ea443f4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-18 01:55:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/62/165262/1/check/gate-taskflow-python26/975fe55/ : SUCCESS in 2m 01s\n- gate-taskflow-pep8 http://logs.openstack.org/62/165262/1/check/gate-taskflow-pep8/8ef0700/ : SUCCESS in 1m 02s\n- gate-taskflow-docs http://docs-draft.openstack.org/62/165262/1/check/gate-taskflow-docs/4a57dd4//doc/build/html/ : SUCCESS in 1m 25s\n- gate-taskflow-python27 http://logs.openstack.org/62/165262/1/check/gate-taskflow-python27/c02fdbf/ : SUCCESS in 2m 00s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/165262/1/check/gate-tempest-dsvm-neutron-src-taskflow/195b3d9/ : SUCCESS in 46m 54s\n- gate-taskflow-python34 http://logs.openstack.org/62/165262/1/check/gate-taskflow-python34/35d08a4/ : SUCCESS in 3m 01s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/62/165262/1/check/gate-taskflow-tox-py26-sa7-mysql/f92c92d/ : SUCCESS in 2m 01s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/62/165262/1/check/gate-taskflow-tox-py27-sa8-mysql/d6e3932/ : SUCCESS in 1m 41s","accounts_in_message":[],"_revision_number":1},{"id":"d96e8771683baed16657eb9f0f91bd7b32b46cde","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-03-18 05:44:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"eb64646415b6333267f59155db31860de6dd6288","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-18 06:32:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/62/165262/2/check/gate-taskflow-python26/327d716/ : SUCCESS in 2m 55s\n- gate-taskflow-pep8 http://logs.openstack.org/62/165262/2/check/gate-taskflow-pep8/4a63e21/ : SUCCESS in 1m 12s\n- gate-taskflow-docs http://docs-draft.openstack.org/62/165262/2/check/gate-taskflow-docs/2ddde97//doc/build/html/ : SUCCESS in 1m 19s\n- gate-taskflow-python27 http://logs.openstack.org/62/165262/2/check/gate-taskflow-python27/06b3f5b/ : SUCCESS in 2m 01s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/165262/2/check/gate-tempest-dsvm-neutron-src-taskflow/9da359e/ : SUCCESS in 47m 49s\n- gate-taskflow-python34 http://logs.openstack.org/62/165262/2/check/gate-taskflow-python34/6ba6c0f/ : SUCCESS in 2m 59s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/62/165262/2/check/gate-taskflow-tox-py26-sa7-mysql/dd0b14d/ : SUCCESS in 2m 26s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/62/165262/2/check/gate-taskflow-tox-py27-sa8-mysql/77f30cc/ : SUCCESS in 1m 39s","accounts_in_message":[],"_revision_number":2},{"id":"95443fa443f64135e9d8d730c27714f195f95e67","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-03-18 17:35:12.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f42b658d48833fc855559c7df3ec217d3a6fc227","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-18 20:48:29.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-taskflow-python26 http://logs.openstack.org/62/165262/3/check/gate-taskflow-python26/1657d15/ : SUCCESS in 1m 36s\n- gate-taskflow-pep8 http://logs.openstack.org/62/165262/3/check/gate-taskflow-pep8/b343bb3/ : SUCCESS in 48s\n- gate-taskflow-docs http://docs-draft.openstack.org/62/165262/3/check/gate-taskflow-docs/4247173//doc/build/html/ : SUCCESS in 1m 42s\n- gate-taskflow-python27 http://logs.openstack.org/62/165262/3/check/gate-taskflow-python27/c8208c8/ : SUCCESS in 3m 37s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/165262/3/check/gate-tempest-dsvm-neutron-src-taskflow/8a7b303/ : SUCCESS in 49m 01s\n- gate-taskflow-python34 http://logs.openstack.org/62/165262/3/check/gate-taskflow-python34/23e9053/ : SUCCESS in 3m 04s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/62/165262/3/check/gate-taskflow-tox-py26-sa7-mysql/ba3cf95/ : SUCCESS in 2m 55s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/62/165262/3/check/gate-taskflow-tox-py27-sa8-mysql/1f9f336/ : FAILURE in 2m 00s","accounts_in_message":[],"_revision_number":3},{"id":"e584a03d0ce13eb4d208141840f535dbf1fd63e8","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-03-18 21:21:19.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"0a3325fac612074604b00fdfbac5107c88b5c9df","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-19 01:20:05.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/62/165262/3/check/gate-taskflow-python26/01025c0/ : SUCCESS in 1m 51s\n- gate-taskflow-pep8 http://logs.openstack.org/62/165262/3/check/gate-taskflow-pep8/c04143b/ : SUCCESS in 49s\n- gate-taskflow-docs http://docs-draft.openstack.org/62/165262/3/check/gate-taskflow-docs/60e1ddf//doc/build/html/ : SUCCESS in 1m 09s\n- gate-taskflow-python27 http://logs.openstack.org/62/165262/3/check/gate-taskflow-python27/2d884b0/ : SUCCESS in 1m 47s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/165262/3/check/gate-tempest-dsvm-neutron-src-taskflow/b3ee1f7/ : SUCCESS in 50m 05s\n- gate-taskflow-python34 http://logs.openstack.org/62/165262/3/check/gate-taskflow-python34/afbf9e0/ : SUCCESS in 4m 52s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/62/165262/3/check/gate-taskflow-tox-py26-sa7-mysql/2c9d7a4/ : SUCCESS in 1m 38s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/62/165262/3/check/gate-taskflow-tox-py27-sa8-mysql/e98be79/ : SUCCESS in 1m 47s","accounts_in_message":[],"_revision_number":3},{"id":"3c33f3be6eb061e7e4902217596de7a415ba5e69","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-19 04:13:55.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"78d961bdfaacb64e24040a4a423ac393968b3ed5","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-03-19 04:13:55.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"aae2059c09259bb8a0fc22423f0e284a88785461","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-19 05:13:46.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-python26 http://logs.openstack.org/62/165262/3/gate/gate-taskflow-python26/b2c588f/ : SUCCESS in 1m 38s\n- gate-taskflow-docs http://docs-draft.openstack.org/62/165262/3/gate/gate-taskflow-docs/939a599//doc/build/html/ : SUCCESS in 1m 34s\n- gate-taskflow-pep8 http://logs.openstack.org/62/165262/3/gate/gate-taskflow-pep8/8528954/ : SUCCESS in 1m 10s\n- gate-taskflow-python27 http://logs.openstack.org/62/165262/3/gate/gate-taskflow-python27/34b7c13/ : SUCCESS in 1m 57s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/165262/3/gate/gate-tempest-dsvm-neutron-src-taskflow/04d5b63/ : SUCCESS in 55m 34s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/62/165262/3/gate/gate-taskflow-tox-py26-sa7-mysql/ced4020/ : SUCCESS in 2m 05s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/62/165262/3/gate/gate-taskflow-tox-py27-sa8-mysql/ec20514/ : SUCCESS in 1m 42s\n- gate-taskflow-python34 http://logs.openstack.org/62/165262/3/gate/gate-taskflow-python34/85cc196/ : SUCCESS in 3m 46s","accounts_in_message":[],"_revision_number":3},{"id":"e8114e25d0394bfb09774e209b5e4df9726daf71","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-19 05:13:47.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"35794109e982334a13a792d9e7ef653ce1c23954","revisions":{"0879c56c4a6a0de3bf6750c7a26cfee2053cefbf":{"kind":"REWORK","_number":1,"created":"2015-03-18 01:05:35.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/62/165262/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/62/165262/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/62/165262/1"}}},"commit":{"parents":[{"commit":"f8af1289c99f056a4611362c9d855f0559d89305","subject":"Merge \"Just use the class name instead of TYPE constant\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f8af1289c99f056a4611362c9d855f0559d89305"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-03-18 00:21:04.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-03-18 01:01:41.000000000","tz":-420},"subject":"Always return scope walker instances from `fetch_scopes_for`","message":"Always return scope walker instances from `fetch_scopes_for`\n\nInstead of returning tuples with fully expanded scopes return walker\ninstances that internally know how to avoid recomputing the visible\nscopes (they do this by caching each visibility level and looking in\nthe local cache before computing the scope and storing it in the cache).\n\nThis makes the usage more uniform and avoids returning different items\ndepending on what is found; making the code easier to follow and\nunderstand.\n\nAlso makes the scope walker call to \u0027_extract_atoms\u0027 to go via a static\nmethod so that if it is ever desired to alter what \u0027_extract_atoms\u0027 does\nit can be more easily done (using standard inheritance).\n\nChange-Id: I5916838163e6be843429fe7b89a0b5622e9c2f36\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/0879c56c4a6a0de3bf6750c7a26cfee2053cefbf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/0879c56c4a6a0de3bf6750c7a26cfee2053cefbf"}]},"branch":"refs/heads/master"},"99fba1b97658e7504de13162e707713000c33aa3":{"kind":"REWORK","_number":2,"created":"2015-03-18 05:44:07.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/62/165262/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/62/165262/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/62/165262/2"}}},"commit":{"parents":[{"commit":"f8af1289c99f056a4611362c9d855f0559d89305","subject":"Merge \"Just use the class name instead of TYPE constant\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f8af1289c99f056a4611362c9d855f0559d89305"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-03-18 00:21:04.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2015-03-18 05:43:02.000000000","tz":-420},"subject":"Always return scope walker instances from `fetch_scopes_for`","message":"Always return scope walker instances from `fetch_scopes_for`\n\nInstead of returning tuples with fully expanded scopes return walker\ninstances that internally know how to avoid recomputing the visible\nscopes (they do this by caching each visibility level and looking in\nthe local cache before computing the scope and storing it in the cache).\n\nThis makes the usage more uniform and avoids returning different items\ndepending on what is found; making the code easier to follow and\nunderstand.\n\nAlso makes the scope walker call to \u0027_extract_atoms\u0027 to go via a static\nmethod so that if it is ever desired to alter what \u0027_extract_atoms\u0027 does\nit can be more easily done (using standard inheritance).\n\nChange-Id: I5916838163e6be843429fe7b89a0b5622e9c2f36\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/99fba1b97658e7504de13162e707713000c33aa3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/99fba1b97658e7504de13162e707713000c33aa3"}]},"branch":"refs/heads/master"},"35794109e982334a13a792d9e7ef653ce1c23954":{"kind":"REWORK","_number":3,"created":"2015-03-18 17:35:12.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/62/165262/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/62/165262/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/165262/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/62/165262/3"}}},"commit":{"parents":[{"commit":"f8af1289c99f056a4611362c9d855f0559d89305","subject":"Merge \"Just use the class name instead of TYPE constant\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f8af1289c99f056a4611362c9d855f0559d89305"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-03-18 00:21:04.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2015-03-18 17:34:26.000000000","tz":-420},"subject":"Always return scope walker instances from `fetch_scopes_for`","message":"Always return scope walker instances from `fetch_scopes_for`\n\nInstead of returning tuples with fully expanded scopes return walker\ninstances that internally know how to avoid recomputing the visible\nscopes (they do this by caching each visibility level and looking in\nthe local cache before computing the scope and storing it in the cache).\n\nThis makes the usage more uniform and avoids returning different items\ndepending on what is found; making the code easier to follow and\nunderstand.\n\nAlso makes the scope walker call to \u0027_extract_atoms\u0027 to go via a static\nmethod so that if it is ever desired to alter what \u0027_extract_atoms\u0027 does\nit can be more easily done (using standard inheritance).\n\nChange-Id: I5916838163e6be843429fe7b89a0b5622e9c2f36\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/35794109e982334a13a792d9e7ef653ce1c23954"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/35794109e982334a13a792d9e7ef653ce1c23954"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
