)]}'
{"taskflow/conductors/backends/impl_executor.py":[{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"e8c5ba155c97c39afc53848f7b72f4af07bff415","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        finally:"},{"line_number":242,"context_line":"            self._dispatched.discard(fut)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def _claim_more_jobs(self, job):"},{"line_number":245,"context_line":"        if self._wait_timeout.is_stopped():"},{"line_number":246,"context_line":"            return False"},{"line_number":247,"context_line":"        if self._max_simultaneous_jobs \u003c\u003d 0:"}],"source_content_type":"text/x-python","patch_set":25,"id":"da85f559_299fd8b5","line":244,"updated":"2015-11-13 01:02:55.000000000","message":"_can_claim_more_jobs would be more descriptive of what this is doing","commit_id":"600fc5562ad8d3dfd0c187ac9f105a2cef93e4dd"}],"taskflow/conductors/backends/impl_nonblocking.py":[{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"7ab210c0091e76e6f1b2e30f6e06ba6860be987d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            persistence\u003dpersistence, engine\u003dengine,"},{"line_number":61,"context_line":"            engine_options\u003dengine_options, wait_timeout\u003dwait_timeout,"},{"line_number":62,"context_line":"            log\u003dlog, max_simultaneous_jobs\u003dmax_simultaneous_jobs)"},{"line_number":63,"context_line":"        if executor_factory is None:"},{"line_number":64,"context_line":"            self._executor_factory \u003d self._default_executor_factory"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            if not six.callable(executor_factory):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a29b11f_daa8ac8e","line":63,"updated":"2015-10-21 23:55:52.000000000","message":"Since here it assigned to self._executor_factory, how about making these making factory logic into a separate generate_executor_factory  or some sort ? I think it is better to separate it from __init__","commit_id":"c0fb552d5e92d8e48856751c7d0032fed8b10946"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"f7459df329a2cf1fdb87342fde1ab4b7da05ae92","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            persistence\u003dpersistence, engine\u003dengine,"},{"line_number":61,"context_line":"            engine_options\u003dengine_options, wait_timeout\u003dwait_timeout,"},{"line_number":62,"context_line":"            log\u003dlog, max_simultaneous_jobs\u003dmax_simultaneous_jobs)"},{"line_number":63,"context_line":"        if executor_factory is None:"},{"line_number":64,"context_line":"            self._executor_factory \u003d self._default_executor_factory"},{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            if not six.callable(executor_factory):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a29b11f_5a4c9cc7","line":63,"in_reply_to":"3a29b11f_daa8ac8e","updated":"2015-10-22 00:07:24.000000000","message":"Factory to make a factory? Unsure if that\u0027s needed, the executor_factory callback that can be provided can internally alter its behavior as needed; do u think its needed to have an executor_factory_factory?","commit_id":"c0fb552d5e92d8e48856751c7d0032fed8b10946"}],"taskflow/conductors/backends/impl_pooled.py":[{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"ed0e415fe1bcb22ca81c225227a29fbed88763bb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    #: Default timeout used to idle/wait when no jobs have been found."},{"line_number":69,"context_line":"    WAIT_TIMEOUT \u003d 0.5"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    MAX_SIMULTANEOUS_JOBS \u003d -1"},{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":"    Default maximum number of jobs that can be in progress at the same time."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba15a1d1_f0cba41c","line":71,"updated":"2015-09-15 18:13:45.000000000","message":"Can we just make this an option in __init__?  That would also make the blocking version use a process pool if you pass in a number, right?  That would be useful as well.","commit_id":"0b64e193e2fa0bf66e94e623f551f345ce692c7a"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"bf11c9b0db3fd592bc88741f0f5710c5e891086a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"       the ``${event}`` in this pseudo-variable will be one of these events."},{"line_number":101,"context_line":"    \"\"\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def __init__(self, name, jobboard,"},{"line_number":104,"context_line":"                 persistence\u003dNone, engine\u003dNone,"},{"line_number":105,"context_line":"                 engine_options\u003dNone, wait_timeout\u003dNone,"},{"line_number":106,"context_line":"                 log\u003dNone):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba15a1d1_76222cbb","line":103,"updated":"2015-09-15 19:02:59.000000000","message":"Same feedback as the last time.  Can we allow for passing in the number of simultaneous jobs instead of just defining it per class?  Would be nice to control the number of threads since they\u0027ll be waiting on I/O a lot, the default of cpus + 1 is probably low.","commit_id":"874aed1bb2a549d35e084713b1b73e67d9ba9312"}],"taskflow/examples/99_bottles.py":[{"author":{"_account_id":12906,"name":"tonytan4ever","email":"tony.tan@rackspace.com","username":"tonytan4ever"},"change_message_id":"7ab210c0091e76e6f1b2e30f6e06ba6860be987d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                  provides\u003d\u0027bottles_left\u0027)"},{"line_number":97,"context_line":"    pass_it \u003d PassItAround(\"pass-%s-around\" % count)"},{"line_number":98,"context_line":"    next_bottles \u003d Conclusion(\"next-bottles-%s\" % (count - 1))"},{"line_number":99,"context_line":"    s.add(take_bottle, pass_it, next_bottles)"},{"line_number":100,"context_line":"    for bottle in reversed(list(range(1, count))):"},{"line_number":101,"context_line":"        take_bottle \u003d TakeABottleDown(\"take-bottle-%s\" % bottle,"},{"line_number":102,"context_line":"                                      provides\u003d\u0027bottles_left\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a29b11f_fa84880b","line":99,"updated":"2015-10-21 23:55:52.000000000","message":"Just one empty line ? lol","commit_id":"c0fb552d5e92d8e48856751c7d0032fed8b10946"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"f7459df329a2cf1fdb87342fde1ab4b7da05ae92","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                                  provides\u003d\u0027bottles_left\u0027)"},{"line_number":97,"context_line":"    pass_it \u003d PassItAround(\"pass-%s-around\" % count)"},{"line_number":98,"context_line":"    next_bottles \u003d Conclusion(\"next-bottles-%s\" % (count - 1))"},{"line_number":99,"context_line":"    s.add(take_bottle, pass_it, next_bottles)"},{"line_number":100,"context_line":"    for bottle in reversed(list(range(1, count))):"},{"line_number":101,"context_line":"        take_bottle \u003d TakeABottleDown(\"take-bottle-%s\" % bottle,"},{"line_number":102,"context_line":"                                      provides\u003d\u0027bottles_left\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3a29b11f_1ac94426","line":99,"in_reply_to":"3a29b11f_fa84880b","updated":"2015-10-22 00:07:24.000000000","message":"Ya, not sure why I did that, ha","commit_id":"c0fb552d5e92d8e48856751c7d0032fed8b10946"}],"taskflow/utils/misc.py":[{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"c85e2e777e346ea4fdf14c5ada5e81eae65b7fdd","unresolved":false,"context_lines":[{"line_number":73,"context_line":"def get_hostname(unknown_hostname\u003dUNKNOWN_HOSTNAME):"},{"line_number":74,"context_line":"    \"\"\"Gets the machines hostname; if not able to returns an invalid one.\"\"\""},{"line_number":75,"context_line":"    try:"},{"line_number":76,"context_line":"        hostname \u003d socket.gethostname()"},{"line_number":77,"context_line":"        if not hostname:"},{"line_number":78,"context_line":"            return unknown_hostname"},{"line_number":79,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a29b11f_e7cdba66","line":76,"updated":"2015-10-22 13:27:13.000000000","message":"Probably outside the scope of this patch, but I\u0027d prefer socket.getfqdn().  That will fall back to gethostname() if the current machine doesn\u0027t have a fqdn.  Thoughts?","commit_id":"bd13126fe159383bc819c698af6680064eac8f64"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"fbaa1d070ef63720c7eca12ddf7b654290800808","unresolved":false,"context_lines":[{"line_number":73,"context_line":"def get_hostname(unknown_hostname\u003dUNKNOWN_HOSTNAME):"},{"line_number":74,"context_line":"    \"\"\"Gets the machines hostname; if not able to returns an invalid one.\"\"\""},{"line_number":75,"context_line":"    try:"},{"line_number":76,"context_line":"        hostname \u003d socket.gethostname()"},{"line_number":77,"context_line":"        if not hostname:"},{"line_number":78,"context_line":"            return unknown_hostname"},{"line_number":79,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a29b11f_9ab2064b","line":76,"in_reply_to":"3a29b11f_e7cdba66","updated":"2015-10-22 22:23:16.000000000","message":"Seems fine to me. Changing.","commit_id":"bd13126fe159383bc819c698af6680064eac8f64"}]}