)]}'
{"taskflow/flow.py":[{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"a64c607911c942320d00e43d87a1a81d4092e06f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Iterates over the children of the flow.\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @abc.abstractmethod"},{"line_number":91,"context_line":"    def iter_links(self, data\u003dTrue):"},{"line_number":92,"context_line":"        \"\"\"Iterates over dependency links between children of the flow."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        Iterates over tuples. Possible tuple members:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_fe1f27b5","line":91,"updated":"2015-08-24 08:10:25.000000000","message":"I don\u0027t think having this data\u003dTrue option adds anything as the default behavior is to always return data.  If the intention is to deprecate the returning of data that\u0027s a different story.  A caller using this function that is not interested in the data has  to be aware enough to pass in data\u003dFalse.  In which case they could just as well bind the data to a variable and not use it.  Having the option adds a decision point without any apparent benefit.","commit_id":"7669fcafb9fb98672af01774199ae73aa5ecc9bf"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"6bbb4ab5129cd7cd9b3c9e19cf06a57ba53a961f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Iterates over the children of the flow.\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @abc.abstractmethod"},{"line_number":91,"context_line":"    def iter_links(self, data\u003dTrue):"},{"line_number":92,"context_line":"        \"\"\"Iterates over dependency links between children of the flow."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        Iterates over tuples. Possible tuple members:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_799ed108","line":91,"in_reply_to":"fa1b9901_fe1f27b5","updated":"2015-08-24 08:43:08.000000000","message":"Min Pae, intention is to not to return metadata if user don\u0027t need it. I checked patch again, it seems that there were 2 decision points in graph_flow implementation(one in networkx graph and one in graph_flow class). Also I\u0027ve checked you concern about costs, them doesn\u0027t seem to be too heavy. \nAs for me, adding data\u003dFalse in client code seems clearer then unused variable.","commit_id":"7669fcafb9fb98672af01774199ae73aa5ecc9bf"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"a64c607911c942320d00e43d87a1a81d4092e06f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @abc.abstractmethod"},{"line_number":105,"context_line":"    def iter_nodes(self, data\u003dTrue):"},{"line_number":106,"context_line":"        \"\"\"Iterate over nodes of the flow"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        If data \u003d\u003d True iterates over tuples `(A, meta)`:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_7e59d78d","line":105,"updated":"2015-08-24 08:10:25.000000000","message":"Same as above","commit_id":"7669fcafb9fb98672af01774199ae73aa5ecc9bf"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":97,"context_line":"              said that ``B`` depends on ``A`` or ``B`` requires ``A``;"},{"line_number":98,"context_line":"            * ``meta`` is link metadata, a dictionary."},{"line_number":99,"context_line":"        If data \u003d\u003d True, iterates over ``(A, B, meta)`` 3-tuples and"},{"line_number":100,"context_line":"        ``(A, B)`` otherwise"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_e1667c28","line":100,"updated":"2015-08-25 01:06:45.000000000","message":"Missing .","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            * ``meta`` is link metadata, a dictionary."},{"line_number":99,"context_line":"        If data \u003d\u003d True, iterates over ``(A, B, meta)`` 3-tuples and"},{"line_number":100,"context_line":"        ``(A, B)`` otherwise"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        \"\"\""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_c1633819","line":101,"updated":"2015-08-25 01:06:45.000000000","message":"Blank line here is wrong - it will distort API docs.","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @abc.abstractmethod"},{"line_number":105,"context_line":"    def iter_nodes(self, data\u003dTrue):"},{"line_number":106,"context_line":"        \"\"\"Iterate over nodes of the flow"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        If data \u003d\u003d True iterates over tuples `(A, meta)`:"},{"line_number":109,"context_line":"            * ``A`` is a child (atom or subflow) of current flow"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_217d54b1","line":106,"updated":"2015-08-25 01:06:45.000000000","message":"Missing .","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        If data \u003d\u003d True iterates over tuples `(A, meta)`:"},{"line_number":109,"context_line":"            * ``A`` is a child (atom or subflow) of current flow"},{"line_number":110,"context_line":"            * ``meta`` is link metadata, a dictionary"},{"line_number":111,"context_line":"        If data \u003d\u003d False iterates over flow nodes"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        \"\"\""},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_a17084dd","line":111,"updated":"2015-08-25 01:06:45.000000000","message":"Missing .","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            * ``A`` is a child (atom or subflow) of current flow"},{"line_number":110,"context_line":"            * ``meta`` is link metadata, a dictionary"},{"line_number":111,"context_line":"        If data \u003d\u003d False iterates over flow nodes"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        \"\"\""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def __str__(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_21a6b453","line":112,"updated":"2015-08-25 01:06:45.000000000","message":"Blank line here is unneeded - it will distort API docs.","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"2312d69725a7e75f289f9101f58b9214768d4dc9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        \"\"\"Iterates over the children of the flow.\"\"\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @abc.abstractmethod"},{"line_number":91,"context_line":"    def iter_links(self, data\u003dTrue):"},{"line_number":92,"context_line":"        \"\"\"Iterates over dependency links between children of the flow."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        Iterates over 3-tuples ``(A, B, meta)``, where"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_5f5fdfe4","line":91,"updated":"2015-08-25 15:29:56.000000000","message":"I guess the \u0027data\u003dTrue\u0027 isn\u0027t needed here anymore?","commit_id":"4f437a495784bf9ae0a37213cce36d75e4ea20d6"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"2312d69725a7e75f289f9101f58b9214768d4dc9","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @abc.abstractmethod"},{"line_number":102,"context_line":"    def iter_nodes(self, data\u003dTrue):"},{"line_number":103,"context_line":"        \"\"\"Iterate over nodes of the flow."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        Iterates over 2-tuples ``(A, meta)``, where"},{"line_number":106,"context_line":"            * ``A`` is a child (atom or subflow) of current flow;"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_ff491332","line":103,"updated":"2015-08-25 15:29:56.000000000","message":"I guess the \u0027data\u003dTrue\u0027 isn\u0027t needed here anymore?","commit_id":"4f437a495784bf9ae0a37213cce36d75e4ea20d6"}],"taskflow/patterns/graph_flow.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"62ad256d5643c8cf46dd86362e30f98b4ef9a4fe","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            yield n"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def iter_links(self, data\u003dTrue):"},{"line_number":273,"context_line":"        for tuple in self._get_subgraph(). \\"},{"line_number":274,"context_line":"                edges_iter(data\u003ddata):"},{"line_number":275,"context_line":"            yield tuple"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_3d291038","line":273,"updated":"2015-08-24 15:35:54.000000000","message":"Can u avoid calling this variable the name of a built-in type :)\n\nJust don\u0027t want people to be confused here...\n\n \u003e\u003e\u003e x \u003d tuple\n \u003e\u003e\u003e x\n \u003ctype \u0027tuple\u0027\u003e\n\nThanks :)","commit_id":"6d944c84db66b286a2437a25156a5e3f412be026"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"2c0b6e016c0eac6e5b84245c5867a83ef6848b3d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            yield n"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def iter_links(self, data\u003dTrue):"},{"line_number":273,"context_line":"        for tuple in self._get_subgraph(). \\"},{"line_number":274,"context_line":"                edges_iter(data\u003ddata):"},{"line_number":275,"context_line":"            yield tuple"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_4e88c822","line":273,"in_reply_to":"fa1b9901_3d291038","updated":"2015-08-24 16:25:19.000000000","message":"Done","commit_id":"6d944c84db66b286a2437a25156a5e3f412be026"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    def iter_links(self, data\u003dTrue):"},{"line_number":273,"context_line":"        for link_info in self._get_subgraph(). \\"},{"line_number":274,"context_line":"                edges_iter(data\u003ddata):"},{"line_number":275,"context_line":"            yield link_info"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def iter_nodes(self, data\u003dTrue):"},{"line_number":278,"context_line":"        for node_info in self._get_subgraph().\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_e14d1c9a","line":275,"updated":"2015-08-25 01:06:45.000000000","message":"This can be written much more cleanly as:\n\n return self._get_subgraph().edges_iter(data\u003ddata)","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    def iter_nodes(self, data\u003dTrue):"},{"line_number":278,"context_line":"        for node_info in self._get_subgraph().\\"},{"line_number":279,"context_line":"                nodes_iter(data\u003ddata):"},{"line_number":280,"context_line":"            yield node_info"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    @property"},{"line_number":283,"context_line":"    def requires(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_415f2841","line":280,"updated":"2015-08-25 01:06:45.000000000","message":"Likewise here.","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"80a09c62c248cbd11bff7c5156f447b0250b3a49","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        return self._get_subgraph().edges_iter(data\u003dTrue)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def iter_nodes(self):"},{"line_number":276,"context_line":"        return self._get_subgraph().nodes_iter(data\u003dTrue)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @property"},{"line_number":279,"context_line":"    def requires(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_f4038740","line":276,"updated":"2015-08-28 14:36:05.000000000","message":"To be consistent with __iter__ how about,\n\n def iter_nodes(self):\n   g \u003d self._get_subgraph()\n   for n in g.topological_sort():\n        yield n, g.node[n]\n\nThat I think will solve your later problem also,\n\nThen this also allows __iter__ to be,\n\n def __iter__(self):\n   for n, _n_data in self. iter_nodes():\n      yield n","commit_id":"2b323159f9bd84f67f0ab60f15bfdf1e02b3b20d"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"f548b07d508c047f4fb5a60015594f2f959c7a77","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        return self._get_subgraph().edges_iter(data\u003dTrue)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def iter_nodes(self):"},{"line_number":276,"context_line":"        return self._get_subgraph().nodes_iter(data\u003dTrue)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    @property"},{"line_number":279,"context_line":"    def requires(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_b70431c0","line":276,"in_reply_to":"da20952f_f4038740","updated":"2015-08-28 15:07:18.000000000","message":"late night commits, yep. Done","commit_id":"2b323159f9bd84f67f0ab60f15bfdf1e02b3b20d"}],"taskflow/patterns/linear_flow.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            for src, dst in \\"},{"line_number":67,"context_line":"                    zip(self._children[:-1], self._children[1:]):"},{"line_number":68,"context_line":"                yield (src, dst)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def iter_nodes(self, data\u003dTrue):"},{"line_number":71,"context_line":"        if data:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_443bb6d1","line":68,"updated":"2015-08-25 01:06:45.000000000","message":"This too can be cleaner: we can avoid duplicating the expression and make it clear that data only adds to whats returned.\n\n items \u003d (self._children[:-1], self._children[1:])\n if data:\n     def meta():\n         while True:\n             yield _LINK_METADATA.copy()\n     items.append(meta())\n return izip(*items)","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                yield (n, {})"},{"line_number":74,"context_line":"        else:"},{"line_number":75,"context_line":"            for n in self._children:"},{"line_number":76,"context_line":"                yield n"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_248c827e","line":76,"updated":"2015-08-25 01:06:45.000000000","message":"nodes \u003d iter(self._children)\n if data:\n     def meta():\n         while True:\n             yield {}\n     return izip(nodes, meta())\n else:\n     return nodes","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"}],"taskflow/patterns/unordered_flow.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"ae614d71e77b91aa90e18a8fae94411463bea183","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                yield (n, {})"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            for n in self._children:"},{"line_number":57,"context_line":"                yield n"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @property"},{"line_number":60,"context_line":"    def requires(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa1b9901_84f30e0a","line":57,"updated":"2015-08-25 01:06:45.000000000","message":"This would be better modified as I proposed in the other flow.","commit_id":"638851f26b4430f654e7bb0f0191c28baf40e9da"}]}
