)]}'
{"taskflow/storage.py":[{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"c1d7e585424c9ca2cf281f6542087531c9e62abe","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        \"\"\"Gets a dict of atom name \u003d\u003e (state, intention) given atom names.\"\"\""},{"line_number":389,"context_line":"        details \u003d {}"},{"line_number":390,"context_line":"        for name in atom_names:"},{"line_number":391,"context_line":"            if name in details:"},{"line_number":392,"context_line":"                continue"},{"line_number":393,"context_line":"            source, _clone \u003d self._atomdetail_by_name(name)"},{"line_number":394,"context_line":"            details[name] \u003d (source.state, source.intention)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_611a8e19","line":391,"updated":"2015-09-02 15:11:46.000000000","message":"if this is an attempt to dedupe the details output, is it perhaps simpler to do the following on line 390?\n\nfor name in set(atom_names):\n...","commit_id":"26d29736977dee2f390677e6773d5e68c5d1ddf7"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a31c3debe475359b68909a0a102396adf448ce26","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        \"\"\"Gets a dict of atom name \u003d\u003e (state, intention) given atom names.\"\"\""},{"line_number":389,"context_line":"        details \u003d {}"},{"line_number":390,"context_line":"        for name in atom_names:"},{"line_number":391,"context_line":"            if name in details:"},{"line_number":392,"context_line":"                continue"},{"line_number":393,"context_line":"            source, _clone \u003d self._atomdetail_by_name(name)"},{"line_number":394,"context_line":"            details[name] \u003d (source.state, source.intention)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_07d402bb","line":391,"in_reply_to":"da20952f_611a8e19","updated":"2015-09-02 15:58:49.000000000","message":"Either is fine with me, one creates a temporary set (your way), the other way doesn\u0027t (but does do alot of \u0027in\u0027 checks), can move to your way if u so desire.","commit_id":"26d29736977dee2f390677e6773d5e68c5d1ddf7"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"4847913a19c17027be2bbf243cc56dda72b58d58","unresolved":false,"context_lines":[{"line_number":388,"context_line":"    def get_atoms_states(self, atom_names):"},{"line_number":389,"context_line":"        \"\"\"Gets a dict of atom name \u003d\u003e (state, intention) given atom names.\"\"\""},{"line_number":390,"context_line":"        details \u003d {}"},{"line_number":391,"context_line":"        for name in iter_utils.unique_seen(atom_names):"},{"line_number":392,"context_line":"            source, _clone \u003d self._atomdetail_by_name(name)"},{"line_number":393,"context_line":"            details[name] \u003d (source.state, source.intention)"},{"line_number":394,"context_line":"        return details"}],"source_content_type":"text/x-python","patch_set":8,"id":"da20952f_833d2291","line":391,"updated":"2015-09-03 20:50:27.000000000","message":"i\u0027d prefer to use set explicitly instead, as Min Pae proposed in previous patch set. I\u0027ve checked unique_seen and noticed that it also creates extra \u0027seen\u0027 set internally, so both approaches are pretty equal.","commit_id":"15975ff4429d3b9e2fa9e28ce772977103e6953d"}]}