)]}'
{"taskflow/engines/action_engine/engine.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"94e86768df95ff5247aae651c734005d152ab81a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                # flow without ensuring its storage is setup for"},{"line_number":134,"context_line":"                # its atoms (since this state change does not affect"},{"line_number":135,"context_line":"                # those units)."},{"line_number":136,"context_line":"                check_storage_ensured\u003dTrue,"},{"line_number":137,"context_line":"                check_validated\u003dFalse)"},{"line_number":138,"context_line":"    def suspend(self):"},{"line_number":139,"context_line":"        self._change_state(states.SUSPENDING)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_8c1dae75","line":136,"updated":"2015-10-14 04:30:40.000000000","message":"apologies  in advance for my ignorance..\n\nthis changed from False to True..\n\nso storage was really needed because suspend need to store it states?","commit_id":"bff88bb36c3d4149bcb5984bd687f2f05dc9f7df"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"b9226664cbe5ffeacac4f9e66b2525536f704d94","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                # flow without ensuring its storage is setup for"},{"line_number":134,"context_line":"                # its atoms (since this state change does not affect"},{"line_number":135,"context_line":"                # those units)."},{"line_number":136,"context_line":"                check_storage_ensured\u003dTrue,"},{"line_number":137,"context_line":"                check_validated\u003dFalse)"},{"line_number":138,"context_line":"    def suspend(self):"},{"line_number":139,"context_line":"        self._change_state(states.SUSPENDING)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_851c7c14","line":136,"in_reply_to":"5a2ca52d_8c1dae75","updated":"2015-10-14 20:19:08.000000000","message":"Yes, let me switch it back and not do it in this commit though...","commit_id":"bff88bb36c3d4149bcb5984bd687f2f05dc9f7df"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"94e86768df95ff5247aae651c734005d152ab81a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        self._validated \u003d True"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    @fasteners.locked"},{"line_number":320,"context_line":"    @_pre_check(\u0027prepare\u0027, check_validated\u003dFalse, check_storage_ensured\u003dFalse)"},{"line_number":321,"context_line":"    def prepare(self):"},{"line_number":322,"context_line":"        if not self._storage_ensured:"},{"line_number":323,"context_line":"            # Set our own state to resuming -\u003e (ensure atoms exist"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_ec7782d2","line":320,"updated":"2015-10-14 04:30:40.000000000","message":"nit: would be nice to see check_storage_ensured before check_validated, kinda got confused when the args got switch while reviewing","commit_id":"bff88bb36c3d4149bcb5984bd687f2f05dc9f7df"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"c0b24fd5164c89d4afac298a47e79b74da0354c3","unresolved":false,"context_lines":[{"line_number":317,"context_line":"        self._validated \u003d True"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    @fasteners.locked"},{"line_number":320,"context_line":"    @_pre_check(\u0027prepare\u0027, check_validated\u003dFalse, check_storage_ensured\u003dFalse)"},{"line_number":321,"context_line":"    def prepare(self):"},{"line_number":322,"context_line":"        if not self._storage_ensured:"},{"line_number":323,"context_line":"            # Set our own state to resuming -\u003e (ensure atoms exist"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_45c4245e","line":320,"in_reply_to":"5a2ca52d_ec7782d2","updated":"2015-10-14 20:23:25.000000000","message":"Okies.","commit_id":"bff88bb36c3d4149bcb5984bd687f2f05dc9f7df"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"cbd79493fc3f2c11667071f6bd20e965ae58dd12","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        task_executor.stop()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _pre_check(do_what,"},{"line_number":60,"context_line":"               check_compiled\u003dTrue, check_storage_ensured\u003dTrue,"},{"line_number":61,"context_line":"               check_validated\u003dTrue):"},{"line_number":62,"context_line":"    \"\"\"Engine state precondition checking decorator.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_e05f1e0d","line":59,"updated":"2015-12-02 16:27:48.000000000","message":"Rather than requiring they pass in the method name, why not just do meth.__name__ ?","commit_id":"2fcf8f9c29f9eddb878599d568e7ae6116334e70"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"5f8f2eac56b9f761028528b1eac322d85c50f331","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        task_executor.stop()"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _pre_check(do_what,"},{"line_number":60,"context_line":"               check_compiled\u003dTrue, check_storage_ensured\u003dTrue,"},{"line_number":61,"context_line":"               check_validated\u003dTrue):"},{"line_number":62,"context_line":"    \"\"\"Engine state precondition checking decorator.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_ae3d80de","line":59,"in_reply_to":"9a8ffd7b_e05f1e0d","updated":"2015-12-02 18:18:32.000000000","message":"Ah, good idea, ya, seems like we can just do that here since all the passed in names are just the method name :-P","commit_id":"2fcf8f9c29f9eddb878599d568e7ae6116334e70"}]}