)]}'
{"id":"openstack%2Ftaskflow~235097","triplet_id":"openstack%2Ftaskflow~master~I27e4af7b891ea3fd1826d5a5e71e808ad5af7647","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"I27e4af7b891ea3fd1826d5a5e71e808ad5af7647","subject":"Ensure node \u0027remove\u0027 and \u0027disassociate\u0027 can not be called when frozen","status":"MERGED","created":"2015-10-15 05:47:20.000000000","updated":"2015-11-18 16:37:20.000000000","submitted":"2015-11-18 16:37:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"25f2e7244740acefe49618c88988e6d7fb7dfc4f","_number":235097,"virtual_id_number":235097,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":2,"date":"2015-11-18 16:37:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"all":[{"value":2,"date":"2015-11-18 15:20:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-11-13 20:26:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"all":[{"value":1,"date":"2015-11-18 15:20:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-13 20:26:20.000000000","updated_by":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"reviewer":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"state":"REVIEWER"},{"updated":"2015-11-18 15:20:17.000000000","updated_by":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"reviewer":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"state":"REVIEWER"},{"updated":"2015-11-18 16:37:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"17925d6a71cb984aaa7ba2b204b7ea0ebcd3ab6b","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2015-10-15 05:47:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3782fed103bee8e9147c9ef055cdc3a9861a0cea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-15 06:54:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-pep8 http://logs.openstack.org/97/235097/1/check/gate-taskflow-pep8/74fd59a/ : SUCCESS in 1m 03s\n- gate-taskflow-docs http://docs-draft.openstack.org/97/235097/1/check/gate-taskflow-docs/d1baa48//doc/build/html/ : SUCCESS in 1m 11s\n- gate-taskflow-python27 http://logs.openstack.org/97/235097/1/check/gate-taskflow-python27/863c8be/ : SUCCESS in 2m 06s\n- gate-taskflow-python34 http://logs.openstack.org/97/235097/1/check/gate-taskflow-python34/1534e67/ : SUCCESS in 2m 36s\n- gate-taskflow-pypy http://logs.openstack.org/97/235097/1/check/gate-taskflow-pypy/f41f109/ : FAILURE in 1m 35s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/97/235097/1/check/gate-tempest-dsvm-neutron-src-taskflow/a05817a/ : SUCCESS in 1h 06m 37s","accounts_in_message":[],"_revision_number":1},{"id":"136eeb81feb19c64e1aeac85a9001eec2321af19","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2015-11-13 20:26:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"e5e720c4feb447eeeab905ba60871f882017ac98","author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"date":"2015-11-18 15:20:17.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nMakes sense to me.","accounts_in_message":[],"_revision_number":1},{"id":"9f7ee4a3a9b1837cc4890a51e5a8086a16ce1f8b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-18 15:20:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"825be68f265b0d02d2e95a816b549be9e0530034","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-18 16:37:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-docs http://docs-draft.openstack.org/97/235097/1/gate/gate-taskflow-docs/a6e2b8d//doc/build/html/ : SUCCESS in 1m 45s\n- gate-taskflow-pep8 http://logs.openstack.org/97/235097/1/gate/gate-taskflow-pep8/1577e6e/ : SUCCESS in 1m 08s\n- gate-taskflow-python27 http://logs.openstack.org/97/235097/1/gate/gate-taskflow-python27/3b6f6e4/ : SUCCESS in 2m 08s\n- gate-taskflow-python34 http://logs.openstack.org/97/235097/1/gate/gate-taskflow-python34/1ef564e/ : SUCCESS in 2m 01s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/97/235097/1/gate/gate-tempest-dsvm-neutron-src-taskflow/f4b2967/ : SUCCESS in 1h 16m 32s","accounts_in_message":[],"_revision_number":1},{"id":"25f2e7244740acefe49618c88988e6d7fb7dfc4f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-18 16:37:20.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4f41c43ed0d2dc01c953d4904e9cca6f6f662da5","revisions":{"4f41c43ed0d2dc01c953d4904e9cca6f6f662da5":{"kind":"REWORK","_number":1,"created":"2015-10-15 05:47:20.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/97/235097/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/97/235097/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/97/235097/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/97/235097/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/97/235097/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/97/235097/1"}}},"commit":{"parents":[{"commit":"4677fdb30e801d7f40344f7ca83cfc6e20c30160","subject":"Merge \"Use the node built-in \u0027dfs_iter\u0027 instead of recursion\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/4677fdb30e801d7f40344f7ca83cfc6e20c30160"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2015-10-15 05:45:13.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2015-10-15 05:47:06.000000000","tz":-420},"subject":"Ensure node \u0027remove\u0027 and \u0027disassociate\u0027 can not be called when frozen","message":"Ensure node \u0027remove\u0027 and \u0027disassociate\u0027 can not be called when frozen\n\nWhen a tree node is frozen it should not be possible to remove nodes\nfrom it or cause that tree node to disassociate itself from its parent,\nso make sure that the appropriate decorator is used to ensure this\ncan not happen (and add tests that verify an exception is raised when\nmutations are attempted).\n\nChange-Id: I27e4af7b891ea3fd1826d5a5e71e808ad5af7647\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/4f41c43ed0d2dc01c953d4904e9cca6f6f662da5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/4f41c43ed0d2dc01c953d4904e9cca6f6f662da5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
