)]}'
{"taskflow/conductors/base.py":[{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"e0296cd4cfc5a05408652aa7c127396774226da0","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if flow_detail.meta and \u0027store\u0027 in flow_detail.meta:"},{"line_number":121,"context_line":"            store.update(flow_detail.meta[\u0027store\u0027])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if job.details and \u0027store\u0027 in job.details:"},{"line_number":124,"context_line":"            store.update(job.details[\"store\"])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        engine \u003d engines.load_from_detail(flow_detail, store\u003dstore,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_45122fb6","line":123,"updated":"2016-01-20 18:32:31.000000000","message":"any reason this is if rather than elif? however unlikely, if flow_detail.meta and job.details both have store then job.details will override flow_detail, is this intended?","commit_id":"909d4e0d74035aa725a5909d7c20271befc4115c"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"bd79f92ca10861b5f69485d700abe56e665ff321","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if flow_detail.meta and \u0027store\u0027 in flow_detail.meta:"},{"line_number":121,"context_line":"            store.update(flow_detail.meta[\u0027store\u0027])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if job.details and \u0027store\u0027 in job.details:"},{"line_number":124,"context_line":"            store.update(job.details[\"store\"])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        engine \u003d engines.load_from_detail(flow_detail, store\u003dstore,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_fb5740c8","line":123,"in_reply_to":"9a68dd71_38263ebb","updated":"2016-01-20 19:03:42.000000000","message":"I think precedence is fine, I have no opinion (yet) as to which should take precedence over the other, but it does need to be documented so that users can understand how stored values in one level affect or override another.","commit_id":"909d4e0d74035aa725a5909d7c20271befc4115c"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"28f6a19f1cf4e58a2ba3d8764f0566f11b5e5921","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        if flow_detail.meta and \u0027store\u0027 in flow_detail.meta:"},{"line_number":121,"context_line":"            store.update(flow_detail.meta[\u0027store\u0027])"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        if job.details and \u0027store\u0027 in job.details:"},{"line_number":124,"context_line":"            store.update(job.details[\"store\"])"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        engine \u003d engines.load_from_detail(flow_detail, store\u003dstore,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a68dd71_38263ebb","line":123,"in_reply_to":"9a68dd71_45122fb6","updated":"2016-01-20 18:39:08.000000000","message":"Yeah, it was intentional.  In the unlikely scenario that they put the store both in the flow meta and the job, we merge them together.  If there are duplicate keys, the job overrides the flow meta.  I didn\u0027t think it worth throwing an exception, but I suppose I could if the same key is in both and has different values, since the order of precedence isn\u0027t entirely obvious.\n\nThoughts?","commit_id":"909d4e0d74035aa725a5909d7c20271befc4115c"}],"taskflow/engines/helpers.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"303c9f0bca48ec9dcdc4c5910be56a7e5b9497e6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    else:"},{"line_number":194,"context_line":"        if store:"},{"line_number":195,"context_line":"            engine.storage.inject(store)"},{"line_number":196,"context_line":"            engine.storage.update_flow_metadata(dict(store\u003dstore))"},{"line_number":197,"context_line":"        return engine"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_bb50cf5f","line":196,"updated":"2015-10-29 02:33:27.000000000","message":"Ya, hmmm, non-local (out of local-memory) writes to persistence locations, not sure I like this :-/ see comments","commit_id":"7d21b3ae28dbbe3d3e4ed4b28160f5c6d66e257c"}]}