)]}'
{"taskflow/engines/action_engine/process_executor.py":[{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"b0c336b7057d2101a2c9f9c3e46390b994a48a1e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    _transitions \u003d {"},{"line_number":131,"context_line":"        \u0027__begin__\u0027: \u0027magic_header_left\u0027,"},{"line_number":132,"context_line":"        \u0027magic_header_left\u0027: \u0027mac_header_left\u0027,"},{"line_number":133,"context_line":"        \u0027mac_header_left\u0027: \u0027mac_left\u0027,"},{"line_number":134,"context_line":"        \u0027mac_left\u0027: \u0027identity_header_left\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba63e191_90aa86d3","line":131,"updated":"2016-01-19 14:06:03.000000000","message":"There\u0027s nothing really wrong with this approach, but wouldn\u0027t a queue type structure be more obvious?\n\n_steps \u003d deque([\u0027__begin__\u0027, \u0027magic_header_left\u0027, \u0027mac_header_left\u0027, ...])\n\nThen you just popleft() until there are no steps left.","commit_id":"9f33edba135760cebe887d924db189776744a935"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1e3b81f38505fa4423ed3caba663d40992b81ed0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    }"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    _transitions \u003d {"},{"line_number":131,"context_line":"        \u0027__begin__\u0027: \u0027magic_header_left\u0027,"},{"line_number":132,"context_line":"        \u0027magic_header_left\u0027: \u0027mac_header_left\u0027,"},{"line_number":133,"context_line":"        \u0027mac_header_left\u0027: \u0027mac_left\u0027,"},{"line_number":134,"context_line":"        \u0027mac_left\u0027: \u0027identity_header_left\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba63e191_6814b143","line":131,"in_reply_to":"ba63e191_90aa86d3","updated":"2016-01-19 21:28:36.000000000","message":"Hmmmm, could try that.\n\nI\u0027d like to drop this whole thing entirely if I could use python-suitcase (or similar); but all those libs don\u0027t seem to do incremental parsing (if they even offer it at all).\n\nBut sure, let me try your deque idea.","commit_id":"9f33edba135760cebe887d924db189776744a935"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"b0c336b7057d2101a2c9f9c3e46390b994a48a1e","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def __init__(self, sock, addr, dispatcher):"},{"line_number":418,"context_line":"        if six.PY2:"},{"line_number":419,"context_line":"            asyncore.dispatcher.__init__(self, map\u003ddispatcher.map, sock\u003dsock)"},{"line_number":420,"context_line":"        else:"},{"line_number":421,"context_line":"            super(DispatcherHandler, self).__init__(map\u003ddispatcher.map,"},{"line_number":422,"context_line":"                                                    sock\u003dsock)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba63e191_10abf675","line":419,"updated":"2016-01-19 14:06:03.000000000","message":"In Python 2 you can\u0027t treat it as a parent class for some reason?  It looks like both the if and else are the exact same thing to me.  Is this some weird Python corner case I\u0027m not aware of?","commit_id":"9f33edba135760cebe887d924db189776744a935"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1e3b81f38505fa4423ed3caba663d40992b81ed0","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    def __init__(self, sock, addr, dispatcher):"},{"line_number":418,"context_line":"        if six.PY2:"},{"line_number":419,"context_line":"            asyncore.dispatcher.__init__(self, map\u003ddispatcher.map, sock\u003dsock)"},{"line_number":420,"context_line":"        else:"},{"line_number":421,"context_line":"            super(DispatcherHandler, self).__init__(map\u003ddispatcher.map,"},{"line_number":422,"context_line":"                                                    sock\u003dsock)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ba63e191_48476d4b","line":419,"in_reply_to":"ba63e191_10abf675","updated":"2016-01-19 21:28:36.000000000","message":"Ya, weird python2.x case with old-style-classes.\n\n    \u003e\u003e\u003e import asyncore\n    \u003e\u003e\u003e class B(asyncore.dispatcher):\n    ...   def __init__(self):\n    ...      super(B, self).__init__()\n    ... \n    \u003e\u003e\u003e \n    \u003e\u003e\u003e x \u003d B()\n    Traceback (most recent call last):\n      File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n      File \"\u003cstdin\u003e\", line 3, in __init__\n    TypeError: super() argument 1 must be type, not classobj","commit_id":"9f33edba135760cebe887d924db189776744a935"}]}