)]}'
{"id":"openstack%2Ftaskflow~270446","triplet_id":"openstack%2Ftaskflow~master~Ief2746debf496b017331a88c7913d9321aac0774","project":"openstack/taskflow","branch":"master","topic":"270446","hashtags":[],"change_id":"Ief2746debf496b017331a88c7913d9321aac0774","subject":"Use helper function for post-atom-completion work","status":"MERGED","created":"2016-01-20 19:46:50.000000000","updated":"2016-02-01 08:47:42.000000000","submitted":"2016-02-01 08:47:42.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"4463c606b5e4c891bfc4fca3dc73c9185ea04161","_number":270446,"virtual_id_number":270446,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":2,"date":"2016-02-01 08:47:42.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"all":[{"value":2,"date":"2016-01-21 14:56:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-02-01 07:08:17.000000000","_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"all":[{"value":0,"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-02-01 07:08:17.000000000","_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-21 14:56:59.000000000","updated_by":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"reviewer":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"state":"REVIEWER"},{"updated":"2016-02-01 07:08:17.000000000","updated_by":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"reviewer":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"state":"REVIEWER"},{"updated":"2016-02-01 08:47:42.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"744d63b689da6c0922b3f95b4a06deb9a31cdb41","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-01-20 19:46:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"89b8b4597684e81606d4a0abbad391972d01bcd5","author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"date":"2016-01-20 19:59:18.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"076d021335353212e8ca789244bbf353b9240aa6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-20 21:47:09.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-taskflow-pep8 http://logs.openstack.org/46/270446/1/check/gate-taskflow-pep8/a61875f/ : SUCCESS in 1m 23s\n- gate-taskflow-docs http://docs-draft.openstack.org/46/270446/1/check/gate-taskflow-docs/db92614//doc/build/html/ : SUCCESS in 1m 51s\n- gate-taskflow-python27 http://logs.openstack.org/46/270446/1/check/gate-taskflow-python27/193589d/ : FAILURE in 2m 31s\n- gate-taskflow-python34 http://logs.openstack.org/46/270446/1/check/gate-taskflow-python34/8dae72d/ : FAILURE in 2m 31s\n- gate-taskflow-pypy http://logs.openstack.org/46/270446/1/check/gate-taskflow-pypy/1c79d05/ : FAILURE in 1m 28s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/46/270446/1/check/gate-tempest-dsvm-neutron-src-taskflow/ac4fb38/ : SUCCESS in 1h 49m 25s","accounts_in_message":[],"_revision_number":1},{"id":"2d44b67bdaafbd08988d3bf84585b685cf4ddbf3","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-01-20 23:20:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d1f9c01344245fd9784c7d4843bc830df29d6542","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-01-20 23:24:29.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2},{"id":"5efb53143b3cbda0862e7655cf593730a3c0c3ce","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-01-21 05:48:31.000000000","message":"Restored","accounts_in_message":[],"_revision_number":2},{"id":"1af89342c8fcb253348e877d228c5c7ebee05d54","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-01-21 05:48:40.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"bc539597e874a6a69a25e5cecdbed99fc872c73b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-21 07:12:30.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-pep8 http://logs.openstack.org/46/270446/3/check/gate-taskflow-pep8/9e29906/ : SUCCESS in 2m 05s\n- gate-taskflow-docs http://docs-draft.openstack.org/46/270446/3/check/gate-taskflow-docs/cccfe03//doc/build/html/ : SUCCESS in 1m 42s\n- gate-taskflow-python27 http://logs.openstack.org/46/270446/3/check/gate-taskflow-python27/04aa3b3/ : SUCCESS in 3m 36s\n- gate-taskflow-python34 http://logs.openstack.org/46/270446/3/check/gate-taskflow-python34/3f5deb1/ : SUCCESS in 2m 42s\n- gate-taskflow-pypy http://logs.openstack.org/46/270446/3/check/gate-taskflow-pypy/e269cf7/ : FAILURE in 1m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/46/270446/3/check/gate-tempest-dsvm-neutron-src-taskflow/bf21ab1/ : SUCCESS in 1h 16m 15s","accounts_in_message":[],"_revision_number":3},{"id":"8601be788d6ff47f4f187e70ec783fb233b1041f","author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"date":"2016-01-21 14:56:59.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"b19b1f41c8f8a3dcf7163affb8df73fbcb9fde43","author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"date":"2016-02-01 07:08:17.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"7b8e886037a6dc360958766e0cfb2fcc11b7341e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-01 07:08:24.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"04ee7a5f3c4b7d45f5d4824bdfe0cb222e9e0e21","date":"2016-02-01 08:47:42.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"8149791771e72b654c03753f42d0a2b3e21ce02c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-01 08:47:42.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-docs http://docs-draft.openstack.org/46/270446/3/gate/gate-taskflow-docs/7149a17//doc/build/html/ : SUCCESS in 1m 48s\n- gate-taskflow-pep8 http://logs.openstack.org/46/270446/3/gate/gate-taskflow-pep8/6c9bd1f/ : SUCCESS in 1m 15s\n- gate-taskflow-python27 http://logs.openstack.org/46/270446/3/gate/gate-taskflow-python27/70021a7/ : SUCCESS in 3m 07s\n- gate-taskflow-python34 http://logs.openstack.org/46/270446/3/gate/gate-taskflow-python34/a247bf0/ : SUCCESS in 2m 29s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/46/270446/3/gate/gate-tempest-dsvm-neutron-src-taskflow/c932d16/ : SUCCESS in 58m 16s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"3243bd2d9b97dceb530744631d96fb3d47fdc1d8","revisions":{"d1643060f7e87f27410a1be6534f95115ba01cd9":{"kind":"REWORK","_number":1,"created":"2016-01-20 19:46:50.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/46/270446/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/46/270446/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/46/270446/1"}}},"commit":{"parents":[{"commit":"04611f57231f8f7cd263023de037f126caa9099c","subject":"Merge \"Add useful/helpful comment to retry scheduler\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/04611f57231f8f7cd263023de037f126caa9099c"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2016-01-20 19:43:17.000000000","tz":-480},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2016-01-20 19:46:34.000000000","tz":-480},"subject":"Use future \u0027add_done_callback\u0027 for post-atom-completion work","message":"Use future \u0027add_done_callback\u0027 for post-atom-completion work\n\nInstead of having to wait until the state-machine enters the\nanalyzing state to save execution/results (and do other completion\nactivities) which is less tolerant of exceptions or other issues\nuse the future \u0027add_done_callback\u0027 instead, which will be called\nonce a atom has finished to complete it. It should be safer to\nuse this, ensuring that results get saved and processed even if\nan engine is stopped early (for some reason).\n\nChange-Id: Ief2746debf496b017331a88c7913d9321aac0774\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/d1643060f7e87f27410a1be6534f95115ba01cd9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/d1643060f7e87f27410a1be6534f95115ba01cd9"}]},"branch":"refs/heads/master"},"d9669d73bbaed5612e3a79e9a2e0e13df98561b4":{"kind":"REWORK","_number":2,"created":"2016-01-20 23:20:21.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/46/270446/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/46/270446/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/46/270446/2"}}},"commit":{"parents":[{"commit":"04611f57231f8f7cd263023de037f126caa9099c","subject":"Merge \"Add useful/helpful comment to retry scheduler\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/04611f57231f8f7cd263023de037f126caa9099c"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2016-01-20 19:43:17.000000000","tz":-480},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2016-01-20 23:18:48.000000000","tz":-480},"subject":"Use future \u0027add_done_callback\u0027 for post-atom-completion work","message":"Use future \u0027add_done_callback\u0027 for post-atom-completion work\n\nInstead of having to wait until the state-machine enters the\nanalyzing state to save execution/results (and do other completion\nactivities) which is less tolerant of exceptions or other issues\nuse the future \u0027add_done_callback\u0027 instead, which will be called\nonce a atom has finished to complete it. It should be safer to\nuse this, ensuring that results get saved and processed even if\nan engine is stopped early (for some reason).\n\nChange-Id: Ief2746debf496b017331a88c7913d9321aac0774\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/d9669d73bbaed5612e3a79e9a2e0e13df98561b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/d9669d73bbaed5612e3a79e9a2e0e13df98561b4"}]},"branch":"refs/heads/master"},"3243bd2d9b97dceb530744631d96fb3d47fdc1d8":{"kind":"REWORK","_number":3,"created":"2016-01-21 05:48:40.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/46/270446/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/46/270446/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/270446/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/46/270446/3"}}},"commit":{"parents":[{"commit":"04611f57231f8f7cd263023de037f126caa9099c","subject":"Merge \"Add useful/helpful comment to retry scheduler\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/04611f57231f8f7cd263023de037f126caa9099c"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2016-01-20 19:43:17.000000000","tz":-480},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2016-01-21 05:48:13.000000000","tz":-480},"subject":"Use helper function for post-atom-completion work","message":"Use helper function for post-atom-completion work\n\nFor allowing for future changes (where the future\n\u0027add_done_callback\u0027 can be used if we deem it to be ok\nto do this) make the completion of an atom a small helper\nfunction that is called (and can be called elsewhere in\nthe future).\n\nChange-Id: Ief2746debf496b017331a88c7913d9321aac0774\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/3243bd2d9b97dceb530744631d96fb3d47fdc1d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/3243bd2d9b97dceb530744631d96fb3d47fdc1d8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}