)]}'
{"taskflow/engines/action_engine/builder.py":[{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"966abe0d0ed6a7e8390f9c7f98446380ed9277c1","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                memory.failures.append(failure.Failure())"},{"line_number":251,"context_line":"                LOG.exception(\"Engine \u0027%s\u0027 atom post-completion\""},{"line_number":252,"context_line":"                              \" failed\", atom)"},{"line_number":253,"context_line":"            return was_canceled"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        def wait(old_state, new_state, event):"},{"line_number":256,"context_line":"            # TODO(harlowja): maybe we should start doing \u0027yield from\u0027 this"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_097b90f5","line":253,"updated":"2016-05-03 21:16:56.000000000","message":"I would expect a method called `complete_an_atom()` would return True if it wasn\u0027t cancelled.  Should this be the inverse?\n\nreturn not was_canceled\n\nI realize that requires you to alter the uses of it (sorry).","commit_id":"d43dd1f69115ff87b34cc4a64e1844d123adbac0"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d0db2daf79532d66b6f0204ad4e64ccecf44aaf0","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                memory.failures.append(failure.Failure())"},{"line_number":251,"context_line":"                LOG.exception(\"Engine \u0027%s\u0027 atom post-completion\""},{"line_number":252,"context_line":"                              \" failed\", atom)"},{"line_number":253,"context_line":"            return was_canceled"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        def wait(old_state, new_state, event):"},{"line_number":256,"context_line":"            # TODO(harlowja): maybe we should start doing \u0027yield from\u0027 this"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_304eacc2","line":253,"in_reply_to":"1a122d0e_097b90f5","updated":"2016-05-03 22:22:18.000000000","message":"I\u0027m ok with that.","commit_id":"d43dd1f69115ff87b34cc4a64e1844d123adbac0"},{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"966abe0d0ed6a7e8390f9c7f98446380ed9277c1","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            elif memory.not_done:"},{"line_number":294,"context_line":"                if (current_flow_state \u003d\u003d st.SUSPENDING"},{"line_number":295,"context_line":"                        and not memory.futures_cancelled):"},{"line_number":296,"context_line":"                    for fut in memory.not_done:"},{"line_number":297,"context_line":"                        fut.cancel()"},{"line_number":298,"context_line":"                        memory.futures_cancelled +\u003d 1"},{"line_number":299,"context_line":"                return WAIT"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_a9da5ce7","line":296,"updated":"2016-05-03 21:16:56.000000000","message":"This exact logic is repeated twice in this file.  Would it make sense to make this a method on the `memory` object?  memory.cancel_futures()?","commit_id":"d43dd1f69115ff87b34cc4a64e1844d123adbac0"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"d0db2daf79532d66b6f0204ad4e64ccecf44aaf0","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            elif memory.not_done:"},{"line_number":294,"context_line":"                if (current_flow_state \u003d\u003d st.SUSPENDING"},{"line_number":295,"context_line":"                        and not memory.futures_cancelled):"},{"line_number":296,"context_line":"                    for fut in memory.not_done:"},{"line_number":297,"context_line":"                        fut.cancel()"},{"line_number":298,"context_line":"                        memory.futures_cancelled +\u003d 1"},{"line_number":299,"context_line":"                return WAIT"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_704824b4","line":296,"in_reply_to":"1a122d0e_a9da5ce7","updated":"2016-05-03 22:22:18.000000000","message":"Works for me :)","commit_id":"d43dd1f69115ff87b34cc4a64e1844d123adbac0"}]}