)]}'
{"taskflow/jobs/backends/impl_zookeeper.py":[{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"fa26f92ac9f90737121989de8e0d9b898e320967","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            if (self._known_jobs and"},{"line_number":336,"context_line":"                    self._last_state \u003d\u003d k_states.KazooState.LOST):"},{"line_number":337,"context_line":"                self._on_job_posting([], delayed\u003dFalse)"},{"line_number":338,"context_line":"            return []"},{"line_number":339,"context_line":"        else:"},{"line_number":340,"context_line":"            if ensure_fresh:"},{"line_number":341,"context_line":"                self._force_refresh()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_455f6772","line":338,"updated":"2016-03-15 18:46:43.000000000","message":"Should we empty out self._known_jobs here as well?  Or will some external process do that automatically?","commit_id":"e08bb543282a3fd170a9fa10999053a34871cc98"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7554b3a6cb6292a39486d13af81624639cec3b38","unresolved":false,"context_lines":[{"line_number":335,"context_line":"            if (self._known_jobs and"},{"line_number":336,"context_line":"                    self._last_state \u003d\u003d k_states.KazooState.LOST):"},{"line_number":337,"context_line":"                self._on_job_posting([], delayed\u003dFalse)"},{"line_number":338,"context_line":"            return []"},{"line_number":339,"context_line":"        else:"},{"line_number":340,"context_line":"            if ensure_fresh:"},{"line_number":341,"context_line":"                self._force_refresh()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_39599b5b","line":338,"in_reply_to":"1af94dfe_455f6772","updated":"2016-03-15 22:09:37.000000000","message":"So assuming suspended means what it says it means.\n\nhttps://github.com/python-zk/kazoo/blob/master/kazoo/protocol/states.py#L10\n\nI think its ok to temporarily return [] but not clear out the jobs in this state; since it may turn back from suspended to connected. What do u think?","commit_id":"e08bb543282a3fd170a9fa10999053a34871cc98"},{"author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"change_message_id":"918324119f90bb83417316aa5036ed7d0394d947","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            last_state \u003d self._last_states[0]"},{"line_number":335,"context_line":"        except IndexError:"},{"line_number":336,"context_line":"            last_state \u003d None"},{"line_number":337,"context_line":"        if (last_state \u003d\u003d k_states.KazooState.LOST or"},{"line_number":338,"context_line":"                last_state \u003d\u003d k_states.KazooState.SUSPENDED):"},{"line_number":339,"context_line":"            # NOTE(harlowja): on lost clear out all known jobs as we can not"},{"line_number":340,"context_line":"            # safely assume there are any jobs to continue working on in"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_46796d92","line":337,"updated":"2016-04-28 17:31:19.000000000","message":"this filtering should be controllable, we may want to be able to retrieve failed or unrecoverable jobs, and there is no other way to retrieve jobs using the jobboard interface","commit_id":"126cc114de695504ce7c4b402ec0fc78ae2cc0ce"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"e563c6eef030f32cf443e12f3fbce38c6ea17e53","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    STATE_HISTORY_LENGTH \u003d 2"},{"line_number":267,"context_line":"    \"\"\""},{"line_number":268,"context_line":"    Number of prior state changes to keep a history of, mainly useful"},{"line_number":269,"context_line":"    for history tracking and debugging connectivity issues."},{"line_number":270,"context_line":"    \"\"\""},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_82e610ae","line":268,"updated":"2016-07-20 07:45:27.000000000","message":"nit: Comment here is written as docstring below the constant, whereas in the previous few lines it\u0027s a normal commant written above the defined constant.","commit_id":"35a9305f172ed8970caf1ff5cec261df7d3fe9ce"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"e563c6eef030f32cf443e12f3fbce38c6ea17e53","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    NO_FETCH_STATES \u003d (k_states.KazooState.LOST, k_states.KazooState.SUSPENDED)"},{"line_number":273,"context_line":"    \"\"\""},{"line_number":274,"context_line":"    Client states underwhich we return empty lists from fetching routines,"},{"line_number":275,"context_line":"    during these states the underlying connection either is being recovered"},{"line_number":276,"context_line":"    or may be recovered (aka, it has not full disconnected)."},{"line_number":277,"context_line":"    \"\"\""},{"line_number":278,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"dada55a8_c28be8c1","line":275,"updated":"2016-07-20 07:45:27.000000000","message":"nit: I think the comment would be clearer if instead of comma we end the sentence and start a new one from \u0027During these states...\u0027","commit_id":"35a9305f172ed8970caf1ff5cec261df7d3fe9ce"}]}