)]}'
{"id":"openstack%2Ftaskflow~300346","triplet_id":"openstack%2Ftaskflow~master~Iaeb86a7d0d1836fbc49a864cbb7e38173999124f","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"Iaeb86a7d0d1836fbc49a864cbb7e38173999124f","subject":"Make optional the dependency to networkx.drawing","status":"ABANDONED","created":"2016-04-01 07:54:58.000000000","updated":"2016-06-21 17:52:04.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8840996f0a644962931a5e132c68df8658ce40ed","_number":300346,"virtual_id_number":300346,"owner":{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-04-01 07:59:05.000000000","_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},{"date":"2016-04-05 20:12:15.000000000","_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":1,"date":"2016-04-01 08:58:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":-1,"date":"2016-04-01 16:54:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-04-01 07:55:19.000000000","_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-01 07:55:19.000000000","updated_by":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"reviewer":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"state":"REVIEWER"},{"updated":"2016-04-01 08:58:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-04-01 16:54:12.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2016-04-05 20:12:15.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"}],"messages":[{"id":"6d3b465741bd874ab16ac99005a0afae91990655","author":{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},"date":"2016-04-01 07:54:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"96163c2085cd993907afb8f487d260c8b3051714","author":{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},"date":"2016-04-01 07:59:05.000000000","message":"Patch Set 1:\n\nJust for reference, gdal pulls in 136MB on disk which is a lot for a single line of code.","accounts_in_message":[],"_revision_number":1},{"id":"24af96e0332ec87c8de432e44dbbb49890176b5f","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2016-04-01 08:00:54.000000000","message":"Patch Set 1: Code-Review+1\n\nYes please!\nOpenStack project need to better handle optional dependencies like recent case with LXD in Manila.","accounts_in_message":[],"_revision_number":1},{"id":"c95b47dfd0a98dda46c0ea85396d46f252959450","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-01 08:58:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-docs http://docs-draft.openstack.org/46/300346/1/check/gate-taskflow-docs/e2aaefa//doc/build/html/ : SUCCESS in 2m 18s\n- gate-taskflow-pep8 http://logs.openstack.org/46/300346/1/check/gate-taskflow-pep8/46e55f3/ : SUCCESS in 2m 15s\n- gate-taskflow-python27-db http://logs.openstack.org/46/300346/1/check/gate-taskflow-python27-db/a2d649a/ : SUCCESS in 3m 24s\n- gate-taskflow-python34-db http://logs.openstack.org/46/300346/1/check/gate-taskflow-python34-db/a7dce2a/ : SUCCESS in 3m 39s\n- gate-taskflow-pypy-db http://logs.openstack.org/46/300346/1/check/gate-taskflow-pypy-db/7126f91/ : FAILURE in 2m 32s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/46/300346/1/check/gate-tempest-dsvm-neutron-src-taskflow/754d7a0/ : SUCCESS in 1h 01m 15s","accounts_in_message":[],"_revision_number":1},{"id":"e5e2562107e711b314209e2e1dc7669aef008b49","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2016-04-01 16:54:12.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nI think we need more justification here.  The referenced packages are not installed on our host that runs our docs job that generates these graphs.","accounts_in_message":[],"_revision_number":1},{"id":"01e4a54ff0872335a25d80e0dfa94ab4f2cbb207","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2016-04-01 16:56:58.000000000","message":"Patch Set 1:\n\nI don\u0027t gdal in the venv either.","accounts_in_message":[],"_revision_number":1},{"id":"dbc54214033de7652419558ca505d57757c85fdc","author":{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},"date":"2016-04-04 14:35:37.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nWe discovered that issue in our continuous delivery platform for OpenStack trunk as we run oslo-config-generator for glance and cinder (this is a transitive issue).\n\nWe historically split up networkx.drawing module from the rest of the package as it has a lot of dependencies\nhttps://github.com/networkx/networkx/blob/master/requirements.txt#L8\n\nnetworkx/gdal package makes it very hard to subpackage features, and distributions can\u0027t ship a crippled networkx package just for OpenStack and we have to limit installed dependencies.\nHonestly, this feature was broken for a long time without anybody noticing, so graciously failing if the module is not present is a good compromise (but warning message can be improved)\n\nThere are a lot of reasons for which it doesn\u0027t break in a virtualenv:\n* code actually not executed by the job (so imports are not failing)\n* gdal being a dependency used in unused code from networkx.drawing from taskflow (which does not mean we can drop this dependency in networkx-drawing packages as OpenStack is not the sole consumer)\netc.","accounts_in_message":[],"_revision_number":1},{"id":"14591ce2d2e8b5860ce3478ac15e27e347d75ba6","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-04-05 20:12:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7f6dce173bd30d2d38b616d3f5b1cb75ab6f59a1","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2016-04-06 08:45:01.000000000","message":"Patch Set 1: -Code-Review\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3b881417bc9255b2ab019486c8ec6ba579249ab7","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-04-13 05:54:24.000000000","message":"Patch Set 1:\n\nLet me know how this goes, if its impossible to change then we can try to help, just would rather not just yet if its fixable...","accounts_in_message":[],"_revision_number":1},{"id":"8840996f0a644962931a5e132c68df8658ce40ed","author":{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},"date":"2016-06-21 17:52:04.000000000","message":"Abandoned\n\nno consensus","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8896ad1e8ed5e1cd70578eb85ac799e0063e2bff","revisions":{"8896ad1e8ed5e1cd70578eb85ac799e0063e2bff":{"kind":"REWORK","_number":1,"created":"2016-04-01 07:54:58.000000000","uploader":{"_account_id":10384,"name":"Haïkel Guémar","email":"hguemar@fedoraproject.org","username":"hguemar"},"ref":"refs/changes/46/300346/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/46/300346/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/300346/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/300346/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/46/300346/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/46/300346/1"}}},"commit":{"parents":[{"commit":"29ba91e93f16097780ac872084398a390638e0d1","subject":"Merge \"Fix export_to_dot for networkx package changes\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/29ba91e93f16097780ac872084398a390638e0d1"}]}],"author":{"name":"Haikel Guemar","email":"hguemar@fedoraproject.org","date":"2016-03-31 23:42:04.000000000","tz":120},"committer":{"name":"Haikel Guemar","email":"hguemar@fedoraproject.org","date":"2016-04-01 07:54:55.000000000","tz":120},"subject":"Make optional the dependency to networkx.drawing","message":"Make optional the dependency to networkx.drawing\n\nCalls to Graph.export_to_dot will show a warning if networkx.drawing\nis not present and works as expected otherwise\n\nRationale being that networkx.drawing module pulls in gdal which has\na lot of dependencies. This is not a good deal for a feature that is\nnot widely used[1] for OpenStack distributions and or operators who\nwant to minimize their deployments.\n\nSince oslo-config-generator try to visit all imported modules, it\ncauses failures if networkx.drawing module is not present. Hence\nthe try/except block.\n\n[1] http://codesearch.openstack.org/?q\u003dexport_to_dot\n\nChange-Id: Iaeb86a7d0d1836fbc49a864cbb7e38173999124f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/8896ad1e8ed5e1cd70578eb85ac799e0063e2bff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/8896ad1e8ed5e1cd70578eb85ac799e0063e2bff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}