)]}'
{"id":"openstack%2Ftaskflow~321874","triplet_id":"openstack%2Ftaskflow~master~I24b0d0b01dbd239b92ba444f6ef44273c5ac25d3","project":"openstack/taskflow","branch":"master","topic":"bug/1581616","hashtags":[],"change_id":"I24b0d0b01dbd239b92ba444f6ef44273c5ac25d3","subject":"Split revert/execute missing args messages","status":"MERGED","created":"2016-05-26 22:07:56.000000000","updated":"2016-06-01 01:41:53.000000000","submitted":"2016-06-01 01:41:53.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0a95199983c4533e68307d7712b1f3129d13b03d","_number":321874,"virtual_id_number":321874,"owner":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2016-06-01 01:41:53.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2016-05-27 00:49:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-06-01 00:45:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-06-01 00:45:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-27 00:49:48.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2016-06-01 00:45:47.000000000","updated_by":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"reviewer":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"state":"REVIEWER"},{"updated":"2016-06-01 01:41:53.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3dbdcdad82d66ba1cd55cdd7506a96233a4237a2","author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"date":"2016-05-26 22:07:56.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de33ab7023dd6034151f79f68ec091ebffaec2fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-26 23:50:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-docs http://docs-draft.openstack.org/74/321874/1/check/gate-taskflow-docs/15bdc43//doc/build/html/ : SUCCESS in 2m 18s\n- gate-taskflow-pep8 http://logs.openstack.org/74/321874/1/check/gate-taskflow-pep8/05355c1/ : SUCCESS in 0s\n- gate-taskflow-python27-db http://logs.openstack.org/74/321874/1/check/gate-taskflow-python27-db/1880154/ : SUCCESS in 4m 21s\n- gate-taskflow-python34-db http://logs.openstack.org/74/321874/1/check/gate-taskflow-python34-db/ec1f662/ : SUCCESS in 3m 21s\n- gate-taskflow-pypy-db http://logs.openstack.org/74/321874/1/check/gate-taskflow-pypy-db/d755287/ : FAILURE in 2m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/74/321874/1/check/gate-tempest-dsvm-neutron-src-taskflow/1fd76ed/ : SUCCESS in 1h 08m 53s","accounts_in_message":[],"_revision_number":1},{"id":"d7b95fba844351dfb4c5abdafd67b2b7b54f5890","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-05-27 00:49:48.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a18b1fe772b4824c815fcf117e22c1a7079035ac","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2016-05-30 22:34:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ba7151507a225d733a8496dc8af871d7573f8285","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-30 22:34:25.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"81fe56d865ed991f6d9339037d46cdc48601614e","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2016-05-30 22:37:10.000000000","message":"Patch Set 1: -Code-Review -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"1f0b5b3366d9850a7ec553afa69ea1b95c664ba7","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2016-05-30 23:18:56.000000000","message":"Patch Set 1:\n\nfeel like there should be unit tests to verify that the message is correct, thoughts?","accounts_in_message":[],"_revision_number":1},{"id":"2d83b02d55f03dbe8e606336e5c84c9310c71885","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-30 23:29:22.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-docs http://docs-draft.openstack.org/74/321874/1/gate/gate-taskflow-docs/0a81b7a//doc/build/html/ : SUCCESS in 2m 34s\n- gate-taskflow-pep8 http://logs.openstack.org/74/321874/1/gate/gate-taskflow-pep8/5266aad/ : SUCCESS in 1m 33s\n- gate-taskflow-python27-db http://logs.openstack.org/74/321874/1/gate/gate-taskflow-python27-db/9679dfc/ : SUCCESS in 2m 45s\n- gate-taskflow-python34-db http://logs.openstack.org/74/321874/1/gate/gate-taskflow-python34-db/4704b99/ : SUCCESS in 3m 36s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/74/321874/1/gate/gate-tempest-dsvm-neutron-src-taskflow/ebaaa32/ : SUCCESS in 54m 05s","accounts_in_message":[],"_revision_number":1},{"id":"8baaf8613a9d3e42f040a3fc464787a0b820d574","author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"date":"2016-05-31 15:14:07.000000000","message":"Patch Set 1:\n\nI generally try to avoid tight coupling between tests and user-oriented content like exception messages.  I\u0027ve seen it cause problems too many times to find it worth the effort to maintain.  If Josh and you want me to do it, I will, but that\u0027s why I didn\u0027t do it to begin with.","accounts_in_message":[],"_revision_number":1},{"id":"b9231466e53e1ed4f5e7b1a13718585d9adaeab3","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-05-31 20:04:50.000000000","message":"Patch Set 1:\n\nI\u0027m ok with not, I pretty much agree. Testing exception messages causes a bunch of pain if that exception message is ever slightly altered in the future; its similar to why I don\u0027t like testing log messages because they have a similar problem (both being fragile things to test). I\u0027m ok with testing logic and expected function results and all that and for things raising exceptions of the right type, but diving deeper into what a logger wrote or what a exception message contained always start to feel like going way to deep.","accounts_in_message":[],"_revision_number":1},{"id":"e218f2951b85354bef37b9008814658fde0c1821","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-05-31 20:05:26.000000000","message":"Patch Set 1:\n\n*feel like going way to deep (for little benefit).","accounts_in_message":[],"_revision_number":1},{"id":"3364feb4197d70a9589c40c0d47482825eb87610","author":{"_account_id":10584,"name":"Min Pae","username":"sputnik13","inactive":true},"date":"2016-06-01 00:45:47.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nk, sgtm","accounts_in_message":[],"_revision_number":1},{"id":"d05903d9e7cc13e27a6be3c2768bff821860895a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-01 00:45:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3b6c78c2fbf53fc4c6dbbf3a520a7af055e78456","date":"2016-06-01 01:41:53.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"6db632781a7347b41f2a998efefef230b0e66912","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-01 01:41:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-docs http://docs-draft.openstack.org/74/321874/1/gate/gate-taskflow-docs/f4dd3da//doc/build/html/ : SUCCESS in 2m 57s\n- gate-taskflow-pep8 http://logs.openstack.org/74/321874/1/gate/gate-taskflow-pep8/db75a2f/ : SUCCESS in 2m 12s\n- gate-taskflow-python27-db http://logs.openstack.org/74/321874/1/gate/gate-taskflow-python27-db/c2961f8/ : SUCCESS in 3m 11s\n- gate-taskflow-python34-db http://logs.openstack.org/74/321874/1/gate/gate-taskflow-python34-db/dc4726e/ : SUCCESS in 5m 25s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/74/321874/1/gate/gate-tempest-dsvm-neutron-src-taskflow/6707870/ : SUCCESS in 55m 35s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8ab0ba9ea8037379dd59a5e972605ac7c6f89e67","revisions":{"8ab0ba9ea8037379dd59a5e972605ac7c6f89e67":{"kind":"REWORK","_number":1,"created":"2016-05-26 22:07:56.000000000","uploader":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"ref":"refs/changes/74/321874/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/74/321874/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/74/321874/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/74/321874/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/74/321874/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/74/321874/1"}}},"commit":{"parents":[{"commit":"c5e9cf28df9dda763d146859b1472d8bbcf85665","subject":"Instead of a multiprocessing queue use sockets via asyncore","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/c5e9cf28df9dda763d146859b1472d8bbcf85665"}]}],"author":{"name":"Greg Hill","email":"greg.hill@rackspace.com","date":"2016-05-26 22:07:03.000000000","tz":-300},"committer":{"name":"Greg Hill","email":"greg.hill@rackspace.com","date":"2016-05-26 22:07:03.000000000","tz":-300},"subject":"Split revert/execute missing args messages","message":"Split revert/execute missing args messages\n\nTo make it more obvious when a revert method is missing\na dependency, we now identify which method was missing\nthe required paramater.\n\nChange-Id: I24b0d0b01dbd239b92ba444f6ef44273c5ac25d3\nCloses-Bug: 1581616\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/8ab0ba9ea8037379dd59a5e972605ac7c6f89e67"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/8ab0ba9ea8037379dd59a5e972605ac7c6f89e67"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
