)]}'
{"id":"openstack%2Ftaskflow~384362","triplet_id":"openstack%2Ftaskflow~master~I52ecf3f4945c4cb99f6350afca1c51d88b16bb8d","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"I52ecf3f4945c4cb99f6350afca1c51d88b16bb8d","subject":"Using assertIsNone() instead of assertIs(None, ..)","status":"MERGED","created":"2016-10-10 08:49:32.000000000","updated":"2016-10-11 09:42:38.000000000","submitted":"2016-10-11 09:42:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"97e947e8beea7bc1e89f639f962bbcbd92b6886d","_number":384362,"virtual_id_number":384362,"owner":{"_account_id":20325,"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","username":"qinchunhua"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2016-10-11 09:42:38.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2016-10-10 22:42:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2016-10-10 22:42:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-10 22:42:57.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2016-10-11 09:42:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c69d6890551cac73a8b6803f5ffdf85eac256290","author":{"_account_id":20325,"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","username":"qinchunhua"},"date":"2016-10-10 08:49:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c51759a3a154f9f579b46a2b697cf93495bbe46b","author":{"_account_id":20325,"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","username":"qinchunhua"},"date":"2016-10-10 08:50:33.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"a1fc4b5217fbf24860ffd1dc8335795b2c7617a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-10 09:31:39.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-docs-ubuntu-xenial http://docs-draft.openstack.org/62/384362/2/check/gate-taskflow-docs-ubuntu-xenial/f6b757c//doc/build/html/ : SUCCESS in 2m 26s\n- gate-taskflow-pep8-ubuntu-xenial http://logs.openstack.org/62/384362/2/check/gate-taskflow-pep8-ubuntu-xenial/edffc57/ : SUCCESS in 2m 09s\n- gate-taskflow-python27-db-ubuntu-xenial http://logs.openstack.org/62/384362/2/check/gate-taskflow-python27-db-ubuntu-xenial/11ba590/ : SUCCESS in 3m 59s\n- gate-taskflow-python34-db http://logs.openstack.org/62/384362/2/check/gate-taskflow-python34-db/74c79ef/ : SUCCESS in 3m 30s\n- gate-taskflow-python35-db http://logs.openstack.org/62/384362/2/check/gate-taskflow-python35-db/b620902/ : SUCCESS in 3m 49s\n- gate-taskflow-pypy-db http://logs.openstack.org/62/384362/2/check/gate-taskflow-pypy-db/4bded6b/ : FAILURE in 2m 46s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/384362/2/check/gate-tempest-dsvm-neutron-src-taskflow/b1bc271/ : SUCCESS in 40m 54s","accounts_in_message":[],"_revision_number":2},{"id":"079fbc21c00d5ee08d7694fb81ec8a04a0bf3336","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2016-10-10 22:42:57.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"5bbba3c54962f2c81d4542f61d6e4a4de80129dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-10 22:43:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e8c603c4e943d225fd0ca54636da85f3db91b1f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-10 22:55:56.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-taskflow-docs-ubuntu-xenial http://docs-draft.openstack.org/62/384362/2/gate/gate-taskflow-docs-ubuntu-xenial/f370ed5//doc/build/html/ : SUCCESS in 2m 09s\n- gate-taskflow-pep8-ubuntu-xenial http://logs.openstack.org/62/384362/2/gate/gate-taskflow-pep8-ubuntu-xenial/bd21ffe/ : SUCCESS in 1m 57s\n- gate-taskflow-python27-db-ubuntu-xenial http://logs.openstack.org/62/384362/2/gate/gate-taskflow-python27-db-ubuntu-xenial/dc39b87/ : SUCCESS in 3m 39s\n- gate-taskflow-python34-db http://logs.openstack.org/62/384362/2/gate/gate-taskflow-python34-db/7c9e534/ : SUCCESS in 4m 51s\n- gate-taskflow-python35-db http://logs.openstack.org/62/384362/2/gate/gate-taskflow-python35-db/c38d840/ : SUCCESS in 3m 54s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/384362/2/gate/gate-tempest-dsvm-neutron-src-taskflow/718c763/ : FAILURE in 12m 46s","accounts_in_message":[],"_revision_number":2},{"id":"94ba5846801aeb70e9d7d4f65ea3e893e6b75c75","author":{"_account_id":20325,"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","username":"qinchunhua"},"date":"2016-10-11 07:43:08.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"5f388b277879c4c9c2e8d5f52fad29a0e5c5bad8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-11 08:47:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-docs-ubuntu-xenial http://docs-draft.openstack.org/62/384362/2/check/gate-taskflow-docs-ubuntu-xenial/dfd424e//doc/build/html/ : SUCCESS in 4m 12s\n- gate-taskflow-pep8-ubuntu-xenial http://logs.openstack.org/62/384362/2/check/gate-taskflow-pep8-ubuntu-xenial/751b27f/ : SUCCESS in 2m 59s\n- gate-taskflow-python27-db-ubuntu-xenial http://logs.openstack.org/62/384362/2/check/gate-taskflow-python27-db-ubuntu-xenial/c60392d/ : SUCCESS in 4m 40s\n- gate-taskflow-python34-db http://logs.openstack.org/62/384362/2/check/gate-taskflow-python34-db/804d65d/ : SUCCESS in 4m 59s\n- gate-taskflow-python35-db http://logs.openstack.org/62/384362/2/check/gate-taskflow-python35-db/1d48a03/ : SUCCESS in 6m 13s\n- gate-taskflow-pypy-db http://logs.openstack.org/62/384362/2/check/gate-taskflow-pypy-db/ba88502/ : FAILURE in 3m 30s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/384362/2/check/gate-tempest-dsvm-neutron-src-taskflow/a4170ea/ : SUCCESS in 1h 03m 12s","accounts_in_message":[],"_revision_number":2},{"id":"4bd9870a847c34aad25be3a11fe6a9fca88788b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-11 08:47:25.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"8c985a75df41338ed9ae87b602c42f96ac76955f","date":"2016-10-11 09:42:38.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"97e947e8beea7bc1e89f639f962bbcbd92b6886d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-11 09:42:38.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-docs-ubuntu-xenial http://docs-draft.openstack.org/62/384362/2/gate/gate-taskflow-docs-ubuntu-xenial/d3cb440//doc/build/html/ : SUCCESS in 3m 10s\n- gate-taskflow-pep8-ubuntu-xenial http://logs.openstack.org/62/384362/2/gate/gate-taskflow-pep8-ubuntu-xenial/1bc1673/ : SUCCESS in 3m 00s\n- gate-taskflow-python27-db-ubuntu-xenial http://logs.openstack.org/62/384362/2/gate/gate-taskflow-python27-db-ubuntu-xenial/2796eda/ : SUCCESS in 5m 16s\n- gate-taskflow-python34-db http://logs.openstack.org/62/384362/2/gate/gate-taskflow-python34-db/509c7ba/ : SUCCESS in 5m 22s\n- gate-taskflow-python35-db http://logs.openstack.org/62/384362/2/gate/gate-taskflow-python35-db/ce03065/ : SUCCESS in 5m 32s\n- gate-tempest-dsvm-neutron-src-taskflow http://logs.openstack.org/62/384362/2/gate/gate-tempest-dsvm-neutron-src-taskflow/8db5fb1/ : SUCCESS in 54m 57s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"e68032929cd241baab782a5bbaa45fe46df70b05","revisions":{"86551e592f6817c31b4050d84993530c35675885":{"kind":"REWORK","_number":1,"created":"2016-10-10 08:49:32.000000000","uploader":{"_account_id":20325,"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","username":"qinchunhua"},"ref":"refs/changes/62/384362/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/62/384362/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/384362/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/384362/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/384362/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/62/384362/1"}}},"commit":{"parents":[{"commit":"50fba9c978b2a3545516f8ea01248b83240b23d0","subject":"Merge \"Fix a typo in logging.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/50fba9c978b2a3545516f8ea01248b83240b23d0"}]}],"author":{"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","date":"2016-10-10 08:43:03.000000000","tz":-240},"committer":{"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","date":"2016-10-10 08:45:55.000000000","tz":-240},"subject":"Using assertIsNone() instead of assertIs(None, ..)","message":"Using assertIsNone() instead of assertIs(None, ..)\n\nFollowing OpenStack Style Guidelines[1]:\nhttp://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n[H203] Unit test assertions tend to give better messages for more\nspecific assertions. As a result, assertIsNone(...) is preferred\nover assertEqual(None, ...) and assertIs(..,None)\n\nChange-Id: I52ecf3f4945c4cb99f6350afca1c51d88b16bb8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/86551e592f6817c31b4050d84993530c35675885"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/86551e592f6817c31b4050d84993530c35675885"}]},"branch":"refs/heads/master"},"e68032929cd241baab782a5bbaa45fe46df70b05":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-10-10 08:50:33.000000000","uploader":{"_account_id":20325,"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","username":"qinchunhua"},"ref":"refs/changes/62/384362/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/62/384362/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/384362/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/384362/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/62/384362/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/62/384362/2"}}},"commit":{"parents":[{"commit":"50fba9c978b2a3545516f8ea01248b83240b23d0","subject":"Merge \"Fix a typo in logging.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/50fba9c978b2a3545516f8ea01248b83240b23d0"}]}],"author":{"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","date":"2016-10-10 08:43:03.000000000","tz":-240},"committer":{"name":"qinchunhua","email":"qin.chunhua@zte.com.cn","date":"2016-10-10 08:50:21.000000000","tz":0},"subject":"Using assertIsNone() instead of assertIs(None, ..)","message":"Using assertIsNone() instead of assertIs(None, ..)\n\nFollowing OpenStack Style Guidelines[1]:\nhttp://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n[H203] Unit test assertions tend to give better messages for more\nspecific assertions. As a result, assertIsNone(...) is preferred\nover assertEqual(None, ...) and assertIs(..,None).\n\nChange-Id: I52ecf3f4945c4cb99f6350afca1c51d88b16bb8d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e68032929cd241baab782a5bbaa45fe46df70b05"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e68032929cd241baab782a5bbaa45fe46df70b05"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
