)]}'
{"id":"openstack%2Ftaskflow~464302","triplet_id":"openstack%2Ftaskflow~master~I4f6c364211500e510fc496f23b03ce056771417d","project":"openstack/taskflow","branch":"master","topic":"do-not-allow-redis-job-reclaim","hashtags":[],"change_id":"I4f6c364211500e510fc496f23b03ce056771417d","subject":"do not allow redis job reclaim by same owner","status":"MERGED","created":"2017-05-13 14:57:44.000000000","updated":"2017-05-31 05:48:00.000000000","submitted":"2017-05-31 05:48:00.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c949a9b75d7d817ed61aefd1914b32639d720732","_number":464302,"virtual_id_number":464302,"owner":{"_account_id":15808,"name":"Rick van de Loo","email":"rickvandeloo@gmail.com","username":"vdloo"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2017-05-31 05:48:00.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":23317,"name":"ShangXiao","email":"shangxiaobj@inspur.com","username":"ShangXiao"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2017-05-16 18:01:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-05-27 06:54:33.000000000","_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":1,"date":"2017-05-27 07:45:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":23317,"name":"ShangXiao","email":"shangxiaobj@inspur.com","username":"ShangXiao"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-05-27 06:54:33.000000000","_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":23317,"name":"ShangXiao","email":"shangxiaobj@inspur.com","username":"ShangXiao"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":23317,"name":"ShangXiao","email":"shangxiaobj@inspur.com","username":"ShangXiao"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"_account_id":23317,"name":"ShangXiao","email":"shangxiaobj@inspur.com","username":"ShangXiao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-05-16 18:01:25.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2017-05-27 06:54:33.000000000","updated_by":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"reviewer":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"state":"REVIEWER"},{"updated":"2017-05-27 07:45:03.000000000","updated_by":{"_account_id":23317,"name":"ShangXiao","email":"shangxiaobj@inspur.com","username":"ShangXiao"},"reviewer":{"_account_id":23317,"name":"ShangXiao","email":"shangxiaobj@inspur.com","username":"ShangXiao"},"state":"REVIEWER"},{"updated":"2017-05-31 05:48:00.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a18c51604f5517c31b68a8b59f00acfa03f49147","author":{"_account_id":15808,"name":"Rick van de Loo","email":"rickvandeloo@gmail.com","username":"vdloo"},"date":"2017-05-13 14:57:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5bf59ba1e33acf3403a0e95568b1b49a784311eb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-13 16:09:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-docs-ubuntu-xenial http://docs-draft.openstack.org/02/464302/1/check/gate-taskflow-docs-ubuntu-xenial/cc5408f//doc/build/html/ : SUCCESS in 2m 36s\n- gate-taskflow-pep8-ubuntu-xenial http://logs.openstack.org/02/464302/1/check/gate-taskflow-pep8-ubuntu-xenial/656010c/ : SUCCESS in 4m 27s\n- gate-taskflow-python27-ubuntu-xenial http://logs.openstack.org/02/464302/1/check/gate-taskflow-python27-ubuntu-xenial/d609f3d/ : SUCCESS in 3m 39s\n- gate-taskflow-python35 http://logs.openstack.org/02/464302/1/check/gate-taskflow-python35/1b4f005/ : SUCCESS in 3m 13s\n- gate-taskflow-pypy http://logs.openstack.org/02/464302/1/check/gate-taskflow-pypy/66fbccb/ : FAILURE in 2m 42s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow-ubuntu-xenial http://logs.openstack.org/02/464302/1/check/gate-tempest-dsvm-neutron-src-taskflow-ubuntu-xenial/c7b8726/ : SUCCESS in 1h 11m 07s","accounts_in_message":[],"_revision_number":1},{"id":"747f32118be4254588436600e14dc251b42ddd7c","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2017-05-16 18:01:25.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"cab091dfec012a44bc30cf3a87fdce8f5e05a263","author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"date":"2017-05-27 06:54:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"e4e35f47819b65da5b82ddc14fc6826652ed649e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-27 06:54:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"7649acae274d288a21360bc2869002e5126cdc42","author":{"_account_id":23317,"name":"ShangXiao","email":"shangxiaobj@inspur.com","username":"ShangXiao"},"date":"2017-05-27 07:45:03.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"c5d95e7be563fd5bcde3b5de5c247e50c59486f7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-27 08:04:06.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-taskflow-docs-ubuntu-xenial http://docs-draft.openstack.org/02/464302/1/gate/gate-taskflow-docs-ubuntu-xenial/15c54d0//doc/build/html/ : SUCCESS in 2m 39s\n- gate-taskflow-pep8-ubuntu-xenial http://logs.openstack.org/02/464302/1/gate/gate-taskflow-pep8-ubuntu-xenial/64d1074/ : SUCCESS in 4m 59s\n- gate-taskflow-python27-ubuntu-xenial http://logs.openstack.org/02/464302/1/gate/gate-taskflow-python27-ubuntu-xenial/da10259/ : SUCCESS in 5m 13s\n- gate-taskflow-python35 http://logs.openstack.org/02/464302/1/gate/gate-taskflow-python35/b56863c/ : SUCCESS in 6m 05s\n- gate-tempest-dsvm-neutron-src-taskflow-ubuntu-xenial http://logs.openstack.org/02/464302/1/gate/gate-tempest-dsvm-neutron-src-taskflow-ubuntu-xenial/d5d8487/ : FAILURE in 1h 07m 12s","accounts_in_message":[],"_revision_number":1},{"id":"5e75a237b578e7ee5dd8b7ad9771c237d586e9b8","author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"date":"2017-05-31 03:02:35.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"a4e5419e6c4955084dace56bbdd474b712dc5a72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-31 04:27:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-taskflow-docs-ubuntu-xenial http://docs-draft.openstack.org/02/464302/1/check/gate-taskflow-docs-ubuntu-xenial/bf9bfe4//doc/build/html/ : SUCCESS in 2m 15s\n- gate-taskflow-pep8-ubuntu-xenial http://logs.openstack.org/02/464302/1/check/gate-taskflow-pep8-ubuntu-xenial/8fc65f6/ : SUCCESS in 4m 09s\n- gate-taskflow-python27-ubuntu-xenial http://logs.openstack.org/02/464302/1/check/gate-taskflow-python27-ubuntu-xenial/be618f8/ : SUCCESS in 4m 48s\n- gate-taskflow-python35 http://logs.openstack.org/02/464302/1/check/gate-taskflow-python35/f4cbb16/ : SUCCESS in 4m 42s\n- gate-taskflow-pypy http://logs.openstack.org/02/464302/1/check/gate-taskflow-pypy/5d9f81e/ : FAILURE in 3m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-taskflow-ubuntu-xenial http://logs.openstack.org/02/464302/1/check/gate-tempest-dsvm-neutron-src-taskflow-ubuntu-xenial/1745632/ : SUCCESS in 1h 23m 23s","accounts_in_message":[],"_revision_number":1},{"id":"1033f03019581867670cb0547ca69fc7bb22036c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-31 04:27:51.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"11f84dcdd7a9aa9c44eb2c6c8fe71696471a1225","date":"2017-05-31 05:48:00.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"235fbe6660a855ea2895afcaefddab97d2460f23","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-05-31 05:48:00.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-taskflow-docs-ubuntu-xenial http://docs-draft.openstack.org/02/464302/1/gate/gate-taskflow-docs-ubuntu-xenial/55a2405//doc/build/html/ : SUCCESS in 2m 19s\n- gate-taskflow-pep8-ubuntu-xenial http://logs.openstack.org/02/464302/1/gate/gate-taskflow-pep8-ubuntu-xenial/cd556ca/ : SUCCESS in 3m 57s\n- gate-taskflow-python27-ubuntu-xenial http://logs.openstack.org/02/464302/1/gate/gate-taskflow-python27-ubuntu-xenial/bb44672/ : SUCCESS in 5m 15s\n- gate-taskflow-python35 http://logs.openstack.org/02/464302/1/gate/gate-taskflow-python35/da2bd1f/ : SUCCESS in 3m 40s\n- gate-tempest-dsvm-neutron-src-taskflow-ubuntu-xenial http://logs.openstack.org/02/464302/1/gate/gate-tempest-dsvm-neutron-src-taskflow-ubuntu-xenial/450a3dd/ : SUCCESS in 1h 18m 41s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5f3c1325239bace46c6adfe775f544467af44b03","revisions":{"5f3c1325239bace46c6adfe775f544467af44b03":{"kind":"REWORK","_number":1,"created":"2017-05-13 14:57:44.000000000","uploader":{"_account_id":15808,"name":"Rick van de Loo","email":"rickvandeloo@gmail.com","username":"vdloo"},"ref":"refs/changes/02/464302/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/02/464302/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/02/464302/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/02/464302/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/02/464302/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/02/464302/1"}}},"commit":{"parents":[{"commit":"656ed3c8479f4bb263d86d6bba6eadad77073dd5","subject":"Merge \"Stop using oslotest.mockpatch\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/656ed3c8479f4bb263d86d6bba6eadad77073dd5"}]}],"author":{"name":"Rick van de Loo","email":"rickvandeloo@gmail.com","date":"2017-05-13 14:55:50.000000000","tz":120},"committer":{"name":"Rick van de Loo","email":"rickvandeloo@gmail.com","date":"2017-05-13 14:55:50.000000000","tz":120},"subject":"do not allow redis job reclaim by same owner","message":"do not allow redis job reclaim by same owner\n\nRunning a nonblocking conductor or two conductors on the same host will re-execute the same job multiple times with the current implementation of \u0027claim\u0027 for the redis jobboard backend. This is different from the ZooKeeper jobboard backend, there the same owner of a job is not allowed to reclaim the job again (https://github.com/openstack/taskflow/blob/master/taskflow/jobs/backends/impl_zookeeper.py#L554). If the same owner is allowed to reclaim the job again there can be no concurrent execution on the same owner because all jobs will be re-claimed and re-executed by the same owner every pass as long as it\u0027s on the jobboard.\n\nTo reproduce this behavior:\n\n- Use the redis jobboard backend\n- Create a flow with a task that sleeps 10 seconds in the execute method\n- Post that flow as a job\n- Run a nonblocking conductor\n\nIt will claim and execute the same job multiple times in a loop until the first worker is finished and consumes the job. After this change it will not re-execute the same job multiple times.\n\nChange-Id: I4f6c364211500e510fc496f23b03ce056771417d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/5f3c1325239bace46c6adfe775f544467af44b03"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/5f3c1325239bace46c6adfe775f544467af44b03"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
