)]}'
{"id":"openstack%2Ftaskflow~743737","triplet_id":"openstack%2Ftaskflow~master~Ia8cc98e701435fd0231da3724f5d7108fc4f96f4","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"Ia8cc98e701435fd0231da3724f5d7108fc4f96f4","subject":"Add sentinel redis support","status":"MERGED","created":"2020-07-29 12:00:01.000000000","updated":"2020-08-24 23:53:03.000000000","submitted":"2020-08-24 23:51:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"743737-1598313093066-038e877c","meta_rev_id":"855de9ae5103adaea20127270448b59815b218d3","_number":743737,"virtual_id_number":743737,"owner":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-24 23:51:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":2,"date":"2020-08-24 22:37:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-08-19 09:44:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":1,"date":"2020-08-24 22:37:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-31 07:30:07.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-08-19 09:44:29.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-08-24 22:37:02.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2020-08-24 23:51:32.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"72edc3849daa263d1d0281e73b4cd5f14a6d89f9","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2020-07-29 12:00:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"be7dc519db1c62c2319ce790f805b36eed82f770","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-29 13:19:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0a431246c64f48a39dea6b8b94481192 : SUCCESS in 1h 10m 05s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e70dc780cab449ab8658d7d0f7ffa3b3 : SUCCESS in 6m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/501fe727da16425cb7e4a5d085a6b9e7 : SUCCESS in 6m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/58f8f2528f0f43de99c7a565e6a0cf92 : SUCCESS in 4m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4483e988716a487885bdc7e67113d959 : SUCCESS in 5m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9842d7406e3e458792ad32c4646449b2 : SUCCESS in 6m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2924594f75204fa78f2041e68a072198 : SUCCESS in 4m 59s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/27339d0109cb42e39ce77017e976a42b : SUCCESS in 5m 12s","accounts_in_message":[],"_revision_number":1},{"id":"3b3a3ea67d3e6428f00a62fcb4ac76f8ee51e60e","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-31 09:00:47.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM, could be worth to let\u0027s review these changes by someone else more experienced than me on redis/sentinel (this is why I only +1).\n\nAlso I wondering if we could add some related unit tests [1] but I don\u0027t seen existing tests related to client\u0027s creation.\n\n[1] https://opendev.org/openstack/taskflow/src/branch/master/taskflow/tests/unit/jobs/test_redis_job.py","accounts_in_message":[],"_revision_number":1},{"id":"e24315200b3daeed5cf286bd4bde3899dae27026","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2020-08-05 13:03:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"378ad3d680689a93d73c30da911a992f456165c9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-05 14:39:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/dba102b4bc7e48f98380f56ec240b43c : SUCCESS in 1h 28m 35s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9bfe210ce5964179a7b8c9350642c9e9 : SUCCESS in 5m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0416ba319d064b0cacf4a21b773fb236 : SUCCESS in 7m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/35d8c47b9c5f4ca5a8d23012e0343515 : SUCCESS in 6m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5b6b9f7144f8413ea0e13a93cb9f84a2 : SUCCESS in 6m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/cf5efe346060498b880232276e971e1a : SUCCESS in 8m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/056e96520161416e9fe8383a61dc62b9 : SUCCESS in 6m 00s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d9c1263de672405dafb08353dbba1460 : SUCCESS in 6m 06s","accounts_in_message":[],"_revision_number":2},{"id":"5c281293ff05866e68a5fb75ca321308f6d38fa3","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-08-19 09:44:29.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"9727a50cc4dd70e32fb94c51ed5752e62b3cba86","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-08-24 22:37:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"fb518ff875cc865ccd9f583cf7385c747ef44864","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 22:37:13.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1ec957bba19e48e86d1a9467341eb525176fe2da","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 23:51:32.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/12afe3635dcb4b97bfd9c51fdddaf128 : SUCCESS in 1h 12m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a0a2f5b0abf649c9aeefc2dc454acf7b : SUCCESS in 8m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b924fead39914ef39959c67555e81028 : SUCCESS in 5m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2169a955d8634062beba3886278627ec : SUCCESS in 4m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4313d2839d3647368a8a350dd3113a90 : SUCCESS in 6m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f8c4ed9325f24292ba7d5ff48ae9666b : SUCCESS in 6m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/4a4d84ed00634039aed0862d46713e33 : SUCCESS in 5m 17s","accounts_in_message":[],"_revision_number":2},{"id":"81d1ddbc7706abdaf12b34ff42001b31de180412","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 23:51:33.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"855de9ae5103adaea20127270448b59815b218d3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 23:53:03.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b69d8b490ca94da7a23d10f89b7f9f32 : SUCCESS in 1m 11s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a6c8b707e5e54f0aa8265a3428b624c2 : SUCCESS in 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f17252de50e857140c389f768caaff831e509ee7","revisions":{"fab653cd21e776e79685dce4e248a173032e53f1":{"kind":"REWORK","_number":1,"created":"2020-07-29 12:00:01.000000000","uploader":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"ref":"refs/changes/37/743737/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/37/743737/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/37/743737/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/37/743737/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/37/743737/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/37/743737/1"}}},"commit":{"parents":[{"commit":"cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7","subject":"Switch from unittest2 compat methods to Python 3.x methods","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7"}]}],"author":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-07-28 13:29:54.000000000","tz":240},"committer":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-07-29 11:59:25.000000000","tz":240},"subject":"Add sentinel redis support","message":"Add sentinel redis support\n\nRedis client has an ability to connect to Redis server\nusing Sentinel[1] (especially important for Redis clusters),\nbut this ability was missing here.\n\nAllow to pass \u0027sentinel\u0027 variable to Redis conf, extend\n_make_client to use sentinel for that case.\n\n[1] - https://github.com/andymccurdy/redis-py#sentinel-support\n\nChange-Id: Ia8cc98e701435fd0231da3724f5d7108fc4f96f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/fab653cd21e776e79685dce4e248a173032e53f1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/fab653cd21e776e79685dce4e248a173032e53f1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7","is_merged_in_target_branch":true,"change_id":"Iaa8251a1e9965a00fe99b7a740a104c011260340","change_number":739360,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"f17252de50e857140c389f768caaff831e509ee7":{"kind":"REWORK","_number":2,"created":"2020-08-05 13:03:40.000000000","uploader":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"ref":"refs/changes/37/743737/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/37/743737/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/37/743737/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/37/743737/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/37/743737/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/37/743737/2"}}},"commit":{"parents":[{"commit":"cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7","subject":"Switch from unittest2 compat methods to Python 3.x methods","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7"}]}],"author":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-07-28 13:29:54.000000000","tz":240},"committer":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-08-05 13:03:25.000000000","tz":240},"subject":"Add sentinel redis support","message":"Add sentinel redis support\n\nRedis client has an ability to connect to Redis server\nusing Sentinel[1] (especially important for Redis clusters),\nbut this ability was missing here.\n\nAllow to pass \u0027sentinel\u0027 variable to Redis conf, extend\n_make_client to use sentinel for that case.\n\n[1] - https://github.com/andymccurdy/redis-py#sentinel-support\n\nChange-Id: Ia8cc98e701435fd0231da3724f5d7108fc4f96f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f17252de50e857140c389f768caaff831e509ee7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f17252de50e857140c389f768caaff831e509ee7"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7","is_merged_in_target_branch":true,"change_id":"Iaa8251a1e9965a00fe99b7a740a104c011260340","change_number":739360,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}