)]}'
{"id":"openstack%2Ftaskflow~744156","triplet_id":"openstack%2Ftaskflow~master~Ic6b0a78d20124cc027468ecc6aeff189c25d1a8a","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"Ic6b0a78d20124cc027468ecc6aeff189c25d1a8a","subject":"Avoid endless loop on StorageFailure","status":"MERGED","created":"2020-07-31 13:06:30.000000000","updated":"2020-08-24 23:34:08.000000000","submitted":"2020-08-24 23:32:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"744156-1598311971188-69a35627","meta_rev_id":"c6977359fec460a3301f4a839de93da82d681794","_number":744156,"virtual_id_number":744156,"owner":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-08-24 23:32:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},{"value":2,"date":"2020-08-24 13:20:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":2,"date":"2020-08-24 22:00:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":1,"date":"2020-08-24 22:00:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-08-10 19:57:12.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-08-24 13:20:55.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-08-24 22:00:25.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"},{"updated":"2020-08-24 23:32:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fe3ad9bc6d8bf3e5dcd905c635485f2e5ac593f1","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2020-07-31 13:06:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9e7b71e073a54e8583989db04b9dff7de40f8adf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-31 14:37:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/dcf498f98fb5457d82a96e790adce5f4 : SUCCESS in 1h 19m 17s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/625f3d8ac6be449cb6593b155e2e58b9 : SUCCESS in 6m 12s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/23c72d0d035b46b384fcdd36b9f895e9 : SUCCESS in 5m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aa96ebbc2455496893902e7ff21e9386 : SUCCESS in 3m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/105162125c9c4a8a95ae69d7c4137fe3 : SUCCESS in 5m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/337979be91504f588074698ca9f2b8c9 : SUCCESS in 6m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b8cfee85951c4e3da82aa8d8c207b0b4 : SUCCESS in 5m 07s","accounts_in_message":[],"_revision_number":1},{"id":"e27b2d335ef366aeb2638ca733142d39611dd392","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-31 14:43:20.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"292bbf81338248e2d2a0e01d50fcbed5d95e0df0","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-08-10 19:57:12.000000000","message":"Patch Set 1: Code-Review-1\n\nThis just logs the error, which kind of hides it if someone doesn\u0027t know to go look through the logs. If there is an error storing persistent information, then it should be raising that error.\n\nI think the more correct fix is to catch these errors and handle them appropriately rather than the endless retrying you mention. But it shouldn\u0027t be immediate. Part of the benefit taskflow provides is that it can handle temporary failures like this. So it really should catch these errors, retry it for a given period, then only fail if some threshold has been reached that would be determined to be enough to give up.","accounts_in_message":[],"_revision_number":1},{"id":"600ca2e01dad379c9075e77792a08ee5feff1477","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2020-08-11 07:18:43.000000000","message":"Patch Set 1:\n\nI would say this approach is a workaround, but it helps to avoid situations disaster for production.\nNote: If StorageFailure was caused dbconnection error it will keep retrying to get connection.","accounts_in_message":[],"_revision_number":1},{"id":"317ba4ac4026f7140ce692af01dbb505ff45da27","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-08-21 10:51:40.000000000","message":"Patch Set 1: -Code-Review\n\n\u003e This just logs the error, which kind of hides it if someone doesn\u0027t\n \u003e know to go look through the logs. If there is an error storing\n \u003e persistent information, then it should be raising that error.\n \u003e \n \u003e I think the more correct fix is to catch these errors and handle\n \u003e them appropriately rather than the endless retrying you mention.\n \u003e But it shouldn\u0027t be immediate. Part of the benefit taskflow\n \u003e provides is that it can handle temporary failures like this. So it\n \u003e really should catch these errors, retry it for a given period, then\n \u003e only fail if some threshold has been reached that would be\n \u003e determined to be enough to give up.\n\nGood point, I agree with Sean if is it possible to manage these errors then we should follow this path. Concerning the retry/threshold part, it could be easily implemented by using tenacity.","accounts_in_message":[],"_revision_number":1},{"id":"c0c18132e92a5f3ffeac6a1df2d61c9438e478d9","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2020-08-21 11:01:49.000000000","message":"Patch Set 1:\n\nIf each retry will cost us accidentally created resource (port/VM/network) - do we really want it? \nI have no problem implementing this - just this will make things just slightly better. As I mentioned before if dbconnection error appear - it will be retried.","accounts_in_message":[],"_revision_number":1},{"id":"3b891f5740a3f7532e53b727ee0b9802776c98f2","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2020-08-24 11:14:40.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"977902ac1f6f3a866aad787eb522554e066e927f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 12:46:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/94abe93baf4b4831b3473637ec746352 : SUCCESS in 1h 26m 47s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a7ab30b2751d4445bf47c31b58f4dd17 : SUCCESS in 5m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b05b2e8bb8564586bbbc3fb45ec04b35 : SUCCESS in 6m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/066e837b2aa34e1ea3502efd2327508d : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d68b6f4387f04cbe9c202a5f3adaf3ac : SUCCESS in 5m 03s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/e015e8b45c8c4daba5ce514d356794de : SUCCESS in 6m 08s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b6219d10fe7c41199f23d9f24730407c : SUCCESS in 5m 10s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1d9809097e204eec8cdf6a304029f7bc : SUCCESS in 6m 07s","accounts_in_message":[],"_revision_number":2},{"id":"89a1f825d774946d4bdd188d5de90b04be3f4977","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-08-24 13:03:32.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nThanks for this new PS, you\u0027ve some nits that should be addressed in your release note (related to my -1).\n\nElse this new PS looks like to a good compromize between the original version and our previous comments.","accounts_in_message":[],"_revision_number":2},{"id":"0aec6fec6d8df7f50124b0293084fa46051c1bce","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2020-08-24 13:17:12.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"b93479111e65eeef70a2d5b4ee39d9c85f14a516","author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"date":"2020-08-24 13:17:29.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c919dd0d9e08d27c81b48b3e9fea44f064573002","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-08-24 13:20:55.000000000","message":"Patch Set 3: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":3},{"id":"a3eba641abe0c6d7ecaf901bdc3ff7c2c7e27ea4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 14:57:19.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/53d0bbc97060408eb190093b21244f05 : SUCCESS in 1h 32m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7308b940f5824cecba55e3cb56d0d85f : SUCCESS in 6m 34s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6e5df36059cd4cbc86c8c1c6ba6ea3a7 : SUCCESS in 5m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b2151e23bb924158bab3a520ddeb8d75 : SUCCESS in 5m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a83b2b445db543df9ffd07ef71f47bb9 : SUCCESS in 5m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3a60cfae9ffe45f4a4d2973dce6d06da : SUCCESS in 8m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a9bd4406610d44908f7b56561cc8a7ba : SUCCESS in 6m 36s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/521718a6613e4520ad296451ab984b24 : SUCCESS in 5m 32s","accounts_in_message":[],"_revision_number":3},{"id":"8186cb9512ad197c2c5607e6967a02cadcd299c3","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2020-08-24 22:00:25.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nI am ok with this option.","accounts_in_message":[],"_revision_number":3},{"id":"789bf5dfb0409a756b3fc65d80344eb988ac0943","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 22:00:37.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"0b6592171813037121ddb2a5b22156dc9949724f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 23:32:50.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0e5b591af2bf45ca946317bfc2cf0084 : SUCCESS in 1h 30m 22s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/38d51fd86e9a486792d255da2a0c320a : SUCCESS in 6m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6a3e495c10e54188826f165a977aab00 : SUCCESS in 4m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/924381c3c05b41f0ab4cc9563fcded94 : SUCCESS in 5m 20s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/24dfbc405f5a47069ddc3610388dc1f3 : SUCCESS in 5m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0e6ebf16af814b20bed09f843aff3926 : SUCCESS in 6m 04s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2c043889dad141c6b4f5a063922344c5 : SUCCESS in 4m 33s","accounts_in_message":[],"_revision_number":3},{"id":"cf708fd7673183f11c58cb39089688b9baf35f98","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 23:32:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"c6977359fec460a3301f4a839de93da82d681794","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-08-24 23:34:08.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1ad54e1d87b841db91beb689b9976178 : SUCCESS in 52s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a41caa6f87de4cd298cb6c23285bf5ec : SUCCESS in 57s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c32454213e5aa1b6cda770f56ddef18f06c2c3c2","revisions":{"f5a803db104d5e3cc889c204984a3fa2ce01dfc0":{"kind":"REWORK","_number":1,"created":"2020-07-31 13:06:30.000000000","uploader":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"ref":"refs/changes/56/744156/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/56/744156/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/56/744156/1"}}},"commit":{"parents":[{"commit":"cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7","subject":"Switch from unittest2 compat methods to Python 3.x methods","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7"}]}],"author":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-07-31 12:58:23.000000000","tz":240},"committer":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-07-31 12:58:23.000000000","tz":240},"subject":"Avoid endless loop on StorageFailure","message":"Avoid endless loop on StorageFailure\n\nIf an error occures with writing atom detail in database(\npersistence backend) flow execution enters an endless loop\nthrowing errors and retrying to save details.\n\nAvoid this situation and log exception message.\n\nChange-Id: Ic6b0a78d20124cc027468ecc6aeff189c25d1a8a\nCloses-bug: 1889773\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f5a803db104d5e3cc889c204984a3fa2ce01dfc0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f5a803db104d5e3cc889c204984a3fa2ce01dfc0"}]},"branch":"refs/heads/master"},"dd46875c0d2f87396be2e41a176e5089653e16fa":{"kind":"REWORK","_number":2,"created":"2020-08-24 11:14:40.000000000","uploader":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"ref":"refs/changes/56/744156/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/56/744156/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/56/744156/2"}}},"commit":{"parents":[{"commit":"cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7","subject":"Switch from unittest2 compat methods to Python 3.x methods","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7"}]}],"author":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-07-31 12:58:23.000000000","tz":240},"committer":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-08-24 11:14:24.000000000","tz":240},"subject":"Avoid endless loop on StorageFailure","message":"Avoid endless loop on StorageFailure\n\nIf an error occures with writing atom detail in database(\npersistence backend) flow execution enters an endless loop\nthrowing errors and retrying to save details.\n\nAvoid this situation and log exception message.\n\nChange-Id: Ic6b0a78d20124cc027468ecc6aeff189c25d1a8a\nCloses-bug: 1889773\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dd46875c0d2f87396be2e41a176e5089653e16fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/dd46875c0d2f87396be2e41a176e5089653e16fa"}]},"branch":"refs/heads/master"},"c32454213e5aa1b6cda770f56ddef18f06c2c3c2":{"kind":"REWORK","_number":3,"created":"2020-08-24 13:17:12.000000000","uploader":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"ref":"refs/changes/56/744156/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/56/744156/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/56/744156/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/56/744156/3"}}},"commit":{"parents":[{"commit":"cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7","subject":"Switch from unittest2 compat methods to Python 3.x methods","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/cf327a2e2d4e2c504b5080fbf7bd48421fe7b4c7"}]}],"author":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-07-31 12:58:23.000000000","tz":240},"committer":{"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","date":"2020-08-24 13:16:54.000000000","tz":0},"subject":"Avoid endless loop on StorageFailure","message":"Avoid endless loop on StorageFailure\n\nIf an error occures with writing atom detail in database(\npersistence backend) flow execution enters an endless loop\nthrowing errors and retrying to save details.\n\nAvoid this situation and log exception message.\n\nChange-Id: Ic6b0a78d20124cc027468ecc6aeff189c25d1a8a\nCloses-bug: 1889773\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/c32454213e5aa1b6cda770f56ddef18f06c2c3c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/c32454213e5aa1b6cda770f56ddef18f06c2c3c2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}