)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1fddd6535a033bf1c155c7b4902409dddd97cd2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9cec7dcd_3773d920","updated":"2021-10-20 13:12:44.000000000","message":"Hello,\n\nPlease see my inline comments.\n\nAlso, it would be nice to add a release note.\n\nMy -1 is related to the `six` comments.","commit_id":"fe655bd88d7212e12d15ede99d83e9ac6dc28073"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5936c983830d63fb7df2f4877b5328c3f5a4a673","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"13617f10_beedac4c","updated":"2021-10-26 21:02:13.000000000","message":"I would like a bit more information on the bug report as I have concerns that setting the task to FAILED may have other side effects.\nI would expect that the worker would abandon the job as opposed to failing the task.","commit_id":"fe655bd88d7212e12d15ede99d83e9ac6dc28073"}],"taskflow/engines/worker_based/executor.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1fddd6535a033bf1c155c7b4902409dddd97cd2c","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        if not self._watch_worker.has_started():"},{"line_number":151,"context_line":"            self._watch_worker.start()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        elif self._watch_worker.expired():"},{"line_number":154,"context_line":"            active_workers \u003d six.itervalues(self._finder._workers)"},{"line_number":155,"context_line":"            with self._request_worker_lock:"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"363a144c_bf1ed0bb","line":153,"range":{"start_line":153,"start_character":8,"end_line":153,"end_character":12},"updated":"2021-10-20 13:12:44.000000000","message":"Don\u0027t you think a `if` would be enough here?\nI mean if we just started the worker above then it won\u0027t be yet expired so this clause will be simply false and then the function will return an empty list as expected.","commit_id":"fe655bd88d7212e12d15ede99d83e9ac6dc28073"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1fddd6535a033bf1c155c7b4902409dddd97cd2c","unresolved":true,"context_lines":[{"line_number":151,"context_line":"            self._watch_worker.start()"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        elif self._watch_worker.expired():"},{"line_number":154,"context_line":"            active_workers \u003d six.itervalues(self._finder._workers)"},{"line_number":155,"context_line":"            with self._request_worker_lock:"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"                for request_uuid, worker in six.iteritems("}],"source_content_type":"text/x-python","patch_set":4,"id":"fef2d540_acb6efae","line":154,"range":{"start_line":154,"start_character":29,"end_line":154,"end_character":32},"updated":"2021-10-20 13:12:44.000000000","message":"Python 2.7 is not longer supported, rather can we simply use `self._finder._workers.values()`?","commit_id":"fe655bd88d7212e12d15ede99d83e9ac6dc28073"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1fddd6535a033bf1c155c7b4902409dddd97cd2c","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        elif self._watch_worker.expired():"},{"line_number":154,"context_line":"            active_workers \u003d six.itervalues(self._finder._workers)"},{"line_number":155,"context_line":"            with self._request_worker_lock:"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"                for request_uuid, worker in six.iteritems("},{"line_number":158,"context_line":"                        self._request_worker_mapping):"},{"line_number":159,"context_line":"                    if worker not in active_workers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"94a2f7b2_b8a9e8fc","line":156,"updated":"2021-10-20 13:12:44.000000000","message":"This blank line can be removed.","commit_id":"fe655bd88d7212e12d15ede99d83e9ac6dc28073"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1fddd6535a033bf1c155c7b4902409dddd97cd2c","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            active_workers \u003d six.itervalues(self._finder._workers)"},{"line_number":155,"context_line":"            with self._request_worker_lock:"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"                for request_uuid, worker in six.iteritems("},{"line_number":158,"context_line":"                        self._request_worker_mapping):"},{"line_number":159,"context_line":"                    if worker not in active_workers:"},{"line_number":160,"context_line":"                        expired_workers_request_uuid.append(request_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"59177110_6104dce1","line":157,"range":{"start_line":157,"start_character":44,"end_line":157,"end_character":47},"updated":"2021-10-20 13:12:44.000000000","message":"Same as above but with `self._request_worker_mapping.items()`","commit_id":"fe655bd88d7212e12d15ede99d83e9ac6dc28073"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1fddd6535a033bf1c155c7b4902409dddd97cd2c","unresolved":true,"context_lines":[{"line_number":188,"context_line":"                    expired_requests[request_uuid] \u003d request"},{"line_number":189,"context_line":"                elif request.current_state \u003d\u003d pr.WAITING:"},{"line_number":190,"context_line":"                    waiting_requests[request_uuid] \u003d request"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"                elif request_uuid in expired_workers_request_uuid:"},{"line_number":193,"context_line":"                    expired_requests[request_uuid] \u003d request"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"31cd6692_b465b05e","line":191,"updated":"2021-10-20 13:12:44.000000000","message":"This blank line can be removed.","commit_id":"fe655bd88d7212e12d15ede99d83e9ac6dc28073"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1fddd6535a033bf1c155c7b4902409dddd97cd2c","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                        del self._ongoing_requests[request.uuid]"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"                    self._clean_request_worker_mapping(request.uuid)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"                    request.set_result(failure)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def execute_task(self, task, task_uuid, arguments,"}],"source_content_type":"text/x-python","patch_set":4,"id":"27ec72f5_217111bf","line":285,"updated":"2021-10-20 13:12:44.000000000","message":"This blank line can be removed.","commit_id":"fe655bd88d7212e12d15ede99d83e9ac6dc28073"}]}