)]}'
{"id":"openstack%2Ftaskflow~80138","triplet_id":"openstack%2Ftaskflow~master~Idb4275d8f07d60e2ed83c0987b6c7354a09c8a71","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"Idb4275d8f07d60e2ed83c0987b6c7354a09c8a71","subject":"Avoid calling callbacks while holding locks","status":"MERGED","created":"2014-03-13 01:25:52.000000000","updated":"2014-03-14 19:29:26.000000000","submitted":"2014-03-14 19:29:25.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"116a3c86a0030916802ba75efcff6504a5114a1d","_number":80138,"virtual_id_number":80138,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2014-03-14 19:29:25.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"all":[{"value":0,"date":"2014-03-14 19:07:04.000000000","permitted_voting_range":{"min":0,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-03-13 14:09:18.000000000","_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":1,"date":"2014-03-13 14:14:00.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2014-03-14 19:07:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-03-13 14:09:18.000000000","_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-13 14:09:18.000000000","updated_by":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"reviewer":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"state":"REVIEWER"},{"updated":"2014-03-13 14:14:00.000000000","updated_by":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"reviewer":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"state":"REVIEWER"},{"updated":"2014-03-14 19:29:25.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"55cca096061c87cb8305e25f9f099848008ed13a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-13 01:25:52.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"dd54e7d5598ba5e8ccb12d2726a77455f6d72d98","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-13 01:26:48.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"f9f9befb4545cfa2ff4bd55e9e8db808f18bdd58","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-03-13 01:26:48.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8dd8f84207203a846c5abacec3ddfc7baaeb9e98","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-13 01:31:48.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/38/80138/2/check/gate-taskflow-pep8/dbffb47 : SUCCESS in 50s\n- gate-taskflow-docs http://docs-draft.openstack.org/38/80138/2/check/gate-taskflow-docs/683f1b9/doc/build/html/ : SUCCESS in 1m 39s\n- gate-taskflow-python26 http://logs.openstack.org/38/80138/2/check/gate-taskflow-python26/fba305b : SUCCESS in 2m 24s\n- gate-taskflow-python27 http://logs.openstack.org/38/80138/2/check/gate-taskflow-python27/d8422d3 : SUCCESS in 2m 26s\n- gate-taskflow-python33 http://logs.openstack.org/38/80138/2/check/gate-taskflow-python33/a7e4a47 : SUCCESS in 4m 56s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/38/80138/2/check/gate-taskflow-tox-py26-sa7-mysql/8d8b69b : SUCCESS in 3m 04s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/38/80138/2/check/gate-taskflow-tox-py27-sa8-mysql/3743335 : SUCCESS in 3m 03s\n","accounts_in_message":[],"_revision_number":2},{"id":"52a94a7e7329f71bc8803238237f24f002a2b02f","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-03-13 14:09:18.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"3d62c5eecd5063137cee25a9bc03253289a5ec08","author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"date":"2014-03-13 14:14:00.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"fad714190068998a5761b5129498439c8821ff06","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-14 19:07:04.000000000","message":"Patch Set 2: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"1eed85302ddc3ee381e61c30d964e0e8ab15d901","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-03-14 19:07:04.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"7d9906aff7d1b628ef0c32f8b4601c246f206a93","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-14 19:24:06.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/38/80138/2/check/gate-taskflow-pep8/f5e3816 : SUCCESS in 1m 35s\n- gate-taskflow-docs http://docs-draft.openstack.org/38/80138/2/check/gate-taskflow-docs/e783d82/doc/build/html/ : SUCCESS in 1m 45s\n- gate-taskflow-python26 http://logs.openstack.org/38/80138/2/check/gate-taskflow-python26/cc28b00 : SUCCESS in 2m 57s\n- gate-taskflow-python27 http://logs.openstack.org/38/80138/2/check/gate-taskflow-python27/9c8f6ed : SUCCESS in 2m 26s\n- gate-taskflow-python33 http://logs.openstack.org/38/80138/2/check/gate-taskflow-python33/8577bb6 : SUCCESS in 5m 41s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/38/80138/2/check/gate-taskflow-tox-py26-sa7-mysql/37c985c : SUCCESS in 3m 04s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/38/80138/2/check/gate-taskflow-tox-py27-sa8-mysql/04c4137 : SUCCESS in 2m 54s\n","accounts_in_message":[],"_revision_number":2},{"id":"a88d9507d8e97bf974826ec9576344b4c85d34c8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-14 19:24:07.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c3ef2b853736324a40dc0b338849bd401e25413f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-14 19:29:25.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-taskflow-docs http://docs-draft.openstack.org/38/80138/2/gate/gate-taskflow-docs/9fb8bfd/doc/build/html/ : SUCCESS in 1m 33s\n- gate-taskflow-pep8 http://logs.openstack.org/38/80138/2/gate/gate-taskflow-pep8/2788fd4 : SUCCESS in 1m 25s\n- gate-taskflow-python26 http://logs.openstack.org/38/80138/2/gate/gate-taskflow-python26/ade0303 : SUCCESS in 2m 27s\n- gate-taskflow-python27 http://logs.openstack.org/38/80138/2/gate/gate-taskflow-python27/7f20dd6 : SUCCESS in 2m 02s\n- gate-taskflow-python33 http://logs.openstack.org/38/80138/2/gate/gate-taskflow-python33/ce677f6 : SUCCESS in 5m 17s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/38/80138/2/gate/gate-taskflow-tox-py26-sa7-mysql/6a6a4c6 : SUCCESS in 3m 02s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/38/80138/2/gate/gate-taskflow-tox-py27-sa8-mysql/2636c75 : SUCCESS in 2m 43s\n","accounts_in_message":[],"_revision_number":2},{"id":"116a3c86a0030916802ba75efcff6504a5114a1d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-14 19:29:26.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d440972d100a66452c8c967500030d57717de4ee","revisions":{"f2e3c1b3670d9ec0efa84c7ee0ebf940041de355":{"kind":"REWORK","_number":1,"created":"2014-03-13 01:25:52.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/38/80138/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/38/80138/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/38/80138/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/38/80138/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/38/80138/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/38/80138/1"}}},"commit":{"parents":[{"commit":"a6930eb537c05269587706559449b1329b58bb28","subject":"Merge \"Correct LOG.warning in persistence utils\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/a6930eb537c05269587706559449b1329b58bb28"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-03-13 01:24:46.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-03-13 01:24:46.000000000","tz":-420},"subject":"Avoid calling callbacks while holding locks","message":"Avoid calling callbacks while holding locks\n\nInstead of calling the callback while holding\na write lock (a recipe for deadlock) call the\ncallbacks after we pop all the values to avoid\nany potential for deadlock.\n\nChange-Id: Idb4275d8f07d60e2ed83c0987b6c7354a09c8a71\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f2e3c1b3670d9ec0efa84c7ee0ebf940041de355"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f2e3c1b3670d9ec0efa84c7ee0ebf940041de355"}]},"branch":"refs/heads/master"},"d440972d100a66452c8c967500030d57717de4ee":{"kind":"REWORK","_number":2,"created":"2014-03-13 01:26:48.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/38/80138/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/38/80138/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/38/80138/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/38/80138/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/38/80138/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/38/80138/2"}}},"commit":{"parents":[{"commit":"a6930eb537c05269587706559449b1329b58bb28","subject":"Merge \"Correct LOG.warning in persistence utils\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/a6930eb537c05269587706559449b1329b58bb28"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-03-13 01:24:46.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-03-13 01:26:23.000000000","tz":-420},"subject":"Avoid calling callbacks while holding locks","message":"Avoid calling callbacks while holding locks\n\nInstead of calling the callback while holding\na write lock (a recipe for deadlock) call the\ncallbacks after we pop all the values to avoid\nany potential for deadlock.\n\nChange-Id: Idb4275d8f07d60e2ed83c0987b6c7354a09c8a71\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/d440972d100a66452c8c967500030d57717de4ee"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/d440972d100a66452c8c967500030d57717de4ee"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
