)]}'
{"id":"openstack%2Ftaskflow~80155","triplet_id":"openstack%2Ftaskflow~master~Idbc5898e97f901a9e8d58948019cdd398b235168","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"Idbc5898e97f901a9e8d58948019cdd398b235168","subject":"Update lock_utils to use the posix IPC lock","status":"ABANDONED","created":"2014-03-13 02:25:44.000000000","updated":"2014-03-25 06:03:42.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8731cda3bfacaa5e3c2b80e541bcd8a8dbd74016","_number":80155,"virtual_id_number":80155,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2014-03-17 08:02:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2014-03-17 07:55:45.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":2,"date":"2014-03-13 20:55:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-03-17 07:55:45.000000000","_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"date":"2014-03-13 20:55:48.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"},{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-13 20:55:48.000000000","updated_by":{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"},"reviewer":{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"},"state":"REVIEWER"},{"updated":"2014-03-17 07:55:45.000000000","updated_by":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"reviewer":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"state":"REVIEWER"},{"updated":"2014-03-17 08:02:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8c71b60292cf85983d6475e1aaac11d55945563f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-13 02:25:51.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"fcef4db051142f68f374c2abae78aa37dd524c11","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-13 02:42:47.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/55/80155/1/check/gate-taskflow-pep8/000da83 : SUCCESS in 1m 27s\n- gate-taskflow-docs http://docs-draft.openstack.org/55/80155/1/check/gate-taskflow-docs/7c3d211/doc/build/html/ : SUCCESS in 1m 34s\n- gate-taskflow-python26 http://logs.openstack.org/55/80155/1/check/gate-taskflow-python26/e0dc3e1 : SUCCESS in 3m 13s\n- gate-taskflow-python27 http://logs.openstack.org/55/80155/1/check/gate-taskflow-python27/275d9ff : SUCCESS in 2m 10s\n- gate-taskflow-python33 http://logs.openstack.org/55/80155/1/check/gate-taskflow-python33/1ea12ea : SUCCESS in 5m 18s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/55/80155/1/check/gate-taskflow-tox-py26-sa7-mysql/e566e29 : SUCCESS in 3m 19s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/55/80155/1/check/gate-taskflow-tox-py27-sa8-mysql/a9008d5 : SUCCESS in 2m 43s\n","accounts_in_message":[],"_revision_number":1},{"id":"67a3224e84e5f5f6d5c2a6a2c0b8a23abdb9efa3","author":{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"},"date":"2014-03-13 20:55:48.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"6973ac1f29a0e7a3b3675e662d0487b91850b91a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-17 07:55:45.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"26e1372976b0e609849f4515b914e89c6b05fbc5","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-03-17 07:55:45.000000000","message":"Patch Set 1: Do not merge\n\nThe only place where we use interprocess lock is filesystem persistence backend. I believe that this backend we relies on its file-based behavior, which is especially important for cases where data is placed on shared filesystem. So, I think we should keep using file-based locking for file persistence backend.\n\nBtw, in oslo-incubator issue with posix locking vs. shared fs recognised and addressed by re-enabling file-based locking in I21dd17d58d1c321566c72e808a055a0bd625c647 .","accounts_in_message":[],"_revision_number":1},{"id":"3c2405349eb63ea26b45390ce600e9f802695770","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-17 08:02:32.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/55/80155/1/check/gate-taskflow-pep8/3ecc99d : SUCCESS in 1m 22s\n- gate-taskflow-docs http://docs-draft.openstack.org/55/80155/1/check/gate-taskflow-docs/e521d8b/doc/build/html/ : SUCCESS in 1m 39s\n- gate-taskflow-python26 http://logs.openstack.org/55/80155/1/check/gate-taskflow-python26/f466518 : SUCCESS in 2m 38s\n- gate-taskflow-python27 http://logs.openstack.org/55/80155/1/check/gate-taskflow-python27/c738587 : SUCCESS in 2m 11s\n- gate-taskflow-python33 http://logs.openstack.org/55/80155/1/check/gate-taskflow-python33/58f1e06 : SUCCESS in 5m 08s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/55/80155/1/check/gate-taskflow-tox-py26-sa7-mysql/3cf7a45 : SUCCESS in 2m 33s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/55/80155/1/check/gate-taskflow-tox-py27-sa8-mysql/5e6ab1e : SUCCESS in 2m 20s\n","accounts_in_message":[],"_revision_number":1},{"id":"5cf4d1a8b06456fe3dfe23b26fc12a3acab685cc","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-03-25 06:03:42.000000000","message":"Patch Set 1:\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1},{"id":"6a198942492cdece247d7dcef14651acf571d0ef","author":{"_account_id":9,"name":"LaunchpadSync","username":"launchpadsync"},"date":"2014-03-25 06:03:42.000000000","message":"Patch Set 1: Abandoned\n\ncode review expired after 1 week of no activity after a negative review, it can be restored using the `Restore Change` button under the Patch Set on the web interface","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7cb087f94ed3d27c77cd9c06f28c039cd1b89d1b","revisions":{"7cb087f94ed3d27c77cd9c06f28c039cd1b89d1b":{"kind":"REWORK","_number":1,"created":"2014-03-13 02:25:44.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/55/80155/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/55/80155/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/55/80155/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/55/80155/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/55/80155/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/55/80155/1"}}},"commit":{"parents":[{"commit":"3ecfe43d90a2e43e5af2c28989789fa313036943","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/3ecfe43d90a2e43e5af2c28989789fa313036943"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-03-13 01:35:57.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-03-13 02:25:28.000000000","tz":-420},"subject":"Update lock_utils to use the posix IPC lock","message":"Update lock_utils to use the posix IPC lock\n\nSince we maintain a miniature copy of the oslo\nlock utils file and that file changed to using\nposix IPC for interprocess locks for non-nt\noperating systems lets update to use that newer\nand improved interprocess lock instead of the\nprevious one based on fnctl.\n\nTaken from oslo-incubator commit c01539f41d\n\nChange-Id: Idbc5898e97f901a9e8d58948019cdd398b235168\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/7cb087f94ed3d27c77cd9c06f28c039cd1b89d1b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/7cb087f94ed3d27c77cd9c06f28c039cd1b89d1b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
