)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"00b3f672a2851a480b57b38adcb9cf93b87681c1","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In case of invalid/missing data in the job, the job entry should be"},{"line_number":10,"context_line":"purged from the backend to avoid re-scheduling it later."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1949950"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I09ab84883cd4dfbab18b56c61e585fd8ac1b6acf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"b0c1099b_857919d8","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":20},"updated":"2024-01-12 09:00:06.000000000","message":"there is a different fix for the same bug which was already merged.\n\nDo we still need this ?\n\nhttps://review.opendev.org/c/openstack/taskflow/+/816798","commit_id":"a45f8249c966a7241556a465f8c07c7fbb210277"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"63cffbd3d005be48541166639ae28500b9b11e8e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"In case of invalid/missing data in the job, the job entry should be"},{"line_number":10,"context_line":"purged from the backend to avoid re-scheduling it later."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1949950"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I09ab84883cd4dfbab18b56c61e585fd8ac1b6acf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"afee4529_64dae9e8","line":12,"range":{"start_line":12,"start_character":13,"end_line":12,"end_character":20},"in_reply_to":"b0c1099b_857919d8","updated":"2024-01-12 09:04:50.000000000","message":"Hi,\n\nThe bug report contains 2 bugs (there are related, as the initia goal was to handle potential invalid data in redis), maybe I should have opened 2 launchpad issues.\nSo yeah, this patch is still needed","commit_id":"a45f8249c966a7241556a465f8c07c7fbb210277"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"574631532f044c625064c3a14f6197d63bb7b6fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d619c1e_1572cbc1","updated":"2022-01-07 17:54:39.000000000","message":"I have some questions about this change.","commit_id":"84a4ad0b8f304a247a3b720aac49da373cf4fd80"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e9d2f59c5523d6b478789c116f260559fdd3d46c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"41f689fc_aaa92c33","updated":"2021-11-08 10:14:25.000000000","message":"Looks sensible according to the parent patch","commit_id":"84a4ad0b8f304a247a3b720aac49da373cf4fd80"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"f3ac9e9b6c24862d3f6cb1ee589d0e5ed6db9e68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7e372bf_a68bb482","updated":"2024-01-23 12:02:42.000000000","message":"Looks good to merge.","commit_id":"a45f8249c966a7241556a465f8c07c7fbb210277"}],"taskflow/conductors/backends/impl_executor.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"574631532f044c625064c3a14f6197d63bb7b6fc","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                self._log.warn(\"Job dispatching interrupted: %s\", job)"},{"line_number":253,"context_line":"        except Exception:"},{"line_number":254,"context_line":"            self._log.warn(\"Job dispatching failed: %s\", job, exc_info\u003dTrue)"},{"line_number":255,"context_line":"            trash \u003d True"},{"line_number":256,"context_line":"        try:"},{"line_number":257,"context_line":"            self._try_finish_job(job, consume, trash)"},{"line_number":258,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"d57eca62_905c747f","line":255,"updated":"2022-01-07 17:54:39.000000000","message":"How does this interact with the max_dispatches feature?\nIt seems like this would short-circuit the dispatch retry mechanisms causing a dispatch to not be retried. Do you maybe need to set the max_dispatches so that it doesn\u0027t loop forever?\nOr maybe catch the StopIteration here and remove it then?\n\nhttps://github.com/openstack/taskflow/blob/38b9011094dbcfdd00e6446393816201e8256d38/taskflow/conductors/backends/impl_executor.py#L264","commit_id":"84a4ad0b8f304a247a3b720aac49da373cf4fd80"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"1e14b34ed13506130996dee5915013cdccca69ea","unresolved":true,"context_lines":[{"line_number":252,"context_line":"                self._log.warn(\"Job dispatching interrupted: %s\", job)"},{"line_number":253,"context_line":"        except Exception:"},{"line_number":254,"context_line":"            self._log.warn(\"Job dispatching failed: %s\", job, exc_info\u003dTrue)"},{"line_number":255,"context_line":"            trash \u003d True"},{"line_number":256,"context_line":"        try:"},{"line_number":257,"context_line":"            self._try_finish_job(job, consume, trash)"},{"line_number":258,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"930b0ab3_ba44f86e","line":255,"in_reply_to":"d57eca62_905c747f","updated":"2022-01-11 17:24:35.000000000","message":"max_dispatches doesn\u0027t prevent from rescheduling the same job after hitting the max_dispatches limit.\nthe patch fixes an issue when a job is fetched, triggers an error, and is not consumed by the exception handler, so it is not removed from the job list and the next iteration triggers the same issue","commit_id":"84a4ad0b8f304a247a3b720aac49da373cf4fd80"}]}