)]}'
{"id":"openstack%2Ftaskflow~82091","triplet_id":"openstack%2Ftaskflow~master~Iab23e245cdc834e2cdcb4b7011e13be59aca754a","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"Iab23e245cdc834e2cdcb4b7011e13be59aca754a","subject":"Flattening improvements","status":"MERGED","created":"2014-03-21 13:29:39.000000000","updated":"2014-03-24 19:45:27.000000000","submitted":"2014-03-24 19:45:27.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bfca3dd89b464bc3360010482bc5353389010821","_number":82091,"virtual_id_number":82091,"owner":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2014-03-24 19:45:27.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7349,"name":"Anastasia Karpinska","email":"akarpinska@griddynamics.com","username":"anastasia-karpinska"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2014-03-24 19:38:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-03-24 10:53:32.000000000","_account_id":7349,"name":"Anastasia Karpinska","email":"akarpinska@griddynamics.com","username":"anastasia-karpinska"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2014-03-24 19:38:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-03-24 10:53:32.000000000","_account_id":7349,"name":"Anastasia Karpinska","email":"akarpinska@griddynamics.com","username":"anastasia-karpinska"},{"value":0,"date":"2014-03-24 09:20:05.000000000","_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7349,"name":"Anastasia Karpinska","email":"akarpinska@griddynamics.com","username":"anastasia-karpinska"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":7349,"name":"Anastasia Karpinska","email":"akarpinska@griddynamics.com","username":"anastasia-karpinska"},{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-03-24 10:53:32.000000000","updated_by":{"_account_id":7349,"name":"Anastasia Karpinska","email":"akarpinska@griddynamics.com","username":"anastasia-karpinska"},"reviewer":{"_account_id":7349,"name":"Anastasia Karpinska","email":"akarpinska@griddynamics.com","username":"anastasia-karpinska"},"state":"REVIEWER"},{"updated":"2014-03-24 19:38:30.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2014-03-24 19:45:27.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c71501a628bcc835ee8d5b0b1deca6a60e9f14ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-21 13:29:40.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"90e8a52ebf6aef5e950f7edee3fe4f1d70982a75","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-03-21 13:30:03.000000000","message":"Patch Set 1: Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"ba7062e25057d46442bfc709067370d0d23d5ed6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-21 13:40:38.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-taskflow-pep8 http://logs.openstack.org/91/82091/1/check/gate-taskflow-pep8/5773727 : FAILURE in 1m 32s\n- gate-taskflow-docs http://docs-draft.openstack.org/91/82091/1/check/gate-taskflow-docs/2042999/doc/build/html/ : SUCCESS in 1m 48s\n- gate-taskflow-python26 http://logs.openstack.org/91/82091/1/check/gate-taskflow-python26/8392d55 : SUCCESS in 2m 51s\n- gate-taskflow-python27 http://logs.openstack.org/91/82091/1/check/gate-taskflow-python27/cb268ea : SUCCESS in 3m 25s\n- gate-taskflow-python33 http://logs.openstack.org/91/82091/1/check/gate-taskflow-python33/7d34107 : FAILURE in 5m 40s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/91/82091/1/check/gate-taskflow-tox-py26-sa7-mysql/1c57e11 : SUCCESS in 2m 19s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/91/82091/1/check/gate-taskflow-tox-py27-sa8-mysql/9a2ed90 : SUCCESS in 2m 10s\n","accounts_in_message":[],"_revision_number":1},{"id":"da713e5395223eefaf4a5d6f3afc77d04f17498e","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-03-24 09:20:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6155857ba9d7ae47ce4642f4164ddb474ae68d62","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-24 09:20:07.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"beeae255bd3f2366266820a15ce90b35b40c1e18","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-24 09:25:28.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/91/82091/2/check/gate-taskflow-pep8/b974876 : SUCCESS in 1m 04s\n- gate-taskflow-docs http://docs-draft.openstack.org/91/82091/2/check/gate-taskflow-docs/598b37e/doc/build/html/ : SUCCESS in 1m 22s\n- gate-taskflow-python26 http://logs.openstack.org/91/82091/2/check/gate-taskflow-python26/cfd0cc5 : SUCCESS in 2m 53s\n- gate-taskflow-python27 http://logs.openstack.org/91/82091/2/check/gate-taskflow-python27/66b5359 : SUCCESS in 2m 56s\n- gate-taskflow-python33 http://logs.openstack.org/91/82091/2/check/gate-taskflow-python33/c41ce98 : SUCCESS in 5m 19s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/91/82091/2/check/gate-taskflow-tox-py26-sa7-mysql/7a87190 : SUCCESS in 2m 20s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/91/82091/2/check/gate-taskflow-tox-py27-sa8-mysql/76c75a3 : SUCCESS in 2m 29s\n\n","accounts_in_message":[],"_revision_number":2},{"id":"6e31fc7be915f5f51e409bc1616e9496561b1241","author":{"_account_id":7349,"name":"Anastasia Karpinska","email":"akarpinska@griddynamics.com","username":"anastasia-karpinska"},"date":"2014-03-24 10:53:32.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"21b0addcd1281034f5e8670b6fd63ee6f8498c87","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-03-24 19:38:30.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"498d5af2eaf757401e8d68355c8085a3b13af521","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-24 19:38:31.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"30d285cf3024ebd3ccdb6657fa98b9674711d584","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-24 19:45:27.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-taskflow-docs http://docs-draft.openstack.org/91/82091/2/gate/gate-taskflow-docs/b4908ad/doc/build/html/ : SUCCESS in 1m 35s\n- gate-taskflow-pep8 http://logs.openstack.org/91/82091/2/gate/gate-taskflow-pep8/eb0a63c : SUCCESS in 2m 08s\n- gate-taskflow-python26 http://logs.openstack.org/91/82091/2/gate/gate-taskflow-python26/fad174a : SUCCESS in 2m 47s\n- gate-taskflow-python27 http://logs.openstack.org/91/82091/2/gate/gate-taskflow-python27/0b09ab8 : SUCCESS in 2m 24s\n- gate-taskflow-python33 http://logs.openstack.org/91/82091/2/gate/gate-taskflow-python33/2f6e90a : SUCCESS in 6m 10s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/91/82091/2/gate/gate-taskflow-tox-py26-sa7-mysql/ddc1869 : SUCCESS in 3m 26s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/91/82091/2/gate/gate-taskflow-tox-py27-sa8-mysql/cea4e58 : SUCCESS in 2m 38s\n\n","accounts_in_message":[],"_revision_number":2},{"id":"bfca3dd89b464bc3360010482bc5353389010821","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-24 19:45:27.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b8b9cc3ac3f3a2d0053fe237aa266a981a040668","revisions":{"2825e798f5cc625240024db4667d65d1cf599239":{"kind":"REWORK","_number":1,"created":"2014-03-21 13:29:39.000000000","uploader":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"ref":"refs/changes/91/82091/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/91/82091/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/91/82091/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/91/82091/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/91/82091/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/91/82091/1"}}},"commit":{"parents":[{"commit":"7b95f500a000bc77f6ff0cf2599df25400395268","subject":"Rework graph flow unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/7b95f500a000bc77f6ff0cf2599df25400395268"}]}],"author":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-03-21 13:24:52.000000000","tz":240},"committer":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-03-21 13:24:52.000000000","tz":240},"subject":"(WIP) Flattening improvements","message":"(WIP) Flattening improvements\n\n- remove extraneous locking from flattener;\n- don\u0027t add \u0027flatten\u0027: True to edge data: it means nothing currently\n  as all the edges get it;\n- add dependency-related links only from providers to consumers of\n  said dependency.\n\nTODO:\n- update and improve unit tests;\n- think about adding information on manual edge origin (like, names\n  of original link source and destination).\n\nChange-Id: Iab23e245cdc834e2cdcb4b7011e13be59aca754a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/2825e798f5cc625240024db4667d65d1cf599239"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/2825e798f5cc625240024db4667d65d1cf599239"}]},"branch":"refs/heads/master"},"b8b9cc3ac3f3a2d0053fe237aa266a981a040668":{"kind":"REWORK","_number":2,"created":"2014-03-24 09:20:05.000000000","uploader":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"ref":"refs/changes/91/82091/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/91/82091/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/91/82091/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/91/82091/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/91/82091/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/91/82091/2"}}},"commit":{"parents":[{"commit":"261d69a75915f869b2e7bf351c47f202c725837c","subject":"Rework graph flow unit tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/261d69a75915f869b2e7bf351c47f202c725837c"}]}],"author":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-03-21 13:24:52.000000000","tz":240},"committer":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-03-24 09:14:17.000000000","tz":240},"subject":"Flattening improvements","message":"Flattening improvements\n\n- remove extraneous locking from flattener;\n- don\u0027t add \u0027flatten\u0027: True to edge data: it means nothing currently\n  as all the edges get it;\n- improve unit tests for flattening:\n  - check retry was correctly set with assertIs instead of assertEqual;\n  - check exact source, destination and attributes of resulting\n    graph edges;\n  - cover more error paths;\n- minor code cleanups.\n\nChange-Id: Iab23e245cdc834e2cdcb4b7011e13be59aca754a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/b8b9cc3ac3f3a2d0053fe237aa266a981a040668"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/b8b9cc3ac3f3a2d0053fe237aa266a981a040668"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
