)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e91f342c1b2f1685ce487de826ab47b97e813dfc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c4bf55e8_5837cc60","updated":"2022-05-18 06:54:32.000000000","message":"Hello,\n\nThank you for these changes, nice work,\n\n-1 because you have to remove one duplicated pickle import and move another, see my inline comments.","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a951d69fea1daa2aa2a415c5f5a116cc4029a6e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6db44260_5c436669","updated":"2022-05-18 07:15:17.000000000","message":"Thanks Hervé for your review. I\u0027ve fixed what you pointed.\n\nIn addition, I noticed the workaround logic for pickle/cPickle is used in Python2 only so I\u0027ve removed that as well.","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6dac5f33e76d1ba60e771a7fa3c2f4ce8ad7e4b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6caecadd_de335a77","in_reply_to":"6db44260_5c436669","updated":"2022-05-18 07:22:23.000000000","message":"You\u0027re welcome. Thanks for this new patch set","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"dfd33b67fc4f007cdaec27d6083fbde314003a97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2c451596_a6bf255e","updated":"2022-06-10 00:11:01.000000000","message":"LGTM\nI was just thinking I should do this. Thanks Takashi!","commit_id":"44f17d005ff53008144ca7c509bcb1307d66b23f"}],"taskflow/engines/action_engine/process_executor.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a951d69fea1daa2aa2a415c5f5a116cc4029a6e2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    },"},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# See http://bugs.python.org/issue1457119 for why this is so complex..."},{"line_number":83,"context_line":"_DECODE_ENCODE_ERRORS \u003d [pickle.PickleError, TypeError]"},{"line_number":84,"context_line":"try:"},{"line_number":85,"context_line":"    import cPickle"}],"source_content_type":"text/x-python","patch_set":5,"id":"21541a7f_20f1960f","line":82,"updated":"2022-05-18 07:15:17.000000000","message":"We can remove this workaround because it is used in Python2 only.","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6dac5f33e76d1ba60e771a7fa3c2f4ce8ad7e4b8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    },"},{"line_number":80,"context_line":"}"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"# See http://bugs.python.org/issue1457119 for why this is so complex..."},{"line_number":83,"context_line":"_DECODE_ENCODE_ERRORS \u003d [pickle.PickleError, TypeError]"},{"line_number":84,"context_line":"try:"},{"line_number":85,"context_line":"    import cPickle"}],"source_content_type":"text/x-python","patch_set":5,"id":"c6d1c585_76c2122e","line":82,"in_reply_to":"21541a7f_20f1960f","updated":"2022-05-18 07:22:23.000000000","message":"Good","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e91f342c1b2f1685ce487de826ab47b97e813dfc","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    pass"},{"line_number":90,"context_line":"_DECODE_ENCODE_ERRORS \u003d tuple(_DECODE_ENCODE_ERRORS)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"# Use the best pickle from here on out..."},{"line_number":93,"context_line":"import pickle"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class UnknownSender(Exception):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7595e8_b6fa8d4d","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":13},"updated":"2022-05-18 06:54:32.000000000","message":"Already imported at line 26.","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a951d69fea1daa2aa2a415c5f5a116cc4029a6e2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    pass"},{"line_number":90,"context_line":"_DECODE_ENCODE_ERRORS \u003d tuple(_DECODE_ENCODE_ERRORS)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"# Use the best pickle from here on out..."},{"line_number":93,"context_line":"import pickle"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class UnknownSender(Exception):"}],"source_content_type":"text/x-python","patch_set":5,"id":"cc977419_67dbc2b3","line":93,"range":{"start_line":92,"start_character":0,"end_line":93,"end_character":13},"in_reply_to":"5f7595e8_b6fa8d4d","updated":"2022-05-18 07:15:17.000000000","message":"Done","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"}],"taskflow/tests/unit/test_failure.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"e91f342c1b2f1685ce487de826ab47b97e813dfc","unresolved":true,"context_lines":[{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_utils import encodeutils"},{"line_number":20,"context_line":"import pickle"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from taskflow import exceptions"},{"line_number":23,"context_line":"from taskflow import test"}],"source_content_type":"text/x-python","patch_set":5,"id":"fd982322_4bd1964e","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":13},"updated":"2022-05-18 06:54:32.000000000","message":"Could be moved before line 17 to respect import order.","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a951d69fea1daa2aa2a415c5f5a116cc4029a6e2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_utils import encodeutils"},{"line_number":20,"context_line":"import pickle"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from taskflow import exceptions"},{"line_number":23,"context_line":"from taskflow import test"}],"source_content_type":"text/x-python","patch_set":5,"id":"5d11bd51_c4bd3e17","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":13},"in_reply_to":"fd982322_4bd1964e","updated":"2022-05-18 07:15:17.000000000","message":"Done","commit_id":"1c7633720d86d919c1c0877933584353cf2f45cb"}]}
