)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"af144fbb15755ecd3cac9cf723e862597f6b768b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"networkx 2.8.3 will raise errors if certain characters, such as a colon, in the node names and the string is not quoted."},{"line_number":10,"context_line":"This patch double quotes flow, node, and task string representations to make sure there are not issues with these characters occuring in the names."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib0941cddf14dde5d6b9f97fe0224d6e6f3975226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"016b2c11_ede6e05d","line":11,"updated":"2022-06-10 09:16:51.000000000","message":"For reference, even if taskflow doesn\u0027t seem to use Storyboard:\n\nStory: 2010083","commit_id":"d528c8c11e97f5f6632b6444d1fa99557a73d0ca"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"8e846c789c114186051ddeaf8fb2944ec2c5b833","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"networkx 2.8.3 will raise errors if certain characters, such as a colon, in the node names and the string is not quoted."},{"line_number":10,"context_line":"This patch double quotes flow, node, and task string representations to make sure there are not issues with these characters occuring in the names."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib0941cddf14dde5d6b9f97fe0224d6e6f3975226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8d5858e7_8f6dfd69","line":11,"in_reply_to":"016b2c11_ede6e05d","updated":"2022-06-10 09:56:45.000000000","message":"Done","commit_id":"d528c8c11e97f5f6632b6444d1fa99557a73d0ca"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d93da852f5aecc3c3a86d1b0a4a636da8183d88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ed3ad16b_747da8c5","updated":"2022-06-09 18:05:58.000000000","message":"Marking WIP for testing with Octavia, etc.","commit_id":"31a9860d5b54c9be73ee693523ea2bd0893f94c9"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a156269e2bd4a0aa4690950b818396fbd2e97963","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"858ff830_19f29a74","updated":"2022-06-10 07:04:06.000000000","message":"Also note that the created graphs were broken before, it is just that the latest networkx release now checks that condition and fails instead of creating broken graphs. See the \"ghost labels\" in e.g.\nhttps://docs.openstack.org/octavia/latest/_images/AmphoraFlows-get_failover_amphora_flow.svg , those are gone with this patch.","commit_id":"d528c8c11e97f5f6632b6444d1fa99557a73d0ca"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bd4a5477a8ee4589ed18725401b5d0aedacdea68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87f88548_8ec60132","updated":"2022-06-10 07:01:10.000000000","message":"Might be good to reference https://github.com/networkx/networkx/issues/4663 , https://github.com/pydot/pydot/issues/258 and https://storyboard.openstack.org/#!/story/2010083 for context.","commit_id":"d528c8c11e97f5f6632b6444d1fa99557a73d0ca"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"8e846c789c114186051ddeaf8fb2944ec2c5b833","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"813ac35e_1ed1be9e","updated":"2022-06-10 09:56:45.000000000","message":"To speed things up a bit, I pushed an update.","commit_id":"2521e3ee00d91d4002b751ecea06906fdf1c9b0e"}],"taskflow/atom.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"bd4a5477a8ee4589ed18725401b5d0aedacdea68","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        \"\"\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def __str__(self):"},{"line_number":385,"context_line":"        return \u0027\\\"%s\u003d\u003d%s\\\"\u0027 % (self.name, misc.get_version_string(self))"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def __repr__(self):"},{"line_number":388,"context_line":"        return \u0027\u003c%s %s\u003e\u0027 % (reflection.get_class_name(self), self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9168fd47_bd8eec63","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":17},"updated":"2022-06-10 07:01:10.000000000","message":"I don\u0027t think all the backslashes are necessary, testing locally the strings have the same results when they are dropped.","commit_id":"d528c8c11e97f5f6632b6444d1fa99557a73d0ca"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"8e846c789c114186051ddeaf8fb2944ec2c5b833","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        \"\"\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def __str__(self):"},{"line_number":385,"context_line":"        return \u0027\\\"%s\u003d\u003d%s\\\"\u0027 % (self.name, misc.get_version_string(self))"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def __repr__(self):"},{"line_number":388,"context_line":"        return \u0027\u003c%s %s\u003e\u0027 % (reflection.get_class_name(self), self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"09e04a81_ed6e7933","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":17},"in_reply_to":"186a1d2d_168466ae","updated":"2022-06-10 09:56:45.000000000","message":"Done","commit_id":"d528c8c11e97f5f6632b6444d1fa99557a73d0ca"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"86f80035a9a8f0e54d0bf1f4cdc3baffa05a6fa3","unresolved":true,"context_lines":[{"line_number":382,"context_line":"        \"\"\""},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    def __str__(self):"},{"line_number":385,"context_line":"        return \u0027\\\"%s\u003d\u003d%s\\\"\u0027 % (self.name, misc.get_version_string(self))"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def __repr__(self):"},{"line_number":388,"context_line":"        return \u0027\u003c%s %s\u003e\u0027 % (reflection.get_class_name(self), self)"}],"source_content_type":"text/x-python","patch_set":2,"id":"186a1d2d_168466ae","line":385,"range":{"start_line":385,"start_character":16,"end_line":385,"end_character":17},"in_reply_to":"9168fd47_bd8eec63","updated":"2022-06-10 07:40:42.000000000","message":"Yeah I agree, I don\u0027t think we need them (the backslashes).","commit_id":"d528c8c11e97f5f6632b6444d1fa99557a73d0ca"}]}