)]}'
{"taskflow/tests/unit/test_utils.py":[{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"e9185f5f06513a95f493d544bd9cf34cfb6f4ae1","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"class UriParseTest(test.TestCase):"},{"line_number":460,"context_line":"    def test_parse(self):"},{"line_number":461,"context_line":"        url \u003d \"http://www.yahoo.com/a/b/?c\u003dd\""},{"line_number":462,"context_line":"        parsed \u003d misc.parse_uri(url)"},{"line_number":463,"context_line":"        self.assertEqual(\u0027http\u0027, parsed.scheme)"},{"line_number":464,"context_line":"        self.assertEqual(\u0027www.yahoo.com\u0027, parsed.hostname)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXX%2F%2Fw94%3D","line":461,"updated":"2014-04-28 06:28:45.000000000","message":"urlparse module has different behavior with standard (well-known) and non-standard schemas:\n\n \u003e\u003e\u003e urlparse.urlsplit(\u0027http:80\u0027)\n SplitResult(scheme\u003d\u0027http\u0027, netloc\u003d\u0027\u0027, path\u003d\u002780\u0027, query\u003d\u0027\u0027, fragment\u003d\u0027\u0027)  \n \u003e\u003e\u003e urlparse.urlsplit(\u0027mysql:80\u0027)\n SplitResult(scheme\u003d\u0027\u0027, netloc\u003d\u0027\u0027, path\u003d\u0027mysql:80\u0027, query\u003d\u0027\u0027, fragment\u003d\u0027\u0027)\n\nSo, maybe it worth to use some other schema for tests, just to be sure.","commit_id":"ff36426a39c4dc6a2d50e878a1e0e78c23941ca3"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"28f5d5fd63edf07721bac52640adf7b50dcd2932","unresolved":false,"context_lines":[{"line_number":458,"context_line":""},{"line_number":459,"context_line":"class UriParseTest(test.TestCase):"},{"line_number":460,"context_line":"    def test_parse(self):"},{"line_number":461,"context_line":"        url \u003d \"http://www.yahoo.com/a/b/?c\u003dd\""},{"line_number":462,"context_line":"        parsed \u003d misc.parse_uri(url)"},{"line_number":463,"context_line":"        self.assertEqual(\u0027http\u0027, parsed.scheme)"},{"line_number":464,"context_line":"        self.assertEqual(\u0027www.yahoo.com\u0027, parsed.hostname)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1371a2_a47b6228","line":461,"in_reply_to":"AAAAXX%2F%2Fw94%3D","updated":"2014-04-28 18:58:39.000000000","message":"Done","commit_id":"ff36426a39c4dc6a2d50e878a1e0e78c23941ca3"}],"taskflow/utils/misc.py":[{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"e9185f5f06513a95f493d544bd9cf34cfb6f4ae1","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# NOTE(imelnikov): regular expression to get scheme from URI,"},{"line_number":47,"context_line":"# see RFC 3986 section 3.1"},{"line_number":48,"context_line":"_SCHEME_REGEX \u003d re.compile(r\"^([A-Za-z]{1}[A-Za-z0-9+.-]*):\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def merge_uri(uri_pieces, conf):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXX%2F%2Fw8k%3D","line":48,"updated":"2014-04-28 06:28:45.000000000","message":"What does \u0027{1}\u0027 mean here? Can we just remove it?","commit_id":"ff36426a39c4dc6a2d50e878a1e0e78c23941ca3"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"91aef44c6f86c8b88228bb5e3a614b7b150089b0","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# NOTE(imelnikov): regular expression to get scheme from URI,"},{"line_number":47,"context_line":"# see RFC 3986 section 3.1"},{"line_number":48,"context_line":"_SCHEME_REGEX \u003d re.compile(r\"^([A-Za-z]{1}[A-Za-z0-9+.-]*):\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def merge_uri(uri_pieces, conf):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1371a2_e4027ab3","line":48,"in_reply_to":"AAAAXX%2F%2Fw8k%3D","updated":"2014-04-28 18:56:04.000000000","message":"Done","commit_id":"ff36426a39c4dc6a2d50e878a1e0e78c23941ca3"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"e9185f5f06513a95f493d544bd9cf34cfb6f4ae1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    if not match:"},{"line_number":84,"context_line":"        raise ValueError(\"Uri %r does not start with a RFC 3986 compliant\""},{"line_number":85,"context_line":"                         \" scheme\" % (uri))"},{"line_number":86,"context_line":"    parsed \u003d network_utils.urlsplit(uri, scheme\u003dmatch.group(1).lower())"},{"line_number":87,"context_line":"    if parsed.query:"},{"line_number":88,"context_line":"        query_params \u003d urlparse.parse_qsl(parsed.query)"},{"line_number":89,"context_line":"        if not query_duplicates:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXX%2F%2Fw8U%3D","line":86,"updated":"2014-04-28 06:28:45.000000000","message":"Maybe it worth to add some note on why we need to pass scheme expicitly here?","commit_id":"ff36426a39c4dc6a2d50e878a1e0e78c23941ca3"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"91aef44c6f86c8b88228bb5e3a614b7b150089b0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    if not match:"},{"line_number":84,"context_line":"        raise ValueError(\"Uri %r does not start with a RFC 3986 compliant\""},{"line_number":85,"context_line":"                         \" scheme\" % (uri))"},{"line_number":86,"context_line":"    parsed \u003d network_utils.urlsplit(uri, scheme\u003dmatch.group(1).lower())"},{"line_number":87,"context_line":"    if parsed.query:"},{"line_number":88,"context_line":"        query_params \u003d urlparse.parse_qsl(parsed.query)"},{"line_number":89,"context_line":"        if not query_duplicates:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1371a2_c4ff7ea9","line":86,"in_reply_to":"AAAAXX%2F%2Fw8U%3D","updated":"2014-04-28 18:56:04.000000000","message":"Done","commit_id":"ff36426a39c4dc6a2d50e878a1e0e78c23941ca3"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"e9185f5f06513a95f493d544bd9cf34cfb6f4ae1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    user \u003d None"},{"line_number":110,"context_line":"    password \u003d None"},{"line_number":111,"context_line":"    try:"},{"line_number":112,"context_line":"        where_at, _host \u003d parsed.netloc.split(\"@\", 1)"},{"line_number":113,"context_line":"    except ValueError:"},{"line_number":114,"context_line":"        pass"},{"line_number":115,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAXX%2F%2Fw5U%3D","line":112,"updated":"2014-04-28 06:28:45.000000000","message":"Why do you implement such splitting here when python has this out of the box?\n\n  \u003e\u003e\u003e parsed \u003d urlparse.urlparse(\u0027mysql://user:password@localhost:3667/test_db\u0027)\n  \u003e\u003e\u003e parsed.username\n  \u0027user\u0027\n  \u003e\u003e\u003e parsed.password\n  \u0027password\u0027\n  \u003e\u003e\u003e parsed.port\n  3667\n  \u003e\u003e\u003e parsed.netloc\n  \u0027user:password@localhost:3667\u0027\n\nDocumentation (https://docs.python.org/2.6/library/urlparse.html) says these attributes are there since python 2.6, and I just checked and on my CentOS vm (python 2.6.6) it works.\n\nThis, of course, raises question on why oslo has network utils module that parses hostname and port itself. Maybe we should ask someone about it.","commit_id":"ff36426a39c4dc6a2d50e878a1e0e78c23941ca3"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"91aef44c6f86c8b88228bb5e3a614b7b150089b0","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    user \u003d None"},{"line_number":110,"context_line":"    password \u003d None"},{"line_number":111,"context_line":"    try:"},{"line_number":112,"context_line":"        where_at, _host \u003d parsed.netloc.split(\"@\", 1)"},{"line_number":113,"context_line":"    except ValueError:"},{"line_number":114,"context_line":"        pass"},{"line_number":115,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a1371a2_84e3c604","line":112,"in_reply_to":"AAAAXX%2F%2Fw5U%3D","updated":"2014-04-28 18:56:04.000000000","message":"Thanks, didn\u0027t know about those. The network utils people are doing it because apparently 2.6 doesn\u0027t do ipv6 hostnames correctly. Apparently thats fixed in newer version of python though.","commit_id":"ff36426a39c4dc6a2d50e878a1e0e78c23941ca3"}]}
