)]}'
{"taskflow/jobs/backends/impl_zookeeper.py":[{"author":{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},"change_message_id":"5e95bfff9eba85ad410f0ae3c9de4e2860c2b0f6","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self._lock_path \u003d \"%s.lock\" % (path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @property"},{"line_number":78,"context_line":"    def lock_path(self):"},{"line_number":79,"context_line":"        return self._lock_path"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FeN8%3D","line":78,"updated":"2014-04-21 14:25:38.000000000","message":"Since this is not part of the Job interface, and shouldn\u0027t be used outside of the class, should it be prefixed with an underscore?","commit_id":"9c31c205d1dc9caf6c28deffedae48b64abddbe4"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a2c37f1734940168729858e52f1e034fc76654de","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self._lock_path \u003d \"%s.lock\" % (path)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @property"},{"line_number":78,"context_line":"    def lock_path(self):"},{"line_number":79,"context_line":"        return self._lock_path"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2Fddo%3D","line":78,"in_reply_to":"AAAAXH%2F%2FeN8%3D","updated":"2014-04-21 15:46:15.000000000","message":"Its used in the jobboard below so not just this class :)\n\nI treat this like a subclass, subclasses can provide more public attributes/methods than the superclass (in this case the job interface/parent class), if a user knows they are interacting soley through the zookeeper jobboard they can then access these attributes (which python will allow). No harm in that.","commit_id":"9c31c205d1dc9caf6c28deffedae48b64abddbe4"},{"author":{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},"change_message_id":"5e95bfff9eba85ad410f0ae3c9de4e2860c2b0f6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return self._lock_path"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    @property"},{"line_number":82,"context_line":"    def path(self):"},{"line_number":83,"context_line":"        return self._path"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAXH%2F%2FeN4%3D","line":82,"updated":"2014-04-21 14:25:38.000000000","message":"Since this is not part of the Job interface, and shouldn\u0027t be used outside of the class, should it be prefixed with an underscore?","commit_id":"9c31c205d1dc9caf6c28deffedae48b64abddbe4"}]}
