)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"5ee41b43abfa97740f741003ddc2b5445cfe6a6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3dcaae41_f0168df3","updated":"2022-12-09 12:53:03.000000000","message":"I can update patch to cover missed usage of check_compatible if needed","commit_id":"f67c0be44e3a2243e5d18db9052afb9d85f78a6f"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"78afdeffb9e2e8c1b55677005d6cd46f2af2c7ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83a88e6a_f958aa3e","updated":"2022-12-09 08:32:54.000000000","message":"I think this also needs patching?\n\nhttps://opendev.org/openstack/taskflow/src/branch/master/taskflow/persistence/backends/impl_zookeeper.py#L164","commit_id":"f67c0be44e3a2243e5d18db9052afb9d85f78a6f"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"05185dfc6942e7b4c0909b1515bda29d64f1a72a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"768ad766_6578e334","in_reply_to":"83a88e6a_f958aa3e","updated":"2022-12-09 13:05:01.000000000","message":"yeah you\u0027re right, I missed it","commit_id":"f67c0be44e3a2243e5d18db9052afb9d85f78a6f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6b27dda3ee070add02cdb34610d7d216d42087c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"198d734d_9700be3f","updated":"2023-04-18 23:00:56.000000000","message":"LGTM","commit_id":"086b3e4335194cbe2bbfcd8c422fa21952124b44"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6a521794b13c3c17417e0f4984f8bbf3fcb19361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"92f68285_3ce615b4","updated":"2023-01-12 13:22:07.000000000","message":"recheck","commit_id":"086b3e4335194cbe2bbfcd8c422fa21952124b44"}],"taskflow/persistence/backends/impl_zookeeper.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"48e8c59579ca95926169cfa64e48c2be4b9d3ea2","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        with self._exc_wrapper():"},{"line_number":164,"context_line":"            try:"},{"line_number":165,"context_line":"                if strutils.bool_from_string("},{"line_number":166,"context_line":"                        self._conf.get(\u0027check_compatible\u0027, True)):"},{"line_number":167,"context_line":"                    k_utils.check_compatible(self._client, MIN_ZK_VERSION)"},{"line_number":168,"context_line":"            except exc.IncompatibleVersion:"},{"line_number":169,"context_line":"                exc.raise_with_cause(exc.StorageFailure, \"Backend storage is\""}],"source_content_type":"text/x-python","patch_set":3,"id":"f53a6f6a_6d9bed2c","line":166,"range":{"start_line":166,"start_character":57,"end_line":166,"end_character":64},"updated":"2023-01-10 14:25:12.000000000","message":"Could be uniformized with the same params you passed in taskflow/jobs/backends/impl_zookeeper.py:\n\n```\nif strutils.bool_from_string(self._conf.get(\u0027check_compatible\u0027), default\u003dTrue)\n```\n\nAnyway I won\u0027t block for that as the result is identical.","commit_id":"b0102a6c87487625896ba97503e059740152ed10"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"dddc8aa4e73b3f127f450530ab411aab8049b3c9","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        with self._exc_wrapper():"},{"line_number":164,"context_line":"            try:"},{"line_number":165,"context_line":"                if strutils.bool_from_string("},{"line_number":166,"context_line":"                        self._conf.get(\u0027check_compatible\u0027, True)):"},{"line_number":167,"context_line":"                    k_utils.check_compatible(self._client, MIN_ZK_VERSION)"},{"line_number":168,"context_line":"            except exc.IncompatibleVersion:"},{"line_number":169,"context_line":"                exc.raise_with_cause(exc.StorageFailure, \"Backend storage is\""}],"source_content_type":"text/x-python","patch_set":3,"id":"57e7b818_2d51cdf9","line":166,"range":{"start_line":166,"start_character":57,"end_line":166,"end_character":64},"in_reply_to":"12277893_13737c9b","updated":"2023-01-12 08:58:28.000000000","message":"Ok, seems it was either intermittent or rebase has helped","commit_id":"b0102a6c87487625896ba97503e059740152ed10"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"6299100fa584533c17b858327067fa02d57a081d","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        with self._exc_wrapper():"},{"line_number":164,"context_line":"            try:"},{"line_number":165,"context_line":"                if strutils.bool_from_string("},{"line_number":166,"context_line":"                        self._conf.get(\u0027check_compatible\u0027, True)):"},{"line_number":167,"context_line":"                    k_utils.check_compatible(self._client, MIN_ZK_VERSION)"},{"line_number":168,"context_line":"            except exc.IncompatibleVersion:"},{"line_number":169,"context_line":"                exc.raise_with_cause(exc.StorageFailure, \"Backend storage is\""}],"source_content_type":"text/x-python","patch_set":3,"id":"12277893_13737c9b","line":166,"range":{"start_line":166,"start_character":57,"end_line":166,"end_character":64},"in_reply_to":"77b1e426_665623be","updated":"2023-01-11 17:58:49.000000000","message":"I\u0027m a bit concerned about setuptools being unhappy in all tox jobs. Though I can\u0027t reproduce that in venv with latest tox/setuptools...","commit_id":"b0102a6c87487625896ba97503e059740152ed10"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"7d6ea7bc3beba74b1eea53432beffdb16b0a366e","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        with self._exc_wrapper():"},{"line_number":164,"context_line":"            try:"},{"line_number":165,"context_line":"                if strutils.bool_from_string("},{"line_number":166,"context_line":"                        self._conf.get(\u0027check_compatible\u0027, True)):"},{"line_number":167,"context_line":"                    k_utils.check_compatible(self._client, MIN_ZK_VERSION)"},{"line_number":168,"context_line":"            except exc.IncompatibleVersion:"},{"line_number":169,"context_line":"                exc.raise_with_cause(exc.StorageFailure, \"Backend storage is\""}],"source_content_type":"text/x-python","patch_set":3,"id":"77b1e426_665623be","line":166,"range":{"start_line":166,"start_character":57,"end_line":166,"end_character":64},"in_reply_to":"a1316a45_0fe91813","updated":"2023-01-11 17:42:03.000000000","message":"I\u0027ll update it","commit_id":"b0102a6c87487625896ba97503e059740152ed10"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"f3965bea8c00f2a5e8a18b26246c3f1165c4942f","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        with self._exc_wrapper():"},{"line_number":164,"context_line":"            try:"},{"line_number":165,"context_line":"                if strutils.bool_from_string("},{"line_number":166,"context_line":"                        self._conf.get(\u0027check_compatible\u0027, True)):"},{"line_number":167,"context_line":"                    k_utils.check_compatible(self._client, MIN_ZK_VERSION)"},{"line_number":168,"context_line":"            except exc.IncompatibleVersion:"},{"line_number":169,"context_line":"                exc.raise_with_cause(exc.StorageFailure, \"Backend storage is\""}],"source_content_type":"text/x-python","patch_set":3,"id":"a1316a45_0fe91813","line":166,"range":{"start_line":166,"start_character":57,"end_line":166,"end_character":64},"in_reply_to":"f53a6f6a_6d9bed2c","updated":"2023-01-11 17:21:50.000000000","message":"Ah, true, I just blindly added this and didn\u0027t double-checked how it was done in other file.","commit_id":"b0102a6c87487625896ba97503e059740152ed10"}]}