)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"f8823801ce57b37c154d96882d3802154fed2d86","unresolved":false,"context_lines":[{"line_number":9,"context_line":"A worker task executor is a good candidate for reuse since"},{"line_number":10,"context_line":"it maintains worker knowledge that is valuable to be retained"},{"line_number":11,"context_line":"across engine runs (tasks on which workers for example). In order"},{"line_number":12,"context_line":"for it to be reused we need a way to for the WBE to be able to"},{"line_number":13,"context_line":"receive and reuse a existing executor."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia9a8f4c544b74e12e2cbd6bd941945da1111499c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_78937cfa","line":12,"updated":"2014-05-01 12:28:37.000000000","message":"... we need a way the WBE to be able to ...","commit_id":"6c10910f4d3a593abee280bb5ae41b1c30a3278a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"93b983ee87a79cb8ea0648356f91ae0bc7b4eb2a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"A worker task executor is a good candidate for reuse since"},{"line_number":10,"context_line":"it maintains worker knowledge that is valuable to be retained"},{"line_number":11,"context_line":"across engine runs (tasks on which workers for example). In order"},{"line_number":12,"context_line":"for it to be reused we need a way to for the WBE to be able to"},{"line_number":13,"context_line":"receive and reuse a existing executor."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia9a8f4c544b74e12e2cbd6bd941945da1111499c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad9bd40_8ac7f844","line":12,"in_reply_to":"9ad9bd40_78937cfa","updated":"2014-05-01 23:56:46.000000000","message":"Done","commit_id":"6c10910f4d3a593abee280bb5ae41b1c30a3278a"}],"taskflow/engines/worker_based/engine.py":[{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"f8823801ce57b37c154d96882d3802154fed2d86","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        if self._executor is not None:"},{"line_number":28,"context_line":"            return action_executor.ProxyTaskExecutor(self._executor,"},{"line_number":29,"context_line":"                                                     stop\u003dFalse)"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            return executor.WorkerTaskExecutor("},{"line_number":32,"context_line":"                uuid\u003dself._flow_detail.uuid,"},{"line_number":33,"context_line":"                url\u003dself._conf.get(\u0027url\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_58ff9834","line":30,"updated":"2014-05-01 12:28:37.000000000","message":"`else` branch is redundant  guess","commit_id":"6c10910f4d3a593abee280bb5ae41b1c30a3278a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"93b983ee87a79cb8ea0648356f91ae0bc7b4eb2a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        if self._executor is not None:"},{"line_number":28,"context_line":"            return action_executor.ProxyTaskExecutor(self._executor,"},{"line_number":29,"context_line":"                                                     stop\u003dFalse)"},{"line_number":30,"context_line":"        else:"},{"line_number":31,"context_line":"            return executor.WorkerTaskExecutor("},{"line_number":32,"context_line":"                uuid\u003dself._flow_detail.uuid,"},{"line_number":33,"context_line":"                url\u003dself._conf.get(\u0027url\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad9bd40_aadbdc19","line":30,"in_reply_to":"9ad9bd40_58ff9834","updated":"2014-05-01 23:56:46.000000000","message":"Done","commit_id":"6c10910f4d3a593abee280bb5ae41b1c30a3278a"},{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"e9a0114301ab4dde5a3504ee3339a2d3154baf48","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def _task_executor_cls(self):"},{"line_number":27,"context_line":"        if self._executor is not None:"},{"line_number":28,"context_line":"            return action_executor.ProxyTaskExecutor(self._executor,"},{"line_number":29,"context_line":"                                                     stop\u003dFalse)"},{"line_number":30,"context_line":"        return executor.WorkerTaskExecutor("},{"line_number":31,"context_line":"            uuid\u003dself._flow_detail.uuid,"},{"line_number":32,"context_line":"            url\u003dself._conf.get(\u0027url\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_5213cbb7","line":29,"updated":"2014-05-02 21:17:30.000000000","message":"How do you know if you need to start passed executor but not stop? Just curious)","commit_id":"c92309ca0bbe7869be67c974f08d312336f7e71b"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"51cb9eeec7bc49e633a7441414f4e2e5b4ac2fc8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def _task_executor_cls(self):"},{"line_number":27,"context_line":"        if self._executor is not None:"},{"line_number":28,"context_line":"            return action_executor.ProxyTaskExecutor(self._executor,"},{"line_number":29,"context_line":"                                                     stop\u003dFalse)"},{"line_number":30,"context_line":"        return executor.WorkerTaskExecutor("},{"line_number":31,"context_line":"            uuid\u003dself._flow_detail.uuid,"},{"line_number":32,"context_line":"            url\u003dself._conf.get(\u0027url\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_6699f11e","line":29,"in_reply_to":"9ad9bd40_5213cbb7","updated":"2014-05-03 01:52:49.000000000","message":"Well hopefully starting (if its already started has no side-effects). The same can\u0027t be said about stopping, shutting down an executor means that nobody else can use it after that. So that\u0027s why I was avoiding stopping (but allowing starting).","commit_id":"c92309ca0bbe7869be67c974f08d312336f7e71b"},{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"f3fff6dfab293032040c321fd1a1a0702b0afa7d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def _task_executor_cls(self):"},{"line_number":27,"context_line":"        if self._executor is not None:"},{"line_number":28,"context_line":"            return action_executor.ProxyTaskExecutor(self._executor,"},{"line_number":29,"context_line":"                                                     stop\u003dFalse)"},{"line_number":30,"context_line":"        return executor.WorkerTaskExecutor("},{"line_number":31,"context_line":"            uuid\u003dself._flow_detail.uuid,"},{"line_number":32,"context_line":"            url\u003dself._conf.get(\u0027url\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_b741613b","line":29,"in_reply_to":"9ad9bd40_6699f11e","updated":"2014-05-03 09:41:11.000000000","message":"Let\u0027s maybe do executor starting all the time to get rid of start parameter, since it is not really needed?","commit_id":"c92309ca0bbe7869be67c974f08d312336f7e71b"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"80f467e44aaa11798e392146ba7984d950fd6a4a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def _task_executor_cls(self):"},{"line_number":27,"context_line":"        if self._executor is not None:"},{"line_number":28,"context_line":"            return action_executor.ProxyTaskExecutor(self._executor,"},{"line_number":29,"context_line":"                                                     stop\u003dFalse)"},{"line_number":30,"context_line":"        return executor.WorkerTaskExecutor("},{"line_number":31,"context_line":"            uuid\u003dself._flow_detail.uuid,"},{"line_number":32,"context_line":"            url\u003dself._conf.get(\u0027url\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_73de0c6f","line":29,"in_reply_to":"9ad9bd40_b741613b","updated":"2014-05-03 16:57:08.000000000","message":"Done","commit_id":"c92309ca0bbe7869be67c974f08d312336f7e71b"},{"author":{"_account_id":8895,"name":"Stanislav Kudriashev","email":"stas.kudriashev@gmail.com","username":"skudriashev"},"change_message_id":"e9a0114301ab4dde5a3504ee3339a2d3154baf48","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def __init__(self, flow, flow_detail, backend, conf):"},{"line_number":39,"context_line":"        super(WorkerBasedActionEngine, self).__init__("},{"line_number":40,"context_line":"            flow, flow_detail, backend, conf)"},{"line_number":41,"context_line":"        self._executor \u003d conf.get(\u0027executor\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_b202576d","line":41,"updated":"2014-05-02 21:17:30.000000000","message":"I\u0027m thinking if you really need to save it here? Can\u0027t you take executor right from the `self._conf(\u0027executor\u0027)` whenever needed?","commit_id":"c92309ca0bbe7869be67c974f08d312336f7e71b"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"51cb9eeec7bc49e633a7441414f4e2e5b4ac2fc8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def __init__(self, flow, flow_detail, backend, conf):"},{"line_number":39,"context_line":"        super(WorkerBasedActionEngine, self).__init__("},{"line_number":40,"context_line":"            flow, flow_detail, backend, conf)"},{"line_number":41,"context_line":"        self._executor \u003d conf.get(\u0027executor\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_c689ddcb","line":41,"in_reply_to":"9ad9bd40_b202576d","updated":"2014-05-03 01:52:49.000000000","message":"Ya, actually I\u0027m gonna change this, so will fix this.","commit_id":"c92309ca0bbe7869be67c974f08d312336f7e71b"}]}