)]}'
{"id":"openstack%2Ftaskflow~92559","triplet_id":"openstack%2Ftaskflow~master~Id5b5dff380460d1fb4ffeeb23f00864e7fc158ed","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"Id5b5dff380460d1fb4ffeeb23f00864e7fc158ed","subject":"Check documentation for simple style requirements","status":"MERGED","created":"2014-05-07 11:28:54.000000000","updated":"2014-05-08 18:14:44.000000000","submitted":"2014-05-08 18:14:43.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7e30d1d89581966525f0f1f937cdb3a9cf550385","_number":92559,"virtual_id_number":92559,"owner":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2014-05-08 18:14:43.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2014-05-08 15:51:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2014-05-08 17:12:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-05-07 15:19:02.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2014-05-08 17:12:44.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2014-05-08 18:14:43.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"79aff0fe9e3bf29942f2d03d321426d0a62f0669","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-05-07 11:28:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f5edc1b268a6240053c49b7717ad16e68f5beebc","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-05-07 11:30:15.000000000","message":"Patch Set 1:\n\nThe code was lying around for quite a long time. Idk if it is useful. Maybe we should relax 79 chars a bit?","accounts_in_message":[],"_revision_number":1},{"id":"cd22dd14c4e34b5edb478da9c8db50c20a4cc41f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-07 13:05:43.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"330ea851d7de29a77149ae39264e2f5fc1e243dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-07 15:06:26.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-taskflow-pep8 http://logs.openstack.org/59/92559/1/check/gate-taskflow-pep8/70a0f74 : SUCCESS in 4m 29s\n- gate-taskflow-docs http://docs-draft.openstack.org/59/92559/1/check/gate-taskflow-docs/e07eb00/doc/build/html/ : SUCCESS in 1m 26s\n- gate-taskflow-python26 http://logs.openstack.org/59/92559/1/check/gate-taskflow-python26/7548354 : SUCCESS in 1m 32s\n- gate-taskflow-python27 http://logs.openstack.org/59/92559/1/check/gate-taskflow-python27/8e84dbf : FAILURE in 2m 21s\n- gate-taskflow-python33 http://logs.openstack.org/59/92559/1/check/gate-taskflow-python33/b9de2b7 : SUCCESS in 5m 59s\n- check-tempest-dsvm-full http://logs.openstack.org/59/92559/1/check/check-tempest-dsvm-full/99be5d6 : SUCCESS in 52m 25s\n- check-tempest-dsvm-neutron http://logs.openstack.org/59/92559/1/check/check-tempest-dsvm-neutron/72ca08d : SUCCESS in 1h 00m 54s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/59/92559/1/check/check-tempest-dsvm-neutron-heat-slow/d344247 : FAILURE in 35m 28s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/59/92559/1/check/check-grenade-dsvm/0446045 : SUCCESS in 48m 28s\n- check-grenade-dsvm-neutron http://logs.openstack.org/59/92559/1/check/check-grenade-dsvm-neutron/78188a6 : FAILURE in 43m 52s (non-voting)\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/59/92559/1/check/gate-taskflow-tox-py26-sa7-mysql/4fd6057 : SUCCESS in 2m 21s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/59/92559/1/check/gate-taskflow-tox-py27-sa8-mysql/90fd643 : SUCCESS in 2m 25s","accounts_in_message":[],"_revision_number":1},{"id":"3bc2f6876c828955e7f17a165539e806dfcf4e13","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-05-07 15:19:02.000000000","message":"Patch Set 1:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- check-grenade-dsvm-neutron: unrecognized error\n- check-tempest-dsvm-neutron-heat-slow: https://bugs.launchpad.net/bugs/1297560 https://bugs.launchpad.net/bugs/1288970\n- gate-taskflow-python27: unrecognized error\n\nYou have some unrecognized errors.\nFor bug details see: http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":1},{"id":"f43788ccea4808393e4d7949658a828ca7cd612b","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-05-07 19:11:21.000000000","message":"Patch Set 1:\n\nI think I\u0027m fine with 79 length, as long as we can have something like #no-qa that can be used (or some kind of notation for this) since sometimes a url that will be linked to will be \u003e 79 chars and u can\u0027t split it (afaik).","accounts_in_message":[],"_revision_number":1},{"id":"819af028f846705afdf140f29fb83f69cb606a3e","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-05-08 08:12:11.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ac4e03a0b34b98fbd0ec160721177f48c6c20e31","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-08 08:12:14.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"5ccc6fec93553d098a1e8a4641a954d69078f554","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-05-08 08:16:07.000000000","message":"Patch Set 1:\n\nI did not implement any way to manually mark a line that must be long, but there are few provisions: if line has no spaces, except, maybe, indentation (e.g. it\u0027s url or some really long word) it is considered to be ok; so are the lines that start witn \u0027..\u0027, which includes sphinx directives and footnotes -- all lengthy urls should be in footnotes anyway, for sake of readability. I hope these exceptions will be enough.","accounts_in_message":[],"_revision_number":1},{"id":"7f3b5be82b3dc14717459b6467bce62e220a6fb6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-08 09:15:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/59/92559/2/check/gate-taskflow-pep8/b98f5a8 : SUCCESS in 49s\n- gate-taskflow-docs http://docs-draft.openstack.org/59/92559/2/check/gate-taskflow-docs/7452449/doc/build/html/ : SUCCESS in 1m 27s\n- gate-taskflow-python26 http://logs.openstack.org/59/92559/2/check/gate-taskflow-python26/bb556d2 : SUCCESS in 2m 36s\n- gate-taskflow-python27 http://logs.openstack.org/59/92559/2/check/gate-taskflow-python27/69f3466 : SUCCESS in 2m 20s\n- gate-taskflow-python33 http://logs.openstack.org/59/92559/2/check/gate-taskflow-python33/2e0e34a : SUCCESS in 4m 53s\n- check-tempest-dsvm-full http://logs.openstack.org/59/92559/2/check/check-tempest-dsvm-full/e55ccbf : SUCCESS in 1h 01m 19s\n- check-tempest-dsvm-neutron http://logs.openstack.org/59/92559/2/check/check-tempest-dsvm-neutron/2338c43 : SUCCESS in 58m 49s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/59/92559/2/check/check-tempest-dsvm-neutron-heat-slow/425acf9 : SUCCESS in 18m 39s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/59/92559/2/check/check-grenade-dsvm/9358dcf : SUCCESS in 32m 14s\n- check-grenade-dsvm-neutron http://logs.openstack.org/59/92559/2/check/check-grenade-dsvm-neutron/21c9daf : SUCCESS in 51m 53s (non-voting)\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/59/92559/2/check/gate-taskflow-tox-py26-sa7-mysql/b700bba : SUCCESS in 1m 59s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/59/92559/2/check/gate-taskflow-tox-py27-sa8-mysql/bd04e3c : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":2},{"id":"bd14f42c78ebacb66eede8f7141b83612c352309","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-05-08 15:51:54.000000000","message":"Patch Set 2: Code-Review+2\n\nLets try this out and improve as needed. Thanks! :)","accounts_in_message":[],"_revision_number":2},{"id":"9a6be49e848a192e356bf0619dd9965dc3cdbaa1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-08 17:12:44.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"815ca434c9196d511e10e36991abe8cd9bbeb5ab","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-05-08 17:12:44.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"9416e1e0c6945b82a61c19fb406ef65ab8b3f038","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-08 18:14:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- gate-taskflow-docs http://docs-draft.openstack.org/59/92559/2/gate/gate-taskflow-docs/ee322a5/doc/build/html/ : SUCCESS in 1m 31s\n- gate-taskflow-pep8 http://logs.openstack.org/59/92559/2/gate/gate-taskflow-pep8/29e31e4 : SUCCESS in 1m 22s\n- gate-taskflow-python26 http://logs.openstack.org/59/92559/2/gate/gate-taskflow-python26/9525049 : SUCCESS in 1m 34s\n- gate-taskflow-python27 http://logs.openstack.org/59/92559/2/gate/gate-taskflow-python27/23b3b33 : SUCCESS in 2m 43s\n- gate-taskflow-python33 http://logs.openstack.org/59/92559/2/gate/gate-taskflow-python33/fb2944d : SUCCESS in 4m 58s\n- gate-tempest-dsvm-full http://logs.openstack.org/59/92559/2/gate/gate-tempest-dsvm-full/5f6b6e8 : SUCCESS in 1h 01m 54s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/59/92559/2/gate/gate-tempest-dsvm-neutron/f7a7ead : SUCCESS in 56m 30s\n- gate-grenade-dsvm http://logs.openstack.org/59/92559/2/gate/gate-grenade-dsvm/4dbb2cc : SUCCESS in 38m 47s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/59/92559/2/gate/gate-taskflow-tox-py26-sa7-mysql/7c4c76b : SUCCESS in 2m 03s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/59/92559/2/gate/gate-taskflow-tox-py27-sa8-mysql/0060454 : SUCCESS in 2m 05s","accounts_in_message":[],"_revision_number":2},{"id":"7e30d1d89581966525f0f1f937cdb3a9cf550385","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-08 18:14:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f986a82731b4402f6130365a13db711e4b779ef9","revisions":{"1371d32b145465945888c0390a6b8d809690f7a7":{"kind":"REWORK","_number":1,"created":"2014-05-07 11:28:54.000000000","uploader":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"ref":"refs/changes/59/92559/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/59/92559/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/59/92559/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/59/92559/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/59/92559/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/59/92559/1"}}},"commit":{"parents":[{"commit":"ee1e96d87d385baf3f583cabea94997b50130985","subject":"Merge \"Add an example for the job board feature\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/ee1e96d87d385baf3f583cabea94997b50130985"}]}],"author":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-05-07 11:21:44.000000000","tz":240},"committer":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-05-07 11:21:44.000000000","tz":240},"subject":"Check documentation for simple style requirements","message":"Check documentation for simple style requirements\n\nWhat is checked:\n - lines should not be longer than 79 characters, also\n   there are few exceptions;\n - no tabulation for indentation;\n - no trailing whitespace.\n\nChange-Id: Id5b5dff380460d1fb4ffeeb23f00864e7fc158ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/1371d32b145465945888c0390a6b8d809690f7a7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/1371d32b145465945888c0390a6b8d809690f7a7"}]},"branch":"refs/heads/master"},"f986a82731b4402f6130365a13db711e4b779ef9":{"kind":"REWORK","_number":2,"created":"2014-05-08 08:12:11.000000000","uploader":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"ref":"refs/changes/59/92559/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/59/92559/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/59/92559/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/59/92559/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/59/92559/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/59/92559/2"}}},"commit":{"parents":[{"commit":"ee1e96d87d385baf3f583cabea94997b50130985","subject":"Merge \"Add an example for the job board feature\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/ee1e96d87d385baf3f583cabea94997b50130985"}]}],"author":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-05-07 11:21:44.000000000","tz":240},"committer":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-05-08 08:11:18.000000000","tz":240},"subject":"Check documentation for simple style requirements","message":"Check documentation for simple style requirements\n\nWhat is checked:\n - lines should not be longer than 79 characters, also\n   there are few exceptions;\n - no tabulation for indentation;\n - no trailing whitespace.\n\nChange-Id: Id5b5dff380460d1fb4ffeeb23f00864e7fc158ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f986a82731b4402f6130365a13db711e4b779ef9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/f986a82731b4402f6130365a13db711e4b779ef9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}