)]}'
{"id":"openstack%2Ftaskflow~93097","triplet_id":"openstack%2Ftaskflow~master~I243ec0551a341df74f478b0161ffd559a75278fe","project":"openstack/taskflow","branch":"master","topic":"tweak-board","hashtags":[],"change_id":"I243ec0551a341df74f478b0161ffd559a75278fe","subject":"Remove the _clear method and do not reset the job_watcher","status":"MERGED","created":"2014-05-09 18:13:07.000000000","updated":"2014-05-10 09:41:35.000000000","submitted":"2014-05-10 09:41:35.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"488232c167745094d203947b742715d102ceacd1","_number":93097,"virtual_id_number":93097,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2014-05-10 09:41:35.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2014-05-10 01:44:20.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2014-05-10 01:44:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-05-10 09:41:35.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4561ec6748305e82ab05848e993b819ce55b0251","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-05-09 18:13:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"706ddb4798a1d52b9f660e6b0147437f1825bb37","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-09 18:13:08.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3264080996b376bc2bbf59039f422901c29a024c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-09 19:29:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/97/93097/1/check/gate-taskflow-pep8/64d5117 : SUCCESS in 1m 17s\n- gate-taskflow-docs http://docs-draft.openstack.org/97/93097/1/check/gate-taskflow-docs/3a1227a/doc/build/html/ : SUCCESS in 1m 41s\n- gate-taskflow-python26 http://logs.openstack.org/97/93097/1/check/gate-taskflow-python26/8df61d0 : SUCCESS in 2m 02s\n- gate-taskflow-python27 http://logs.openstack.org/97/93097/1/check/gate-taskflow-python27/6781afb : SUCCESS in 2m 30s\n- gate-taskflow-python33 http://logs.openstack.org/97/93097/1/check/gate-taskflow-python33/685782a : SUCCESS in 4m 42s\n- check-tempest-dsvm-full http://logs.openstack.org/97/93097/1/check/check-tempest-dsvm-full/de409f1 : SUCCESS in 1h 14m 14s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/93097/1/check/check-tempest-dsvm-neutron/ce7be22 : SUCCESS in 57m 15s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/97/93097/1/check/check-tempest-dsvm-neutron-heat-slow/60806f2 : SUCCESS in 24m 11s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/97/93097/1/check/check-grenade-dsvm/4b1680f : SUCCESS in 40m 47s\n- check-grenade-dsvm-neutron http://logs.openstack.org/97/93097/1/check/check-grenade-dsvm-neutron/2368ed5 : FAILURE in 35m 00s (non-voting)\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/97/93097/1/check/gate-taskflow-tox-py26-sa7-mysql/ce2f5be : SUCCESS in 2m 13s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/97/93097/1/check/gate-taskflow-tox-py27-sa8-mysql/1bff092 : SUCCESS in 2m 32s","accounts_in_message":[],"_revision_number":1},{"id":"b16619e3dd1ffdf1d0d78f625b766862c696b81b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-10 01:44:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"67da79cd043304f21d7a3a7df2a82395a4cc2de2","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-05-10 01:44:20.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nFixes job_watcher misusage.","accounts_in_message":[],"_revision_number":1},{"id":"d055ae4b3c60172a0b9aa23997a6fd6a668cecba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-10 02:57:34.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-taskflow-docs http://docs-draft.openstack.org/97/93097/1/gate/gate-taskflow-docs/0eb1492/doc/build/html/ : SUCCESS in 1m 27s\n- gate-taskflow-pep8 http://logs.openstack.org/97/93097/1/gate/gate-taskflow-pep8/f9b43dd : SUCCESS in 1m 06s\n- gate-taskflow-python26 http://logs.openstack.org/97/93097/1/gate/gate-taskflow-python26/862205c : FAILURE in 2m 07s\n- gate-taskflow-python27 http://logs.openstack.org/97/93097/1/gate/gate-taskflow-python27/ce506bc : FAILURE in 1m 58s\n- gate-taskflow-python33 http://logs.openstack.org/97/93097/1/gate/gate-taskflow-python33/6182d48 : FAILURE in 4m 53s\n- gate-tempest-dsvm-full http://logs.openstack.org/97/93097/1/gate/gate-tempest-dsvm-full/0e1c62a : FAILURE in 54m 32s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/97/93097/1/gate/gate-tempest-dsvm-neutron/957929d : SUCCESS in 53m 01s\n- gate-grenade-dsvm http://logs.openstack.org/97/93097/1/gate/gate-grenade-dsvm/fcbdad1 : SUCCESS in 39m 27s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/97/93097/1/gate/gate-taskflow-tox-py26-sa7-mysql/7f6f49c : FAILURE in 2m 03s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/97/93097/1/gate/gate-taskflow-tox-py27-sa8-mysql/57e6424 : FAILURE in 1m 49s","accounts_in_message":[],"_revision_number":1},{"id":"916ec47a975818b9cb756c296daaca14a7918650","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-05-10 07:04:35.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"5008ff91a5932a248d65676f55c3805ca5591e7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-10 07:04:36.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"800cabc9ac1087d331716b739d0d6f62aede80f5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-10 08:03:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/97/93097/1/check/gate-taskflow-pep8/5b33753 : SUCCESS in 1m 03s\n- gate-taskflow-docs http://docs-draft.openstack.org/97/93097/1/check/gate-taskflow-docs/e05b39d/doc/build/html/ : SUCCESS in 1m 34s\n- gate-taskflow-python26 http://logs.openstack.org/97/93097/1/check/gate-taskflow-python26/6445e3f : SUCCESS in 2m 01s\n- gate-taskflow-python27 http://logs.openstack.org/97/93097/1/check/gate-taskflow-python27/380d322 : SUCCESS in 2m 19s\n- gate-taskflow-python33 http://logs.openstack.org/97/93097/1/check/gate-taskflow-python33/d68de91 : SUCCESS in 5m 16s\n- check-tempest-dsvm-full http://logs.openstack.org/97/93097/1/check/check-tempest-dsvm-full/8d06d99 : SUCCESS in 56m 02s\n- check-tempest-dsvm-neutron http://logs.openstack.org/97/93097/1/check/check-tempest-dsvm-neutron/4e49ef7 : SUCCESS in 56m 58s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/97/93097/1/check/check-tempest-dsvm-neutron-heat-slow/525d1d2 : SUCCESS in 22m 31s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/97/93097/1/check/check-grenade-dsvm/7ff9e1f : SUCCESS in 40m 07s\n- check-grenade-dsvm-neutron http://logs.openstack.org/97/93097/1/check/check-grenade-dsvm-neutron/c7e4d65 : SUCCESS in 58m 33s (non-voting)\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/97/93097/1/check/gate-taskflow-tox-py26-sa7-mysql/40a6635 : SUCCESS in 1m 55s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/97/93097/1/check/gate-taskflow-tox-py27-sa8-mysql/a5b1458 : SUCCESS in 1m 50s","accounts_in_message":[],"_revision_number":1},{"id":"f931e696ff19cf4dfba5dbfa8e25f3aa700df136","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-10 08:03:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"7d4d58a19362bdab18c2a8eb4433c05fd2cc0729","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-10 09:41:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded.\n\n- gate-taskflow-docs http://docs-draft.openstack.org/97/93097/1/gate/gate-taskflow-docs/2d8589f/doc/build/html/ : SUCCESS in 1m 26s\n- gate-taskflow-pep8 http://logs.openstack.org/97/93097/1/gate/gate-taskflow-pep8/01b92ec : SUCCESS in 1m 06s\n- gate-taskflow-python26 http://logs.openstack.org/97/93097/1/gate/gate-taskflow-python26/5dd9754 : SUCCESS in 2m 09s\n- gate-taskflow-python27 http://logs.openstack.org/97/93097/1/gate/gate-taskflow-python27/f9ea24b : SUCCESS in 2m 31s\n- gate-taskflow-python33 http://logs.openstack.org/97/93097/1/gate/gate-taskflow-python33/eba2c2a : SUCCESS in 4m 41s\n- gate-tempest-dsvm-full http://logs.openstack.org/97/93097/1/gate/gate-tempest-dsvm-full/808d03f : SUCCESS in 1h 38m 20s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/97/93097/1/gate/gate-tempest-dsvm-neutron/f7316e0 : SUCCESS in 55m 06s\n- gate-grenade-dsvm http://logs.openstack.org/97/93097/1/gate/gate-grenade-dsvm/d38b2a2 : SUCCESS in 43m 07s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/97/93097/1/gate/gate-taskflow-tox-py26-sa7-mysql/83d3dd5 : SUCCESS in 1m 51s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/97/93097/1/gate/gate-taskflow-tox-py27-sa8-mysql/ee20804 : SUCCESS in 1m 43s","accounts_in_message":[],"_revision_number":1},{"id":"76f8de31b0787f3da2df7a9db995ba74e1c47da0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-10 09:41:35.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"449d221d822d2d68a32b81700d798a5fb6aa0584","revisions":{"449d221d822d2d68a32b81700d798a5fb6aa0584":{"kind":"REWORK","_number":1,"created":"2014-05-09 18:13:07.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/97/93097/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/97/93097/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/97/93097/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/97/93097/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/97/93097/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/97/93097/1"}}},"commit":{"parents":[{"commit":"258e009ae36b29f2d96eb0f55e13e44a6c4d5235","subject":"Merge \"Check documentation for simple style requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/258e009ae36b29f2d96eb0f55e13e44a6c4d5235"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-05-09 18:05:29.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@yahoo-inc.com","date":"2014-05-09 18:08:10.000000000","tz":-420},"subject":"Remove the _clear method and do not reset the job_watcher","message":"Remove the _clear method and do not reset the job_watcher\n\nThe _clear method is only used in one place (in close) so the\nbenefit of it being a function is not really valueable so move\nits logic to the close method itself.\n\nAlso fix that the job_watcher does not need to be reset since\nit can now survive session lose/disconnection, setting it to\nnone is not useful anymore and actually creates more watchers\nthat provide the same data (which is bad).\n\nChange-Id: I243ec0551a341df74f478b0161ffd559a75278fe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/449d221d822d2d68a32b81700d798a5fb6aa0584"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/449d221d822d2d68a32b81700d798a5fb6aa0584"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
