)]}'
{"id":"openstack%2Ftaskflow~93771","triplet_id":"openstack%2Ftaskflow~master~Iae1f918e35d41794fc348860e6aa3b52ae2211f4","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"Iae1f918e35d41794fc348860e6aa3b52ae2211f4","subject":"Don\u0027t create fake LogBook when we can not fetch one","status":"MERGED","created":"2014-05-15 18:25:02.000000000","updated":"2014-05-16 14:48:39.000000000","submitted":"2014-05-16 14:48:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"662cd0b987e7556d41b287d4730ee21de2d89ca9","_number":93771,"virtual_id_number":93771,"owner":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2014-05-16 14:48:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":2,"date":"2014-05-16 02:31:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":1,"date":"2014-05-16 13:46:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-05-16 13:46:56.000000000","updated_by":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"reviewer":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"state":"REVIEWER"},{"updated":"2014-05-16 14:48:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"19aac9d388a877bc3839b87958966cb748abedbe","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-05-15 18:25:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"989116506def440ff87f31aab5d300bb3f7b98d0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-15 18:25:03.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a43a1a1ded08852beb5d7212f7f31f2b504f73eb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-15 19:19:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-taskflow-pep8 http://logs.openstack.org/71/93771/1/check/gate-taskflow-pep8/c8c3a7d : FAILURE in 1m 11s\n- gate-taskflow-docs http://docs-draft.openstack.org/71/93771/1/check/gate-taskflow-docs/7c7b054/doc/build/html/ : SUCCESS in 1m 43s\n- gate-taskflow-python26 http://logs.openstack.org/71/93771/1/check/gate-taskflow-python26/d104aa5 : SUCCESS in 1m 48s\n- gate-taskflow-python27 http://logs.openstack.org/71/93771/1/check/gate-taskflow-python27/94b326a : SUCCESS in 2m 16s\n- gate-taskflow-python33 http://logs.openstack.org/71/93771/1/check/gate-taskflow-python33/e046f10 : SUCCESS in 5m 16s\n- check-tempest-dsvm-full http://logs.openstack.org/71/93771/1/check/check-tempest-dsvm-full/7b8af31 : SUCCESS in 50m 53s\n- check-tempest-dsvm-neutron http://logs.openstack.org/71/93771/1/check/check-tempest-dsvm-neutron/137fc8e : SUCCESS in 54m 16s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/71/93771/1/check/check-tempest-dsvm-neutron-heat-slow/e6e22a7 : FAILURE in 22m 24s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/71/93771/1/check/check-grenade-dsvm/c100cf8 : SUCCESS in 43m 28s\n- check-grenade-dsvm-neutron http://logs.openstack.org/71/93771/1/check/check-grenade-dsvm-neutron/e43ee33 : FAILURE in 34m 37s (non-voting)\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/71/93771/1/check/gate-taskflow-tox-py26-sa7-mysql/94da8ea : SUCCESS in 1m 51s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/71/93771/1/check/gate-taskflow-tox-py27-sa8-mysql/a6247a8 : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":1},{"id":"ef2eededd0dca03d18aa56b244101d7952a6018e","author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"date":"2014-05-15 19:34:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5090c6729b43e53a56d6efe927b7277169114166","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-15 19:34:54.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"45446666fb87a5bc25c851d54879869815184826","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-15 20:40:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/71/93771/2/check/gate-taskflow-pep8/278afdb : SUCCESS in 50s\n- gate-taskflow-docs http://docs-draft.openstack.org/71/93771/2/check/gate-taskflow-docs/279e7f8/doc/build/html/ : SUCCESS in 1m 31s\n- gate-taskflow-python26 http://logs.openstack.org/71/93771/2/check/gate-taskflow-python26/907592d : SUCCESS in 2m 04s\n- gate-taskflow-python27 http://logs.openstack.org/71/93771/2/check/gate-taskflow-python27/851ad9b : SUCCESS in 1m 56s\n- gate-taskflow-python33 http://logs.openstack.org/71/93771/2/check/gate-taskflow-python33/d958228 : SUCCESS in 6m 52s\n- check-tempest-dsvm-full http://logs.openstack.org/71/93771/2/check/check-tempest-dsvm-full/54f2e33 : SUCCESS in 1h 05m 35s\n- check-tempest-dsvm-neutron http://logs.openstack.org/71/93771/2/check/check-tempest-dsvm-neutron/eb8f4f1 : SUCCESS in 1h 01m 12s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/71/93771/2/check/check-tempest-dsvm-neutron-heat-slow/27d49af : FAILURE in 27m 36s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/71/93771/2/check/check-grenade-dsvm/d36ff62 : SUCCESS in 46m 28s\n- check-grenade-dsvm-neutron http://logs.openstack.org/71/93771/2/check/check-grenade-dsvm-neutron/a06c97e : FAILURE in 38m 44s (non-voting)\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/71/93771/2/check/gate-taskflow-tox-py26-sa7-mysql/4b87ceb : SUCCESS in 2m 13s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/71/93771/2/check/gate-taskflow-tox-py27-sa8-mysql/3c8f506 : SUCCESS in 1m 56s","accounts_in_message":[],"_revision_number":2},{"id":"ce3fbbc4ce5a104ee6d08c6b326d7b3c14496094","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-05-16 02:31:23.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"5bebf93f797ce1d2d65c227f2d3a621b30ea383b","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-05-16 13:46:56.000000000","message":"Patch Set 2: Workflow+1\n\nLets do it.","accounts_in_message":[],"_revision_number":2},{"id":"b4a274da8452248583d7b13e4a906749e65f41d5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-16 13:46:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2e40940f5af03ab30f4c781592deeaa6841c64e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-16 14:48:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- gate-taskflow-docs http://docs-draft.openstack.org/71/93771/2/gate/gate-taskflow-docs/2b3bd2e/doc/build/html/ : SUCCESS in 1m 02s\n- gate-taskflow-pep8 http://logs.openstack.org/71/93771/2/gate/gate-taskflow-pep8/2083dec : SUCCESS in 1m 08s\n- gate-taskflow-python26 http://logs.openstack.org/71/93771/2/gate/gate-taskflow-python26/a71a371 : SUCCESS in 2m 09s\n- gate-taskflow-python27 http://logs.openstack.org/71/93771/2/gate/gate-taskflow-python27/ffc59ba : SUCCESS in 1m 35s\n- gate-taskflow-python33 http://logs.openstack.org/71/93771/2/gate/gate-taskflow-python33/ea9fe69 : SUCCESS in 4m 12s\n- gate-tempest-dsvm-full http://logs.openstack.org/71/93771/2/gate/gate-tempest-dsvm-full/f535d34 : SUCCESS in 50m 06s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/71/93771/2/gate/gate-tempest-dsvm-neutron/4a55589 : SUCCESS in 1h 01m 25s\n- gate-grenade-dsvm http://logs.openstack.org/71/93771/2/gate/gate-grenade-dsvm/c5dac4c : SUCCESS in 40m 50s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/71/93771/2/gate/gate-taskflow-tox-py26-sa7-mysql/018efdb : SUCCESS in 2m 16s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/71/93771/2/gate/gate-taskflow-tox-py27-sa8-mysql/5c7ab72 : SUCCESS in 1m 35s","accounts_in_message":[],"_revision_number":2},{"id":"662cd0b987e7556d41b287d4730ee21de2d89ca9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-05-16 14:48:39.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"268d935a0a5adff7f0d59bdf3882210c49e45f5c","revisions":{"e615208fcf67aebdaf4f614553005858bc203be2":{"kind":"REWORK","_number":1,"created":"2014-05-15 18:25:02.000000000","uploader":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"ref":"refs/changes/71/93771/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/71/93771/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/71/93771/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/71/93771/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/71/93771/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/71/93771/1"}}},"commit":{"parents":[{"commit":"25873576c688dade66d4baae190807310e2e8bc5","subject":"Merge \"Default the impl_memory conf to none\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/25873576c688dade66d4baae190807310e2e8bc5"}]}],"author":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-05-15 18:18:45.000000000","tz":240},"committer":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-05-15 18:18:45.000000000","tz":240},"subject":"Don\u0027t create fake LogBook when we can not fetch one","message":"Don\u0027t create fake LogBook when we can not fetch one\n\nWhen there is no LogBook nor backend in ZookeeperJob or something is\nwrong with book data, we now return None from `book` property instead\nof new (fake) LogBook. Having two (or more) logbooks with same uuid but\ndifferent data is too confusing and makes root cause of the problem\n(backend or jobboard misconfiguration) less obvious.\n\nThis change also adds `book_name` and `book_uuid` properties to Job\nabstract class to provide a way to access book data even if book\nitself cannot be fetched.\n\nChange-Id: Iae1f918e35d41794fc348860e6aa3b52ae2211f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e615208fcf67aebdaf4f614553005858bc203be2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/e615208fcf67aebdaf4f614553005858bc203be2"}]},"branch":"refs/heads/master"},"268d935a0a5adff7f0d59bdf3882210c49e45f5c":{"kind":"REWORK","_number":2,"created":"2014-05-15 19:34:53.000000000","uploader":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"ref":"refs/changes/71/93771/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/71/93771/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/71/93771/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/71/93771/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/71/93771/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/71/93771/2"}}},"commit":{"parents":[{"commit":"25873576c688dade66d4baae190807310e2e8bc5","subject":"Merge \"Default the impl_memory conf to none\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/25873576c688dade66d4baae190807310e2e8bc5"}]}],"author":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-05-15 18:18:45.000000000","tz":240},"committer":{"name":"Ivan A. Melnikov","email":"imelnikov@griddynamics.com","date":"2014-05-15 19:34:25.000000000","tz":240},"subject":"Don\u0027t create fake LogBook when we can not fetch one","message":"Don\u0027t create fake LogBook when we can not fetch one\n\nWhen there is no LogBook nor backend in ZookeeperJob or something is\nwrong with book data, we now return None from `book` property instead\nof new (fake) LogBook. Having two (or more) logbooks with same uuid but\ndifferent data is too confusing and makes root cause of the problem\n(backend or jobboard misconfiguration) less obvious.\n\nThis change also adds `book_name` and `book_uuid` properties to Job\nabstract class to provide a way to access book data even if book\nitself cannot be fetched.\n\nChange-Id: Iae1f918e35d41794fc348860e6aa3b52ae2211f4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/268d935a0a5adff7f0d59bdf3882210c49e45f5c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/268d935a0a5adff7f0d59bdf3882210c49e45f5c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}