)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"77d40ee4420d6d85abfcd7a5e264c06576548a8b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove zake from runtime dependency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"zake is used only by tests, and is not used by actual functionality."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5723be0224a26bb1c27d439472d762f787969fc6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"50dbc9c8_9ca2a90f","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":68},"updated":"2025-02-06 15:26:23.000000000","message":"Then, are these test legit in this case?\nDo we need it at all?","commit_id":"6286ea4fab4bf2b6d4d8d918041ee38bf4029c64"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"76c037ef5150197a0b8c950bccb18f0f5c65a057","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove zake from runtime dependency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"zake is used only by tests, and is not used by actual functionality."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I5723be0224a26bb1c27d439472d762f787969fc6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b9e3ccf2_055d4c25","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":68},"in_reply_to":"50dbc9c8_9ca2a90f","updated":"2025-02-06 15:50:42.000000000","message":"zake is imported in test codes actually.\n```\n$ grep -r zake taskflow/\ntaskflow/examples/jobboard_produce_consume_colors.py:from zake import fake_client\ntaskflow/examples/tox_conductor.py:from zake import fake_client\ntaskflow/examples/tox_conductor.py:# the zake library that mimics an actual zookeeper cluster using threads and\ntaskflow/tests/unit/jobs/test_entrypoint.py:from zake import fake_client\ntaskflow/tests/unit/jobs/test_zk_job.py:from zake import fake_client\ntaskflow/tests/unit/jobs/test_zk_job.py:from zake import utils as zake_utils\ntaskflow/tests/unit/jobs/test_zk_job.py:        self.bad_paths.extend(zake_utils.partition_path(self.board.path))\ntaskflow/tests/unit/persistence/test_zk_persistence.py:from zake import fake_client\ntaskflow/tests/unit/test_conductors.py:from zake import fake_client\ntaskflow/tests/unit/test_listeners.py:from zake import fake_client\n```","commit_id":"6286ea4fab4bf2b6d4d8d918041ee38bf4029c64"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"77d40ee4420d6d85abfcd7a5e264c06576548a8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf68d590_43711222","updated":"2025-02-06 15:26:23.000000000","message":"From a functional PoV I\u0027m ok with that, my question (inline) is more, do we still need zack if it is only used by tests?\nI don\u0027t know what is zack","commit_id":"6286ea4fab4bf2b6d4d8d918041ee38bf4029c64"}]}
