)]}'
{"id":"openstack%2Ftaskflow~97410","triplet_id":"openstack%2Ftaskflow~master~I0ad0178240613fda166ea8fcdc441b37290445f8","project":"openstack/taskflow","branch":"master","hashtags":[],"change_id":"I0ad0178240613fda166ea8fcdc441b37290445f8","subject":"Rename inject_task_args to inject_atom_args","status":"MERGED","created":"2014-06-03 06:19:47.000000000","updated":"2014-06-05 01:16:50.000000000","submitted":"2014-06-05 01:16:49.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fbe7be0c91d4da6443c83030099c9a7e03a881cc","_number":97410,"virtual_id_number":97410,"owner":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},{"value":0,"date":"2014-06-03 16:49:45.000000000","_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":2,"date":"2014-06-05 01:16:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-06-03 10:02:13.000000000","_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"recommended":{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},"all":[{"value":1,"date":"2014-06-04 00:16:21.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":1,"date":"2014-06-03 19:10:06.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},{"value":2,"date":"2014-06-03 23:26:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"all":[{"value":0,"date":"2014-06-03 06:25:15.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"date":"2014-06-03 06:25:19.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},{"value":1,"date":"2014-06-03 23:26:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"value":0,"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},{"value":0,"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-06-03 06:25:15.000000000","updated_by":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"reviewer":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"state":"REVIEWER"},{"updated":"2014-06-03 06:25:19.000000000","updated_by":{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},"reviewer":{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},"state":"REVIEWER"},{"updated":"2014-06-03 10:02:13.000000000","updated_by":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"reviewer":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"state":"REVIEWER"},{"updated":"2014-06-05 01:16:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e4b6b73756ccae5e6c2d2d8d20e922ea61d2dcff","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-06-03 06:19:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4f8362ff4525d450367e06e5858dceecb6be005f","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-06-03 06:21:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7373c4c82cce2a2593b153dbe5b75c6dee171342","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 08:35:39.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"1de0b7b1b632d9aa640693a51e7c49288d7da99d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 08:35:42.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"362545ba0a0afcb98f8b10bbdcdeab521d7328e4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 09:55:52.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-taskflow-pep8 http://logs.openstack.org/10/97410/2/check/gate-taskflow-pep8/71a5ae4 : SUCCESS in 1m 37s\n- gate-taskflow-docs http://docs-draft.openstack.org/10/97410/2/check/gate-taskflow-docs/1ab3756/doc/build/html/ : SUCCESS in 1m 32s\n- gate-taskflow-python26 http://logs.openstack.org/10/97410/2/check/gate-taskflow-python26/092ced7 : SUCCESS in 2m 32s\n- gate-taskflow-python27 http://logs.openstack.org/10/97410/2/check/gate-taskflow-python27/231104e : SUCCESS in 2m 24s\n- gate-taskflow-python33 http://logs.openstack.org/10/97410/2/check/gate-taskflow-python33/99e8b75 : SUCCESS in 4m 41s\n- check-tempest-dsvm-full http://logs.openstack.org/10/97410/2/check/check-tempest-dsvm-full/7358ddc : SUCCESS in 53m 01s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/10/97410/2/check/check-tempest-dsvm-postgres-full/b70c4fd : FAILURE in 54m 12s\n- check-tempest-dsvm-neutron http://logs.openstack.org/10/97410/2/check/check-tempest-dsvm-neutron/883038b : SUCCESS in 55m 15s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/10/97410/2/check/check-tempest-dsvm-neutron-heat-slow/0b17ecb : FAILURE in 32m 16s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/10/97410/2/check/check-grenade-dsvm/883584e : SUCCESS in 41m 59s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/10/97410/2/check/gate-taskflow-tox-py26-sa7-mysql/07edb78 : SUCCESS in 2m 03s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/10/97410/2/check/gate-taskflow-tox-py27-sa8-mysql/e3a40db : SUCCESS in 1m 51s","accounts_in_message":[],"_revision_number":2},{"id":"82dc01754be8dec996eb43251632c3d83068cd7b","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-06-03 10:02:13.000000000","message":"Patch Set 2:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- check-tempest-dsvm-postgres-full: unrecognized error\n- check-tempest-dsvm-neutron-heat-slow: https://bugs.launchpad.net/bugs/1297560\n\nYou have some unrecognized errors.\nFor bug details see: http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":2},{"id":"57787e100c19786ac629e6f6943feeef496f8a80","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-06-03 16:49:45.000000000","message":"Patch Set 2:\n\nrecheck bug 1267326","accounts_in_message":[],"_revision_number":2},{"id":"aa8360859521bab956ce3f5c2e49d3a825726e9c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 16:55:07.000000000","message":"Patch Set 2: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"d0eec127cd32e6d7b36775123b8ab7d989833c38","author":{"_account_id":11024,"name":"Dan Krause","email":"dan@dankrause.net","username":"dankrause"},"date":"2014-06-03 19:10:06.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"8f87c74e9fd2234b257c856ae18e014b4a7f678e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 23:02:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-taskflow-pep8 http://logs.openstack.org/10/97410/2/check/gate-taskflow-pep8/1a4f584 : SUCCESS in 1m 52s\n- gate-taskflow-docs http://docs-draft.openstack.org/10/97410/2/check/gate-taskflow-docs/c806fe1/doc/build/html/ : SUCCESS in 2m 11s\n- gate-taskflow-python26 http://logs.openstack.org/10/97410/2/check/gate-taskflow-python26/0f892f6 : SUCCESS in 2m 55s\n- gate-taskflow-python27 http://logs.openstack.org/10/97410/2/check/gate-taskflow-python27/7eab0b1 : SUCCESS in 2m 48s\n- gate-taskflow-python33 http://logs.openstack.org/10/97410/2/check/gate-taskflow-python33/f49f1b4 : SUCCESS in 6m 15s\n- check-tempest-dsvm-full http://logs.openstack.org/10/97410/2/check/check-tempest-dsvm-full/3d24479 : SUCCESS in 43m 09s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/10/97410/2/check/check-tempest-dsvm-postgres-full/45b1ead : SUCCESS in 45m 24s\n- check-tempest-dsvm-neutron http://logs.openstack.org/10/97410/2/check/check-tempest-dsvm-neutron/ff5b563 : SUCCESS in 54m 21s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/10/97410/2/check/check-tempest-dsvm-neutron-heat-slow/ee68bf6 : FAILURE in 31m 57s (non-voting)\n- check-grenade-dsvm http://logs.openstack.org/10/97410/2/check/check-grenade-dsvm/146eb66 : SUCCESS in 40m 29s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/10/97410/2/check/gate-taskflow-tox-py26-sa7-mysql/81543f6 : SUCCESS in 2m 42s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/10/97410/2/check/gate-taskflow-tox-py27-sa8-mysql/673a35c : SUCCESS in 2m 02s","accounts_in_message":[],"_revision_number":2},{"id":"9e6ce27be82a0db40b2318157d042b64b04eab98","author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"date":"2014-06-03 23:26:39.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b012fd585ee18b136c45c65cfd739ffa3d4142a8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-03 23:41:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"e16fae4bd8876ba548ce952a461fbe7f7705f6b3","author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"date":"2014-06-04 00:16:21.000000000","message":"Patch Set 2: Code-Review+1\n\nI had debated the naming when I wrote it, but went with task because I wasn\u0027t sure if we wanted it to apply to all atoms or not.  Probably should\u0027ve just asked.","accounts_in_message":[],"_revision_number":2},{"id":"bdd3cb0a6e7c2a5d3fd626f17732cb39475ee667","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-04 03:06:30.000000000","message":"Patch Set 2:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2ac23064042eea2d2bc9912be3ca05ae4b6da7a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-05 01:16:49.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- gate-taskflow-docs http://docs-draft.openstack.org/10/97410/2/gate/gate-taskflow-docs/2c695b2/doc/build/html/ : SUCCESS in 2m 25s\n- gate-taskflow-pep8 http://logs.openstack.org/10/97410/2/gate/gate-taskflow-pep8/9b0819e : SUCCESS in 54s\n- gate-taskflow-python26 http://logs.openstack.org/10/97410/2/gate/gate-taskflow-python26/7f02e04 : SUCCESS in 2m 09s\n- gate-taskflow-python27 http://logs.openstack.org/10/97410/2/gate/gate-taskflow-python27/99a6e18 : SUCCESS in 2m 15s\n- gate-taskflow-python33 http://logs.openstack.org/10/97410/2/gate/gate-taskflow-python33/6f9a475 : SUCCESS in 5m 29s\n- gate-tempest-dsvm-full http://logs.openstack.org/10/97410/2/gate/gate-tempest-dsvm-full/55c830a : SUCCESS in 51m 50s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/10/97410/2/gate/gate-tempest-dsvm-postgres-full/8dc2628 : SUCCESS in 50m 17s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/10/97410/2/gate/gate-tempest-dsvm-neutron/bcfb27a : SUCCESS in 57m 38s\n- gate-grenade-dsvm http://logs.openstack.org/10/97410/2/gate/gate-grenade-dsvm/5484f29 : SUCCESS in 40m 50s\n- gate-taskflow-tox-py26-sa7-mysql http://logs.openstack.org/10/97410/2/gate/gate-taskflow-tox-py26-sa7-mysql/13a7e0a : SUCCESS in 2m 18s\n- gate-taskflow-tox-py27-sa8-mysql http://logs.openstack.org/10/97410/2/gate/gate-taskflow-tox-py27-sa8-mysql/8feee88 : SUCCESS in 1m 36s","accounts_in_message":[],"_revision_number":2},{"id":"fbe7be0c91d4da6443c83030099c9a7e03a881cc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-05 01:16:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2ac96676e473faa6452d070d6bc73a74f131b1d4","revisions":{"a3ca4cefdf01a8245ef4f76c4f3b2810967e9bf3":{"kind":"REWORK","_number":1,"created":"2014-06-03 06:19:47.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/10/97410/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/10/97410/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/10/97410/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/10/97410/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/10/97410/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/10/97410/1"}}},"commit":{"parents":[{"commit":"c8a281aa360117a03baecb38bde411a990b50551","subject":"Merge \"Warn about internal helper/utility usage\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/c8a281aa360117a03baecb38bde411a990b50551"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2014-06-03 06:17:44.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2014-06-03 06:17:44.000000000","tz":-420},"subject":"Rename inject_task_args to inject_atom_args","message":"Rename inject_task_args to inject_atom_args\n\nSince storage injection can target atoms and not\njust tasks (just one type of atom) the method naming\nis more appropriate when named as atom injection (and\nassociated variable name changes reflect this as well).\n\nChange-Id: I0ad0178240613fda166ea8fcdc441b37290445f8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/a3ca4cefdf01a8245ef4f76c4f3b2810967e9bf3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/a3ca4cefdf01a8245ef4f76c4f3b2810967e9bf3"}]},"branch":"refs/heads/master"},"2ac96676e473faa6452d070d6bc73a74f131b1d4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2014-06-03 06:21:32.000000000","uploader":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"ref":"refs/changes/10/97410/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/taskflow","ref":"refs/changes/10/97410/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/10/97410/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/10/97410/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/taskflow refs/changes/10/97410/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/taskflow refs/changes/10/97410/2"}}},"commit":{"parents":[{"commit":"c8a281aa360117a03baecb38bde411a990b50551","subject":"Merge \"Warn about internal helper/utility usage\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/c8a281aa360117a03baecb38bde411a990b50551"}]}],"author":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2014-06-03 06:17:44.000000000","tz":-420},"committer":{"name":"Joshua Harlow","email":"harlowja@gmail.com","date":"2014-06-03 06:20:51.000000000","tz":-420},"subject":"Rename inject_task_args to inject_atom_args","message":"Rename inject_task_args to inject_atom_args\n\nSince storage injection can target atoms and not\njust tasks (just one type of atom) the method naming\nis more appropriate when named as atom injection (and\nassociated variable name changes reflect this as well).\n\nAlso add more stringent checking around the names of\natoms that are targeted for injection (ensuring that\nthe name provided actually exists in the storage unit).\n\nChange-Id: I0ad0178240613fda166ea8fcdc441b37290445f8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/2ac96676e473faa6452d070d6bc73a74f131b1d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/taskflow/commit/2ac96676e473faa6452d070d6bc73a74f131b1d4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}