)]}'
{"taskflow/engines/worker_based/executor.py":[{"author":{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"},"change_message_id":"9021e82820ec90329b80a8fbf5e2102b67c6687d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                    # NOTE(imelnikov): request should not be in cache when"},{"line_number":138,"context_line":"                    # another thread can see its result and schedule another"},{"line_number":139,"context_line":"                    # request with same uuid; so we remove it, then set result"},{"line_number":140,"context_line":"                    self._requests_cache.pop(request.uuid)"},{"line_number":141,"context_line":"                    request.set_result(**response.data)"},{"line_number":142,"context_line":"                else:"},{"line_number":143,"context_line":"                    LOG.warning(\"Unexpected response status: \u0027%s\u0027\","}],"source_content_type":"text/x-python","patch_set":2,"id":"dab895d6_650a11d4","line":140,"updated":"2014-06-29 19:08:44.000000000","message":"Why not this?\n\n\"del self._requests_cache[request.uuid]\"","commit_id":"335067f3dd41970c51eae2fb04038e00f0909882"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8301b621c68e81478dbaee6e8ff4ef9133f08ea0","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                    # NOTE(imelnikov): request should not be in cache when"},{"line_number":138,"context_line":"                    # another thread can see its result and schedule another"},{"line_number":139,"context_line":"                    # request with same uuid; so we remove it, then set result"},{"line_number":140,"context_line":"                    self._requests_cache.pop(request.uuid)"},{"line_number":141,"context_line":"                    request.set_result(**response.data)"},{"line_number":142,"context_line":"                else:"},{"line_number":143,"context_line":"                    LOG.warning(\"Unexpected response status: \u0027%s\u0027\","}],"source_content_type":"text/x-python","patch_set":2,"id":"dab895d6_45a18da8","line":140,"in_reply_to":"dab895d6_650a11d4","updated":"2014-06-29 19:15:48.000000000","message":"Done","commit_id":"335067f3dd41970c51eae2fb04038e00f0909882"},{"author":{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"},"change_message_id":"9021e82820ec90329b80a8fbf5e2102b67c6687d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            with misc.capture_failure() as failure:"},{"line_number":194,"context_line":"                LOG.exception(\"Failed to submit the \u0027%s\u0027 request.\" %"},{"line_number":195,"context_line":"                              request)"},{"line_number":196,"context_line":"                self._requests_cache.pop(request.uuid)"},{"line_number":197,"context_line":"                request.set_result(failure)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _notify_topics(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab895d6_a51429f6","line":196,"updated":"2014-06-29 19:08:44.000000000","message":"Same here. \"del\" can be used.","commit_id":"335067f3dd41970c51eae2fb04038e00f0909882"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8301b621c68e81478dbaee6e8ff4ef9133f08ea0","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            with misc.capture_failure() as failure:"},{"line_number":194,"context_line":"                LOG.exception(\"Failed to submit the \u0027%s\u0027 request.\" %"},{"line_number":195,"context_line":"                              request)"},{"line_number":196,"context_line":"                self._requests_cache.pop(request.uuid)"},{"line_number":197,"context_line":"                request.set_result(failure)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _notify_topics(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab895d6_65a691c3","line":196,"in_reply_to":"dab895d6_a51429f6","updated":"2014-06-29 19:15:48.000000000","message":"Done","commit_id":"335067f3dd41970c51eae2fb04038e00f0909882"}],"taskflow/types/cache.py":[{"author":{"_account_id":6648,"name":"Changbin Liu","email":"changbin.liu@gmail.com","username":"changbl"},"change_message_id":"9021e82820ec90329b80a8fbf5e2102b67c6687d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        with self._lock.read_lock():"},{"line_number":42,"context_line":"            return len(self._data)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get(self, key, default\u003dNone):"},{"line_number":45,"context_line":"        \"\"\"Retrieve a value from the cache (default if not found).\"\"\""},{"line_number":46,"context_line":"        with self._lock.read_lock():"},{"line_number":47,"context_line":"            return self._data.get(key, default)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab895d6_a52b492f","line":44,"updated":"2014-06-29 19:08:44.000000000","message":"It seems get() is not invoked/used anywhere.","commit_id":"335067f3dd41970c51eae2fb04038e00f0909882"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"7e10ad2f260cb0dd771cf6f85ecbced31a23c480","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        with self._lock.read_lock():"},{"line_number":42,"context_line":"            return len(self._data)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get(self, key, default\u003dNone):"},{"line_number":45,"context_line":"        \"\"\"Retrieve a value from the cache (default if not found).\"\"\""},{"line_number":46,"context_line":"        with self._lock.read_lock():"},{"line_number":47,"context_line":"            return self._data.get(key, default)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab895d6_c5259d0b","line":44,"in_reply_to":"dab895d6_85aba588","updated":"2014-06-29 19:34:14.000000000","message":"Found a usage of it! WBE Executor uses it to fetch a request out (and handles the None case when its not found).","commit_id":"335067f3dd41970c51eae2fb04038e00f0909882"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"8301b621c68e81478dbaee6e8ff4ef9133f08ea0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        with self._lock.read_lock():"},{"line_number":42,"context_line":"            return len(self._data)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get(self, key, default\u003dNone):"},{"line_number":45,"context_line":"        \"\"\"Retrieve a value from the cache (default if not found).\"\"\""},{"line_number":46,"context_line":"        with self._lock.read_lock():"},{"line_number":47,"context_line":"            return self._data.get(key, default)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab895d6_85aba588","line":44,"in_reply_to":"dab895d6_a52b492f","updated":"2014-06-29 19:15:48.000000000","message":"Agreed, will remove until used (if ever).","commit_id":"335067f3dd41970c51eae2fb04038e00f0909882"}]}