)]}'
{"taskflow/tests/unit/test_action_engine_compile.py":[{"author":{"_account_id":9648,"name":"Greg Hill","email":"greg.hill@rackspace.com","username":"jimbobhickville"},"change_message_id":"f1f7cfb1b74acafb6123df762a891a278129fb6f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_retry(self):"},{"line_number":48,"context_line":"        r \u003d retry.AlwaysRevert(\u0027r1\u0027)"},{"line_number":49,"context_line":"        msg_regex \u003d \"^Retry controller: .* must only be used .*\""},{"line_number":50,"context_line":"        self.assertRaisesRegexp(TypeError, msg_regex,"},{"line_number":51,"context_line":"                                compiler.PatternCompiler().compile, r)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_441409f5","line":49,"updated":"2014-06-09 18:26:39.000000000","message":"I\u0027ve never been a fan of tests checking for specific error messages.  Too tightly coupled and fragile (as evidenced by the need to fix this test here).  Should really only be checking exception metadata in tests.  Given that these tests already exist, I\u0027ma let it slide... this time.","commit_id":"7c7e52351b61deb6b94b61ce3188ca27b44c3cad"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e0b95c823460f3733840b6cb026fb101b90149a4","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_retry(self):"},{"line_number":48,"context_line":"        r \u003d retry.AlwaysRevert(\u0027r1\u0027)"},{"line_number":49,"context_line":"        msg_regex \u003d \"^Retry controller: .* must only be used .*\""},{"line_number":50,"context_line":"        self.assertRaisesRegexp(TypeError, msg_regex,"},{"line_number":51,"context_line":"                                compiler.PatternCompiler().compile, r)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_c2a804de","line":49,"in_reply_to":"1ae5cdf2_441409f5","updated":"2014-06-09 21:32:28.000000000","message":"Agreed, there needs to be more refactoring here to just check the exception metadata (type for example) here, but for a later change I think.","commit_id":"7c7e52351b61deb6b94b61ce3188ca27b44c3cad"}]}
