)]}'
{"specs/juno/add-alarm-severity.rst":[{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"4f9d08a8b2bb591ecf6a65b8d09bf8ddd0a8d2d2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Define 3 alarm severity as options: low, medium, high."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Implement storage model for adding alarm severity."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_0c99156e","line":43,"updated":"2014-06-18 03:39:27.000000000","message":"Severity levels should be configurable since they will probably vary from vendor to vendor. E.g. you could have critical above high or you could use numbers from 0 to 10.","commit_id":"78f867496c6003b08e454bfce1c589e41d142046"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"027feee9a2af9cf4b7a7b0d66026b84c1c14a4ed","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Define 3 alarm severity as options: low, medium, high."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Implement storage model for adding alarm severity."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1ae5cdf2_0fde39da","line":43,"in_reply_to":"1ae5cdf2_0c99156e","updated":"2014-06-19 01:03:39.000000000","message":"Hi Fabio Giannetti, thanks for your suggestion, the severity levels should be unified, I would prefer add critical above high :) that will be done next ps. and add more choices to following \"Alternatives\" group.","commit_id":"78f867496c6003b08e454bfce1c589e41d142046"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"deaf549eef0b418d13dbe6018b63f2fecb4a7731","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Work Items"},{"line_number":110,"context_line":"----------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"1. Add alarm severity as an alarm attribute to alarm model definition."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"2. Implement the alarm db table updating or db version migration for different"},{"line_number":115,"context_line":"   storage backend."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_744b8c59","line":112,"updated":"2014-07-01 08:47:33.000000000","message":"How would the severity of a combination alarm be calculated?\n\nFor say, an AND combination, then perhaps it would be the highest severity of the underpinning alarms.\n\nBut for an OR combination, surely it should be based on the highest severity of the the underpinning alarms that have *actually fired*? (i.e. not statically set for the alarm in the persistent representation)","commit_id":"78f867496c6003b08e454bfce1c589e41d142046"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"a4c8f9a24e36f147dc14e3beb613b512008ba44b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"Work Items"},{"line_number":110,"context_line":"----------"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"1. Add alarm severity as an alarm attribute to alarm model definition."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"2. Implement the alarm db table updating or db version migration for different"},{"line_number":115,"context_line":"   storage backend."}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_fab065df","line":112,"in_reply_to":"baada198_744b8c59","updated":"2014-07-01 09:45:10.000000000","message":"Hi Eoghan, thanks for your review, I think it it better let the alarm creator to set the severity of a combination alarm. Because for one user, the combination alarm based on a list of alarms may signify \"high alarm severity\", but for another user, a combination alarm based on the same list of alarms may signify \"low alarm severity\", this is closely related the usage of user.\nso the concept of alarm severity cover both the two types of alarm.\n\nThanks :)","commit_id":"78f867496c6003b08e454bfce1c589e41d142046"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"08fa92022e02ce98963188e85570adf5c3e7b905","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"- Limiting actions by conditions against alarm severity"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"- Send alarm notify with alarm severity attribute which allow 3th part alarm"},{"line_number":38,"context_line":"  consumer doing different action with different level alarm."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_8a85b7ae","line":37,"updated":"2014-07-21 12:29:35.000000000","message":"3rd party","commit_id":"04e0c1e998d6427fb3b84a99ee3bf263fe19fe9e"}],"specs/kilo/add-alarm-severity.rst":[{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"b36fab5c8aed421af9c0c6a9497f2ce15f6825ce","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Define 4 alarm severity as options: low, medium, high, critical."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Implement storage model for adding alarm severity."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_d812acb3","line":43,"updated":"2014-12-09 09:28:49.000000000","message":"I have questions:\n1.How to define the severity level ? user can defined or ceilometer hard-coded.","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"e9e140caa279b1eff5c192c17d55adcc3d8f8550","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Define 4 alarm severity as options: low, medium, high, critical."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Implement storage model for adding alarm severity."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_0bbbddc4","line":43,"in_reply_to":"3a961159_0202e10a","updated":"2014-12-10 05:25:52.000000000","message":"Firstly, thanks for your review, if you have toke a look at PS1, you may didn\u0027t have this question, so please pay attention to the topic than pick words fault.\n \nSecondly, yeah, you are right, but that is your personal thoughts, and this is my personal thought, I will change this there are other reviewers\u0027 suggestion of this. if you can give some samples or evidences of industry standards, it will be better.\n\nthanks for review","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"725a6b540fc6ea3946571de1c402547a449ac70a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Define 4 alarm severity as options: low, medium, high, critical."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Implement storage model for adding alarm severity."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_0ef3eb73","line":43,"in_reply_to":"3a961159_0b683df4","updated":"2014-12-10 07:01:07.000000000","message":"Hi Kai Qiang Wu, There\u0027s no need to apologize, just to reply your review comments and without any disrespect :), PS is the abbreviation of \"patch set\", but that is a bad usage habit :)\n\nI have the same thought about levels of user-definition or hard-coded and how to define the levels (\"low, medium, high, critical\" or 0-10? ), to my knowledge, the severity is hard-coded defining several options, so if there is different samples to reference, I will change this spec\n\nthanks for review","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"b9cf7b129b1804f4257bb0b302bd1c1f5ac03960","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Define 4 alarm severity as options: low, medium, high, critical."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Implement storage model for adding alarm severity."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_0b683df4","line":43,"in_reply_to":"3a961159_0bbbddc4","updated":"2014-12-10 05:40:31.000000000","message":"Hi, Sheng,\n\n1. If my words sound bad, I apologize for that. I never want to pick words fault.  \n\nI just not know PS meaning in above your comment, I got to know it now, (it is patch)\n\n2. Second, yes, it is my personal view, I think code review is personal thought, we can wait other core members review.\nI am ok with that.\n\n\nThanks","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"e6de933d65041a7216bbca7239b7c2076b126dcb","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Define 4 alarm severity as options: low, medium, high, critical."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Implement storage model for adding alarm severity."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_0202e10a","line":43,"in_reply_to":"3a961159_cc8492b3","updated":"2014-12-10 03:49:36.000000000","message":"1  For  \"I have thought about this question, and this has been mentioned in early spec \".\nCould you give me the link of early spec ? I did not get it.\n\n2. I think alarm severity should have a standard or else, it should be user defined, not hardcoded. This related should be mentioned in this spec. (Or else, I can not know what\u0027s that)\n\nThanks","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9ed9409727dbc0de8b4a18a198650cbed1caba57","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Proposed change"},{"line_number":41,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* Define 4 alarm severity as options: low, medium, high, critical."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"* Implement storage model for adding alarm severity."},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_cc8492b3","line":43,"in_reply_to":"3a961159_d812acb3","updated":"2014-12-10 02:01:05.000000000","message":"I have thought about this question, and this has been mentioned in early spec PS. If this proposal be approved (not the *metadata* approach), I prefer to be hard-code the levels.","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"b36fab5c8aed421af9c0c6a9497f2ce15f6825ce","unresolved":false,"context_lines":[{"line_number":53,"context_line":"alarms list. Because for one user, the combination alarm based on a list of"},{"line_number":54,"context_line":"alarms may signify \"high alarm severity\", but for another user, a combination"},{"line_number":55,"context_line":"alarm based on the same list of alarms may signify \"low alarm severity\", this"},{"line_number":56,"context_line":"is closely related the usage of user."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Alternatives"},{"line_number":59,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_78f53882","line":56,"updated":"2014-12-09 09:28:49.000000000","message":"relate to","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9ed9409727dbc0de8b4a18a198650cbed1caba57","unresolved":false,"context_lines":[{"line_number":53,"context_line":"alarms list. Because for one user, the combination alarm based on a list of"},{"line_number":54,"context_line":"alarms may signify \"high alarm severity\", but for another user, a combination"},{"line_number":55,"context_line":"alarm based on the same list of alarms may signify \"low alarm severity\", this"},{"line_number":56,"context_line":"is closely related the usage of user."},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Alternatives"},{"line_number":59,"context_line":"------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_ec930ef8","line":56,"in_reply_to":"3a961159_78f53882","updated":"2014-12-10 02:01:05.000000000","message":"Done","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"164f813c62d687ed0171149cacc65a0141cb2845","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Alternatives"},{"line_number":59,"context_line":"------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add *metadata* to alarm definition"},{"line_number":62,"context_line":"  The alarm severity has no impact on the evaluation process,just a"},{"line_number":63,"context_line":"  informational attribute, the alarm severity is mainly used by consumer of"},{"line_number":64,"context_line":"  alarm notification to take different action according different severity."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_7980c946","line":61,"updated":"2014-12-09 18:23:37.000000000","message":"I think this is a better proposal. Adding metadata decouples the significance/importance of the alarm from the alarm itself.\nThis also frees deployers from adding/interpreting all sort of severity. What I suggest is to have a default metadata which emulates what you have in your main changes and describe how people can customize it if needed.","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9ed9409727dbc0de8b4a18a198650cbed1caba57","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Alternatives"},{"line_number":59,"context_line":"------------"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"* Add *metadata* to alarm definition"},{"line_number":62,"context_line":"  The alarm severity has no impact on the evaluation process,just a"},{"line_number":63,"context_line":"  informational attribute, the alarm severity is mainly used by consumer of"},{"line_number":64,"context_line":"  alarm notification to take different action according different severity."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_47eddb24","line":61,"in_reply_to":"3a961159_7980c946","updated":"2014-12-10 02:01:05.000000000","message":"Yeah, this is advisable approach, and flexibility of metadata will allow users to freely define the severity.\nBut,as I mentioned, the severity is a inborn property of alarm, to my knowledge, the *metadata* means extra info of a resource, allow users to freely CURD, and empty or not of metadata should have no effect to alarm and its handling chain  ,this go against to the severity definition. But I am not very sure for this :)","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":7049,"name":"Kai Qiang Wu(Kennan)","email":"wkq5325@gmail.com","username":"Kennan"},"change_message_id":"b36fab5c8aed421af9c0c6a9497f2ce15f6825ce","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  informational attribute, the alarm severity is mainly used by consumer of"},{"line_number":64,"context_line":"  alarm notification to take different action according different severity."},{"line_number":65,"context_line":"  metadata is a more flexible way to define the alarm severity, additionally,"},{"line_number":66,"context_line":"  metadata also allow users add extra information to alarm definition, the"},{"line_number":67,"context_line":"  extra information may have special meaning for alarm creator and alarm"},{"line_number":68,"context_line":"  consumer."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_b8c16030","line":66,"updated":"2014-12-09 09:28:49.000000000","message":"allow to","commit_id":"7cf34ed7791db5917078131425461153887b9e51"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"9ed9409727dbc0de8b4a18a198650cbed1caba57","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  informational attribute, the alarm severity is mainly used by consumer of"},{"line_number":64,"context_line":"  alarm notification to take different action according different severity."},{"line_number":65,"context_line":"  metadata is a more flexible way to define the alarm severity, additionally,"},{"line_number":66,"context_line":"  metadata also allow users add extra information to alarm definition, the"},{"line_number":67,"context_line":"  extra information may have special meaning for alarm creator and alarm"},{"line_number":68,"context_line":"  consumer."},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3a961159_8cba8a6c","line":66,"in_reply_to":"3a961159_b8c16030","updated":"2014-12-10 02:01:05.000000000","message":"Done","commit_id":"7cf34ed7791db5917078131425461153887b9e51"}]}