)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"df88316f7ef06d393603f1872a67a3151abdb574","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-07-03 14:19:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add spec for IPMI support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If2d355c39120fdb9b8800901761cd9e7768fc18a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_5c8fdb74","line":8,"updated":"2014-07-07 11:34:06.000000000","message":"Would be useful if the commit message clarified between notification and polling support. This spec is about polling IPMI enabled hardware _from_ Ceilometer. That ought to be made more clear for the sake of casual browsers.","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"}],"specs/juno/ipmi.rst":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"df88316f7ef06d393603f1872a67a3151abdb574","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/ipmi-support"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Add IPMI function in ceilometer, so that power/thermal data can be fetched through IPMI capable servers. These data can be exported to other openstack component for other usage, like policy control."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_dcc92bad","line":13,"updated":"2014-07-07 11:34:06.000000000","message":"Please wrap at 79 columns as advised in the template: https://github.com/openstack/ceilometer-specs/blob/master/specs/template.rst\n\nOtherwise it is quite hard to review.","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"df88316f7ef06d393603f1872a67a3151abdb574","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Add a new IPMI agent, who get the power \u0026 thermal data via IPMI protocol in periodic way and publish these data via pipeline."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Need add following typical metrics:"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_7c43bfae","line":26,"updated":"2014-07-07 11:34:06.000000000","message":"Where (that in relation to what other services and instances) does the IPMI agent live? How does it become aware of what it is supposed to poll?","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"change_message_id":"ea18f9696e9dab29045266744d0c30a222b08033","unresolved":false,"context_lines":[{"line_number":33,"context_line":" power                                        g              W               n"},{"line_number":34,"context_line":" temperature                                  g              degree          n"},{"line_number":35,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  * g \u003d gauge, n \u003d notification , p \u003d pollster"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"IPMI is generic protocol, each vendor may add specific metric for their own hardware. So there are probably more vendor specific metric in implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_556e2d97","line":36,"updated":"2014-07-03 06:36:12.000000000","message":"Can we have fan speed also ?","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"5953e4d21ab79c5aa9b8e5bccb179364c2346351","unresolved":false,"context_lines":[{"line_number":33,"context_line":" power                                        g              W               n"},{"line_number":34,"context_line":" temperature                                  g              degree          n"},{"line_number":35,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  * g \u003d gauge, n \u003d notification , p \u003d pollster"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"IPMI is generic protocol, each vendor may add specific metric for their own hardware. So there are probably more vendor specific metric in implementation"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_b8dea00f","line":36,"in_reply_to":"baada198_556e2d97","updated":"2014-07-08 10:37:32.000000000","message":"IPMI spec defines typical sensor to get power, temperature, and fan speed. But I\u0027m not sure if fan speed is as popular as power/temperature when vendor produce their server. So I\u0027d like make it as vendor specific metric and marked as example in below.","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"change_message_id":"ea18f9696e9dab29045266744d0c30a222b08033","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  * g \u003d gauge, n \u003d notification , p \u003d pollster"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"IPMI is generic protocol, each vendor may add specific metric for their own hardware. So there are probably more vendor specific metric in implementation"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_354c5942","line":39,"updated":"2014-07-03 06:36:12.000000000","message":"Is the aim to hide the details of each hardware type and produce a single standard metric ? Different BMCs have different SDR specification strings which should be hidden from the cloud operator.","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"5953e4d21ab79c5aa9b8e5bccb179364c2346351","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  * g \u003d gauge, n \u003d notification , p \u003d pollster"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"IPMI is generic protocol, each vendor may add specific metric for their own hardware. So there are probably more vendor specific metric in implementation"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_18ececc6","line":39,"in_reply_to":"baada198_354c5942","updated":"2014-07-08 10:37:32.000000000","message":"Aim to provide:\n1. a standard metric that exist for most of vendor\n2. infrastructure to enable IPMI, that is, basic working unit to send IPMI commands.\n\nIt could include an simple vendor specific implementation based on 2 as example, so other vendor can do their own work easily.","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"change_message_id":"ea18f9696e9dab29045266744d0c30a222b08033","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"IPMI is generic protocol, each vendor may add specific metric for their own hardware. So there are probably more vendor specific metric in implementation"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_f55901ff","line":41,"updated":"2014-07-03 06:36:12.000000000","message":"There are multiple sensors for temperature between motherboard and CPU temperatures. Some BMCs provide more detail than others. Would the aim be to provide a list of metrics which would always be provided and a list which, if provided, should be consistent ?","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"5953e4d21ab79c5aa9b8e5bccb179364c2346351","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"IPMI is generic protocol, each vendor may add specific metric for their own hardware. So there are probably more vendor specific metric in implementation"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_58f4a486","line":41,"in_reply_to":"baada198_f55901ff","updated":"2014-07-08 10:37:32.000000000","message":"to provide a list of metrics available for most of the IPMI servers, and provide infrastructure allowing each vendor to provide specific feature","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"df88316f7ef06d393603f1872a67a3151abdb574","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Alternatives"},{"line_number":43,"context_line":"------------"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Ceilometer already have SNMP support to monitor server information, so we can just add IPMI support in inspector without introducing a new agent. But this is a little bit intrusive."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Data model impact"},{"line_number":48,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"baada198_1ccd6366","line":45,"updated":"2014-07-07 11:34:06.000000000","message":"I\u0027m relatively new in these parts so please take the following with a suitable dose of salt, but I was under the impression that pollsters were considered the less preferred mode of gathering samples, requiring too much shared knowledge between the sample source and the ceilometer agents.\n\nI suspect some of the confusion is the result of the ceilometer name being an umbrella over a variety of not necessarily contiguous services:\n\n* pollsters\n* notification consumers\n* data store\n* data api\n* alarms\n\nThere\u0027s a lot of shared knowledge going on between each of these services as well as the services that provide notifications. \n\nAs Eoghan points out there are issues with IPMI credentials when polling, adding those credential to ceilometer would be yet another bit of shared knowledge. We should instead be striving to keep each service as stupid as possible. That pollsters effectively produce notifications is a step in the right direction, but it would be better if pollsters were outside the domain of ceilometer.\n\nIn any case I think it would be useful to point out here (in the alternatives section) why polling is the right thing (I think that\u0027s been done in the review comments but should be reflected here) and other options could be considered.","commit_id":"9ec4c8be4d0eb165243407c2aa1416bc7e8b2a15"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"782f10fa2291d9a50defa552cefa5c4975a17fb6","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Add a new IPMI agent, who get the power \u0026 thermal data via IPMI protocol in"},{"line_number":39,"context_line":"periodic way and publish these data via pipeline. IPMI agent lives in each IPMI"},{"line_number":40,"context_line":"capable node, and gets configured in deployment."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In this way, data can be fetched locally without credentials via network. Also"},{"line_number":43,"context_line":"agent polling period can be controlled by pipeline file."}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_12b9472e","line":40,"updated":"2014-07-10 12:41:23.000000000","message":"By node, I\u0027m assuming you mean what in a real deployment would be a baremetal host, similar to a compute node in nova? And you\u0027d have this agent on each node, potentially thousands.\n\nI\u0027m asking because I\u0027m trying to compare this solution with the one in https://github.com/openstack/ironic-specs/blob/master/specs/juno/send-data-to-ceilometer.rst where Ironic itself hosts (at least) one agent for a bunch of nodes.\n\nEach has a different model for how to manage multiple data sources. This one is potentially less complex.\n\nThis proposal also seems to be striving to ensure that IPMI data from various vendors is consolidated to a common view. This is a very good thing.","commit_id":"18bb275432ce59c93de0fb27d1b4fe6257f725a9"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"62ebede725be8cfcda8d31d459c6d5b392b92ffb","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Add a new IPMI agent, who get the power \u0026 thermal data via IPMI protocol in"},{"line_number":39,"context_line":"periodic way and publish these data via pipeline. IPMI agent lives in each IPMI"},{"line_number":40,"context_line":"capable node, and gets configured in deployment."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"In this way, data can be fetched locally without credentials via network. Also"},{"line_number":43,"context_line":"agent polling period can be controlled by pipeline file."}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_870cd7ed","line":40,"in_reply_to":"baada198_12b9472e","updated":"2014-07-15 01:41:00.000000000","message":"Chris,\nCentral agent solution is a little bit simple, but \n1. We need add IPMI credential support. \n2. The scalability is not good, as central agent need poll each node periodically.\n\nThe solution in this BP would have agent on each IPMI capable node, and send data to ceilometer with good scalability.","commit_id":"18bb275432ce59c93de0fb27d1b4fe6257f725a9"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"f492fb38c0336caeb35a4ab2d31b49544815f264","unresolved":false,"context_lines":[{"line_number":47,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":48,"context_line":"              Name                         Type             Unit           Origin"},{"line_number":49,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":" power                                        g              W               n"},{"line_number":51,"context_line":" temperature                                  g              degree          n"},{"line_number":52,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_522d8afc","line":50,"updated":"2014-07-17 08:56:04.000000000","message":"we already have the meter named \u0027power\u0027 which polls from kwapi, maybe another name?","commit_id":"18bb275432ce59c93de0fb27d1b4fe6257f725a9"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"782f10fa2291d9a50defa552cefa5c4975a17fb6","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"1) an IPMI agent for data fetching"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"2) ceilometer need talk with IPMI agent to get data and export them"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Future lifecycle"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_92cab79f","line":141,"updated":"2014-07-10 12:41:23.000000000","message":"I think the ordering here is backwards. What ought to be happening is that the IPMI agent is doing data fetching and the formulating notifications to drop on the bus that central notification agent can \"hear\". Then we are making sure that the controller side of ceilometer doesn\u0027t have to have any knowledge of the IPMI agent.\n\n_And_ if the IPMI agent is send data of a similar form to what the Ironic collection (from https://github.com/openstack/ironic-specs/blob/master/specs/juno/send-data-to-ceilometer.rst ) is doing the same code in the ceilometer notification agent can handle storing the samples.","commit_id":"18bb275432ce59c93de0fb27d1b4fe6257f725a9"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"62ebede725be8cfcda8d31d459c6d5b392b92ffb","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"1) an IPMI agent for data fetching"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"2) ceilometer need talk with IPMI agent to get data and export them"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Future lifecycle"}],"source_content_type":"text/x-rst","patch_set":2,"id":"baada198_272eab8c","line":141,"in_reply_to":"baada198_92cab79f","updated":"2014-07-15 01:41:00.000000000","message":"Yes. The order is IPMI agent is doing data fetching and drop it on the bus. My description here is not accurate.","commit_id":"18bb275432ce59c93de0fb27d1b4fe6257f725a9"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"757ffcada2d3f8fb860d035bdeed0162b1d0f17b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"IPMI support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/ipmi-support"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_9dfc71b7","line":9,"updated":"2014-07-24 09:22:33.000000000","message":"Just a nit: title length must match the underline.","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"744d720298cd5ac4649ca610ae334389861044c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"IPMI support"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/ipmi-support"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_0765e0ae","line":9,"in_reply_to":"baada198_9dfc71b7","updated":"2014-07-29 07:26:09.000000000","message":"Will change it.","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"8f0d86b15f9b856d2ff3af498534ec51b6ec795f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"usage. Data center managers can maximize the rack density with the confidence"},{"line_number":31,"context_line":"that rack power budget will not be exceeded. During a power or thermal"},{"line_number":32,"context_line":"emergency, we can limit server power consumption and send alert to"},{"line_number":33,"context_line":"administrators via the pre-defined policy."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_e9a9bedd","line":33,"updated":"2014-07-28 15:31:45.000000000","message":"It would be good to state explicitly that this is intended to include support for the use-case where Ironic is _not_ managing the nodes (so that the approach described in [1] is not feasible), but also could be used as an alternative approach for Ironic-managed nodes as well?\n\n[1] https://github.com/openstack/ceilometer-specs/blob/master/specs/juno/ironic-notifications.rst","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"744d720298cd5ac4649ca610ae334389861044c1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"usage. Data center managers can maximize the rack density with the confidence"},{"line_number":31,"context_line":"that rack power budget will not be exceeded. During a power or thermal"},{"line_number":32,"context_line":"emergency, we can limit server power consumption and send alert to"},{"line_number":33,"context_line":"administrators via the pre-defined policy."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Proposed change"},{"line_number":36,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_472d1845","line":33,"in_reply_to":"baada198_e9a9bedd","updated":"2014-07-29 07:26:09.000000000","message":"Reasonable. Will add it.","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"8f0d86b15f9b856d2ff3af498534ec51b6ec795f","unresolved":false,"context_lines":[{"line_number":49,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":" watts                                        g              W               n"},{"line_number":51,"context_line":" temperature                                  g              degree          n"},{"line_number":52,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  * g \u003d gauge, n \u003d notification , p \u003d pollster"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_761bc97f","line":52,"updated":"2014-07-28 15:31:45.000000000","message":"Why not line the meter names up with the naming convention used by the notification handler that consumes IPMI notifications from Ironic, i.e.:\n\nhttps://github.com/openstack/ceilometer/blob/master/doc/source/measurements.rst#ironic-hardware-ipmi-sensor-data\n\nIt would be great if this spec was really just an alternative means of getting the *same* data from the IPMI, via an agent-per-node directly emitting samples as opposed to the ceilometer notification agent consuming notifications emitted by Ironic.\n\nSo deployers could choose which measurement scheme they wanted, but end up with the *same* meters being collected.","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"744d720298cd5ac4649ca610ae334389861044c1","unresolved":false,"context_lines":[{"line_number":49,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":50,"context_line":" watts                                        g              W               n"},{"line_number":51,"context_line":" temperature                                  g              degree          n"},{"line_number":52,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  * g \u003d gauge, n \u003d notification , p \u003d pollster"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_2784a40d","line":52,"in_reply_to":"baada198_761bc97f","updated":"2014-07-29 07:26:09.000000000","message":"ok. Will state it explicitly.","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"change_message_id":"83f32f00b0fb508388e793ab79f42ca3b80b4fa9","unresolved":false,"context_lines":[{"line_number":50,"context_line":" watts                                        g              W               n"},{"line_number":51,"context_line":" temperature                                  g              degree          n"},{"line_number":52,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  * g \u003d gauge, n \u003d notification , p \u003d pollster"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"IPMI is generic protocol, each vendor may add specific metric for their own"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_074240ab","line":53,"updated":"2014-07-29 06:46:42.000000000","message":"Fully agree. Consistency of the meters would be very useful when we look at horizon dashboards etc. so they would only need to written for one set. Other use cases would be power optimised scheduling.","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"8f0d86b15f9b856d2ff3af498534ec51b6ec795f","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* IPMI config option(default off) need to be added"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* an IPMI agent need to be added"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Developer impact"},{"line_number":120,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_a908a627","line":117,"updated":"2014-07-28 15:31:45.000000000","message":"an IPMI agent needs to be added *and deployed to _every_ node, along with ceilometer config such as the metering secret*","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"744d720298cd5ac4649ca610ae334389861044c1","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"* IPMI config option(default off) need to be added"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"* an IPMI agent need to be added"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Developer impact"},{"line_number":120,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"baada198_677e9c1d","line":117,"in_reply_to":"baada198_a908a627","updated":"2014-07-29 07:26:09.000000000","message":"Good comments","commit_id":"c95c7921eeb4eb6e98db9a6f0a119b2bb75ccb4e"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a4471a1e465a81af0321e0a6104aa02a45a35c37","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Line up metrics with IPMI support in Ironic, so we get same IPMI data regardless"},{"line_number":53,"context_line":"of the underlying method (an agent-per-node directly emitting samples, or the"},{"line_number":54,"context_line":"ceilometer notification agent consuming notifications emitted by Ironic):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":57,"context_line":"              Name                         Type             Unit           Origin"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_6a84990e","line":54,"updated":"2014-07-29 11:53:48.000000000","message":"Do I understand correctly that if we have Ironic in a deployment and this IPMI agent too, then we will get samples from both mechanisms? If yes, then is there a plan for turn off IPMI agent for Ironic managed nodes?","commit_id":"169a463ed225e702dd026703caa1fc3818e428f1"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"bc6cd5a7bfcd59bb1254919d3dfb9025c0f9c400","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Line up metrics with IPMI support in Ironic, so we get same IPMI data regardless"},{"line_number":53,"context_line":"of the underlying method (an agent-per-node directly emitting samples, or the"},{"line_number":54,"context_line":"ceilometer notification agent consuming notifications emitted by Ironic):"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":57,"context_line":"              Name                         Type             Unit           Origin"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_ac3a2dc2","line":54,"in_reply_to":"baada198_6a84990e","updated":"2014-07-30 05:24:34.000000000","message":"Choosing one should be done in deployment phase. We need some doc to ask user only deploy one if both available.","commit_id":"169a463ed225e702dd026703caa1fc3818e428f1"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a4471a1e465a81af0321e0a6104aa02a45a35c37","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Work Items"},{"line_number":152,"context_line":"----------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"1) an IPMI agent for data fetching deployed in each IPMI capable node."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_2aee21b6","line":152,"updated":"2014-07-29 11:53:48.000000000","message":"This section should contain the work items of the implementation of the feature.","commit_id":"169a463ed225e702dd026703caa1fc3818e428f1"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"bc6cd5a7bfcd59bb1254919d3dfb9025c0f9c400","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Work Items"},{"line_number":152,"context_line":"----------"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"1) an IPMI agent for data fetching deployed in each IPMI capable node."},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_8c78092e","line":152,"in_reply_to":"baada198_2aee21b6","updated":"2014-07-30 05:24:34.000000000","message":"remove 2) to avoid confusion","commit_id":"169a463ed225e702dd026703caa1fc3818e428f1"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a4471a1e465a81af0321e0a6104aa02a45a35c37","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Documentation Impact"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"None."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_ca368551","line":181,"updated":"2014-07-29 11:53:48.000000000","message":"The new meters and the new configuration requirements should be provided, please add a note about these here.","commit_id":"169a463ed225e702dd026703caa1fc3818e428f1"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"bc6cd5a7bfcd59bb1254919d3dfb9025c0f9c400","unresolved":false,"context_lines":[{"line_number":178,"context_line":"Documentation Impact"},{"line_number":179,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"None."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"References"}],"source_content_type":"text/x-rst","patch_set":5,"id":"baada198_cc5e8113","line":181,"in_reply_to":"baada198_ca368551","updated":"2014-07-30 05:24:34.000000000","message":"will add it","commit_id":"169a463ed225e702dd026703caa1fc3818e428f1"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"7faf708eecff4e087a62f4fecf4a0fe01f58e3a7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"containing IPMI sensor data, so that Ceilometer is possible to process these"},{"line_number":37,"context_line":"notifications for high level usage. But for nodes that are not managed by"},{"line_number":38,"context_line":"Ironic, IPMI data is still missing. This spec removes dependency on Ironic by"},{"line_number":39,"context_line":"adding IPMI support in Ceilometer, also serves as an alternative approach even"},{"line_number":40,"context_line":"Ironic is available."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_b0f8b74b","line":39,"updated":"2014-07-30 08:54:56.000000000","message":"According to my knowledge in Ceilometer notifications cannot be turned off for services. So if this agent is deployed on Ironic managed nodes, then it will be a duplicated solution, if Ironic does not support to turn off those notifications either. Do you have any information about this?","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"dc3b70aad69488540734cdc1a14efd2586b62857","unresolved":false,"context_lines":[{"line_number":36,"context_line":"containing IPMI sensor data, so that Ceilometer is possible to process these"},{"line_number":37,"context_line":"notifications for high level usage. But for nodes that are not managed by"},{"line_number":38,"context_line":"Ironic, IPMI data is still missing. This spec removes dependency on Ironic by"},{"line_number":39,"context_line":"adding IPMI support in Ceilometer, also serves as an alternative approach even"},{"line_number":40,"context_line":"Ironic is available."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_e60199b6","line":39,"in_reply_to":"baada198_863a9dc2","updated":"2014-07-30 09:18:50.000000000","message":"In this case it would be good to remove this alternative approach comment from here, because in reality it is not an alternative option as it shouldn\u0027t be deployed if a node is managed with Ironic. And also it would be good to add a half sentence into the docco section about this.","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"a0ea6ff263df3270d38c91e1c96dd1d0aafa33ef","unresolved":false,"context_lines":[{"line_number":36,"context_line":"containing IPMI sensor data, so that Ceilometer is possible to process these"},{"line_number":37,"context_line":"notifications for high level usage. But for nodes that are not managed by"},{"line_number":38,"context_line":"Ironic, IPMI data is still missing. This spec removes dependency on Ironic by"},{"line_number":39,"context_line":"adding IPMI support in Ceilometer, also serves as an alternative approach even"},{"line_number":40,"context_line":"Ironic is available."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_863a9dc2","line":39,"in_reply_to":"baada198_b0f8b74b","updated":"2014-07-30 09:12:13.000000000","message":"Yes, notification cannot be turned off. In this situation, end user should not deploy IPMI agent in Ironic managed nodes. we need state it in document.","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"aff7df8b4a978f5ccf3e9fc2c870ee23ce74e8b1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"containing IPMI sensor data, so that Ceilometer is possible to process these"},{"line_number":37,"context_line":"notifications for high level usage. But for nodes that are not managed by"},{"line_number":38,"context_line":"Ironic, IPMI data is still missing. This spec removes dependency on Ironic by"},{"line_number":39,"context_line":"adding IPMI support in Ceilometer, also serves as an alternative approach even"},{"line_number":40,"context_line":"Ironic is available."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Proposed change"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_f7906144","line":39,"in_reply_to":"baada198_e60199b6","updated":"2014-07-30 10:57:39.000000000","message":"Remove \"alternative\" statement and will add notice in \"documentation impact\"","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"7faf708eecff4e087a62f4fecf4a0fe01f58e3a7","unresolved":false,"context_lines":[{"line_number":57,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":"              Name                         Type             Unit           Origin"},{"line_number":59,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":" hardware.ipmi.fan                            g              RPM             n"},{"line_number":61,"context_line":" hardware.ipmi.temperature                    g              C               n"},{"line_number":62,"context_line":" hardware.ipmi.current                        g              W               n"},{"line_number":63,"context_line":" hardware.ipmi.voltage                        g              V               n"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_b0735715","line":60,"updated":"2014-07-30 08:54:56.000000000","message":"The data in this solution is gathered by polling instead of notifications, right?","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"a0ea6ff263df3270d38c91e1c96dd1d0aafa33ef","unresolved":false,"context_lines":[{"line_number":57,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":58,"context_line":"              Name                         Type             Unit           Origin"},{"line_number":59,"context_line":" \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d         \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d   \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":" hardware.ipmi.fan                            g              RPM             n"},{"line_number":61,"context_line":" hardware.ipmi.temperature                    g              C               n"},{"line_number":62,"context_line":" hardware.ipmi.current                        g              W               n"},{"line_number":63,"context_line":" hardware.ipmi.voltage                        g              V               n"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_e670b9a9","line":60,"in_reply_to":"baada198_b0735715","updated":"2014-07-30 09:12:13.000000000","message":"yes, will change it","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"7faf708eecff4e087a62f4fecf4a0fe01f58e3a7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Pipeline impact"},{"line_number":107,"context_line":"---------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Need new IPMI agent required to host the data acquisition pollsters"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_c35ba720","line":109,"updated":"2014-07-30 08:54:56.000000000","message":"Does this have explicit pipeline impact?","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"dc3b70aad69488540734cdc1a14efd2586b62857","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Pipeline impact"},{"line_number":107,"context_line":"---------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Need new IPMI agent required to host the data acquisition pollsters"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_661ca915","line":109,"in_reply_to":"baada198_868ffd75","updated":"2014-07-30 09:18:50.000000000","message":"Yes please, as this comment is really only about the agent and has nothing to do with the pipeline itself.","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"a0ea6ff263df3270d38c91e1c96dd1d0aafa33ef","unresolved":false,"context_lines":[{"line_number":106,"context_line":"Pipeline impact"},{"line_number":107,"context_line":"---------------"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"Need new IPMI agent required to host the data acquisition pollsters"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Other end user impact"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_868ffd75","line":109,"in_reply_to":"baada198_c35ba720","updated":"2014-07-30 09:12:13.000000000","message":"Should not have explicit pipeline impact, as this agent is specific agent on each IPMI on each IPMI capable nodes. Maybe remove it?","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"7faf708eecff4e087a62f4fecf4a0fe01f58e3a7","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Work Items"},{"line_number":156,"context_line":"----------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"* an IPMI agent for data fetching deployed in each IPMI capable node."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Future lifecycle"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_e35a6bf4","line":158,"updated":"2014-07-30 08:54:56.000000000","message":"This work item still looks like a deployment work item rather than an implementation related one to me.\n\nSo this section is about to specify what is needed to be implemented in order to mark the BP as implemented. Like implement the IPMI agent, add tests and documentation, etc.","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"a0ea6ff263df3270d38c91e1c96dd1d0aafa33ef","unresolved":false,"context_lines":[{"line_number":155,"context_line":"Work Items"},{"line_number":156,"context_line":"----------"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"* an IPMI agent for data fetching deployed in each IPMI capable node."},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Future lifecycle"}],"source_content_type":"text/x-rst","patch_set":7,"id":"baada198_06ebed12","line":158,"in_reply_to":"baada198_e35a6bf4","updated":"2014-07-30 09:12:13.000000000","message":"Will change it to \"Implement an IPMI agent for data fetching deployed in each IPMI capable node\"","commit_id":"dd53ad8be176d8657537d2b5996472a773c9d690"}]}