)]}'
{"specs/kilo/hyper-v-disk-iops-metrics.rst":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"32c453bf6d26dc0760468a5fb01b7de8da07d94c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add DiskIOPSPollster and PerDeviceDiskIOPSPollster pollsters, which create samples having the properties:"},{"line_number":30,"context_line":"* name: \u0027disk.iops\u0027"},{"line_number":31,"context_line":"* type: \u0027gauge\u0027"},{"line_number":32,"context_line":"* unit: \u0027count/second\u0027"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_634b4b87","line":29,"updated":"2014-12-22 13:06:49.000000000","message":"too long line?","commit_id":"8b429ff8703c55cd9b011e4ef992855ab9d0704d"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d08b391da10b0e579f0fdca512955f8cccfb5033","unresolved":false,"context_lines":[{"line_number":26,"context_line":"Proposed change"},{"line_number":27,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Add DiskIOPSPollster and PerDeviceDiskIOPSPollster pollsters, which create samples having the properties:"},{"line_number":30,"context_line":"* name: \u0027disk.iops\u0027"},{"line_number":31,"context_line":"* type: \u0027gauge\u0027"},{"line_number":32,"context_line":"* unit: \u0027count/second\u0027"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_dd7bf7f2","line":29,"in_reply_to":"3a961159_634b4b87","updated":"2014-12-22 15:55:19.000000000","message":"Done","commit_id":"8b429ff8703c55cd9b011e4ef992855ab9d0704d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"32c453bf6d26dc0760468a5fb01b7de8da07d94c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Pipeline impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Other end user impact"},{"line_number":72,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_035c474a","line":69,"updated":"2014-12-22 13:06:49.000000000","message":"it\u0027s strange that you posted \u0027Users will have to add meter \u0027disk.iops\u0027 in the disk_source source in pipeline.yaml\u0027 to the other deployer impact, but did not mention here :)","commit_id":"8b429ff8703c55cd9b011e4ef992855ab9d0704d"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"d08b391da10b0e579f0fdca512955f8cccfb5033","unresolved":false,"context_lines":[{"line_number":66,"context_line":"Pipeline impact"},{"line_number":67,"context_line":"---------------"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Other end user impact"},{"line_number":72,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3a961159_7d6a031b","line":69,"in_reply_to":"3a961159_035c474a","updated":"2014-12-22 15:55:19.000000000","message":"Yeah, that line should have been added here. :)","commit_id":"8b429ff8703c55cd9b011e4ef992855ab9d0704d"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2332848df54a0f6cddd57c4c41773ebc912e4c41","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* unit: \u0027count/second\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add \u0027iops_count\u0027 to the DiskStats object and add this field to the DiskStats"},{"line_number":36,"context_line":"object returned by the \u0027inspect_disks\u0027 method in HyperVInspector."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The metric value will be fetched from Hyper-V VMs, located in the"},{"line_number":39,"context_line":"Msvm_AggregationMetricValue object (further refered to as metric object)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_ca14e145","line":36,"updated":"2014-12-24 04:42:41.000000000","message":"If it is returned by inspect_disks, when hypervisor_type is set to libvirt, then we should handle the case of no iops is set.\n\nIf we define a new method, then Ceilometer.NotImplementedError will be raised, which seems better\n\nI personally prefer the second one, see what we do for cpu_util: https://github.com/openstack/ceilometer/blob/master/ceilometer/compute/virt/inspector.py#L162","commit_id":"1c48a18e595718e4a55fcbf6c7de97604e242829"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"1498b36d757aa7c5e0c3e11f9cb3b1406bc395c4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"* unit: \u0027count/second\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Add \u0027iops_count\u0027 to the DiskStats object and add this field to the DiskStats"},{"line_number":36,"context_line":"object returned by the \u0027inspect_disks\u0027 method in HyperVInspector."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The metric value will be fetched from Hyper-V VMs, located in the"},{"line_number":39,"context_line":"Msvm_AggregationMetricValue object (further refered to as metric object)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_7b5acb2b","line":36,"in_reply_to":"3a961159_ca14e145","updated":"2014-12-25 07:27:23.000000000","message":"due to the spec\u0027s work items \"* Adds the \u0027iops_count\u0027 field to the returned DiskStats object to the \u0027inspect_disks\u0027 method in HyperVInspector.\" - this will be added to the inspect_disks method. i prefer your variant with other method as well, this will protect us from handling separately all other backends here.","commit_id":"1c48a18e595718e4a55fcbf6c7de97604e242829"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"722be10000f66071a38ec4f4e320a832d8f87f55","unresolved":false,"context_lines":[{"line_number":70,"context_line":"---------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Users will have to add the meter \u0027disk.iops\u0027 in the disk_source source in"},{"line_number":73,"context_line":"pipeline.yaml instead of \u0027disk.read.requests\u0027 and \u0027disk.write.requests\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Other end user impact"},{"line_number":76,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_9f636719","line":73,"updated":"2015-01-05 19:13:42.000000000","message":"Can you please clarify the point here?\nIf I want to collect the data from the new Windows version I will add the disk.iops but do I need to remove the disk.read/write.requests?\nWhat is going to happen if the user leaves the disk.read/write.requests and simply adds the disk.iops?","commit_id":"423d2ea65916941186684c4c2d5a1c8ed9b543f3"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"5215818f8740879ed805fbe3206baa5cffba7823","unresolved":false,"context_lines":[{"line_number":70,"context_line":"---------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Users will have to add the meter \u0027disk.iops\u0027 in the disk_source source in"},{"line_number":73,"context_line":"pipeline.yaml instead of \u0027disk.read.requests\u0027 and \u0027disk.write.requests\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Other end user impact"},{"line_number":76,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_e5a13cf8","line":73,"in_reply_to":"3a961159_9f636719","updated":"2015-01-05 19:59:27.000000000","message":"Sure. So, having disk.read/write.requests there has no use, since it will just report 0 every time (there are no such metrics, hence the need for disk.iops), so having disk.read.requests and disk.write.requests is useless on Windows, even bad in fact, since it will only report zeroes.","commit_id":"423d2ea65916941186684c4c2d5a1c8ed9b543f3"},{"author":{"_account_id":7052,"name":"Fabio Giannetti","email":"fgiannet@cisco.com","username":"fabgia"},"change_message_id":"dbf5dfe844b366126a7680ea597f1517e65a8d6c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"---------------"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Users will have to add the meter \u0027disk.iops\u0027 in the disk_source source in"},{"line_number":73,"context_line":"pipeline.yaml instead of \u0027disk.read.requests\u0027 and \u0027disk.write.requests\u0027."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Other end user impact"},{"line_number":76,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3a961159_10a12446","line":73,"in_reply_to":"3a961159_e5a13cf8","updated":"2015-01-05 20:59:47.000000000","message":"Thanks, I understand now. I think it would be good to extend this session with the same explanation so when the docs are made they will give a hint to the user.","commit_id":"423d2ea65916941186684c4c2d5a1c8ed9b543f3"}]}