)]}'
{"specs/kilo/disk-info-meters.rst":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/disk-info-meters"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_8e2057b1","line":13,"updated":"2015-01-16 01:46:31.000000000","message":"remove extra blank lines ?","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/disk-info-meters"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Problem description"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b1bacf08","line":13,"in_reply_to":"3a961159_8e2057b1","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently, Libvirt Inspector does not collect disk capacity, usage and "},{"line_number":20,"context_line":"allocation metrics. This feature can be added for Libvirt to monitor disk"},{"line_number":21,"context_line":"metrics : capacity, usage and allocation."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_ce4fbf8a","line":19,"updated":"2015-01-16 01:46:31.000000000","message":"remove trailing spaces ?","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Problem description"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Currently, Libvirt Inspector does not collect disk capacity, usage and "},{"line_number":20,"context_line":"allocation metrics. This feature can be added for Libvirt to monitor disk"},{"line_number":21,"context_line":"metrics : capacity, usage and allocation."},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_f137f7ad","line":19,"in_reply_to":"3a961159_ce4fbf8a","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a702a1bae66ecd1a6568fc29af5adcb2964461d3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Implemet the method \u0027inspect_disk_info\u0027 in Inspector for Libvirt. This method "},{"line_number":27,"context_line":"will return the disk capacity,usage and allocation per device. The values"},{"line_number":28,"context_line":"correspond to values monitored by domblkinfo command of Libvirt."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_7446a022","line":26,"updated":"2015-01-15 21:33:23.000000000","message":"s/Implemet/Implement/","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Proposed change"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Implemet the method \u0027inspect_disk_info\u0027 in Inspector for Libvirt. This method "},{"line_number":27,"context_line":"will return the disk capacity,usage and allocation per device. The values"},{"line_number":28,"context_line":"correspond to values monitored by domblkinfo command of Libvirt."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_113ba39c","line":26,"in_reply_to":"3a961159_7446a022","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":27,"context_line":"will return the disk capacity,usage and allocation per device. The values"},{"line_number":28,"context_line":"correspond to values monitored by domblkinfo command of Libvirt."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Add CapacityPollster which create sample :"},{"line_number":31,"context_line":"* name\u003d\u0027disk.capacity\u0027"},{"line_number":32,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":33,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_e94d5573","line":30,"updated":"2015-01-16 01:46:31.000000000","message":"I\u0027m not sure if it is a good idea, since these pollsters already in disk.py, but maybe we add a prefix Disk is better? the following pollsters too?\n\nDiskCapacityPollster","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"will return the disk capacity,usage and allocation per device. The values"},{"line_number":28,"context_line":"correspond to values monitored by domblkinfo command of Libvirt."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Add CapacityPollster which create sample :"},{"line_number":31,"context_line":"* name\u003d\u0027disk.capacity\u0027"},{"line_number":32,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":33,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_9191539c","line":30,"in_reply_to":"3a961159_e94d5573","updated":"2015-01-16 04:25:09.000000000","message":"I named it referring already implemented pollsters. As ReadRequestsRatePollster did not have Disk as prefix so I avoided adding in new pollsters.","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":43,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Add PerDeviceAllocationPollster which create sample :"},{"line_number":46,"context_line":"* name\u003d\u0027disk.device.capacity\u0027"},{"line_number":47,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":48,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_ee18fb85","line":46,"updated":"2015-01-16 01:46:31.000000000","message":"-1: disk.device.allocation","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Add PerDeviceAllocationPollster which create sample :"},{"line_number":46,"context_line":"* name\u003d\u0027disk.device.capacity\u0027"},{"line_number":47,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":48,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_112f23f7","line":46,"in_reply_to":"3a961159_ee18fb85","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":48,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Add PhysicalPollster which create sample :"},{"line_number":51,"context_line":"* name\u003d\u0027disk.usage\u0027"},{"line_number":52,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":53,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_4920299a","line":50,"updated":"2015-01-16 01:46:31.000000000","message":"what the Physical means? why don\u0027t use word Usage?","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":48,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Add PhysicalPollster which create sample :"},{"line_number":51,"context_line":"* name\u003d\u0027disk.usage\u0027"},{"line_number":52,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":53,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_31233f59","line":50,"in_reply_to":"3a961159_4920299a","updated":"2015-01-16 04:25:09.000000000","message":"domblkinfo of Libvirt returns 3 statistics of device : capacity , allocation and physical. From users perspective , usage made sense rather than calling it physical . So I mapped physical attribute to disk.usage rather than disk.physical. But at the same time , kept the implementation verbiage near to domblkinfo verbiage , so called the class name as Physical Pollster.","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Other deployer impact"},{"line_number":98,"context_line":"---------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"In pipeline.yaml , if user is not having * in meters_sink"},{"line_number":101,"context_line":"then new meters disk.capacity, disk.allocation, disk.usage, "},{"line_number":102,"context_line":"disk.device.capacity and disk.device.allocation needs to be added"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_8e07771c","line":100,"updated":"2015-01-16 01:46:31.000000000","message":"remove extra space before , ?","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":97,"context_line":"Other deployer impact"},{"line_number":98,"context_line":"---------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"In pipeline.yaml , if user is not having * in meters_sink"},{"line_number":101,"context_line":"then new meters disk.capacity, disk.allocation, disk.usage, "},{"line_number":102,"context_line":"disk.device.capacity and disk.device.allocation needs to be added"},{"line_number":103,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_911b131b","line":100,"in_reply_to":"3a961159_8e07771c","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":98,"context_line":"---------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"In pipeline.yaml , if user is not having * in meters_sink"},{"line_number":101,"context_line":"then new meters disk.capacity, disk.allocation, disk.usage, "},{"line_number":102,"context_line":"disk.device.capacity and disk.device.allocation needs to be added"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_4e12ef61","line":101,"updated":"2015-01-16 01:46:31.000000000","message":"ditto","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":98,"context_line":"---------------------"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"In pipeline.yaml , if user is not having * in meters_sink"},{"line_number":101,"context_line":"then new meters disk.capacity, disk.allocation, disk.usage, "},{"line_number":102,"context_line":"disk.device.capacity and disk.device.allocation needs to be added"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Developer impact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_b1164ff0","line":101,"in_reply_to":"3a961159_4e12ef61","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a702a1bae66ecd1a6568fc29af5adcb2964461d3","unresolved":false,"context_lines":[{"line_number":114,"context_line":"-----------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Primary assignee:"},{"line_number":117,"context_line":"  \u003cahmed-nooras-saba\u003e"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_94686c89","line":117,"updated":"2015-01-15 21:33:23.000000000","message":"you can drop the \u0027\u003c\u0027 and \u0027\u003e\u0027","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"-----------"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Primary assignee:"},{"line_number":117,"context_line":"  \u003cahmed-nooras-saba\u003e"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"Work Items"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d1111bf9","line":117,"in_reply_to":"3a961159_94686c89","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":124,"context_line":"* all devices"},{"line_number":125,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk "},{"line_number":126,"context_line":"* metrics at intance level"},{"line_number":127,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and "},{"line_number":128,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_ae027309","line":125,"updated":"2015-01-16 01:46:31.000000000","message":"ditto","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":124,"context_line":"* all devices"},{"line_number":125,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk "},{"line_number":126,"context_line":"* metrics at intance level"},{"line_number":127,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and "},{"line_number":128,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_31da5f4b","line":125,"in_reply_to":"3a961159_ae027309","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":123,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":124,"context_line":"* all devices"},{"line_number":125,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk "},{"line_number":126,"context_line":"* metrics at intance level"},{"line_number":127,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and "},{"line_number":128,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"},{"line_number":129,"context_line":"* Add inspect_disk_info to Libvirt inspectors"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_cefdff0a","line":126,"updated":"2015-01-16 01:46:31.000000000","message":"instance","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":123,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":124,"context_line":"* all devices"},{"line_number":125,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk "},{"line_number":126,"context_line":"* metrics at intance level"},{"line_number":127,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and "},{"line_number":128,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"},{"line_number":129,"context_line":"* Add inspect_disk_info to Libvirt inspectors"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_51dd2b40","line":126,"in_reply_to":"3a961159_cefdff0a","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":127,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and "},{"line_number":128,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"},{"line_number":129,"context_line":"* Add inspect_disk_info to Libvirt inspectors"},{"line_number":130,"context_line":"* Add new metrics definition in measurement.rst"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Future lifecycle"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_4909092a","line":130,"updated":"2015-01-16 01:46:31.000000000","message":"measurements.rst","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":127,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and "},{"line_number":128,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"},{"line_number":129,"context_line":"* Add inspect_disk_info to Libvirt inspectors"},{"line_number":130,"context_line":"* Add new metrics definition in measurement.rst"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Future lifecycle"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_91e233ff","line":130,"in_reply_to":"3a961159_4909092a","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a702a1bae66ecd1a6568fc29af5adcb2964461d3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"None"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_3426d867","line":142,"updated":"2015-01-15 21:33:23.000000000","message":"is there a minimum libvirt version required?","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":139,"context_line":"Dependencies"},{"line_number":140,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"None"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"Testing"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_51ab6b87","line":142,"in_reply_to":"3a961159_3426d867","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"731e1f51be30836fad2ca8660c97451f0b73d164","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Documentation Impact"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Added the following metrics in ceilometer/doc/source/measurements.rst and "},{"line_number":157,"context_line":"\"measurement section\" of "},{"line_number":158,"context_line":"http://docs.openstack.org/developer/ceilometer/measurements.html needs to "},{"line_number":159,"context_line":"be updated."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_c9141943","line":156,"updated":"2015-01-16 01:46:31.000000000","message":"ditto, trailing space","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":153,"context_line":"Documentation Impact"},{"line_number":154,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"Added the following metrics in ceilometer/doc/source/measurements.rst and "},{"line_number":157,"context_line":"\"measurement section\" of "},{"line_number":158,"context_line":"http://docs.openstack.org/developer/ceilometer/measurements.html needs to "},{"line_number":159,"context_line":"be updated."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_11be43d4","line":156,"in_reply_to":"3a961159_c9141943","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a702a1bae66ecd1a6568fc29af5adcb2964461d3","unresolved":false,"context_lines":[{"line_number":170,"context_line":"References"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_34ddf841","line":173,"updated":"2015-01-15 21:33:23.000000000","message":"any links to libvirt docs which show what attribute matches with corresponding metric?","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"1cd35b1446e7b4a44c9404ff1bbb80e021de9acc","unresolved":false,"context_lines":[{"line_number":170,"context_line":"References"},{"line_number":171,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"None"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a961159_d1e91bac","line":173,"in_reply_to":"3a961159_34ddf841","updated":"2015-01-16 04:25:09.000000000","message":"Done","commit_id":"83e7e1bd9e67150d7620b9bf398520d389a86bd7"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":24,"context_line":"will return the disk capacity,usage and allocation per device. The values"},{"line_number":25,"context_line":"correspond to values monitored by domblkinfo command of Libvirt."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Add CapacityPollster which create sample :"},{"line_number":28,"context_line":"* name\u003d\u0027disk.capacity\u0027"},{"line_number":29,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":30,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_5420b999","line":27,"updated":"2015-01-16 04:58:19.000000000","message":"you need an empty line here, otherwise the following can not be displayed correctly.\n\nPlease use http://rst.ninjs.org/ to see what\u0027s the your final display output of the rst file","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"will return the disk capacity,usage and allocation per device. The values"},{"line_number":25,"context_line":"correspond to values monitored by domblkinfo command of Libvirt."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Add CapacityPollster which create sample :"},{"line_number":28,"context_line":"* name\u003d\u0027disk.capacity\u0027"},{"line_number":29,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":30,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_34324d5e","line":27,"in_reply_to":"3a961159_5420b999","updated":"2015-01-16 16:07:27.000000000","message":"Thanks for the help.Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":30,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add PerDeviceCapacityPollster which create sample :"},{"line_number":33,"context_line":"* name\u003d\u0027disk.device.capacity\u0027"},{"line_number":34,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":35,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_9435c1dc","line":32,"updated":"2015-01-16 04:58:19.000000000","message":"ditto","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":30,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Add PerDeviceCapacityPollster which create sample :"},{"line_number":33,"context_line":"* name\u003d\u0027disk.device.capacity\u0027"},{"line_number":34,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":35,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_54351943","line":32,"in_reply_to":"3a961159_9435c1dc","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":35,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Add AllocationPollster which create sample :"},{"line_number":38,"context_line":"* name\u003d\u0027disk.allocation\u0027"},{"line_number":39,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":40,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_d42bc979","line":37,"updated":"2015-01-16 04:58:19.000000000","message":"ditto","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":35,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Add AllocationPollster which create sample :"},{"line_number":38,"context_line":"* name\u003d\u0027disk.allocation\u0027"},{"line_number":39,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":40,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_743f7525","line":37,"in_reply_to":"3a961159_d42bc979","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":40,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add PerDeviceAllocationPollster which create sample :"},{"line_number":43,"context_line":"* name\u003d\u0027disk.device.allocation\u0027"},{"line_number":44,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":45,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_f44d2573","line":42,"updated":"2015-01-16 04:58:19.000000000","message":"ditto","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":40,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Add PerDeviceAllocationPollster which create sample :"},{"line_number":43,"context_line":"* name\u003d\u0027disk.device.allocation\u0027"},{"line_number":44,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":45,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_943a2132","line":42,"in_reply_to":"3a961159_f44d2573","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":45,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Add PhysicalPollster which create sample :"},{"line_number":48,"context_line":"* name\u003d\u0027disk.usage\u0027"},{"line_number":49,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":50,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_34540dfd","line":47,"updated":"2015-01-16 04:58:19.000000000","message":"ditto","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":45,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Add PhysicalPollster which create sample :"},{"line_number":48,"context_line":"* name\u003d\u0027disk.usage\u0027"},{"line_number":49,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":50,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_b4455db5","line":47,"in_reply_to":"3a961159_34540dfd","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":49,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":50,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Add PerDevicePhysicalPollster which create sample :"},{"line_number":53,"context_line":"* name\u003d\u0027disk.device.usage\u0027"},{"line_number":54,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":55,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_74413538","line":52,"updated":"2015-01-16 04:58:19.000000000","message":"ditto","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":50,"context_line":"* unit\u003d\u0027B\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Add PerDevicePhysicalPollster which create sample :"},{"line_number":53,"context_line":"* name\u003d\u0027disk.device.usage\u0027"},{"line_number":54,"context_line":"* type\u003dsample.TYPE_GAUGE"},{"line_number":55,"context_line":"* unit\u003d\u0027B\u0027"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_d44029a4","line":52,"in_reply_to":"3a961159_74413538","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"df16b0be91170f8734d16177e8d16821e968b165","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"In pipeline.yaml, if user is not having * in meters_sink"},{"line_number":98,"context_line":"then new meters disk.capacity, disk.allocation, disk.usage,"},{"line_number":99,"context_line":"disk.device.capacity and disk.device.allocation needs to be added"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Developer impact"},{"line_number":102,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_cf733614","line":99,"updated":"2015-01-16 07:21:11.000000000","message":"miss disk.device.usage?","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"In pipeline.yaml, if user is not having * in meters_sink"},{"line_number":98,"context_line":"then new meters disk.capacity, disk.allocation, disk.usage,"},{"line_number":99,"context_line":"disk.device.capacity and disk.device.allocation needs to be added"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Developer impact"},{"line_number":102,"context_line":"----------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_0106e31b","line":99,"in_reply_to":"3a961159_cf733614","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":118,"context_line":"----------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":121,"context_line":"* all devices"},{"line_number":122,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk"},{"line_number":123,"context_line":"* metrics at instance level"},{"line_number":124,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_346b2dba","line":121,"updated":"2015-01-16 04:58:19.000000000","message":"no need for the prepending * because they\u0027re in the same line as the above line, otherwise it can\u0027t be displayed correctly.","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"df16b0be91170f8734d16177e8d16821e968b165","unresolved":false,"context_lines":[{"line_number":118,"context_line":"----------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":121,"context_line":"* all devices"},{"line_number":122,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk"},{"line_number":123,"context_line":"* metrics at instance level"},{"line_number":124,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_8f6dae34","line":121,"in_reply_to":"3a961159_346b2dba","updated":"2015-01-16 07:21:11.000000000","message":"@ahmed-nooras-saba\n\nyou can use tox -edocs to get build files, or click jenkins ci result docs:gate-ceilometer-specs-docs to find you page, and check the displays","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"----------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":121,"context_line":"* all devices"},{"line_number":122,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk"},{"line_number":123,"context_line":"* metrics at instance level"},{"line_number":124,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_8119f37b","line":121,"in_reply_to":"3a961159_346b2dba","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"----------"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":121,"context_line":"* all devices"},{"line_number":122,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk"},{"line_number":123,"context_line":"* metrics at instance level"},{"line_number":124,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_b44abdaa","line":121,"in_reply_to":"3a961159_346b2dba","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":120,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":121,"context_line":"* all devices"},{"line_number":122,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk"},{"line_number":123,"context_line":"* metrics at instance level"},{"line_number":124,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and"},{"line_number":125,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"},{"line_number":126,"context_line":"* Add inspect_disk_info to Libvirt inspectors"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_546ef9c8","line":123,"updated":"2015-01-16 04:58:19.000000000","message":"ditto","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"* Add _DiskInfoPollsterBase base class to reading values and aggregating for"},{"line_number":121,"context_line":"* all devices"},{"line_number":122,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk"},{"line_number":123,"context_line":"* metrics at instance level"},{"line_number":124,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and"},{"line_number":125,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"},{"line_number":126,"context_line":"* Add inspect_disk_info to Libvirt inspectors"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_f4c7e50f","line":123,"in_reply_to":"3a961159_546ef9c8","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":122,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk"},{"line_number":123,"context_line":"* metrics at instance level"},{"line_number":124,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and"},{"line_number":125,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"},{"line_number":126,"context_line":"* Add inspect_disk_info to Libvirt inspectors"},{"line_number":127,"context_line":"* Add new metrics definition in measurements.rst"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_946301dc","line":125,"updated":"2015-01-16 04:58:19.000000000","message":"ditto","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"* Add CapacityPollster , AllocationPollster , PhysicalPollster for disk"},{"line_number":123,"context_line":"* metrics at instance level"},{"line_number":124,"context_line":"* Add PerDeviceCapacityPollster , PerDeviceAllocationPollster and"},{"line_number":125,"context_line":"* PerDevicePhysicalPollster for disk metrics at device level of an instance"},{"line_number":126,"context_line":"* Add inspect_disk_info to Libvirt inspectors"},{"line_number":127,"context_line":"* Add new metrics definition in measurements.rst"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_14cb911e","line":125,"in_reply_to":"3a961159_946301dc","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":155,"context_line":"http://docs.openstack.org/developer/ceilometer/measurements.html needs to"},{"line_number":156,"context_line":"be updated."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"disk.capacity           g B inst ID n 1 Capacity of disk in B"},{"line_number":159,"context_line":"disk.allocation         g B inst ID n 1 Allocation of disk in B"},{"line_number":160,"context_line":"disk.usage              g B inst ID n 1 Usage of disk in B"},{"line_number":161,"context_line":"disk.device.capacity    g B inst ID n 1 Capacity per device of disk in B"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_d459092a","line":158,"updated":"2015-01-16 04:58:19.000000000","message":"the following can\u0027t be displayed correctly","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":155,"context_line":"http://docs.openstack.org/developer/ceilometer/measurements.html needs to"},{"line_number":156,"context_line":"be updated."},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"disk.capacity           g B inst ID n 1 Capacity of disk in B"},{"line_number":159,"context_line":"disk.allocation         g B inst ID n 1 Allocation of disk in B"},{"line_number":160,"context_line":"disk.usage              g B inst ID n 1 Usage of disk in B"},{"line_number":161,"context_line":"disk.device.capacity    g B inst ID n 1 Capacity per device of disk in B"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_263bf5ea","line":158,"in_reply_to":"3a961159_d459092a","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b8c8704d5a7ce6a8c5696659d08edf36b1569d32","unresolved":false,"context_lines":[{"line_number":158,"context_line":"disk.capacity           g B inst ID n 1 Capacity of disk in B"},{"line_number":159,"context_line":"disk.allocation         g B inst ID n 1 Allocation of disk in B"},{"line_number":160,"context_line":"disk.usage              g B inst ID n 1 Usage of disk in B"},{"line_number":161,"context_line":"disk.device.capacity    g B inst ID n 1 Capacity per device of disk in B"},{"line_number":162,"context_line":"disk.device.allocation  g B inst ID n 1 Allocation per device of disk in B"},{"line_number":163,"context_line":"disk.device.usage       g B inst ID n 1 Usage per device of disk in B"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_f4828550","line":161,"updated":"2015-01-16 04:58:19.000000000","message":"I don\u0027t think it\u0027s right to use only instID as the resource_id for the per device metrics. It should be the combination of instID and deviceID.","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"},{"author":{"_account_id":14551,"name":"Saba","email":"ahmed.nooras.saba@gmail.com","username":"ansaba"},"change_message_id":"46800309bd524b54b902fafc2ba022123a95994d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"disk.capacity           g B inst ID n 1 Capacity of disk in B"},{"line_number":159,"context_line":"disk.allocation         g B inst ID n 1 Allocation of disk in B"},{"line_number":160,"context_line":"disk.usage              g B inst ID n 1 Usage of disk in B"},{"line_number":161,"context_line":"disk.device.capacity    g B inst ID n 1 Capacity per device of disk in B"},{"line_number":162,"context_line":"disk.device.allocation  g B inst ID n 1 Allocation per device of disk in B"},{"line_number":163,"context_line":"disk.device.usage       g B inst ID n 1 Usage per device of disk in B"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3a961159_66209db0","line":161,"in_reply_to":"3a961159_f4828550","updated":"2015-01-16 16:07:27.000000000","message":"Done","commit_id":"2cb2103641ce4dd073685dc0d5d63dfa4c4f58a4"}]}