)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d86ee35363e3f6bca14bbdaeeca2933a2ab1567f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keep obsolete meters for one release"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reanme and deletion of meters would keep obsolete for one release to"},{"line_number":10,"context_line":"keep compatibility"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8fbb09e15db861e19737d9fc573bcc1f5f17bb08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa32b979_4ff21571","line":9,"updated":"2015-06-15 21:09:23.000000000","message":"Hmm, if I remember correctly we agreed on two releases, like for the API changes.","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"0b8c0c07ce08b14d22de3c780f9fa59bdc08c95d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keep obsolete meters for one release"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reanme and deletion of meters would keep obsolete for one release to"},{"line_number":10,"context_line":"keep compatibility"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8fbb09e15db861e19737d9fc573bcc1f5f17bb08"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1af86dd1_305cea24","line":9,"updated":"2015-06-12 16:35:16.000000000","message":"Rename","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"}],"specs/liberty/meters-decrepit-period.rst":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"4310bf371547e78208af0e43721107414b911a8f","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- Show meter /v2/meters/{meter_name}"},{"line_number":56,"context_line":"- Create meter /v2/meters/{meter_name}"},{"line_number":57,"context_line":"- Show meter statistics /v2/meters/{meter_name}/statistics"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"In other words, the behavior of these API changes a little bit when meter_name"},{"line_number":60,"context_line":"is renamed or deleted."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_d59c516b","line":57,"updated":"2015-05-15 08:49:51.000000000","message":"we have /v2/samples?q.filed\u003dmeter\u0026q.value\u003dxxx and /v2/query/samples","commit_id":"ed4386187d61ac912a32ea9ea273374659ac295c"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"842c7d2bf60da22870e2987dbe7a7b7d0f099dd1","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- Show meter /v2/meters/{meter_name}"},{"line_number":56,"context_line":"- Create meter /v2/meters/{meter_name}"},{"line_number":57,"context_line":"- Show meter statistics /v2/meters/{meter_name}/statistics"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"In other words, the behavior of these API changes a little bit when meter_name"},{"line_number":60,"context_line":"is renamed or deleted."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a016987_c5bc5408","line":57,"in_reply_to":"7a016987_d59c516b","updated":"2015-05-19 07:57:11.000000000","message":"Is /v2/query/ official API for Ceilometer? I can\u0027t find it in API doc.\n\nSo we can check if any \"q.filed\u003dmeter\" and replace \"q.value\u003dxxx\". Is it enough for all the query specifying meter?","commit_id":"ed4386187d61ac912a32ea9ea273374659ac295c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1ef1751a379eaa5cc268ec76d6aea1c20b01a0b","unresolved":false,"context_lines":[{"line_number":5,"context_line":" http://creativecommons.org/licenses/by/3.0/legalcode"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":8,"context_line":"Example Spec - The title of your blueprint"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/meters-decrepit-period"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_47e9f319","line":8,"updated":"2015-06-05 14:00:28.000000000","message":"add title","commit_id":"abe2c3b9117a514b4dee0ec81443c401d8cbcf82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1ef1751a379eaa5cc268ec76d6aea1c20b01a0b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Example Spec - The title of your blueprint"},{"line_number":9,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/meters-decrepit-period"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint add one deprecation period for renamed or deleted meters, in"},{"line_number":14,"context_line":"which, end user can still access these meters."}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_e7f7bff3","line":11,"updated":"2015-06-05 14:00:28.000000000","message":"i don\u0027t think decrepit is the right word you\u0027re looking for... meter-deprecation-period?","commit_id":"abe2c3b9117a514b4dee0ec81443c401d8cbcf82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1ef1751a379eaa5cc268ec76d6aea1c20b01a0b","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"https://blueprints.launchpad.net/ceilometer/+spec/meters-decrepit-period"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This blueprint add one deprecation period for renamed or deleted meters, in"},{"line_number":14,"context_line":"which, end user can still access these meters."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_67bbcf0f","line":13,"updated":"2015-06-05 14:00:28.000000000","message":"s/blueprint add one/blueprint declares one/","commit_id":"abe2c3b9117a514b4dee0ec81443c401d8cbcf82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1ef1751a379eaa5cc268ec76d6aea1c20b01a0b","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Meter rename and deletion are common, which cause big confusion when end user"},{"line_number":21,"context_line":"try to access these meters with original name. This spec introduces one"},{"line_number":22,"context_line":"deprecation period, in which obsolete meter appear to be present for one or two"},{"line_number":23,"context_line":"release cycle. The implementation goes in API level to avoid intrusive code"},{"line_number":24,"context_line":"changes."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_6752afdf","line":22,"updated":"2015-06-05 14:00:28.000000000","message":"drop \"or two\"?","commit_id":"abe2c3b9117a514b4dee0ec81443c401d8cbcf82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1ef1751a379eaa5cc268ec76d6aea1c20b01a0b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"---------------"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"This blueprint does not change API itself, but add some compatibility for"},{"line_number":61,"context_line":"follwoing API:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- Show meter /v2/meters/{meter_name}"},{"line_number":64,"context_line":"- Create meter /v2/meters/{meter_name}"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_270a77d3","line":61,"updated":"2015-06-05 14:00:28.000000000","message":"s/follwoing/following/","commit_id":"abe2c3b9117a514b4dee0ec81443c401d8cbcf82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1ef1751a379eaa5cc268ec76d6aea1c20b01a0b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"follwoing API:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- Show meter /v2/meters/{meter_name}"},{"line_number":64,"context_line":"- Create meter /v2/meters/{meter_name}"},{"line_number":65,"context_line":"- Show meter statistics /v2/meters/{meter_name}/statistics"},{"line_number":66,"context_line":"- Show samples with specific meter /v2/samples?q.filed\u003dmeter_name\u0026q.value\u003dxxx"},{"line_number":67,"context_line":"- Create alarm /v2/alarms"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_67006fab","line":64,"updated":"2015-06-05 14:00:28.000000000","message":"why do we need to handle compatibility for post?","commit_id":"abe2c3b9117a514b4dee0ec81443c401d8cbcf82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1ef1751a379eaa5cc268ec76d6aea1c20b01a0b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"-------------------------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Extra mapping function for some API, but should be minimal as it just search"},{"line_number":94,"context_line":"the mapping table and replace some parameters."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"Other deployer impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_e8930fa2","line":94,"updated":"2015-06-05 14:00:28.000000000","message":"this actually worries me a little bit. if we modify the input, that should not affect performance much. but if we modify the output, that can be huge... ie. looping and replacing thousands of samples","commit_id":"abe2c3b9117a514b4dee0ec81443c401d8cbcf82"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1ef1751a379eaa5cc268ec76d6aea1c20b01a0b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"Testing"},{"line_number":145,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Add unit test for renamed and delted meter."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"Documentation Impact"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3afb71cf_c795e340","line":147,"updated":"2015-06-05 14:00:28.000000000","message":"s/delted/deleted/","commit_id":"abe2c3b9117a514b4dee0ec81443c401d8cbcf82"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d86ee35363e3f6bca14bbdaeeca2933a2ab1567f","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Meter rename and deletion are common, which cause big confusion when end user"},{"line_number":21,"context_line":"try to access these meters with original name. This spec introduces one"},{"line_number":22,"context_line":"deprecation period, in which obsolete meter appear to be present for one"},{"line_number":23,"context_line":"release cycle. The implementation goes in API level to avoid intrusive code"},{"line_number":24,"context_line":"changes."},{"line_number":25,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_619fedb4","line":22,"updated":"2015-06-15 21:09:23.000000000","message":"If I remember correctly on the Summit we agreed in two cycles:\n\nhttps://etherpad.openstack.org/p/liberty-ceilometer-meter-deprecation","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d86ee35363e3f6bca14bbdaeeca2933a2ab1567f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"For deleted meters, we stop collecting and storing samples after deprecation"},{"line_number":39,"context_line":"period. But old samples in DB are still accessible."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"For alarm, end user probably create or update it with old meter name, so"},{"line_number":42,"context_line":"translation is also needed here."},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"All above mapping work is actually parameter translation without intrusive"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_2f4b1189","line":41,"updated":"2015-06-15 21:09:23.000000000","message":"Does this mean to translate it from the old name to the new one? If yes it would be good to return some deprecation warning to the user, if that\u0027s possible.","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"82f728bcf0109774718552a3601daf5bf99b08d0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Data model impact"},{"line_number":53,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_bd1e1a61","line":50,"updated":"2015-06-09 04:19:52.000000000","message":"one alternative is we offer a migration tool. this will make the \u0027cleaning samples\u0027 overhead a one time event?","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f62837df9a4744db0066e56eb717dbb990932811","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Data model impact"},{"line_number":53,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1af86dd1_d50d9a38","line":50,"in_reply_to":"3afb71cf_005585f8","updated":"2015-06-12 08:03:29.000000000","message":"i meant some migration script but yeah... that was a stupid idea from me. please ignore. :)","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b2b01a6dab839f891d8262856dfbd19bc6b67d9a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Alternatives"},{"line_number":48,"context_line":"------------"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"None"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Data model impact"},{"line_number":53,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_005585f8","line":50,"in_reply_to":"3afb71cf_bd1e1a61","updated":"2015-06-10 08:13:43.000000000","message":"You mean a stand alone tool translating samples? It only handle get samples API, and need end user use the tool himself.\nHow to handle the alarm that based on old meter name?","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"82f728bcf0109774718552a3601daf5bf99b08d0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"following API:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- Show meter /v2/meters/{meter_name}"},{"line_number":64,"context_line":"- Create meter /v2/meters/{meter_name}"},{"line_number":65,"context_line":"- Show meter statistics /v2/meters/{meter_name}/statistics"},{"line_number":66,"context_line":"- Show samples with specific meter /v2/samples?q.filed\u003dmeter_name\u0026q.value\u003dxxx"},{"line_number":67,"context_line":"- Create alarm /v2/alarms"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_8232dd0e","line":64,"updated":"2015-06-09 04:19:52.000000000","message":"\u003e If switch to new meter name, we should not create any samples\n\u003e with old name unless existed ones in DB. User will get nothing \n\u003e when post then query samples with old name, if we just ignore post.\n\nso i guess that\u0027s part of the question. when we post meters, we don\u0027t actually dictate what the user can/can\u0027t post. secondly, if we\u0027re already doing the compatibilty on GET, why do we need to handle compatbility on POST?","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f62837df9a4744db0066e56eb717dbb990932811","unresolved":false,"context_lines":[{"line_number":61,"context_line":"following API:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- Show meter /v2/meters/{meter_name}"},{"line_number":64,"context_line":"- Create meter /v2/meters/{meter_name}"},{"line_number":65,"context_line":"- Show meter statistics /v2/meters/{meter_name}/statistics"},{"line_number":66,"context_line":"- Show samples with specific meter /v2/samples?q.filed\u003dmeter_name\u0026q.value\u003dxxx"},{"line_number":67,"context_line":"- Create alarm /v2/alarms"}],"source_content_type":"text/x-rst","patch_set":4,"id":"1af86dd1_d1112f5f","line":64,"in_reply_to":"3afb71cf_8018551f","updated":"2015-06-12 08:03:29.000000000","message":"my idea is that we don\u0027t care to process POST data... our GET mapping should be enough to handle the remapping? this admittedly will allow deprecated meter names to be stored... but then again, we don\u0027t decide what the user POST","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b2b01a6dab839f891d8262856dfbd19bc6b67d9a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"following API:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- Show meter /v2/meters/{meter_name}"},{"line_number":64,"context_line":"- Create meter /v2/meters/{meter_name}"},{"line_number":65,"context_line":"- Show meter statistics /v2/meters/{meter_name}/statistics"},{"line_number":66,"context_line":"- Show samples with specific meter /v2/samples?q.filed\u003dmeter_name\u0026q.value\u003dxxx"},{"line_number":67,"context_line":"- Create alarm /v2/alarms"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_8018551f","line":64,"in_reply_to":"3afb71cf_8232dd0e","updated":"2015-06-10 08:13:43.000000000","message":"yes. We don\u0027t dictate what user can/can\u0027t post. Only filter it according to our mapping table. Any issues here?\n\nI think consistent handling between GET and POST is natural. Maybe I don\u0027t fully understand your point:(","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d86ee35363e3f6bca14bbdaeeca2933a2ab1567f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"- Show meter /v2/meters/{meter_name}"},{"line_number":64,"context_line":"- Create meter /v2/meters/{meter_name}"},{"line_number":65,"context_line":"- Show meter statistics /v2/meters/{meter_name}/statistics"},{"line_number":66,"context_line":"- Show samples with specific meter /v2/samples?q.filed\u003dmeter_name\u0026q.value\u003dxxx"},{"line_number":67,"context_line":"- Create alarm /v2/alarms"},{"line_number":68,"context_line":"- Update alarm /v2/alarms/{alarm_id}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_ef120962","line":66,"updated":"2015-06-15 21:09:23.000000000","message":"Complex query should be handled also.\n/v2/query/samples","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d86ee35363e3f6bca14bbdaeeca2933a2ab1567f","unresolved":false,"context_lines":[{"line_number":80,"context_line":"Pipeline impact"},{"line_number":81,"context_line":"---------------"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"None"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Other end user impact"},{"line_number":86,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa32b979_612a8d80","line":83,"updated":"2015-06-15 21:09:23.000000000","message":"Parsing should be mentioned here to support both versions for a name.","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"82f728bcf0109774718552a3601daf5bf99b08d0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Performance/Scalability Impacts"},{"line_number":91,"context_line":"-------------------------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Extra mapping function for some API, but should be minimal as it just search"},{"line_number":94,"context_line":"the mapping table and replace some parameters."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_e208712f","line":93,"updated":"2015-06-09 04:19:52.000000000","message":"\u003e We only modify the output when user specify one obsolete meter \n\u003e name. So perf drop only happen for this case. But if this \n\u003e obsolete meter query returns a lot of samples, we need looping \n\u003e and replacing here.\n\nso the problem i guess the main problem is that if we restrict queries on meter name it\u0027s easy, but if not, it can be a huge issue because you have to look through all entries to verify","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f62837df9a4744db0066e56eb717dbb990932811","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Performance/Scalability Impacts"},{"line_number":91,"context_line":"-------------------------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Extra mapping function for some API, but should be minimal as it just search"},{"line_number":94,"context_line":"the mapping table and replace some parameters."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1af86dd1_15045213","line":93,"in_reply_to":"3afb71cf_8053b5e1","updated":"2015-06-12 08:03:29.000000000","message":"tbh, this probably is less of an issue now that i think about it... maybe we don\u0027t need to replace anything. we just filter return it as is (whether it\u0027s new name or old)... only thing we do is filter on both names.","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"},{"author":{"_account_id":11235,"name":"Edwin Zhai","email":"edwin.zhai@intel.com","username":"gzhai"},"change_message_id":"b2b01a6dab839f891d8262856dfbd19bc6b67d9a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"Performance/Scalability Impacts"},{"line_number":91,"context_line":"-------------------------------"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"Extra mapping function for some API, but should be minimal as it just search"},{"line_number":94,"context_line":"the mapping table and replace some parameters."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3afb71cf_8053b5e1","line":93,"in_reply_to":"3afb71cf_e208712f","updated":"2015-06-10 08:13:43.000000000","message":"We want restrict on both query and return, so give consistent view for the end user.\nYes, it\u0027s a big concern. I\u0027ll raise it to others.","commit_id":"7fdb2b67716c8731b6999f5dcbe6fc85a6197ef7"}]}
