)]}'
{"telemetry_tempest_plugin/config.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ce6ea9e4acf76dd38e54c376b54cd45b41dc7c53","unresolved":true,"context_lines":[{"line_number":28,"context_line":"                                  \u0027aodh_plugin\u0027,"},{"line_number":29,"context_line":"                                  group\u003d\u0027service_available\u0027)]),"},{"line_number":30,"context_line":"                  cfg.BoolOpt(\u0027gnocchi\u0027,"},{"line_number":31,"context_line":"                              default\u003dFalse,"},{"line_number":32,"context_line":"                              help\u003d\"Whether or not Gnocchi is expected to be\""},{"line_number":33,"context_line":"                                   \"available\"),"},{"line_number":34,"context_line":"                  cfg.BoolOpt(\u0027mysql\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"970d429a_d2f40e28","line":31,"range":{"start_line":31,"start_character":38,"end_line":31,"end_character":43},"updated":"2023-12-04 14:44:35.000000000","message":"I\u0027d insist that changing the default value should be avoided because it\u0027s backword incompatible. If we do so then we need an appropriate warning period.","commit_id":"4f612b457d6203a600a233063212327363775d01"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a4c478976dbe75e5a9f9775d30abda788ea72c3f","unresolved":true,"context_lines":[{"line_number":28,"context_line":"                                  \u0027aodh_plugin\u0027,"},{"line_number":29,"context_line":"                                  group\u003d\u0027service_available\u0027)]),"},{"line_number":30,"context_line":"                  cfg.BoolOpt(\u0027gnocchi\u0027,"},{"line_number":31,"context_line":"                              default\u003dFalse,"},{"line_number":32,"context_line":"                              help\u003d\"Whether or not Gnocchi is expected to be\""},{"line_number":33,"context_line":"                                   \"available\"),"},{"line_number":34,"context_line":"                  cfg.BoolOpt(\u0027mysql\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"34d40bcb_e1bd2441","line":31,"range":{"start_line":31,"start_character":38,"end_line":31,"end_character":43},"in_reply_to":"624385b9_8a452bfe","updated":"2023-12-06 16:06:48.000000000","message":"Probably the word \"breaking\" is not appropriate.\n\nMy main concern is about changing the default. Previously gnocchi tests were enabled by default, and if we disable it by default now then users might not notice their gnocchi tests are all skipped because they expect the previous behavior. My understanding is that the even new patchset disables gnocchi tests by default.","commit_id":"4f612b457d6203a600a233063212327363775d01"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8d4c835713250d6aa0358f14c88107beb406d725","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                                  \u0027aodh_plugin\u0027,"},{"line_number":29,"context_line":"                                  group\u003d\u0027service_available\u0027)]),"},{"line_number":30,"context_line":"                  cfg.BoolOpt(\u0027gnocchi\u0027,"},{"line_number":31,"context_line":"                              default\u003dFalse,"},{"line_number":32,"context_line":"                              help\u003d\"Whether or not Gnocchi is expected to be\""},{"line_number":33,"context_line":"                                   \"available\"),"},{"line_number":34,"context_line":"                  cfg.BoolOpt(\u0027mysql\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"624385b9_8a452bfe","line":31,"range":{"start_line":31,"start_character":38,"end_line":31,"end_character":43},"in_reply_to":"970d429a_d2f40e28","updated":"2023-12-06 10:16:43.000000000","message":"I would like to see actual example of what this breaks, yet should be addressed in the latest PS.","commit_id":"4f612b457d6203a600a233063212327363775d01"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ce6ea9e4acf76dd38e54c376b54cd45b41dc7c53","unresolved":true,"context_lines":[{"line_number":31,"context_line":"                              default\u003dFalse,"},{"line_number":32,"context_line":"                              help\u003d\"Whether or not Gnocchi is expected to be\""},{"line_number":33,"context_line":"                                   \"available\"),"},{"line_number":34,"context_line":"                  cfg.BoolOpt(\u0027mysql\u0027,"},{"line_number":35,"context_line":"                              default\u003dFalse,"},{"line_number":36,"context_line":"                              help\u003d\"Whether or not mysql is expected\""},{"line_number":37,"context_line":"                                   \"to be available\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"05eb4c38_36d6aa1e","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":36},"updated":"2023-12-04 14:44:35.000000000","message":"I think these mysql/postgresql options are too generic and can conflict with the others. Also, its technocally possible that a specific service may use a different backend.\n\nIf this is for backend in a specific service (aodh) then I\u0027d rather prefer more specific value such as `aodh_database_backend`, which defaults to None.","commit_id":"4f612b457d6203a600a233063212327363775d01"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"8d4c835713250d6aa0358f14c88107beb406d725","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                              default\u003dFalse,"},{"line_number":32,"context_line":"                              help\u003d\"Whether or not Gnocchi is expected to be\""},{"line_number":33,"context_line":"                                   \"available\"),"},{"line_number":34,"context_line":"                  cfg.BoolOpt(\u0027mysql\u0027,"},{"line_number":35,"context_line":"                              default\u003dFalse,"},{"line_number":36,"context_line":"                              help\u003d\"Whether or not mysql is expected\""},{"line_number":37,"context_line":"                                   \"to be available\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"be50f0e6_fc6500ba","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":36},"in_reply_to":"05eb4c38_36d6aa1e","updated":"2023-12-06 10:16:43.000000000","message":"Thanks Takashi,\n\nI think I got the scope of these config groups mixed up. Should be clearer on the latests ps.","commit_id":"4f612b457d6203a600a233063212327363775d01"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a4c478976dbe75e5a9f9775d30abda788ea72c3f","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                              help\u003d\"Whether or not Gnocchi is expected to be\""},{"line_number":33,"context_line":"                                   \"available\","},{"line_number":34,"context_line":"                              deprecated_for_removal\u003dTrue),"},{"line_number":35,"context_line":"                  cfg.BoolOpt(\u0027sg_core\u0027,"},{"line_number":36,"context_line":"                              default\u003dFalse,"},{"line_number":37,"context_line":"                              help\u003d\"Whether or not sg-core is expected to be\""},{"line_number":38,"context_line":"                                   \"available\","},{"line_number":39,"context_line":"                              deprecated_for_removal\u003dTrue)]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"telemetry_group \u003d cfg.OptGroup(name\u003d\u0027telemetry\u0027,"},{"line_number":42,"context_line":"                               title\u003d\u0027Telemetry Service Options\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9062971c_0e2d93cd","line":39,"range":{"start_line":35,"start_character":18,"end_line":39,"end_character":58},"updated":"2023-12-06 16:06:48.000000000","message":"No release has been created since this option was added so I think you can just remove this.","commit_id":"f4f0daaa4805b2bb7e2d31421e32f5f806d122c8"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"487b0339118831cf86c433b0fbb32450be561563","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                              help\u003d\"Whether or not Gnocchi is expected to be\""},{"line_number":33,"context_line":"                                   \"available\","},{"line_number":34,"context_line":"                              deprecated_for_removal\u003dTrue),"},{"line_number":35,"context_line":"                  cfg.BoolOpt(\u0027sg_core\u0027,"},{"line_number":36,"context_line":"                              default\u003dFalse,"},{"line_number":37,"context_line":"                              help\u003d\"Whether or not sg-core is expected to be\""},{"line_number":38,"context_line":"                                   \"available\","},{"line_number":39,"context_line":"                              deprecated_for_removal\u003dTrue)]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"telemetry_group \u003d cfg.OptGroup(name\u003d\u0027telemetry\u0027,"},{"line_number":42,"context_line":"                               title\u003d\u0027Telemetry Service Options\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"cc009d92_905d91dc","line":39,"range":{"start_line":35,"start_character":18,"end_line":39,"end_character":58},"in_reply_to":"9062971c_0e2d93cd","updated":"2023-12-06 19:20:02.000000000","message":"sg-core will be required for transporting metrics from ceilometer to prometheus. There currently is a test in telemetry_tempest_plugin/scenario/telemetry_integration_prometheus_gabbits, which requires sg-core running. I\u0027d expect more tests which require sg-core to appear in the near future.","commit_id":"f4f0daaa4805b2bb7e2d31421e32f5f806d122c8"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"0bafc6c3303a7a64554ef873950ba393802c8abe","unresolved":true,"context_lines":[{"line_number":32,"context_line":"                              help\u003d\"Whether or not Gnocchi is expected to be\""},{"line_number":33,"context_line":"                                   \"available\","},{"line_number":34,"context_line":"                              deprecated_for_removal\u003dTrue),"},{"line_number":35,"context_line":"                  cfg.BoolOpt(\u0027sg_core\u0027,"},{"line_number":36,"context_line":"                              default\u003dFalse,"},{"line_number":37,"context_line":"                              help\u003d\"Whether or not sg-core is expected to be\""},{"line_number":38,"context_line":"                                   \"available\","},{"line_number":39,"context_line":"                              deprecated_for_removal\u003dTrue)]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"telemetry_group \u003d cfg.OptGroup(name\u003d\u0027telemetry\u0027,"},{"line_number":42,"context_line":"                               title\u003d\u0027Telemetry Service Options\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1cbc0dc9_38f2a1be","line":39,"range":{"start_line":35,"start_character":18,"end_line":39,"end_character":58},"in_reply_to":"cc009d92_905d91dc","updated":"2023-12-07 08:29:29.000000000","message":"yup, literally just marked it so I remember to change it to the telemetry_services group for clarity.","commit_id":"f4f0daaa4805b2bb7e2d31421e32f5f806d122c8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a4c478976dbe75e5a9f9775d30abda788ea72c3f","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"]"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"telemetry_services_opts \u003d ["},{"line_number":89,"context_line":"    cfg.BoolOpt(\u0027aodh_gnocchi\u0027,"},{"line_number":90,"context_line":"                default\u003dFalse,"},{"line_number":91,"context_line":"                help\u003d\"Can telemetry plugin expect gnocchi backend\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"72ccda56_fd9bd008","line":88,"range":{"start_line":88,"start_character":0,"end_line":88,"end_character":23},"updated":"2023-12-06 16:06:48.000000000","message":"If we make the option names specific to aodh then should these be in the alarming_plugin section, IMHO.\n\nAlso, IIUC the meaning of \"backend\" is different for mysql/postgresql(DB backend to store alarm-related data) and gnocchi/promethus(Storage backend to store metrics and events).\nIt might be easier to create options like\n```\ncfg.ListOpt(\u0027telemetry_backends\u0027,\n            default\u003d[],\n            item_type\u003dtypes.String(choices\u003d(\u0027gnocchi\u0027, \u0027prometheus\u0027)),\n            help\u003d\u0027Backends to store telemetry data\u0027),\ncfg.StrOpt(\u0027storage_backend\u0027,\n           default\u003d\u0027mysql\u0027,\n           choices\u003d(\u0027mysql\u0027, \u0027postgresql\u0027),\n           help\u003d\u0027Storage backend used by Aodh\u0027),\n```\nto explain that grouping more explicitly.","commit_id":"f4f0daaa4805b2bb7e2d31421e32f5f806d122c8"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a4c478976dbe75e5a9f9775d30abda788ea72c3f","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    cfg.BoolOpt(\u0027aodh_mysql\u0027,"},{"line_number":93,"context_line":"                default\u003dFalse,"},{"line_number":94,"context_line":"                help\u003d\"Can telemetry plugin expect mysql backend\"),"},{"line_number":95,"context_line":"    cfg.BoolOpt(\u0027aodh_postgre\u0027,"},{"line_number":96,"context_line":"                default\u003dFalse,"},{"line_number":97,"context_line":"                help\u003d\"Can telemetry plugin expect postgre backend\"),"},{"line_number":98,"context_line":"    cfg.BoolOpt(\u0027aodh_prometheus\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"d6800f52_09782da5","line":95,"range":{"start_line":95,"start_character":17,"end_line":95,"end_character":29},"updated":"2023-12-06 16:06:48.000000000","message":"s/postgre/postgresql/g","commit_id":"f4f0daaa4805b2bb7e2d31421e32f5f806d122c8"}]}