)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8ba76b02_5064c87f","updated":"2024-02-22 13:28:54.000000000","message":"Thanks Marihan,\n\nSome comments and questions inline.","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"459fbf78d4ca8dc482dd4be3845ec33b63f419eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a76646e8_3e5e8900","updated":"2024-02-26 10:42:15.000000000","message":"I answered some of Erno\u0027s comments and added one of my own. Otherwise I\u0027d agree with the rest of Erno\u0027s remarks. This will be a great addition to the plugin. Thanks Marihan.","commit_id":"316d2b0bfa58283fbb5ceea47e4bd45398c9c064"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"768caa33551b2b3cdda316d841db068648078f40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2d5522f6_0acf6af9","updated":"2024-02-28 19:49:34.000000000","message":"I\u0027ve opened a pull request[1] against telemetry-operator that tests this change.\n\nWhen you upload a new patchset here, you\u0027ll need to bump the changeRefspec in the PR.\n\n[1] https://github.com/openstack-k8s-operators/telemetry-operator/pull/322","commit_id":"0d1c7901e387c773e42cb89682fcebc01661f9be"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"e816fdd6c539043dd0d53e11bfa77a29d73eab5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c72bf26c_d69529fb","updated":"2024-03-01 08:16:26.000000000","message":"Looks like something unrelated changed and caused failures being reported in .zuul.yaml. This could possibly be a fix: https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/910572","commit_id":"87ed7ecc4debe9c956abf3892bcce203f1d79918"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"72cdd394119a15ec1afea2f953ac6f412a7bac5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bef1b1ed_1ae752dc","updated":"2024-03-08 09:40:52.000000000","message":"recheck\n\nThe dib patch is now merged, but we also have disabled testing of gabbi integration tests, https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/910572/3/.zuul.yaml#35","commit_id":"8cf2722a018073994458614541557cb6a18c9c28"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"ab6f015821d9e0609f3bedc00e36fba1d513e476","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1ad3f8f9_17cc405e","updated":"2024-03-08 19:12:19.000000000","message":"recheck tempest.lib.exceptions.UnexpectedContentType: Unexpected content type provided","commit_id":"24c172ac5297e2c0e9dc4aadd6a3a95dc7dbcd7f"}],"telemetry_tempest_plugin/config.py":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"459fbf78d4ca8dc482dd4be3845ec33b63f419eb","unresolved":true,"context_lines":[{"line_number":84,"context_line":"               default\u003d\"127.0.0.1:3000\","},{"line_number":85,"context_line":"               help\u003d\"URL to sg-core prometheus endpoint\"),"},{"line_number":86,"context_line":"    cfg.StrOpt(\u0027prometheus_service_url\u0027,"},{"line_number":87,"context_line":"               default\u003d\"127.0.0.1:9091\","},{"line_number":88,"context_line":"               help\u003d\"URL to prometheus endpoint\"),"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"cff79de8_2cf0d90f","line":87,"range":{"start_line":87,"start_character":34,"end_line":87,"end_character":38},"updated":"2024-02-26 10:42:15.000000000","message":"We should default to 9090 as this is what\u0027s used by default by prometheus. 9090 is also the default when using the sg-core\u0027s devstack plugin to deploy prometheus.","commit_id":"bf5ff0478d2a95844886e7c246a3643385a2a97b"}],"telemetry_tempest_plugin/scenario/telemetry_integration_prometheus_gabbits/autoscaling.yaml":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":3,"context_line":"        x-auth-token: $ENVIRON[\u0027USER_TOKEN\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"tests:"},{"line_number":6,"context_line":"    - name: list alarms none"},{"line_number":7,"context_line":"      desc: Lists alarms, none yet exist"},{"line_number":8,"context_line":"      verbose: all"},{"line_number":9,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms"},{"line_number":10,"context_line":"      method: GET"},{"line_number":11,"context_line":"      response_strings:"},{"line_number":12,"context_line":"          - \"[]\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: list servers none"},{"line_number":15,"context_line":"      desc: List servers, none yet exists"},{"line_number":16,"context_line":"      verbose: all"},{"line_number":17,"context_line":"      url: $ENVIRON[\u0027NOVA_SERVICE_URL\u0027]/servers"},{"line_number":18,"context_line":"      method: GET"},{"line_number":19,"context_line":"      response_strings:"},{"line_number":20,"context_line":"          - \"[]\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: create stack"},{"line_number":23,"context_line":"      desc: Create an autoscaling stack"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4c2861fe_19e19101","line":20,"range":{"start_line":6,"start_character":4,"end_line":20,"end_character":16},"updated":"2024-02-22 13:28:54.000000000","message":"If this is existing environment these would potentially fail or the token expected to be for dedicated project that has no other activity?","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"459fbf78d4ca8dc482dd4be3845ec33b63f419eb","unresolved":true,"context_lines":[{"line_number":3,"context_line":"        x-auth-token: $ENVIRON[\u0027USER_TOKEN\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"tests:"},{"line_number":6,"context_line":"    - name: list alarms none"},{"line_number":7,"context_line":"      desc: Lists alarms, none yet exist"},{"line_number":8,"context_line":"      verbose: all"},{"line_number":9,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms"},{"line_number":10,"context_line":"      method: GET"},{"line_number":11,"context_line":"      response_strings:"},{"line_number":12,"context_line":"          - \"[]\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: list servers none"},{"line_number":15,"context_line":"      desc: List servers, none yet exists"},{"line_number":16,"context_line":"      verbose: all"},{"line_number":17,"context_line":"      url: $ENVIRON[\u0027NOVA_SERVICE_URL\u0027]/servers"},{"line_number":18,"context_line":"      method: GET"},{"line_number":19,"context_line":"      response_strings:"},{"line_number":20,"context_line":"          - \"[]\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: create stack"},{"line_number":23,"context_line":"      desc: Create an autoscaling stack"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"501af5cf_2578a58f","line":20,"range":{"start_line":6,"start_character":4,"end_line":20,"end_character":16},"in_reply_to":"4c2861fe_19e19101","updated":"2024-02-26 10:42:15.000000000","message":"Judging from the leftovers after unsuccessful executions of the scenario from testing this. Tempest seems to be creating a new temporary user and project, which it uses to execute the scenarios, so there shouldn\u0027t be any alarms or servers running at this point.\n\nAlso see the \"Allocating Credentials\" subsection of: https://docs.openstack.org/tempest/latest/write_tests.html#adding-a-new-testcase \"the base TestCase class will automatically allocate a regular user for each TestCase during the setup_credentials() phase\"","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":56,"context_line":"          $.servers[0].status: ACTIVE"},{"line_number":57,"context_line":"          $.servers[1].status: ACTIVE"},{"line_number":58,"context_line":"          $.servers.`len`: 2"},{"line_number":59,"context_line":"         "},{"line_number":60,"context_line":"    - name: check prometheus query for the servers count ."},{"line_number":61,"context_line":"      desc: Check the Prometheus metric for the existence of servers"},{"line_number":62,"context_line":"      url: $ENVIRON[\u0027PROMETHEUS_SERVICE_URL\u0027]/api/v1/query"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a322792d_d014caf6","line":59,"updated":"2024-02-22 13:28:54.000000000","message":"Not sure if we have hacking tests affecting these YAMLs, but the extra whitespaces here and L#44 would not pass. Could you please do a quick respin to clean those out.","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":78,"context_line":"      desc: Check the aodh alarm and its state"},{"line_number":79,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms?sort\u003dname%3Aasc"},{"line_number":80,"context_line":"      method: GET"},{"line_number":81,"context_line":"      poll:"},{"line_number":82,"context_line":"          count: 600"},{"line_number":83,"context_line":"          delay: 5"},{"line_number":84,"context_line":"      response_strings:"},{"line_number":85,"context_line":"          - \"$ENVIRON[\u0027STACK_NAME\u0027]-cpu_alarm_high\""},{"line_number":86,"context_line":"      response_json_paths:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f1f83d57_338beffb","line":83,"range":{"start_line":81,"start_character":5,"end_line":83,"end_character":18},"updated":"2024-02-22 13:28:54.000000000","message":"50min polling time really necessary?","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"459fbf78d4ca8dc482dd4be3845ec33b63f419eb","unresolved":true,"context_lines":[{"line_number":78,"context_line":"      desc: Check the aodh alarm and its state"},{"line_number":79,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms?sort\u003dname%3Aasc"},{"line_number":80,"context_line":"      method: GET"},{"line_number":81,"context_line":"      poll:"},{"line_number":82,"context_line":"          count: 600"},{"line_number":83,"context_line":"          delay: 5"},{"line_number":84,"context_line":"      response_strings:"},{"line_number":85,"context_line":"          - \"$ENVIRON[\u0027STACK_NAME\u0027]-cpu_alarm_high\""},{"line_number":86,"context_line":"      response_json_paths:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a97f9ff8_d3e7b260","line":83,"range":{"start_line":81,"start_character":5,"end_line":83,"end_character":18},"in_reply_to":"f1f83d57_338beffb","updated":"2024-02-26 10:42:15.000000000","message":"The scenario along with the polling times is based on the gnocchi based autoscaling we already have in the plugin. We may be able to adjust this, but maybe it\u0027d be better in a follow-up patch and adjust it for this scenario as well as for the legacy autoscaling? This patch: https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/909459 adds the ceilometer_polling_interval parameter.\n\nWhen polling here, we\u0027re basically waiting for ceilometer to generate new metrics (which it does every ceilometer_polling_interval) and for aodh to trigger alarms (which should happen every minute). So I think we could reduce most of these intervals to something like 2*ceilometer_polling_interval + 120.\n\nWould you be OK with doing it like this in a follow-up patch?","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":91,"context_line":"      desc: Check the aodh alarm and its state"},{"line_number":92,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms?sort\u003dname%3Aasc"},{"line_number":93,"context_line":"      method: GET"},{"line_number":94,"context_line":"      poll:"},{"line_number":95,"context_line":"          count: 600"},{"line_number":96,"context_line":"          delay: 5"},{"line_number":97,"context_line":"      response_strings:"},{"line_number":98,"context_line":"          - \"$ENVIRON[\u0027STACK_NAME\u0027]-cpu_alarm_high-\""},{"line_number":99,"context_line":"      response_json_paths:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"68f5783a_62cec72d","line":96,"range":{"start_line":94,"start_character":5,"end_line":96,"end_character":18},"updated":"2024-02-22 13:28:54.000000000","message":"Ditto","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":104,"context_line":"      desc: Check the aodh alarm and its state"},{"line_number":105,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms?sort\u003dname%3Aasc"},{"line_number":106,"context_line":"      method: GET"},{"line_number":107,"context_line":"      poll:"},{"line_number":108,"context_line":"          count: 600"},{"line_number":109,"context_line":"          delay: 5"},{"line_number":110,"context_line":"      response_strings:"},{"line_number":111,"context_line":"          - \"$ENVIRON[\u0027STACK_NAME\u0027]-cpu_alarm_low-\""},{"line_number":112,"context_line":"      response_json_paths:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"b106186b_34cd7374","line":109,"range":{"start_line":107,"start_character":4,"end_line":109,"end_character":18},"updated":"2024-02-22 13:28:54.000000000","message":"Ditto","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":115,"context_line":"    - name: list servers shrink"},{"line_number":116,"context_line":"      verbose: all"},{"line_number":117,"context_line":"      desc: Wait for the autoscaling stack to delete one server"},{"line_number":118,"context_line":"      url: $ENVIRON[\u0027NOVA_SERVICE_URL\u0027]/servers/detail"},{"line_number":119,"context_line":"      method: GET"},{"line_number":120,"context_line":"      poll:"},{"line_number":121,"context_line":"          count: 600"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c50e432c_a62529e9","line":118,"updated":"2024-02-22 13:28:54.000000000","message":"Is there a way we could have Nova filtering this list rather than returning all servers visible to the project?","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"459fbf78d4ca8dc482dd4be3845ec33b63f419eb","unresolved":true,"context_lines":[{"line_number":115,"context_line":"    - name: list servers shrink"},{"line_number":116,"context_line":"      verbose: all"},{"line_number":117,"context_line":"      desc: Wait for the autoscaling stack to delete one server"},{"line_number":118,"context_line":"      url: $ENVIRON[\u0027NOVA_SERVICE_URL\u0027]/servers/detail"},{"line_number":119,"context_line":"      method: GET"},{"line_number":120,"context_line":"      poll:"},{"line_number":121,"context_line":"          count: 600"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7721756e_3f38793f","line":118,"in_reply_to":"c50e432c_a62529e9","updated":"2024-02-26 10:42:15.000000000","message":"Is that necessary if this uses a temporary project created solely for this scenario?","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":142,"context_line":"      url: $ENVIRON[\u0027HEAT_SERVICE_URL\u0027]/stacks/$ENVIRON[\u0027STACK_NAME\u0027]"},{"line_number":143,"context_line":"      redirects: true"},{"line_number":144,"context_line":"      method: GET"},{"line_number":145,"context_line":"      poll:"},{"line_number":146,"context_line":"          count: 300"},{"line_number":147,"context_line":"          delay: 5"},{"line_number":148,"context_line":"      status: 404"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    - name: list alarms deleted"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dace613a_02b96ecb","line":147,"range":{"start_line":145,"start_character":6,"end_line":147,"end_character":18},"updated":"2024-02-22 13:28:54.000000000","message":"If Heat API is behaving correctly this should not be needed. As per Heat API documentation when returning the 204 from the delete call, the response indicates that the resource has been deleted.\n\nOn a potential failure in Heats part this delays the test job unnecessarily by 25min.","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":147,"context_line":"          delay: 5"},{"line_number":148,"context_line":"      status: 404"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    - name: list alarms deleted"},{"line_number":151,"context_line":"      desc: List alarms, no more exist"},{"line_number":152,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms"},{"line_number":153,"context_line":"      method: GET"},{"line_number":154,"context_line":"      response_strings:"},{"line_number":155,"context_line":"          - \"[]\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    - name: list servers deleted"},{"line_number":158,"context_line":"      desc: List servers, no more exists"},{"line_number":159,"context_line":"      url: $ENVIRON[\u0027NOVA_SERVICE_URL\u0027]/servers"},{"line_number":160,"context_line":"      method: GET"},{"line_number":161,"context_line":"      response_strings:"},{"line_number":162,"context_line":"          - \"[]\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"efe905f7_6fe9797b","line":162,"range":{"start_line":150,"start_character":4,"end_line":162,"end_character":16},"updated":"2024-02-22 13:28:54.000000000","message":"Again unless the project of the used token is dedicates for the tempest we might fail here expecting that there is nothing visible for the project.","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"459fbf78d4ca8dc482dd4be3845ec33b63f419eb","unresolved":true,"context_lines":[{"line_number":147,"context_line":"          delay: 5"},{"line_number":148,"context_line":"      status: 404"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    - name: list alarms deleted"},{"line_number":151,"context_line":"      desc: List alarms, no more exist"},{"line_number":152,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms"},{"line_number":153,"context_line":"      method: GET"},{"line_number":154,"context_line":"      response_strings:"},{"line_number":155,"context_line":"          - \"[]\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    - name: list servers deleted"},{"line_number":158,"context_line":"      desc: List servers, no more exists"},{"line_number":159,"context_line":"      url: $ENVIRON[\u0027NOVA_SERVICE_URL\u0027]/servers"},{"line_number":160,"context_line":"      method: GET"},{"line_number":161,"context_line":"      response_strings:"},{"line_number":162,"context_line":"          - \"[]\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6fdedceb_4e5014a0","line":162,"range":{"start_line":150,"start_character":4,"end_line":162,"end_character":16},"in_reply_to":"efe905f7_6fe9797b","updated":"2024-02-26 10:42:15.000000000","message":"Should be fine. See my answer to your comment at the top of the file.","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"}],"telemetry_tempest_plugin/scenario/telemetry_integration_prometheus_gabbits/create_stack.json":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            \"cpu_alarm_high\": {"},{"line_number":42,"context_line":"                \"type\": \"OS::Aodh::PrometheusAlarm\","},{"line_number":43,"context_line":"                \"properties\": {"},{"line_number":44,"context_line":"                    \"description\": \"Scale-up if the mean CPU \u003e 10% on 1 minute\","},{"line_number":45,"context_line":"                    \"threshold\": $ENVIRON[\"AODH_THRESHOLD\"],"},{"line_number":46,"context_line":"                    \"comparison_operator\": \"gt\","},{"line_number":47,"context_line":"                    \"alarm_actions\": ["}],"source_content_type":"application/json","patch_set":2,"id":"698a8223_32276c53","line":44,"range":{"start_line":44,"start_character":63,"end_line":44,"end_character":78},"updated":"2024-02-22 13:28:54.000000000","message":"First the load is based on the configuration option treshold, not static 10%.\nSecond part that confuses me here is that on 1 minute part, but the alarm that\u0027s been set is not configured with time constraint, granularity nor evaluation periods; so it will be evaluated in 1 minute intervals but in my understanding the alarm will trigger as soon as the treshold is met, where is this 1 minute mean coming from?","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            \"cpu_alarm_low\": {"},{"line_number":70,"context_line":"                \"type\": \"OS::Aodh::PrometheusAlarm\","},{"line_number":71,"context_line":"                \"properties\": {"},{"line_number":72,"context_line":"                    \"description\": \"Scale-down if the mean CPU \u003c 10% on 1 minute\","},{"line_number":73,"context_line":"                    \"threshold\": $ENVIRON[\"AODH_THRESHOLD\"],"},{"line_number":74,"context_line":"                    \"comparison_operator\": \"lt\","},{"line_number":75,"context_line":"                    \"alarm_actions\": ["}],"source_content_type":"application/json","patch_set":2,"id":"bb71f650_97acd893","line":72,"range":{"start_line":72,"start_character":65,"end_line":72,"end_character":80},"updated":"2024-02-22 13:28:54.000000000","message":"ditto","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"}],"telemetry_tempest_plugin/scenario/test_telemetry_integration_prometheus.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"16772153a5ad05f24fc4b6eb088bde4eed6ae886","unresolved":true,"context_lines":[{"line_number":32,"context_line":"    @classmethod"},{"line_number":33,"context_line":"    def skip_checks(cls):"},{"line_number":34,"context_line":"        super(PrometheusGabbiTest, cls).skip_checks()"},{"line_number":35,"context_line":"        if not CONF.service_available.sg_core:"},{"line_number":36,"context_line":"            raise cls.skipException(\"sg-core support is required\")"},{"line_number":37,"context_line":"        for name in [\"aodh\", \"nova\", \"heat\","},{"line_number":38,"context_line":"                     \"ceilometer\", \"glance\"]:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3b6519f6_19e775fe","line":35,"updated":"2024-02-22 13:28:54.000000000","message":"How about adding sg_core on the list below as well as all the services are required. And just remove this.","commit_id":"8857051f70fcb4160a8750f2e15c748f56756c88"}]}