)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"54b35c57edd51ca1599fec241b182da18a6acb19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"760648ab_1aa60777","updated":"2024-03-13 18:21:08.000000000","message":"check rdo experimental","commit_id":"04e6c790a48ea302383da7623ad473abc1f7fd17"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"6958c01821f10812d0f1cde80d8f2df09b3e55d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5c5a89e5_f81e37ce","updated":"2024-03-14 14:32:19.000000000","message":"I see proof in the aodh evaluator logs that prometheus is queried\n DEBUG aodh.evaluator.prometheus [-] Querying Prometheus instance on: (rate(ceilometer_cpu{resource_name\u003d~\u0027.*213223.*\u0027}[1m])) * 100 _get_metric_data /opt/stack/aodh/aodh/evaluator/prometheus.py:46\n\nHEAT logs have proof of the stack ar 14 12:13:51.172190 np0037062430 devstack@h-api.service[106473]: INFO heat.common.wsgi [None req-ddd596e9-f0ec-4ee4-8e19-6ef578cc86db tempest-PrometheusGabbiTest-1035353653 tempest-PrometheusGabbiTest-1035353653-project-member] Processing request: GET /heat-api/v1/4fd07d02d5c14bb9abab960efe1284dc/stacks/tempest-telemetry-377213223\nespecially on scaling down \nPOST /heat-api/v1/4fd07d02d5c14bb9abab960efe1284dc/stacks/tempest-telemetry-377213223/50d611da-7587-44a3-b1ef-314db4da6f3d/resources/web_server_scaledown_policy/signal\n\n\n\n\n\nI am not entirely clear why gnocchi is deployed as part of this? That can be a follow-up fix though.\n\nAh, found it, there are also gnocchi based tests being executed.\n\nMarihan, could you please fix the pep8 issues (whitespaces), and IMHO this is good to go.","commit_id":"8463b53df99d75fd443ca69619e9bae47a2a7294"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"b3e7a1d619dda7195fcc648acf027d56fabbe08d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"448e780e_021c668f","updated":"2024-03-15 09:33:12.000000000","message":"Thank you Marihan!","commit_id":"218b9f2e603452d160b13599a2b0b5a0211cccce"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"40a4a96b7c9223c8b8790dc2ffc4ee0f260a7ada","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"13b11429_28b2f3aa","updated":"2024-03-15 15:14:29.000000000","message":"check rdo experimental","commit_id":"218b9f2e603452d160b13599a2b0b5a0211cccce"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"32c738f21707c86464d212942277f7bb3f9a2e09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b205beea_8bc65515","updated":"2024-03-21 11:44:32.000000000","message":"Just couple of little things to tidy up and I think we would be good to go.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"6ae784dbb9f994e8daa305c717854277e2616524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8e0e09af_bb0a726a","updated":"2024-03-22 19:06:23.000000000","message":"The RDO failure is not related to this change.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"e353a1b373acd21133424ef7ba92808f020bd22e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"781310b5_168a1660","updated":"2024-03-22 16:22:57.000000000","message":"check rdo experimental","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"ed27b9ae3cfac8b64037636cf3cd4ef576bb7539","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"818cc5a5_0805721e","updated":"2024-03-28 14:38:04.000000000","message":"@Marihan, Thanks for letting me use your review to test this new job for openstack-k8s-operators","commit_id":"069c5a45b9269010379ff9f98c0b59c4de089479"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"692aa69d1023fcd2b6dcf0f2617fb16cb67fab71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"03b18728_616f084c","updated":"2024-04-02 08:01:58.000000000","message":"Thank you, looks good in general!","commit_id":"069c5a45b9269010379ff9f98c0b59c4de089479"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"2a377c33f5ee5b81922a6e800cdef2be25a520e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"71529bc1_748a10d4","updated":"2024-03-28 14:37:02.000000000","message":"check rdo experimental","commit_id":"069c5a45b9269010379ff9f98c0b59c4de089479"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"e3999dc5eb26d3a5dd9030ba935bbb5fe90b7c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e0ad3430_c2125d70","updated":"2024-04-05 10:43:49.000000000","message":"I assume Matthias\u0027 +2 as only clarifying comment was added. Ninjaing this in on that assumption.","commit_id":"d00901d59e04f0f96c0f24ee83656fae2ed28881"}],"telemetry_tempest_plugin/config.py":[{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"511bb32ee735d5f09a21a392fb23fa327f75fbde","unresolved":true,"context_lines":[{"line_number":83,"context_line":"    cfg.StrOpt(\u0027sg_core_service_url\u0027,"},{"line_number":84,"context_line":"               default\u003d\"127.0.0.1:3000\","},{"line_number":85,"context_line":"               help\u003d\"URL to sg-core prometheus endpoint\"),"},{"line_number":86,"context_line":"     cfg.StrOpt(\u0027prometheus_service_url\u0027,"},{"line_number":87,"context_line":"               default\u003d\"127.0.0.1:9090\","},{"line_number":88,"context_line":"               help\u003d\"URL to prometheus endpoint\"),"},{"line_number":89,"context_line":"    cfg.IntOpt(\u0027ceilometer_polling_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb28fc3a_d508c6d9","line":86,"in_reply_to":"94c48f03_8d6b1571","updated":"2024-04-03 09:43:45.000000000","message":"\u003e pep8: E131 continuation line unaligned for hanging indent\n\nPlease fix.","commit_id":"ee81f5ec06d4fe9e7710912cf6afd3dd250d4af0"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"da5cc959d3bcf1465420756a8b86774ef90edd76","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    cfg.StrOpt(\u0027sg_core_service_url\u0027,"},{"line_number":84,"context_line":"               default\u003d\"127.0.0.1:3000\","},{"line_number":85,"context_line":"               help\u003d\"URL to sg-core prometheus endpoint\"),"},{"line_number":86,"context_line":"     cfg.StrOpt(\u0027prometheus_service_url\u0027,"},{"line_number":87,"context_line":"               default\u003d\"127.0.0.1:9090\","},{"line_number":88,"context_line":"               help\u003d\"URL to prometheus endpoint\"),"},{"line_number":89,"context_line":"    cfg.IntOpt(\u0027ceilometer_polling_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbf37e12_7ba532f2","line":86,"in_reply_to":"eb28fc3a_d508c6d9","updated":"2024-04-03 09:48:16.000000000","message":"Done","commit_id":"ee81f5ec06d4fe9e7710912cf6afd3dd250d4af0"}],"telemetry_tempest_plugin/scenario/telemetry_integration_prometheus_gabbits/autoscaling.yaml":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"32c738f21707c86464d212942277f7bb3f9a2e09","unresolved":true,"context_lines":[{"line_number":3,"context_line":"        x-auth-token: $ENVIRON[\u0027USER_TOKEN\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"tests:"},{"line_number":6,"context_line":"    - name: list alarms none"},{"line_number":7,"context_line":"      desc: Lists alarms, none yet exist"},{"line_number":8,"context_line":"      verbose: all"},{"line_number":9,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms"},{"line_number":10,"context_line":"      method: GET"},{"line_number":11,"context_line":"      response_strings:"},{"line_number":12,"context_line":"          - \"[]\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: list servers none"},{"line_number":15,"context_line":"      desc: List servers, none yet exists"},{"line_number":16,"context_line":"      verbose: all"},{"line_number":17,"context_line":"      url: $ENVIRON[\u0027NOVA_SERVICE_URL\u0027]/servers"},{"line_number":18,"context_line":"      method: GET"},{"line_number":19,"context_line":"      response_strings:"},{"line_number":20,"context_line":"          - \"[]\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: create stack"},{"line_number":23,"context_line":"      desc: Create an autoscaling stack"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d18c0b17_f60f6f08","line":20,"range":{"start_line":6,"start_character":0,"end_line":20,"end_character":16},"updated":"2024-03-21 11:44:32.000000000","message":"I have my concerns about these \"test if empty\" gabbi tests, especially when utilizing same credentials with other tests, but I don\u0027t think they are matter to address in this change as they seem to work in CI as they are, we need to take look at these tests as whole.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"511bb32ee735d5f09a21a392fb23fa327f75fbde","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        x-auth-token: $ENVIRON[\u0027USER_TOKEN\u0027]"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"tests:"},{"line_number":6,"context_line":"    - name: list alarms none"},{"line_number":7,"context_line":"      desc: Lists alarms, none yet exist"},{"line_number":8,"context_line":"      verbose: all"},{"line_number":9,"context_line":"      url: $ENVIRON[\u0027AODH_SERVICE_URL\u0027]/v2/alarms"},{"line_number":10,"context_line":"      method: GET"},{"line_number":11,"context_line":"      response_strings:"},{"line_number":12,"context_line":"          - \"[]\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    - name: list servers none"},{"line_number":15,"context_line":"      desc: List servers, none yet exists"},{"line_number":16,"context_line":"      verbose: all"},{"line_number":17,"context_line":"      url: $ENVIRON[\u0027NOVA_SERVICE_URL\u0027]/servers"},{"line_number":18,"context_line":"      method: GET"},{"line_number":19,"context_line":"      response_strings:"},{"line_number":20,"context_line":"          - \"[]\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    - name: create stack"},{"line_number":23,"context_line":"      desc: Create an autoscaling stack"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0274fa6a_e5915984","line":20,"range":{"start_line":6,"start_character":0,"end_line":20,"end_character":16},"in_reply_to":"d18c0b17_f60f6f08","updated":"2024-04-03 09:43:45.000000000","message":"Acknowledged","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"32c738f21707c86464d212942277f7bb3f9a2e09","unresolved":true,"context_lines":[{"line_number":41,"context_line":"          delay: 1"},{"line_number":42,"context_line":"      response_json_paths:"},{"line_number":43,"context_line":"          $.stack.stack_status: \"CREATE_COMPLETE\""},{"line_number":44,"context_line":"          "},{"line_number":45,"context_line":"    - name: list servers grow"},{"line_number":46,"context_line":"      verbose: all"},{"line_number":47,"context_line":"      desc: Wait the autoscaling stack grow to two servers"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"d7bd7698_21c8f3a9","line":44,"updated":"2024-03-21 11:44:32.000000000","message":"Extra trailing whitespaces still left.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"511bb32ee735d5f09a21a392fb23fa327f75fbde","unresolved":false,"context_lines":[{"line_number":41,"context_line":"          delay: 1"},{"line_number":42,"context_line":"      response_json_paths:"},{"line_number":43,"context_line":"          $.stack.stack_status: \"CREATE_COMPLETE\""},{"line_number":44,"context_line":"          "},{"line_number":45,"context_line":"    - name: list servers grow"},{"line_number":46,"context_line":"      verbose: all"},{"line_number":47,"context_line":"      desc: Wait the autoscaling stack grow to two servers"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6c4da82f_1d844a6b","line":44,"in_reply_to":"d7bd7698_21c8f3a9","updated":"2024-04-03 09:43:45.000000000","message":"Done","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"32c738f21707c86464d212942277f7bb3f9a2e09","unresolved":true,"context_lines":[{"line_number":56,"context_line":"          $.servers[0].status: ACTIVE"},{"line_number":57,"context_line":"          $.servers[1].status: ACTIVE"},{"line_number":58,"context_line":"          $.servers.`len`: 2"},{"line_number":59,"context_line":"          "},{"line_number":60,"context_line":"    - name: check prometheus query for the servers count ."},{"line_number":61,"context_line":"      desc: Check the Prometheus metric for the existence of servers"},{"line_number":62,"context_line":"      url: $ENVIRON[\u0027PROMETHEUS_SERVICE_URL\u0027]/api/v1/query"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"34c9f65b_cfc20d95","line":59,"updated":"2024-03-21 11:44:32.000000000","message":"Ditto","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"511bb32ee735d5f09a21a392fb23fa327f75fbde","unresolved":false,"context_lines":[{"line_number":56,"context_line":"          $.servers[0].status: ACTIVE"},{"line_number":57,"context_line":"          $.servers[1].status: ACTIVE"},{"line_number":58,"context_line":"          $.servers.`len`: 2"},{"line_number":59,"context_line":"          "},{"line_number":60,"context_line":"    - name: check prometheus query for the servers count ."},{"line_number":61,"context_line":"      desc: Check the Prometheus metric for the existence of servers"},{"line_number":62,"context_line":"      url: $ENVIRON[\u0027PROMETHEUS_SERVICE_URL\u0027]/api/v1/query"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"70bb42a8_143d9f27","line":59,"in_reply_to":"34c9f65b_cfc20d95","updated":"2024-04-03 09:43:45.000000000","message":"Done","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"32c738f21707c86464d212942277f7bb3f9a2e09","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"56c0a280_7d9fcefc","line":164,"updated":"2024-03-21 11:44:32.000000000","message":"NIT: While you\u0027re at it, please trim these to single new line at the end of the file.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"511bb32ee735d5f09a21a392fb23fa327f75fbde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"48ab0ebd_95102cd7","line":164,"in_reply_to":"56c0a280_7d9fcefc","updated":"2024-04-03 09:43:45.000000000","message":"Done","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"692aa69d1023fcd2b6dcf0f2617fb16cb67fab71","unresolved":true,"context_lines":[{"line_number":40,"context_line":"          count: 300"},{"line_number":41,"context_line":"          delay: 1"},{"line_number":42,"context_line":"      response_json_paths:"},{"line_number":43,"context_line":"          $.stack.stack_status: \"CREATE_COMPLETE\"      "},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: list servers grow"},{"line_number":46,"context_line":"      verbose: all"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"1ed49330_a8e0ce45","line":43,"updated":"2024-04-02 08:01:58.000000000","message":"Please trim trailing blanks","commit_id":"069c5a45b9269010379ff9f98c0b59c4de089479"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"da5cc959d3bcf1465420756a8b86774ef90edd76","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          count: 300"},{"line_number":41,"context_line":"          delay: 1"},{"line_number":42,"context_line":"      response_json_paths:"},{"line_number":43,"context_line":"          $.stack.stack_status: \"CREATE_COMPLETE\"      "},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    - name: list servers grow"},{"line_number":46,"context_line":"      verbose: all"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"c8125f2b_977836d4","line":43,"in_reply_to":"1ed49330_a8e0ce45","updated":"2024-04-03 09:48:16.000000000","message":"Done","commit_id":"069c5a45b9269010379ff9f98c0b59c4de089479"}],"telemetry_tempest_plugin/scenario/telemetry_integration_prometheus_gabbits/create_stack.json":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"32c738f21707c86464d212942277f7bb3f9a2e09","unresolved":true,"context_lines":[{"line_number":87,"context_line":"            }"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":"}"}],"source_content_type":"application/json","patch_set":10,"id":"2277b8f0_3ed5564b","line":90,"updated":"2024-03-21 11:44:32.000000000","message":"NIT: New line missing at the end.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"511bb32ee735d5f09a21a392fb23fa327f75fbde","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            }"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":"}"}],"source_content_type":"application/json","patch_set":10,"id":"bfc72193_f01c516e","line":90,"in_reply_to":"2277b8f0_3ed5564b","updated":"2024-04-03 09:43:45.000000000","message":"Done","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"}],"telemetry_tempest_plugin/scenario/test_telemetry_integration_prometheus.py":[{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"32c738f21707c86464d212942277f7bb3f9a2e09","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        networks \u003d self.os_primary.networks_client.list_networks("},{"line_number":82,"context_line":"            **{\u0027router:external\u0027: False, \u0027fields\u0027: \u0027id\u0027})[\u0027networks\u0027]"},{"line_number":83,"context_line":"        stack_name \u003d data_utils.rand_name(\u0027telemetry\u0027)"},{"line_number":84,"context_line":"        resource_prefix \u003d stack_name[-7:]"},{"line_number":85,"context_line":"        os.environ.update({"},{"line_number":86,"context_line":"            \"USER_TOKEN\": auth[0],"},{"line_number":87,"context_line":"            \"AODH_THRESHOLD\": str(config.CONF.telemetry.alarm_threshold),"}],"source_content_type":"text/x-python","patch_set":10,"id":"e42d9e13_f0282a96","line":84,"range":{"start_line":84,"start_character":37,"end_line":84,"end_character":40},"updated":"2024-03-21 11:44:32.000000000","message":"The random number at the end of the name is 9 digits, is there a reason why we use only last 7 of them here?\n\neven if it\u0027s just arbitrary part of the name we think is sufficient enough, that\u0027s fine as long as we do it consciously. Truncating the 9 character(digit) section of the name by 2 characters feels bit silly if not done with good reason.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"692aa69d1023fcd2b6dcf0f2617fb16cb67fab71","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        networks \u003d self.os_primary.networks_client.list_networks("},{"line_number":82,"context_line":"            **{\u0027router:external\u0027: False, \u0027fields\u0027: \u0027id\u0027})[\u0027networks\u0027]"},{"line_number":83,"context_line":"        stack_name \u003d data_utils.rand_name(\u0027telemetry\u0027)"},{"line_number":84,"context_line":"        resource_prefix \u003d stack_name[-7:]"},{"line_number":85,"context_line":"        os.environ.update({"},{"line_number":86,"context_line":"            \"USER_TOKEN\": auth[0],"},{"line_number":87,"context_line":"            \"AODH_THRESHOLD\": str(config.CONF.telemetry.alarm_threshold),"}],"source_content_type":"text/x-python","patch_set":10,"id":"f3bec105_9a2756a0","line":84,"range":{"start_line":84,"start_character":37,"end_line":84,"end_character":40},"in_reply_to":"e42d9e13_f0282a96","updated":"2024-04-02 08:01:58.000000000","message":"Erno\u0027s question from patch set 10 is still not answered?","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"511bb32ee735d5f09a21a392fb23fa327f75fbde","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        networks \u003d self.os_primary.networks_client.list_networks("},{"line_number":82,"context_line":"            **{\u0027router:external\u0027: False, \u0027fields\u0027: \u0027id\u0027})[\u0027networks\u0027]"},{"line_number":83,"context_line":"        stack_name \u003d data_utils.rand_name(\u0027telemetry\u0027)"},{"line_number":84,"context_line":"        resource_prefix \u003d stack_name[-7:]"},{"line_number":85,"context_line":"        os.environ.update({"},{"line_number":86,"context_line":"            \"USER_TOKEN\": auth[0],"},{"line_number":87,"context_line":"            \"AODH_THRESHOLD\": str(config.CONF.telemetry.alarm_threshold),"}],"source_content_type":"text/x-python","patch_set":10,"id":"2ecfb99d_9023d685","line":84,"range":{"start_line":84,"start_character":37,"end_line":84,"end_character":40},"in_reply_to":"e42d9e13_f0282a96","updated":"2024-04-03 09:43:45.000000000","message":"the reason is that the servers is being created with  for example \"name\": \"te-3246047-...., and that represent only the last 7 characters from the stackName and we need this prefix in the prometheus query filter.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":5202,"name":"Erno Kuvaja","email":"jokke@usr.fi","username":"jokke"},"change_message_id":"32c738f21707c86464d212942277f7bb3f9a2e09","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        resource_prefix \u003d stack_name[-7:]"},{"line_number":85,"context_line":"        os.environ.update({"},{"line_number":86,"context_line":"            \"USER_TOKEN\": auth[0],"},{"line_number":87,"context_line":"            \"AODH_THRESHOLD\": str(config.CONF.telemetry.alarm_threshold),"},{"line_number":88,"context_line":"            \"SCALEDOWN_THRESHOLD\":"},{"line_number":89,"context_line":"            str(config.CONF.telemetry.scaledown_alarm_threshold),"},{"line_number":90,"context_line":"            \"AODH_SERVICE_URL\": self._get_endpoint(auth, \"alarming_plugin\"),"},{"line_number":91,"context_line":"            \"HEAT_SERVICE_URL\": self._get_endpoint(auth, \"heat_plugin\"),"},{"line_number":92,"context_line":"            \"NOVA_SERVICE_URL\": self._get_endpoint(auth, \"compute\"),"},{"line_number":93,"context_line":"            \"SG_CORE_SERVICE_URL\":"},{"line_number":94,"context_line":"            str(config.CONF.telemetry.sg_core_service_url),"},{"line_number":95,"context_line":"            \"CEILOMETER_POLLING_INTERVAL\":"},{"line_number":96,"context_line":"            str(CONF.telemetry.ceilometer_polling_interval),"},{"line_number":97,"context_line":"            \"PROMETHEUS_SERVICE_URL\":"},{"line_number":98,"context_line":"            str(config.CONF.telemetry.prometheus_service_url),"},{"line_number":99,"context_line":"            \"GLANCE_IMAGE_NAME\": self.image_create(),"},{"line_number":100,"context_line":"            \"NOVA_FLAVOR_REF\": config.CONF.compute.flavor_ref,"},{"line_number":101,"context_line":"            \"NEUTRON_NETWORK\": networks[0].get(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"691a0ae2_7d087dbc","line":98,"range":{"start_line":87,"start_character":0,"end_line":98,"end_character":62},"updated":"2024-03-21 11:44:32.000000000","message":"Lets be consistent with these config references. We have the CONF defined on L: 21 so CONf.X.Y would do on all of these.\n\nhttps://peps.python.org/pep-0008/#a-foolish-consistency-is-the-hobgoblin-of-little-minds\n\nNIT: I also believe that stringifying the *_service_urls is not necessary.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"},{"author":{"_account_id":35145,"name":"marihan girgis","email":"mgirgisf@redhat.com","username":"mgirgisf"},"change_message_id":"511bb32ee735d5f09a21a392fb23fa327f75fbde","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        resource_prefix \u003d stack_name[-7:]"},{"line_number":85,"context_line":"        os.environ.update({"},{"line_number":86,"context_line":"            \"USER_TOKEN\": auth[0],"},{"line_number":87,"context_line":"            \"AODH_THRESHOLD\": str(config.CONF.telemetry.alarm_threshold),"},{"line_number":88,"context_line":"            \"SCALEDOWN_THRESHOLD\":"},{"line_number":89,"context_line":"            str(config.CONF.telemetry.scaledown_alarm_threshold),"},{"line_number":90,"context_line":"            \"AODH_SERVICE_URL\": self._get_endpoint(auth, \"alarming_plugin\"),"},{"line_number":91,"context_line":"            \"HEAT_SERVICE_URL\": self._get_endpoint(auth, \"heat_plugin\"),"},{"line_number":92,"context_line":"            \"NOVA_SERVICE_URL\": self._get_endpoint(auth, \"compute\"),"},{"line_number":93,"context_line":"            \"SG_CORE_SERVICE_URL\":"},{"line_number":94,"context_line":"            str(config.CONF.telemetry.sg_core_service_url),"},{"line_number":95,"context_line":"            \"CEILOMETER_POLLING_INTERVAL\":"},{"line_number":96,"context_line":"            str(CONF.telemetry.ceilometer_polling_interval),"},{"line_number":97,"context_line":"            \"PROMETHEUS_SERVICE_URL\":"},{"line_number":98,"context_line":"            str(config.CONF.telemetry.prometheus_service_url),"},{"line_number":99,"context_line":"            \"GLANCE_IMAGE_NAME\": self.image_create(),"},{"line_number":100,"context_line":"            \"NOVA_FLAVOR_REF\": config.CONF.compute.flavor_ref,"},{"line_number":101,"context_line":"            \"NEUTRON_NETWORK\": networks[0].get(\u0027id\u0027),"}],"source_content_type":"text/x-python","patch_set":10,"id":"5eae4fc5_e99ffa75","line":98,"range":{"start_line":87,"start_character":0,"end_line":98,"end_character":62},"in_reply_to":"691a0ae2_7d087dbc","updated":"2024-04-03 09:43:45.000000000","message":"I removed the CONF as its not being used and the str also.","commit_id":"bf718f7f67c2b28efe5d62af2a0be2bd5b057b14"}]}