)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"006d5bca5b7cb55322f2a68336d2c4e9d04390c7","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Emma Foley \u003cefoley@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-09 13:08:37 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update pre-check for test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The aodh.api.gnocchi tests have a pre-check that uses the base"},{"line_number":10,"context_line":"BaseAlarmingTest.skip_checks(), which only checks for aodh."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"312e059a_3d3cfc4c","line":7,"updated":"2025-06-10 11:50:39.000000000","message":"This has little information about the motivation of this change. I\u0027d probably suggest something like\n\n```\nCheck service available flag for availability of gnocchi\n```\n\nAlso please consider describing the issue, instead of the code block being changed...","commit_id":"1797b6dd761cdabee90a994e25a44a97fb05e134"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"55b6c106713762a412058c900e9b0a39f455742b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Emma Foley \u003cefoley@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-09 13:08:37 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update pre-check for test"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The aodh.api.gnocchi tests have a pre-check that uses the base"},{"line_number":10,"context_line":"BaseAlarmingTest.skip_checks(), which only checks for aodh."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"2395e36c_ca822b2a","line":7,"in_reply_to":"312e059a_3d3cfc4c","updated":"2025-06-10 17:27:57.000000000","message":"Updated the commit message to explain the change from users\u0027 PoV, not from developer\u0027s PoV. IMO in the commit message we don\u0027t need to explain how the current behavior is implemented but we should put more focus on describing the current behavior and problem caused by it. \n\nIn case anything is wrong please feel free to update it.","commit_id":"1797b6dd761cdabee90a994e25a44a97fb05e134"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"ec820704b961ec3765d6ba3d38bc1a10b311ccc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f1024220_8531a5f2","updated":"2025-06-09 11:44:46.000000000","message":"This patch\u0027s former dependancy [1] demonstrates the issue identified and addressed in this patch.\n\n\nWith the first patch[1], there are 45 test run and 4 skipped [2], these include gnocchi test, even though gnocchi is set as disabled in the tempest config.\n\nWith the fix [3], there are 25 tests run and 3 skipped [4], and the gnocchi tests are not run.\n\n[1] https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/951978\n[2] https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d6f/openstack/d6f26ca125a7436a99ebd7568436315a/testr_results.html\n[3] https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/951979\n[4] https://647ea51a7c76ba5f17c8-d499b2e7288499505ef93c98963c2e35.ssl.cf5.rackcdn.com/openstack/0c70d659a77e4a2c97463a89acd105aa/testr_results.html","commit_id":"e006b110b712e41bdffbf1b5192199ed694ac7d5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"006d5bca5b7cb55322f2a68336d2c4e9d04390c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d4368f74_d5512cc7","updated":"2025-06-10 11:50:39.000000000","message":"If we consider the [service_available] gnocchi option is a viable and want to honor it in more places then IMO we should consider un-deprecating the option, which I proposed in https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/914167 ...","commit_id":"1797b6dd761cdabee90a994e25a44a97fb05e134"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dff0723bb9a50d742713c028fa522166209129a2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0d565b13_8c9f54bd","in_reply_to":"c9a89e88_195972dc","updated":"2025-06-10 17:11:12.000000000","message":"Let\u0027s keep that separate but I\u0027m hoping that we can merge that one first (or merge this and that at the same time).","commit_id":"1797b6dd761cdabee90a994e25a44a97fb05e134"},{"author":{"_account_id":13177,"name":"Emma Foley","email":"efoley@redhat.com","username":"emma-l-foley"},"change_message_id":"e14fbe0d33b5b43be5cad826573258303d44d989","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c9a89e88_195972dc","in_reply_to":"d4368f74_d5512cc7","updated":"2025-06-10 16:42:33.000000000","message":"I agree. Unless telemetry-tempest-plugin is going to remove the tests, then the options should remain.\n\nHow does that effect this change? Probably the scope would change to fix the typo/give a better error message","commit_id":"1797b6dd761cdabee90a994e25a44a97fb05e134"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2cac3b98bfd802f96ff1fd5233407e6e69af98c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ade1e843_657ffb6a","updated":"2025-06-10 17:14:22.000000000","message":"I feel like that having [services_available] gnocchi \u003d False along with [telemetry_services] metric_backend \u003d gnocchi is misconfiguration.\nWe can probably add a warning message to indicate the potential misconfiguration but adding a log in the check may result in duplicated noisy message so I don\u0027t require it. Maybe the skip message can be enough.","commit_id":"c6f3065f5947d1a17dec770e24ea178cde4ba166"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"67bc414b8f00e29491b0b41c3eeeca5328044207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"775a11eb_8a903669","updated":"2025-06-11 06:13:31.000000000","message":"Thank you all","commit_id":"212d66606d2a77690ca6ad87a5b422736e09a0b5"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"1c2ab1fe3ecb657d9cefa83e023fec40a40f8ff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"763dbd8a_33bd75bd","updated":"2025-06-10 20:30:50.000000000","message":"This looks good to me. I\u0027m not +Wing as I think it\u0027d be good to see that Emma is OK with the last change in the commit message. I added a comment on the discussed patch as well.","commit_id":"212d66606d2a77690ca6ad87a5b422736e09a0b5"}]}