)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"79ac2daf35845a87f790ec10f9714e7a7123933c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will make tox.ini the only place with logic about how we are "},{"line_number":14,"context_line":"running our tests, and developers will not be confused with shell file"},{"line_number":15,"context_line":"useful only when called through tox.ini"},{"line_number":16,"context_line":" "},{"line_number":17,"context_line":"Change-Id: Ib8a2ffae96175eaa2fd9cd6e2b3138ad675ceb91"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa81d914_8b689b88","line":15,"updated":"2015-01-29 18:55:46.000000000","message":"I disagree with this statement. Having it outside of the tox.ini is useful for manually calling testr while piping the output through subunit trace, which I think is valuable.","commit_id":"23a854237d9b1f26c12bb4d3c6d041482077e0fd"}],"tools/pretty_tox.sh":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"79ac2daf35845a87f790ec10f9714e7a7123933c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"set -o pipefail"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"TESTRARGS\u003d$1"},{"line_number":6,"context_line":"python setup.py testr --slowest --testr-args\u003d\"--subunit $TESTRARGS\" | subunit-trace --no-failure-debug -f"}],"source_content_type":"text/x-sh","patch_set":6,"id":"fa81d914_ebe837b6","side":"PARENT","line":6,"updated":"2015-01-29 18:55:46.000000000","message":"The slowest arg here doesn\u0027t actually print anything because of the pipe. This is why most of the other projects\u0027 pretty_tox are more than 1 line. I think instead of inlining this in the tox.ini it would be better to add the fix to the slowest output here too.","commit_id":"5b807bf2c0a3e22564c78250d42887d9d4f15c65"}],"tox.ini":[{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"d340194d20f8cb2507debcdccd108862a3e15b2c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":12,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":13,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"commands \u003d bash -o pipefail -c \u0027python setup.py testr --slowest --testr-args\u003d\"--subunit {posargs}\" | subunit-trace -f\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[testenv:pep8]"},{"line_number":17,"context_line":"commands \u003d flake8"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1a930d6b_18efbf88","line":14,"updated":"2015-01-22 18:16:50.000000000","message":"The script runs subunit-trace with the --no-debug-failure flag, and this invocation does not.  Is that intentional, or an oversight?","commit_id":"b4712db26e460bdb0139e0506c85e90fae3f3b24"},{"author":{"_account_id":7225,"name":"Serg Melikyan","email":"smelikyan@mirantis.com","username":"smelikyan"},"change_message_id":"cc84263ca3a38da683a3a1a528af99691667f4ee","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":12,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":13,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"commands \u003d bash -o pipefail -c \u0027python setup.py testr --slowest --testr-args\u003d\"--subunit {posargs}\" | subunit-trace -f\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[testenv:pep8]"},{"line_number":17,"context_line":"commands \u003d flake8"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1a930d6b_fb182d77","line":14,"in_reply_to":"1a930d6b_18efbf88","updated":"2015-01-23 11:05:57.000000000","message":"Oversight, thank you!","commit_id":"b4712db26e460bdb0139e0506c85e90fae3f3b24"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"219d67620014781594aa7bab4ea519e57fd6351d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":12,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":13,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"commands \u003d bash -o pipefail -c \u0027python setup.py testr --slowest --testr-args\u003d\"--subunit {posargs}\" | subunit-trace --no-failure-deb\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[testenv:pep8]"},{"line_number":17,"context_line":"commands \u003d flake8"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1a930d6b_0a320110","line":14,"updated":"2015-01-22 20:59:42.000000000","message":"The flags to subunit trace should be \"--no-failure-debug -f\"\n\nGerrit\u0027s word-wrapping seems to have gotten you in trouble.","commit_id":"65548c375a7a5feb005d3c870d7347a106ef7f0e"},{"author":{"_account_id":7225,"name":"Serg Melikyan","email":"smelikyan@mirantis.com","username":"smelikyan"},"change_message_id":"4dd8361bba085176f64a5dfb83e558e5c08d9180","unresolved":false,"context_lines":[{"line_number":11,"context_line":"   VIRTUAL_ENV\u003d{envdir}"},{"line_number":12,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":13,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":14,"context_line":"commands \u003d bash -o pipefail -c \u0027python setup.py testr --slowest --testr-args\u003d\"--subunit {posargs}\" | subunit-trace --no-failure-deb\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[testenv:pep8]"},{"line_number":17,"context_line":"commands \u003d flake8"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1a930d6b_04d82352","line":14,"in_reply_to":"1a930d6b_0a320110","updated":"2015-01-23 11:05:52.000000000","message":"Done, thank you. Yeah, missed that too :(","commit_id":"65548c375a7a5feb005d3c870d7347a106ef7f0e"}]}
