)]}'
{"tempest_lib/tests/cli/test_execute.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0657865c93225c55436dc580e20a2eafd38c1a1c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def test_execute(self):"},{"line_number":21,"context_line":"        cli_base.execute(\"/bin/true\","},{"line_number":22,"context_line":"                         action\u003d\"action\", params\u003d\"some params\","},{"line_number":23,"context_line":"                         flags\u003d\"--flag1 --flag2\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b9b3694c","line":23,"updated":"2015-08-31 19:17:29.000000000","message":"I\u0027m wondering maybe we should do testing on this to make sure it\u0027s doing the right thing?\n\nI mean something is better than nothing, but all we\u0027re testing is that it doesn\u0027t explode.\nMaybe we should mock out subprocess here and verify things get passed and decoded properly.","commit_id":"fe78f8cc26efc56ab0cc36e107c1d523825cb63e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a01e97ece9144934b90d0bc7db8b9fe1eeae15f0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def test_execute(self):"},{"line_number":21,"context_line":"        cli_base.execute(\"/bin/true\","},{"line_number":22,"context_line":"                         action\u003d\"action\", params\u003d\"some params\","},{"line_number":23,"context_line":"                         flags\u003d\"--flag1 --flag2\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_7614ede7","line":23,"in_reply_to":"da20952f_b9b3694c","updated":"2015-09-01 05:11:00.000000000","message":"I think mocking subprocess is not a good solution because python2 and python3 doesn\u0027t return the same thing.\n\nI have proposed something that assert on the response, not only that\u0027s the command success.","commit_id":"fe78f8cc26efc56ab0cc36e107c1d523825cb63e"}]}