)]}'
{"tempest_lib/services/identity/v2/token_client.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6f36c6894d9c5eb94ac1b9e31e6acb190381ff37","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        resp, resp_body \u003d self.raw_request(url, method,"},{"line_number":86,"context_line":"                                           headers\u003dheaders, body\u003dbody)"},{"line_number":87,"context_line":"        self._log_request(method, url, resp, req_headers\u003dheaders,"},{"line_number":88,"context_line":"                          req_body\u003dbody, resp_body\u003dresp_body)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if resp.status in [401, 403]:"},{"line_number":91,"context_line":"            resp_body \u003d json.loads(resp_body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_76b45ed0","line":88,"updated":"2015-10-07 17:00:45.000000000","message":"My only concern here is are we gonna end up logging passwords? That\u0027s something we should try to be careful about since this can be used with creds that we don\u0027t wanted logged.","commit_id":"07a680f143990fe991e5e9f9e5d538e26044e8e4"},{"author":{"_account_id":15640,"name":"Roxana Gherle","email":"roxana.gherle@hpe.com","username":"roxana-gherle"},"change_message_id":"bb6ad6982d64321fe215455ee1b930628b90db53","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        resp, resp_body \u003d self.raw_request(url, method,"},{"line_number":86,"context_line":"                                           headers\u003dheaders, body\u003dbody)"},{"line_number":87,"context_line":"        self._log_request(method, url, resp, req_headers\u003dheaders,"},{"line_number":88,"context_line":"                          req_body\u003dbody, resp_body\u003dresp_body)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if resp.status in [401, 403]:"},{"line_number":91,"context_line":"            resp_body \u003d json.loads(resp_body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_df546522","line":88,"in_reply_to":"7a2fa921_76b45ed0","updated":"2015-10-07 18:18:41.000000000","message":"That\u0027s a very good point. We would have a password in the request body which would be an issue. I will try to omit the password from the output. \n\nDo we not want tokens either in the log output? I see we currently print \u0027x-subject-token\u0027 in the response headers of get_token request. We might want to mask that out...","commit_id":"07a680f143990fe991e5e9f9e5d538e26044e8e4"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"e31d78807cfb8cc5e1c69099837c403d1366b2de","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        resp, resp_body \u003d self.raw_request(url, method,"},{"line_number":86,"context_line":"                                           headers\u003dheaders, body\u003dbody)"},{"line_number":87,"context_line":"        self._log_request(method, url, resp, req_headers\u003dheaders,"},{"line_number":88,"context_line":"                          req_body\u003dbody, resp_body\u003dresp_body)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if resp.status in [401, 403]:"},{"line_number":91,"context_line":"            resp_body \u003d json.loads(resp_body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_5c85aa04","line":88,"in_reply_to":"7a2fa921_df546522","updated":"2015-10-08 08:25:45.000000000","message":"Tokens are usually relatively ephemeral, but it really depends on the configuration, so it\u0027s probably good to mask them out as well.","commit_id":"07a680f143990fe991e5e9f9e5d538e26044e8e4"}]}
