)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"b2654f30a2b152b7b4e6243782424277ff2a7d0c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kenji Yasui \u003ck-yasui@ti.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-14 07:50:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"UPdate unit test about quotas_client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently unit test about quotas_client does not support \"user_id\" in"},{"line_number":10,"context_line":"test_show_default_quota_set and  test_update_quota_set."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a2ca52d_d5f23d9a","line":7,"updated":"2015-10-14 12:09:39.000000000","message":"/UPdate/update/s","commit_id":"a3da84d6975d674be4e32a914ffb318ba27a720a"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"c59c63fb8be956be146518224a3873f7d9b253ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kenji Yasui \u003ck-yasui@ti.jp.nec.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-14 07:50:40 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"UPdate unit test about quotas_client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently unit test about quotas_client does not support \"user_id\" in"},{"line_number":10,"context_line":"test_show_default_quota_set and  test_update_quota_set."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a2ca52d_88d24cff","line":7,"in_reply_to":"5a2ca52d_d5f23d9a","updated":"2015-10-14 23:50:00.000000000","message":"Done","commit_id":"a3da84d6975d674be4e32a914ffb318ba27a720a"}],"tempest_lib/tests/services/compute/test_quotas_client.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29f35d2666f9f278f0844c4c841c7518a2e7e682","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    project_id \u003d \"8421f7be61064f50b680465c07f334af\""},{"line_number":44,"context_line":"    user_id \u003d \"fake_user_id\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestQuotasClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_475f7172","line":44,"updated":"2015-10-14 05:06:24.000000000","message":"Is it possible to use UUID format value instead of \"fake_user_id\" like the above project_id ?\n\nThat would be nice to test the similar value on actual env.","commit_id":"ee21866fa79da281936dd634329c67adbfbab2d2"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"fe94d2cb78d03a5dcd572c5b3166c46f8907535b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    project_id \u003d \"8421f7be61064f50b680465c07f334af\""},{"line_number":44,"context_line":"    user_id \u003d \"fake_user_id\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(TestQuotasClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_4dcb0f54","line":44,"in_reply_to":"5a2ca52d_475f7172","updated":"2015-10-14 07:10:45.000000000","message":"I\u0027ll rewrite here with UUID format.","commit_id":"ee21866fa79da281936dd634329c67adbfbab2d2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29f35d2666f9f278f0844c4c841c7518a2e7e682","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.client \u003d quotas_client.QuotasClient("},{"line_number":50,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _test_show_quota_set(self, bytes_body\u003dFalse, user_id\u003dNone):"},{"line_number":53,"context_line":"        self.check_service_client_function("},{"line_number":54,"context_line":"            self.client.show_quota_set,"},{"line_number":55,"context_line":"            \u0027tempest_lib.common.rest_client.RestClient.get\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_a7fc453f","line":52,"updated":"2015-10-14 05:06:24.000000000","message":"This new \"user_id\" argument is not used at all in this internal method.\nThat seems wrong for the patch purpose.","commit_id":"ee21866fa79da281936dd634329c67adbfbab2d2"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"fe94d2cb78d03a5dcd572c5b3166c46f8907535b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.client \u003d quotas_client.QuotasClient("},{"line_number":50,"context_line":"            fake_auth, \u0027compute\u0027, \u0027regionOne\u0027)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _test_show_quota_set(self, bytes_body\u003dFalse, user_id\u003dNone):"},{"line_number":53,"context_line":"        self.check_service_client_function("},{"line_number":54,"context_line":"            self.client.show_quota_set,"},{"line_number":55,"context_line":"            \u0027tempest_lib.common.rest_client.RestClient.get\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_ed09bb96","line":52,"in_reply_to":"5a2ca52d_a7fc453f","updated":"2015-10-14 07:10:45.000000000","message":"I missed to modify the internal method. I\u0027ll fix here to use \"user_id\".","commit_id":"ee21866fa79da281936dd634329c67adbfbab2d2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29f35d2666f9f278f0844c4c841c7518a2e7e682","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def test_show_default_quota_set_with_bytes_body(self):"},{"line_number":84,"context_line":"        self._test_show_quota_set(bytes_body\u003dTrue)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _test_update_quota_set(self, bytes_body\u003dFalse, user_id\u003dNone):"},{"line_number":87,"context_line":"        fake_quota_set \u003d copy.deepcopy(self.FAKE_QUOTA_SET)"},{"line_number":88,"context_line":"        fake_quota_set[\u0027quota_set\u0027].pop(\"id\")"},{"line_number":89,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_078739b6","line":86,"updated":"2015-10-14 05:06:24.000000000","message":"Ditto: This new \"user_id\" argument is not used at all in this internal method. That seems wrong for the patch purpose.","commit_id":"ee21866fa79da281936dd634329c67adbfbab2d2"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"fe94d2cb78d03a5dcd572c5b3166c46f8907535b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def test_show_default_quota_set_with_bytes_body(self):"},{"line_number":84,"context_line":"        self._test_show_quota_set(bytes_body\u003dTrue)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _test_update_quota_set(self, bytes_body\u003dFalse, user_id\u003dNone):"},{"line_number":87,"context_line":"        fake_quota_set \u003d copy.deepcopy(self.FAKE_QUOTA_SET)"},{"line_number":88,"context_line":"        fake_quota_set[\u0027quota_set\u0027].pop(\"id\")"},{"line_number":89,"context_line":"        self.check_service_client_function("}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_4df9cf7f","line":86,"in_reply_to":"5a2ca52d_078739b6","updated":"2015-10-14 07:10:45.000000000","message":"Done","commit_id":"ee21866fa79da281936dd634329c67adbfbab2d2"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"29f35d2666f9f278f0844c4c841c7518a2e7e682","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.check_service_client_function("},{"line_number":90,"context_line":"            self.client.update_quota_set,"},{"line_number":91,"context_line":"            \u0027tempest_lib.common.rest_client.RestClient.put\u0027,"},{"line_number":92,"context_line":"            fake_quota_set,"},{"line_number":93,"context_line":"            tenant_id\u003dself.project_id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_update_quota_set_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_87c109e7","line":92,"updated":"2015-10-14 05:06:24.000000000","message":"We need to add\n\n to_utf\u003dbytes_body,\n\nhere, I feel","commit_id":"ee21866fa79da281936dd634329c67adbfbab2d2"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"fe94d2cb78d03a5dcd572c5b3166c46f8907535b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.check_service_client_function("},{"line_number":90,"context_line":"            self.client.update_quota_set,"},{"line_number":91,"context_line":"            \u0027tempest_lib.common.rest_client.RestClient.put\u0027,"},{"line_number":92,"context_line":"            fake_quota_set,"},{"line_number":93,"context_line":"            tenant_id\u003dself.project_id)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_update_quota_set_with_str_body(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_6dc84b56","line":92,"in_reply_to":"5a2ca52d_87c109e7","updated":"2015-10-14 07:10:45.000000000","message":"I\u0027ll add it.","commit_id":"ee21866fa79da281936dd634329c67adbfbab2d2"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"e717416503f811093b790ebf7e5c675823305176","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                self.FAKE_QUOTA_SET,"},{"line_number":58,"context_line":"                to_utf\u003dbytes_body,"},{"line_number":59,"context_line":"                tenant_id\u003dself.project_id,"},{"line_number":60,"context_line":"                user_id\u003dself.fake_user_id)"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            self.check_service_client_function("},{"line_number":63,"context_line":"                self.client.show_quota_set,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_5b5c294b","line":60,"updated":"2015-10-14 07:57:50.000000000","message":"I noticed after posting , if here is following,  I don\u0027t have to separate ? \n\n user_id\u003duser_id","commit_id":"a3da84d6975d674be4e32a914ffb318ba27a720a"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"c59c63fb8be956be146518224a3873f7d9b253ca","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                self.FAKE_QUOTA_SET,"},{"line_number":58,"context_line":"                to_utf\u003dbytes_body,"},{"line_number":59,"context_line":"                tenant_id\u003dself.project_id,"},{"line_number":60,"context_line":"                user_id\u003dself.fake_user_id)"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            self.check_service_client_function("},{"line_number":63,"context_line":"                self.client.show_quota_set,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_68d7b0ed","line":60,"in_reply_to":"5a2ca52d_26f90d81","updated":"2015-10-14 23:50:00.000000000","message":"Done","commit_id":"a3da84d6975d674be4e32a914ffb318ba27a720a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"628c78f6aed5f3fa9fb9c729c2aedd3d23564342","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                self.FAKE_QUOTA_SET,"},{"line_number":58,"context_line":"                to_utf\u003dbytes_body,"},{"line_number":59,"context_line":"                tenant_id\u003dself.project_id,"},{"line_number":60,"context_line":"                user_id\u003dself.fake_user_id)"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            self.check_service_client_function("},{"line_number":63,"context_line":"                self.client.show_quota_set,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_26f90d81","line":60,"in_reply_to":"5a2ca52d_5b5c294b","updated":"2015-10-14 10:11:01.000000000","message":"As you know, the result is the same but yeah, here should be\n\n user_id\u003duser_id\n\ninstead of\n\n user_id\u003dself.fake_user_id\n\nbecause the method argument becomes a little meaningless and the internal method of scope should be small as possible for the readability.","commit_id":"a3da84d6975d674be4e32a914ffb318ba27a720a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"628c78f6aed5f3fa9fb9c729c2aedd3d23564342","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                fake_quota_set,"},{"line_number":103,"context_line":"                to_utf\u003dbytes_body,"},{"line_number":104,"context_line":"                tenant_id\u003dself.project_id,"},{"line_number":105,"context_line":"                user_id\u003dself.fake_user_id)"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            self.check_service_client_function("},{"line_number":108,"context_line":"                self.client.update_quota_set,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_a62bddea","line":105,"updated":"2015-10-14 10:11:01.000000000","message":"ditto","commit_id":"a3da84d6975d674be4e32a914ffb318ba27a720a"},{"author":{"_account_id":17104,"name":"Kenji Yasui","email":"k-yasui@ti.jp.nec.com","username":"yasui"},"change_message_id":"c59c63fb8be956be146518224a3873f7d9b253ca","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                fake_quota_set,"},{"line_number":103,"context_line":"                to_utf\u003dbytes_body,"},{"line_number":104,"context_line":"                tenant_id\u003dself.project_id,"},{"line_number":105,"context_line":"                user_id\u003dself.fake_user_id)"},{"line_number":106,"context_line":"        else:"},{"line_number":107,"context_line":"            self.check_service_client_function("},{"line_number":108,"context_line":"                self.client.update_quota_set,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_e801806b","line":105,"in_reply_to":"5a2ca52d_a62bddea","updated":"2015-10-14 23:50:00.000000000","message":"Done","commit_id":"a3da84d6975d674be4e32a914ffb318ba27a720a"}]}