)]}'
{"requirements.txt":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"588d672b72b8075cd19e10e58490503bdf5f7cfe","unresolved":false,"context_lines":[{"line_number":11,"context_line":"six\u003e\u003d1.9.0"},{"line_number":12,"context_line":"oslo.log\u003e\u003d1.8.0 # Apache-2.0"},{"line_number":13,"context_line":"os-testr\u003e\u003d0.4.1"},{"line_number":14,"context_line":"os-client-config"}],"source_content_type":"text/plain","patch_set":2,"id":"7a5de9d1_2521fafb","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":16},"updated":"2016-01-28 16:35:12.000000000","message":"Do we want to set a min version on this? I can\u0027t remember if we g-r sync tempest-lib","commit_id":"0623f301c91259b6900ae6a94ffaf666757efc7e"}],"tempest_lib/cli/base.py":[{"author":{"_account_id":12259,"name":"Anant Patil","email":"anant.techie@gmail.com","username":"ananta"},"change_message_id":"561c8ee7dd9edcfce87e2921dd3de6e83666d3de","unresolved":false,"context_lines":[{"line_number":401,"context_line":"    def _get_clients(self):"},{"line_number":402,"context_line":"        \"\"\"Method to initialize CLIClient object."},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        This method can be overloaded in child test classes if there is"},{"line_number":405,"context_line":"        something additional that the child test wants to accomplish."},{"line_number":406,"context_line":"        It should be used to initialize the CLIClient object with the"},{"line_number":407,"context_line":"        appropriate credentials during the setUp() phase of tests."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_35f39875","line":404,"updated":"2015-10-19 03:48:13.000000000","message":"s/overloaded/overridden ?","commit_id":"e479719a1507f487f359d9e5bdadac658382ec31"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ddbfc7d7a7eaf3b48882159c06566470c6d12450","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        cli_dir \u003d os.environ.get("},{"line_number":410,"context_line":"            self.CLIENT_ENV_KEY,"},{"line_number":411,"context_line":"            os.path.join(os.path.abspath(\u0027.\u0027), \u0027.tox/functional/bin\u0027))"},{"line_number":412,"context_line":"        return base.CLIClient(cli_dir\u003dcli_dir, **self.creds)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def assertTableStruct(self, items, field_names):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_271a0970","line":411,"updated":"2015-12-02 22:07:48.000000000","message":"I\u0027m not sure we should default to running in tox. It\u0027s fine for projects that have a tox job named functional and use this framework. (which is is admittedly a lot of them since they all cargo culted it from the cli testing from novaclient) But, I think it\u0027s kinda weird to assume if the exec dir isn\u0027t set assume we\u0027re running in tox as part of a job named functional. Maybe just raise here if it\u0027s not found, or don\u0027t set it and let the defaults do their thing.","commit_id":"e479719a1507f487f359d9e5bdadac658382ec31"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"588d672b72b8075cd19e10e58490503bdf5f7cfe","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def setUp(self):"},{"line_number":374,"context_line":"        super(ClientTestBase, self).setUp()"},{"line_number":375,"context_line":"        self.creds \u003d self._get_creds()"},{"line_number":376,"context_line":"        self.clients \u003d self._get_clients()"},{"line_number":377,"context_line":"        self.parser \u003d tempest_lib.cli.output_parser"},{"line_number":378,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_5021564c","line":375,"updated":"2016-01-28 16:35:12.000000000","message":"what if there isn\u0027t a clouds.yaml present? Won\u0027t this just explode. I\u0027m afraid requiring this hard will break everyone. _get_creds() wasn\u0027t something to overload in subclasses before so if there is someone using this outside a devstack env and they don\u0027t have clouds.yaml when this releases it\u0027ll break anyone in that case (assuming there are any) \n\nI\u0027m thinking we should catch that exception and emit a warning and move on. This should protect people because they would have to be overloading _get_clients()","commit_id":"0623f301c91259b6900ae6a94ffaf666757efc7e"}]}